Commit Graph

73282 Commits

Author SHA1 Message Date
Tony Wickham bd29dde623 Update live tile during dismiss anim even if disabled at start
Before we only checked if live tile drawing was enabled at the
start of the dismiss animation, and didn't add the frame callback
listener at all if not. Now we always add the frame callback
listener when dismissing the running task, and check if live tile
drawing is enabled within the listener in case there is a race.

Fixes: 312261719
Test: Swipe up to Overview from an app, immediately swipe up to
dismiss the app; ensure it always follows your finger
Flag: None

Change-Id: Ia12b02d5989c09d2104edd202f8c016f202f76b8
2023-12-20 19:58:28 +00:00
Vadim Tryshev 1c7bc492fb Merge "Inserting waiting for wallpaper animation into "back" gesture from app to workspace" into main 2023-12-12 18:24:56 +00:00
Jagrut Desai 2be2b93256 Merge "TaskbarPinningController Unit Tests" into main 2023-12-12 16:19:00 +00:00
Sergey Pinkevich 2adff1b7c0 Merge "Update secondary grid translation" into main 2023-12-12 13:06:40 +00:00
Sunny Goyal 6263ac3894 Merge "Adding support for getting task overlay" into main 2023-12-12 08:25:18 +00:00
Jeremy Sim e73146de77 Merge "Fix clipping issue when dragging app pair icons" into main 2023-12-12 01:03:42 +00:00
Jeremy Sim 160225029d Merge "App Pairs: Launch animation" into main 2023-12-12 00:58:49 +00:00
Xin Li 7545bab7ab [automerger skipped] Merge "Merge Android 14 QPR1" into main am: aa168f204e -s ours am: e2d8c0c312 -s ours am: 26fa6bd719 -s ours
am skip reason: Merged-In I7f5bca7edd18631b36f2b9213e17554cf769cbc6 with SHA-1 861ce33a59 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2863559

Change-Id: I9c2ad64b29aee915aae6ba9784e32fd4f1829ace
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-11 23:00:17 +00:00
Xin Li b65a2490d4 [automerger skipped] Merge Android 14 QPR1 am: 65e37d77fe -s ours am: 3cbfd5623b -s ours am: c95f995a9e -s ours
am skip reason: Merged-In I7f5bca7edd18631b36f2b9213e17554cf769cbc6 with SHA-1 861ce33a59 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2863559

Change-Id: I3b541ffd85a0a721b27b873668ee83089c9c0efd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-11 22:57:27 +00:00
Jagrut Desai 70de8a4823 TaskbarPinningController Unit Tests
Test: Presubmit
Bug: 265439107
Flag: NONE

Change-Id: I5da3558adf88126b07c5d6217ee4fbbcc1e2e348
2023-12-11 14:46:55 -08:00
Brian Isganitis 98057e7451 Merge "Have Taskbar overlay window consume IME insets." into main 2023-12-11 22:21:22 +00:00
Xin Li 26fa6bd719 [automerger skipped] Merge "Merge Android 14 QPR1" into main am: aa168f204e -s ours am: e2d8c0c312 -s ours
am skip reason: Merged-In I7f5bca7edd18631b36f2b9213e17554cf769cbc6 with SHA-1 861ce33a59 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2863559

Change-Id: I6c44ba248bfcb774dad1066dc999ac5e97b5a43e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-11 22:05:03 +00:00
Xin Li c95f995a9e [automerger skipped] Merge Android 14 QPR1 am: 65e37d77fe -s ours am: 3cbfd5623b -s ours
am skip reason: Merged-In I7f5bca7edd18631b36f2b9213e17554cf769cbc6 with SHA-1 861ce33a59 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2863559

Change-Id: I80c12e5f9df2800928e385bb759446fcf5aace28
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-11 22:02:14 +00:00
Tracy Zhou 6c24bf7c8e Merge "Do not set isImmersive in TaskbarDelegate" into main 2023-12-11 22:00:33 +00:00
Tracy Zhou 901b190153 Merge "Pass in navigation bar panel context created by task bar when taskbar navbar unification is on" into main 2023-12-11 21:47:59 +00:00
Sebastián Franco 1b86ab623f Merge "Testing if the test failing is because of an incorrect state" into main 2023-12-11 21:47:24 +00:00
Xin Li e2d8c0c312 [automerger skipped] Merge "Merge Android 14 QPR1" into main am: aa168f204e -s ours
am skip reason: Merged-In I7f5bca7edd18631b36f2b9213e17554cf769cbc6 with SHA-1 861ce33a59 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2863559

Change-Id: Ifecff25b799b50b69594c664bfa4351b2251166e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-11 21:19:18 +00:00
Xin Li 3cbfd5623b [automerger skipped] Merge Android 14 QPR1 am: 65e37d77fe -s ours
am skip reason: Merged-In I7f5bca7edd18631b36f2b9213e17554cf769cbc6 with SHA-1 861ce33a59 is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2863559

Change-Id: Ie15a9e1fdafe177270dc6c5102ed1c2f86ab30e5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-11 21:16:25 +00:00
Sebastian Franco 08d31d2595 Testing if the test failing is because of an incorrect state
Bug: 315525621
Flag: NA
Test: TaplTestsQuickstep#testPressBack
Change-Id: Iba41abac8e808fadd9e0513d8c0386bbfd63fdd6
2023-12-11 20:39:15 +00:00
Sebastián Franco c715781453 Merge "Removing debbug comments" into main 2023-12-11 20:37:38 +00:00
Sebastián Franco 9287ec0810 Merge "Simplify attemptPushInDirection" into main 2023-12-11 20:34:07 +00:00
Vadim Tryshev 5e9e07e0dc Merge "Enabling wallpaper animation wait in presubmit widget tests" into main 2023-12-11 20:10:51 +00:00
Brian Isganitis 36ffc96382 Have Taskbar overlay window consume IME insets.
Test: Manual
Flag: N/A
Fix: 301321668
Change-Id: Ia12dec7560bd3a0269a9efdccaecc032c70b1630
2023-12-11 19:50:53 +00:00
Vadim Tryshev 5915443a33 Merge "Disabling leak checks in presubmits" into main 2023-12-11 19:50:20 +00:00
Sebastián Franco f217079aea Merge "Move onInitialBindComplete to ModelCallbacks" into main 2023-12-11 19:31:15 +00:00
Vadim Tryshev 8c3dbdf22a Enabling wallpaper animation wait in presubmit widget tests
This check is stable now

Bug: 313926097
Flag: N/A
Test: presubmit, postsubmit runs
Change-Id: Id6bbe5f8ca3aaae3ef025732b4d429d109b567ce
2023-12-11 10:31:20 -08:00
Vadim Tryshev 79e12b893d Disabling leak checks in presubmits
They block 36% of presubmit runs

Bug: 313501215
Test: presubmit
Flag: N/A
Change-Id: Id91e5a467dfe2485614a4ac99861670a1afaa533
2023-12-11 10:16:13 -08:00
Vadim Tryshev 04e044565d Merge "Disable alpha jump detector" into main 2023-12-11 18:07:03 +00:00
Sebastian Franco 0b461efeeb Move onInitialBindComplete to ModelCallbacks
Changes are part of go/launcher_SoR .

Flag: NA
Bug: 301108526
Test: TaplWorkspace
Change-Id: I1a12309897a04f3ae1642fcdc9f984f7f274ba13
2023-12-11 10:07:40 -06:00
Sebastian Franco 9658523297 Removing debbug comments
Bug: 303263644
Flag: NA
Test: TaplWidgetPickerTest
Change-Id: I6ad428100b2455110315755cea4b75f46b7217c0
2023-12-11 10:01:16 -06:00
Sergey Pinkevich 83462a488b Update secondary grid translation
In order to properly animate task on the vertical axis we need to update `taskSecondaryTranslation`.

Bug: 304782953
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Test: manual

Change-Id: I1afe78d4eb1575e9c967ff594cffedd7d3620541
2023-12-11 15:25:29 +00:00
Thales Lima df643c4540 Merge changes from topic "numFolderRows" into main
* changes:
  Update dump tests
  Make numFolderRows/Columns accept more values
2023-12-11 10:54:04 +00:00
Jeremy Sim 0b070d9312 Fix clipping issue when dragging app pair icons
This CL changes AppPairIcon#getWorkspaceVisualDragBounds() to return the correct icon bounds, fixing an issue where the icon would appear clipped when being dragged.

Fixes: 312299947
Test: Icon is no longer clipped while dragging
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Change-Id: I103bdf53bf34d751147e1ba892f36145f04175e4
2023-12-11 17:17:00 +09:00
Tracy Zhou f3e5382042 Do not set isImmersive in TaskbarDelegate
allow_gesture and immersive_mode are opposite of each other, and currently we set one or another, check one or another in different places. We should consolidate the two. Hence, we are removing all references of immersive_mode (allow_gesture has more usages).

Bug: 313033827
Test: N/A
Change-Id: I52d86c37cb39ef0bc04a04a0fa78d2b051a0e56e
2023-12-10 21:18:22 -08:00
Jeremy Sim 23fcbf2f73 App Pairs: Launch animation
[App Pairs 7/?]

This patch implements the app pair launch animation from icon. Adds a new function, composeFadeInSplitLaunchAnimator(), in SplitAnimationController, that builds the combined launcher + shell animation.

Bug: 309618233
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Test: Manual
Change-Id: I8e95f629ae2a71f1bd6cbb356f5e33233e5c2906
2023-12-11 13:09:06 +09:00
Jeremy Sim d761f5c3bd Merge "App Pairs: Implement Taskbar functionality" into main 2023-12-09 02:20:45 +00:00
Xin Li aa168f204e Merge "Merge Android 14 QPR1" into main 2023-12-09 00:12:03 +00:00
Vadim Tryshev 151751c014 Merge "Fixing non-sending wallpaper animation finish event" into main 2023-12-08 23:33:53 +00:00
Jeremy Sim 2987d95ba4 App Pairs: Implement Taskbar functionality
[App Pairs 8/?]

This CL adds taskbar functionality for app pairs:
- Ability to drag an app pair icon to Taskbar
- App pair launch from Home Taskbar
- App pair launch from Overview Taskbar
- App pair launch from in-app Taskbar

KNOWN ISSUES:
- Bug (b/315190686): if user is inside a running split pair and attempts to launch the same pair from an app pair icon on taskbar, Overview tiles get temporarily messed up (recoverable by leaving Overview)
- User can attempt to split with an app pair icon on the Taskbar. This should result in a "can't split with this" bounce animation on the SplitInstructionsView (to be implemented). Currently does nothing.

Bug: 274835596
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Test: Manual
Change-Id: I5256547af236fc2deeb192d60bfe1f2b7ddc5647
2023-12-08 15:07:45 -08:00
Saumya Prakash 55fdc45ecc Merge "Ensure Taskbar stashes when launching an app from folder" into main 2023-12-08 22:59:45 +00:00
Sunny Goyal 41aca1e7b3 Adding support for getting task overlay
Test: Verified the flow in Launcher
Bug: 273828110
Flag: LEGACY USE_ACTIVITY_OVERLAY DISABLED

Change-Id: Ia61f4f165e328335820a33ceea2b810ac5e6c3af
2023-12-08 14:39:50 -08:00
Vinit Nayak fe22e7fa4d Merge "Only launch from split taskView if it's visible to user" into main 2023-12-08 22:34:33 +00:00
Vadim Tryshev 3277cbdb17 Fixing non-sending wallpaper animation finish event
Wallpaper animation may be interrupted with an animation to go to Normal state.
Then the animation won't succeed, but it will still end.

Bug: 315074923
Flag: N/A
Test: presubmit
Change-Id: I15a106de78030f6935978539d333cc85ee95b4e7
2023-12-08 14:11:55 -08:00
Thales Lima 0c9e869a8a Update dump tests
Bug: 309800141
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Change-Id: I75c6a07192f6af94adbea89a6dfdf03984272849
2023-12-08 22:00:51 +00:00
Thales Lima 1faa4edc42 Make numFolderRows/Columns accept more values
InvariantDeviceProfile hold values that are not related to current DP in use. Now other classes get the value correctly from DeviceProfile, and each posture can hold different values, making it akin to iconSize.

Fix: 309800141
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Change-Id: I32295738585de67205dcd6c8942d08a3d07d169a
2023-12-08 22:00:48 +00:00
Xin Li 65e37d77fe Merge Android 14 QPR1
Merged-In: I7f5bca7edd18631b36f2b9213e17554cf769cbc6
Bug: 315507370
Change-Id: I53db199aae0b6104272ad9cdcf86fa878758124b
2023-12-08 13:14:20 -08:00
Saumya Prakash 86285d477d Ensure Taskbar stashes when launching an app from folder
We use the folder closing callback to trigger a call to stash the
taskbar if an app was launched. We can check whether an app was launched
from a folder based on whether a folder's view is open when
an app is launched. This ensures that the taskbar only stashes after the
folder is done animating.

Flag: NA
Fix: 295296529
Test: Launched an app in a folder on taskbar. Also ensured that other
taskbar behavior remains unchanged.

Change-Id: Ib5a797186978ee960e44b6b62c833eead03bccd0
2023-12-08 20:16:15 +00:00
Vadim Tryshev 5eac9a5d81 Waiting for wallpaper animation in widget tests only for Nexus Launcher and in postsubmit
This code flakes in postsubmit and presubmit, but the failure is
not reproducible in local and abtd runs. Landing the change to make postsubmit
flake; then I'll use tricks like tracing to debug the cause.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I77c324d43a2400fe1015f5cd0a4729e34552687c
2023-12-08 12:06:45 -08:00
Holly Jiuyu Sun d60f56c36e Merge "[tile] Update protos." into main 2023-12-08 19:26:50 +00:00
Sebastián Franco c811263007 Merge "Moving finishBindingItems to ModelCallbacks" into main 2023-12-08 16:06:32 +00:00