Commit Graph

19258 Commits

Author SHA1 Message Date
Sunny Goyal bbbfc62c63 Merge "Disable seamless rotation for 3 and 2 button mode" into ub-launcher3-qt-dev
am: 19f7c6fefb

Change-Id: Iec2636f14a157e9a9b5e9c47e1c258b9158dc942
2019-06-06 15:58:04 -07:00
TreeHugger Robot 19f7c6fefb Merge "Disable seamless rotation for 3 and 2 button mode" into ub-launcher3-qt-dev 2019-06-06 22:45:47 +00:00
Sunny Goyal 0b1cb75ee8 Disable seamless rotation for 3 and 2 button mode
Bug: 134095068
Change-Id: I8603e49a85b5524a02c9085485a180b022e3f91e
2019-06-06 15:35:45 -07:00
Vadim Tryshev 9788fbda66 Merge "Test: using RuleChain to create a correct order of rules." into ub-launcher3-qt-dev
am: 8278148e41

Change-Id: I764fef9315039c1272b63495c261a5ec83839220
2019-06-06 14:31:43 -07:00
Vadim Tryshev 8278148e41 Merge "Test: using RuleChain to create a correct order of rules." into ub-launcher3-qt-dev 2019-06-06 21:20:50 +00:00
vadimt 44e9a873fc Test: using RuleChain to create a correct order of rules.
Change-Id: I2eeb933eab8e5f19b1f80d47566a511ddbdeb28b
2019-06-06 14:02:33 -07:00
Jon Miranda 9c078a6b99 Merge "Reduce alpha delay 25ms to reduce flashy feeling of appearing large." into ub-launcher3-qt-dev
am: 256762251e

Change-Id: I99bd2383244e0b753ee18cb8657efe0bd0b676d0
2019-06-06 12:58:20 -07:00
TreeHugger Robot 256762251e Merge "Reduce alpha delay 25ms to reduce flashy feeling of appearing large." into ub-launcher3-qt-dev 2019-06-06 19:48:42 +00:00
Sunny Goyal f95a845924 Merge "Using a separate InputConsumer when Launcher is resumed but not focused" into ub-launcher3-qt-dev
am: 7183795ff8

Change-Id: Idafa9bc76dc8d22b3f69388824859d86e0737a81
2019-06-06 12:13:57 -07:00
Tony Wickham d5270da80d Merge "Fix flicker to OVERVIEW state during quick switch" into ub-launcher3-qt-dev
am: 215ab0ca87

Change-Id: I04e1068111893c41a6ade925daf3f37259e0591f
2019-06-06 12:07:54 -07:00
TreeHugger Robot 7183795ff8 Merge "Using a separate InputConsumer when Launcher is resumed but not focused" into ub-launcher3-qt-dev 2019-06-06 19:06:30 +00:00
Sunny Goyal 6f479ff9de Using a separate InputConsumer when Launcher is resumed but not focused
When Launcher is not focused and we try to dispatch events to Launcher, it
can lead to a inconsistent state. For eg, NavBarTouchController was trying
to take launcher from NORMAL to NORMAL state causing the endCallback to be
called immediately, which in turn didn't clear Swipedetetor state

Bug: 132209249
Bug: 132815672
Change-Id: I82e4fdcb8fd5339e82fc8551f3a6e0b046d906f8
2019-06-06 11:57:54 -07:00
Tony Wickham 215ab0ca87 Merge "Fix flicker to OVERVIEW state during quick switch" into ub-launcher3-qt-dev 2019-06-06 18:55:14 +00:00
vadimt 77d4204544 Temporarily not using RuleChain as it mysteriously breaks tests
am: 63013c5e57

Change-Id: I0e105abbf0f3a52124f40a44ba4c5f0cc2bc2fc8
2019-06-05 19:55:38 -07:00
Sunny Goyal 5db7cb9c2d Merge "Fixing wrong origin when launching new task from overview" into ub-launcher3-qt-dev
am: bfaabbea81

Change-Id: Ie0939ae8c5286631da3ef08ffaf0151bdc81c7e6
2019-06-05 19:54:59 -07:00
vadimt 63013c5e57 Temporarily not using RuleChain as it mysteriously breaks tests
Change-Id: I8bdd9a8ea12cfdbd92fe724181e7479cadcb26fe
2019-06-05 18:34:23 -07:00
Tony Wickham df4727e8ee Fix flicker to OVERVIEW state during quick switch
Here's what was happening:
- When animating to a new task, the launcher controller ends first (when
  quick switching it likely ends immediately since we're already scaled up).
- Then we get onApplyWindowInsets(), which re-builds the launcher controller.
- Finally, the window animation ends, invalidating the handler and ending
  the new controller, which sets the state to OVERVIEW.

To fix this, never create a new controller if it has ever been started.

Bug: 133508173
Change-Id: Ibd0e18e488353df73159ffbdd9a3b335bed57d98
2019-06-05 17:19:20 -07:00
Sunny Goyal bfaabbea81 Merge "Fixing wrong origin when launching new task from overview" into ub-launcher3-qt-dev 2019-06-06 00:16:29 +00:00
Vadim Tryshev be8f7d2845 Merge "Taking local screenshot before navigation state is restored" into ub-launcher3-qt-dev
am: e7f313dc0c

Change-Id: I210029248261971df07524e7836a54bd721daa4e
2019-06-05 16:48:56 -07:00
Vadim Tryshev e7f313dc0c Merge "Taking local screenshot before navigation state is restored" into ub-launcher3-qt-dev 2019-06-05 23:34:05 +00:00
vadimt 7a38854284 Taking local screenshot before navigation state is restored
Change-Id: Id8003b17c68af5b4882bdbf5e14a142875791cbc
2019-06-05 16:18:55 -07:00
Tony Wickham dd31cda247 Merge "Fade out scrim when swiping to home" into ub-launcher3-qt-dev
am: be1fde798c

Change-Id: I490a890b122a87a42e21b2dda30abb32c209a717
2019-06-05 15:36:30 -07:00
Tony Wickham be1fde798c Merge "Fade out scrim when swiping to home" into ub-launcher3-qt-dev 2019-06-05 22:27:49 +00:00
Sunny Goyal 90e9352ee1 Merge "Allowing tracing to be enabled using command line on all build flavors" into ub-launcher3-qt-dev
am: 0d6856a108

Change-Id: I8366486c5370ed34f2694b37be41f6fed7e66d54
2019-06-05 15:19:24 -07:00
Sunny Goyal 0d6856a108 Merge "Allowing tracing to be enabled using command line on all build flavors" into ub-launcher3-qt-dev 2019-06-05 22:04:25 +00:00
Sunny Goyal 17ccea1ec9 Merge "Adding some state for fallback recents View" into ub-launcher3-qt-dev
am: 4ab6254bdc

Change-Id: I6a4e56565114a30b9b98c640b54fb55c6ea10e15
2019-06-05 14:49:45 -07:00
TreeHugger Robot 4ab6254bdc Merge "Adding some state for fallback recents View" into ub-launcher3-qt-dev 2019-06-05 21:40:38 +00:00
Sunny Goyal b88d4a64fd Allowing tracing to be enabled using command line on all
build flavors

Change-Id: I5f8ee996bdcede2393eeb4aaa1b45fec7619d405
2019-06-05 14:09:51 -07:00
Zak Cohen 55dfef4aa2 Remove unused hints code.
am: 8d19146b7b

Change-Id: Ib2d24730a4e11cb376851056324380d6f173b43d
2019-06-05 12:39:04 -07:00
Sunny Goyal bda6b45341 Fixing wrong origin when launching new task from overview
> Also removing some unnecessary layout passes during launch animation

Bug: 133226418
Change-Id: I36fe69827853366deb7c56ca25f39e20c1a0b825
2019-06-05 12:25:28 -07:00
Winson Chung 4934b6f89f Merge "Use device locked input consumer when an activity is showing when locked" into ub-launcher3-qt-dev
am: ff9fe09b3f

Change-Id: Ife915a7d822a865da477979bb3ca290949843c69
2019-06-05 11:32:52 -07:00
Zak Cohen 8d19146b7b Remove unused hints code.
This layout is handled by the provider of the hints now.

Bug: 132886768
Test: manual
Change-Id: Ifc0db2395a7503b1b03dcb796961ef6647c0413b
(cherry picked from commit f3231f417d)
2019-06-05 11:18:09 -07:00
Jon Miranda 88dd84254c Reduce alpha delay 25ms to reduce flashy feeling of appearing large.
Bug: 123900446
Change-Id: Ia8ff74eb6b65affbf5c6c1599f4d168b459f324e
2019-06-05 11:07:17 -07:00
Sunny Goyal 87c8a511cd resolve merge conflicts of f17eb616a8 to ub-launcher3-qt-r1-dev
Bug: None
Test: I solemnly swear I tested this conflict resolution.
Change-Id: I4e177dfb7ba3bde6eb53f63c2f2df273feef90ee
2019-06-05 10:44:02 -07:00
Tony ae087dc9b8 Fade out scrim when swiping to home
Bug: 134517106
Change-Id: Ica725e3a327c1c069e3859732ea6a878d361a3d8
2019-06-04 19:25:03 -07:00
vadimt 8474ab2b9d Merge "Fixing All Apps's getting stuck in a non-updating state" into ub-launcher3-qt-dev
am: 8789aa05a1

Change-Id: I583ea8c9e6920aa072fa29087c51ce817e6b9d63
2019-06-04 17:51:24 -07:00
Winson Chung ff9fe09b3f Merge "Use device locked input consumer when an activity is showing when locked" into ub-launcher3-qt-dev 2019-06-04 21:42:44 +00:00
TreeHugger Robot f17eb616a8 Merge "Some RecentsView layout fixes" into ub-launcher3-qt-dev 2019-06-04 21:34:19 +00:00
Sunny Goyal 1b52c7e5de Some RecentsView layout fixes
> Only creating task overlay for one view at a time
> Fixing setOverviewStateEnabled called twice when going
  between OVERVIEW and BACKGROUND state

Bug: 132815672
Bug: 122345781
Change-Id: I51ac5b0744af87194eca08e07fd2c75b8fa0d3e0
2019-06-04 14:17:30 -07:00
Winson Chung ed6a3eada7 Use device locked input consumer when an activity is showing when locked
Bug: 133871965
Change-Id: I51a32a99990813e510c757e5e295a09f041c0514
2019-06-04 10:40:31 -07:00
Perumaal Shanmugam 067bce7d8a Merge "Re-enable chips in qt-r1-dev" into ub-launcher3-qt-r1-dev 2019-06-04 17:29:10 +00:00
TreeHugger Robot 8789aa05a1 Merge "Fixing All Apps's getting stuck in a non-updating state" into ub-launcher3-qt-dev 2019-06-04 16:37:58 +00:00
vadimt 3ca5280186 Fixing All Apps's getting stuck in a non-updating state
Normally, if all apps is open, and an app installs/uninstalls/updates,
All Apps will immediately reflect this.

However, depending on something subtle in the intensity of the swipe
gesture that brought All Apps, all apps will freeze, and won't update.

This frozen state will go away after scrolling in all apps, iteration
with an icon and, generally, any tap interaction with All Apps.
Otherwise, it will stay until it's closed and opened again via a gesture
with a different pattern.

The reason is in the code that freezes All Apps updates during user
interactions with all apps.

For example, during scrolls. Or while the user holds an icon, expecting
to see a context menu; in this case an update would cause the menu to
not appear, which is somewhat annoying.

The motivation to add this code was to solve a category of lab-only
flakes when a context menu couldn't open because the lab device was busy
with post-flash activities.

The code incorrectly assumed that after ACTION_DOWN, we are guaranteed
to get either UP or CANCEL, which is wrong.

It's after *consumed* ACTION_DOWN that we'll get these events.

The fix still solves the user's and tests' problems that the code was
supposed to solve.

Bug: 134442147
Change-Id: I9db74a33ecf93b1dc6bc69df301f7f542dea2a40
2019-06-03 18:35:52 -07:00
Sunny Goyal 7241d7cfe5 Merge "Removing user locked change in LauncherAppState" into ub-launcher3-qt-dev
am: ce0c093133

Change-Id: Ib85ff9f162f4511726d270e9d1ab94734c04e054
2019-06-03 16:55:12 -07:00
TreeHugger Robot ce0c093133 Merge "Removing user locked change in LauncherAppState" into ub-launcher3-qt-dev 2019-06-03 23:44:58 +00:00
Sunny Goyal d17a951df8 Removing user locked change in LauncherAppState
The process will crash anyway when loading sharedPreference. So
we do not need any extra check to cause the same crash.

Bug: 134094839
Change-Id: Icfd4406ff601d6b9a75bd95ddcecb9869f7e7fa2
2019-06-03 23:19:02 +00:00
TreeHugger Robot 0f405d78d7 Merge "Remove unused hints code." into ub-launcher3-qt-r1-dev 2019-06-03 23:02:01 +00:00
Sunny Goyal 9d8b1376e8 Adding some state for fallback recents View
Maintaining a boolean corresponding to overview or QuickSwitch which
updates the visuals for RecentsView accordingly

Bug: 134166337
Change-Id: If1aec99257de4db1796335f2cf39d2d35789915b
2019-06-03 16:00:06 -07:00
Hyunyoung Song 355a04ed39 Merge "Add shape detection logic only for circle icons" into ub-launcher3-qt-dev
am: ed45267bf9

Change-Id: I73fb9cfb2ed66bf88baa62f53714c028ea47b648
2019-06-03 15:46:47 -07:00
Hyunyoung Song ed45267bf9 Merge "Add shape detection logic only for circle icons" into ub-launcher3-qt-dev 2019-06-03 22:34:02 +00:00