Commit Graph

60338 Commits

Author SHA1 Message Date
Mady Mellor b7dce64db5 Merge "Add Bubbles and BubblesListener to SystemUiProxy and use it" into udc-dev 2023-05-06 17:22:06 +00:00
Brian Isganitis 0b53332c31 Merge changes I35fe528b,Ia612c1b5 into udc-dev
* changes:
  Don't close AFVs when opening Taskbar folder.
  Keep persistent Taskbar visible over Taskbar All Apps.
2023-05-06 14:42:54 +00:00
Sunny Goyal 3a75b494f2 Merge "Fixing WidgetBottomSheet getting cut off around insets" into udc-dev 2023-05-06 09:43:06 +00:00
Treehugger Robot 698f59ccbb Merge "Loading widget description on the background thread" into udc-dev 2023-05-06 08:19:12 +00:00
Winson Chung 8e7e159645 Merge "Try to detect and handle delayed quickswitch task launch failure" into udc-dev 2023-05-06 07:12:18 +00:00
Fengjiang Li 9a055ee5dd Merge "[3/n] Update StartupLatencyLogger's @VisibleForTesting" into udc-dev 2023-05-06 03:32:03 +00:00
Treehugger Robot 8b0fcbffb0 Merge "Updating SurfaceTransactionApplier to handle view not being attached" into udc-dev 2023-05-06 01:57:51 +00:00
Sebastián Franco 5fd9a76760 Merge "Call getModelWriter() to get the newest version instead of using the old one" into udc-dev 2023-05-06 00:22:20 +00:00
Winson Chung df51c1ada8 Try to detect and handle delayed quickswitch task launch failure
- The main issue arises when a task is successfully launched from
  overview, but the activity later finishes (ie. during resume) which
  prevents the usual logic of resetting Launcher to a good state
  (ie. it can get stuck in overview with a blank or empty snapshot)

  In this case, the Launch will "succeed" so that onTaskLaunchFailed
  is not called, but then also silently fail (launched task finishes
  and Launcher is again resumed) before Launcher stops, which does the
  usual resetting of the state back to normal state after quickswitching.

  This change checks for this case by listening for the activity and
  transition state, and in the case where Launcher has not been stopped
  or is resumed again after the transition finishes, returns the
  user to the default home state.

  This primarily only affects quickswitch for now, as other launch
  failures leave the user in a valid state (ie. overview) while this
  issue will leave the user in background state while quickswitching.

Bug: 268448123
Test: Quickswitch to an activity that finishes when resumed
Change-Id: I7d554f8fd521f7bc480dc06930ad91eeef0f1a1a
2023-05-05 23:55:22 +00:00
Sunny Goyal 2185f6f420 Loading widget description on the background thread
Bug: 281074741
Test: Varified on device
Flag: N/A
Change-Id: I6b9b13e712534bdc582b98dbfb7bdfcc40d2f19d
2023-05-05 23:15:41 +00:00
Sunny Goyal e7da062d9a Fixing WidgetBottomSheet getting cut off around insets
Bug: 265639220
Test: Verified on device
Flag: N/A
Change-Id: If595fde8e84a226aef82f41caa0be913b22d99c2
2023-05-05 23:15:31 +00:00
Sunny Goyal 63cf4d07a8 Updating SurfaceTransactionApplier to handle view not being attached
Bug: 278833389
Test: Presubmit
Flag: N/A
Change-Id: I88c240a1a7bdfe2e68c858c30e91cc5d06bc7bcf
2023-05-05 15:57:42 -07:00
Saumya Prakash 958eabcd8f Merge "Remove unused Sandbox Mode in the gesture navigation tutorial" into udc-dev 2023-05-05 22:52:54 +00:00
Sebastian Franco a64f3a6c98 Call getModelWriter() to get the newest version instead of using the old one
DropTargetHandler was calling getModelWriter() on a final variable
and the model writer it was using was and old one.

Fix: 280170665
Test: Manul test, delete widget and rotate the device, you have to do this twice.
Change-Id: I7b3ac4b272568fcc81438ffd5ac84cf7b64a62ea
2023-05-05 16:09:38 -06:00
Anushree Ganjam b7c43c94db Merge "Introduce new Attributes to indicate data source of Toast results." into udc-dev 2023-05-05 21:43:45 +00:00
Mady Mellor 50e8d0ff60 Add Bubbles and BubblesListener to SystemUiProxy and use it
Adds a method to call into WMShell to set the listener and
indicate when a bubble is shown or when the expanded state
changes.

BubbleBarController sets or clears out the listener.

BubbleBarViewController calls SystemUiProxy when bubbles are shown
or when the expanded state changes.

Bug: 253318833
Test: manual, with other CLs, see go/bubble-bar-tests
Flag: WM_BUBBLE_BAR
Change-Id: I2364b9bbdea237fc268b0999d9c896585c194a86
2023-05-05 14:18:00 -07:00
Brandon Dayauon 1ee28cd273 Merge "ENABLE_TWOLINE_ALLAPPS default true (only in teamfood)" into udc-dev 2023-05-05 20:49:58 +00:00
Sunny Goyal 2e17bcaa0b Merge "Simplifying widget cell layout" into udc-dev 2023-05-05 19:18:46 +00:00
Qiao Yang 1aee68df56 Merge "Revert "Revert "Listen for hover events over stashed taskbar.""" into udc-dev 2023-05-05 19:09:44 +00:00
Qiao Yang 2482c8dcd4 Revert "Revert "Listen for hover events over stashed taskbar.""
This reverts commit c27605099c.

Reason for revert: DroidMonitor-triggered revert due to breakage <https://android-build.googleplex.com/builds/quarterdeck?branch=git_udc-dev&target=cf_x86_64_phone-userdebug&lkgb=10076607&lkbb=10076982&fkbb=10076788>, bug <281093059>

Change-Id: I71e7fd07232c27a004243df0ffb0457fe53fe13b
2023-05-05 19:07:17 +00:00
Sunny Goyal d17c8add74 Merge "Revert "Revert "Changing GridMigrationTask to use ModelDbController directly""" into udc-dev 2023-05-05 18:21:04 +00:00
Qiao Yang 51669b612f Merge "Revert "Listen for hover events over stashed taskbar."" into udc-dev 2023-05-05 18:05:16 +00:00
Pat Manning c27605099c Revert "Listen for hover events over stashed taskbar."
This reverts commit c5882bcdfc.

Reason for revert: b/281068877

Change-Id: I431678658fc464c995df0df5e3cac5491d91b052
2023-05-05 17:22:21 +00:00
Anushree Ganjam 8b42b73286 Introduce new Attributes to indicate data source of Toast results.
Bug: 278734310
Test: Manual
Flag: NA
Change-Id: I44fe19ba4f172b241edd958df5184793b4c6f74e
2023-05-05 17:03:49 +00:00
Stefan Andonian 5882e97857 Merge "Enforce setting up SystemUIProxy on the main thread." into udc-dev 2023-05-05 16:56:10 +00:00
Sunny Goyal 8de4199463 Simplifying widget cell layout
Calculating the preview scale during onMeasure to ensure the
content is never clipped.

Bug: 268715418
Test: Verified on device
Change-Id: Ia0fd5ca3ccaae9644e043d75f810e91909a2aea0
2023-05-05 09:28:30 -07:00
Sunny Goyal 8d9e468dbb Revert "Revert "Changing GridMigrationTask to use ModelDbController directly""
This reverts commit 30bb3a247a.

Reason for revert: Fixed original issue

Change-Id: I02d85d604631795d96f0379eb94b7b6789102ea9
2023-05-05 16:00:49 +00:00
Jordan Silva 11167aa1f2 Merge "Fix text sizes and alignment in drop target" into udc-dev 2023-05-05 14:09:23 +00:00
Holly Jiuyu Sun ae1c56e34d Merge "[play] Add debug config flag to GMS Play." into udc-dev 2023-05-05 06:55:43 +00:00
Brian Isganitis f3135fea05 Don't close AFVs when opening Taskbar folder.
Test: Manual
Fix: 276798702
Change-Id: I35fe528bf3ad7fb374b8d8ae83f0d525e131681e
2023-05-04 23:55:23 -04:00
Brian Isganitis 9c311b2917 Keep persistent Taskbar visible over Taskbar All Apps.
Additionally, this CL fixes some touchable insets issues with the
overlay window. Dragging and dropping is now reliable from taskbar while
All Apps or EDU is also open.

Change-Id: Ia612c1b5266a8fb2b7005a773fbd2b00ec4824db
Bug: 279465803
Bug: 275890048
Bug: 264463659
Flag: PERSISTENT_TASKBAR_OVER_TASKBAR_ALL_APPS (Teamfood)
Test: Taskbar is functional over All Apps and EDU.
2023-05-04 23:54:27 -04:00
Brandon Dayauon 017e7a2e06 ENABLE_TWOLINE_ALLAPPS default true (only in teamfood)
- modified test so enabling two line all apps work
- have appIconSelector() select from content description

bug: 275116822
test: manual
Change-Id: Id3ccc6859b55d6b8a80ca509d420409d484207cf
2023-05-04 19:37:48 -07:00
Treehugger Robot b6f64a4465 Merge "Listen for hover events over stashed taskbar." into udc-dev 2023-05-04 23:15:44 +00:00
Fengjiang Li 1ecbfe153c [3/n] Update StartupLatencyLogger's @VisibleForTesting
Change to use (otherwise = VisibleForTesting.PROTECTED)

Bug: Bug: 278092752
Test: print launcher startup latency logs locally
Flag: not needed
Change-Id: I19630cc3436370e4d6a846e58dee002e5d28d5d7
2023-05-04 16:13:24 -07:00
Stefan Andonian 672fa7a9a9 Enforce setting up SystemUIProxy on the main thread.
Bug: 280086782
Test: Added annotations and device did not crash under normal usage.
Change-Id: Ie587aafaaa018a3e6a5c33ca238e204f5cc0ea4e
2023-05-04 22:28:26 +00:00
Brian Isganitis 64ee67c6b5 Merge "Add header protection for Taskbar All Apps search bar." into udc-dev 2023-05-04 22:20:46 +00:00
Josep del Río 229d11892a Merge "Close floating panels on Launcher when using Escape" into udc-dev 2023-05-04 20:50:28 +00:00
Treehugger Robot 948962d0b7 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev am: d5668d10a7 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22972105

Change-Id: I2e6cd14bb8d3ee1f4557092a0e3325e23a2a8c32
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-04 19:59:32 +00:00
Bill Yi 8303ef30f3 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 2d464fea1c -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22972105

Change-Id: I54f7becc41a3dd68678436d7c442108ead72ff87
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-04 19:59:17 +00:00
Pat Manning c5882bcdfc Listen for hover events over stashed taskbar.
Bug: 243191650
Test: TaplTestsTaskbar
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: Ia189ac6a6097d073c40c69ead6ecaf398d22eba8
2023-05-04 20:35:44 +01:00
Brian Isganitis cd7078372a Merge "Only close overlays onTaskMovedToFront for desktop prototype." into udc-dev 2023-05-04 18:55:42 +00:00
Treehugger Robot d5668d10a7 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2023-05-04 18:53:24 +00:00
Charlie Anderson 178802d35c Merge "Revert "Changing GridMigrationTask to use ModelDbController directly"" into udc-dev 2023-05-04 17:58:01 +00:00
Treehugger Robot c2dca5fec4 Merge "Always insetting the widget by a minimum of 6dp" into udc-dev 2023-05-04 17:48:48 +00:00
Schneider Victor-tulias d1054fd86b Merge "Revert "Fix broken TaplTestsTaskbar splitscreen test cases"" into udc-dev 2023-05-04 16:55:21 +00:00
Brian Isganitis 0c7f244f18 Merge "Better handle large display and text scaling on EDU tooltip." into udc-dev 2023-05-04 16:30:07 +00:00
Josep del Rio 1d976c6702 Close floating panels on Launcher when using Escape
This change will make the Escape key close floating panels in
Launcher.

Bug: 280801803
Test: Flashed on device, tried with physical keyboard and panels
will close.

Change-Id: Ie09e57716a7be74638037abe6272b47eec1b8a6c
2023-05-04 16:07:50 +00:00
Charlie Anderson 30bb3a247a Revert "Changing GridMigrationTask to use ModelDbController directly"
This reverts commit 9ef41413e0.

Reason for revert: This was the only launcher CL during the time  b/280669657 and 280680602 occurred

Change-Id: Id7107f0935f84908ca87e1ae4c62ab05efe41a24
2023-05-04 15:19:58 +00:00
Fengjiang Li efb0c4e98c Merge "[2/n] Refactor StartupLatencyLogger 1. Use kt stirng's $substitutions for StartupLatencyLogger 2. Add "otherwise =" for @VisibleForTesting" into udc-dev 2023-05-04 13:39:08 +00:00
Tony Huang 2725473272 Merge "Send divider change to launcher to animate" into udc-dev 2023-05-04 13:02:53 +00:00