Commit Graph

33151 Commits

Author SHA1 Message Date
Bill Lin b61a3850b2 Merge changes I7b9e6e7f,I9729cd40 into sc-dev am: 51b35256d2 am: ae054d8584
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14800258

Change-Id: I775c0edcfe403c854a7c87104fa9aba78761f18d
2021-06-04 00:49:48 +00:00
Wei Sheng Shih 4ff61e0876 Merge "Read the starting surface icon size from framework" into sc-dev am: 630efccd7a am: e909a01164
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14609921

Change-Id: I48b29916929c0e6ebae7e6cb0ca4a362557c07a8
2021-06-04 00:49:35 +00:00
Brian Isganitis d8998a9fab Merge "Update preferences to Material Next styling" into sc-dev am: b177133e7b am: aa6aa7bb69
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14740617

Change-Id: I952a8818396916db08100a0b02cc606230da9cae
2021-06-04 00:49:26 +00:00
Bill Lin ae054d8584 Merge changes I7b9e6e7f,I9729cd40 into sc-dev am: 51b35256d2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14800258

Change-Id: I7dd368b3289795396bcc967e3650abfb64e40390
2021-06-04 00:31:54 +00:00
Bill Lin 51b35256d2 Merge changes I7b9e6e7f,I9729cd40 into sc-dev
* changes:
  2/ Notify adjust touch slop when one handed mode activated
  1/ Provides feasibility to adjust touch slop in TouchController
2021-06-04 00:16:12 +00:00
Brian Isganitis f8bf0c6307 Show toolbar back button on subsettings pages am: 6afcfd7cbd am: d2ad24f763
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14741513

Change-Id: I8c09f6b7661efd876f69b08c115ee8facebcd975
2021-06-03 23:01:58 +00:00
Brian Isganitis bd9f4db7de Pad bottom of settings list view with bottom system insets am: ed49a7187d am: fc96a7d41e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14738959

Change-Id: Ie8c7a86a9a1ff66090cf67e6a36a51ed3672abe1
2021-06-03 23:01:57 +00:00
Brian Isganitis d2ad24f763 Show toolbar back button on subsettings pages am: 6afcfd7cbd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14741513

Change-Id: I1044251b276263c7315328e635fd2f9d7723562a
2021-06-03 22:38:13 +00:00
Brian Isganitis fc96a7d41e Pad bottom of settings list view with bottom system insets am: ed49a7187d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14738959

Change-Id: I71a84336583875e70afbdce0e80a6df09da5f328
2021-06-03 22:38:11 +00:00
Brian Isganitis 6afcfd7cbd Show toolbar back button on subsettings pages
Test: Back button displayed and functional on subsettings
Bug: 187732263
Change-Id: I6a3679de3a00480f5a0861f966d178be25f001d4
2021-06-03 17:04:33 -04:00
Brian Isganitis ed49a7187d Pad bottom of settings list view with bottom system insets
This change allows for a transparent navigation bar in the settings Material next redesign.

Test: Bottom of settings not cut off by bottom navigation bar
Bug: 187732263
Change-Id: I237011003ca0c3760c0fbdbb2865ef90c19d7b81
2021-06-03 17:02:05 -04:00
Jonathan Miranda df3caf7274 Merge "Only inset widgets if workspaceTopPadding is greater than the widget padding." into sc-dev am: 3ed65ede16 am: 328a2bd5ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14823934

Change-Id: Id16a11d69a03051846aa52edcf2a4935e1bfc4b1
2021-06-03 20:58:39 +00:00
Jonathan Miranda 328a2bd5ef Merge "Only inset widgets if workspaceTopPadding is greater than the widget padding." into sc-dev am: 3ed65ede16
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14823934

Change-Id: I76ecb9bb0cf1bd6e768dca2c8c7ee4f1e835c4ab
2021-06-03 20:41:22 +00:00
Jonathan Miranda 3ed65ede16 Merge "Only inset widgets if workspaceTopPadding is greater than the widget padding." into sc-dev 2021-06-03 20:23:18 +00:00
Bill Lin a1221bcd53 2/ Notify adjust touch slop when one handed mode activated
When one handed mode activated, user swipe-up to exit usually
cross over the NavBar region, and then invoke TouchController
intercept touch event to trigger All Apps drawer on Home.

To enhanced the UX of gesture conflict of exit OHM & All Apps,
notify TouchController throught LauncherActivityInterface,
and Launcher dispatch onOneHandedModeStateChanged() event to
all mTouchControllers in DragLayer that touchController can
adjust the touch slop by it's SingleAxisSwipeDetector.

Test: manual trigger One handed mode and swipe-up to exit
Test: monitor minDisplacement of SingleAxisSwipeDetector
      OHM activated : touchSlop x multiplier
      OHM deactivated : touchSlop x 1
Test: check All Apps doesn't mis-trigger when exit one handed mode
Bug: 186235522
Change-Id: I7b9e6e7fa898231697d1866186a5f9b1717a9aa3
2021-06-04 01:44:51 +08:00
Bill Lin 945bb34b5e 1/ Provides feasibility to adjust touch slop in TouchController
There is a case when one handed mode triggered(Activated), all apps
drawer is very easy to trigger while user swipe up around NavBar
region to exit one handed mode. Since System Gesture monitor regsion
is small on screen bottom, swipe-up gesture usually cross over NavBar
monitor region and invoke launcher touch controller intercept touch
event and introduce unexpectedly trigger all apps drawer.

Adding onOneHandedModeStateChanged(boolean activated) for controller
be able to adjust the touch slop by multiplier, we can set a larger
multiplier when the visible window size translate become smaller
and make swipe gesture not too sensitive.

Test: manual swipe up to swich "home <-> all apps" and monitor
      minDisplacement of SingleAxisSwipeDetector
Test: Trigger one handed mode and swipe up to exit one handed mode
      check the minDisplacement of SingleAxisSwipeDetector
Bug: 186235522
Change-Id: I9729cd408d85b2b22582bf800e28d1471fc06980
2021-06-04 01:44:50 +08:00
Zak Cohen 333fed77a4 Merge "RecentsView - reduce work in color tint animator" into sc-dev am: d7129fc919 am: 68df577307
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14803765

Change-Id: If649266bbe8ff16829ea54a63ee80a131c0015e0
2021-06-03 17:44:40 +00:00
Zak Cohen 68df577307 Merge "RecentsView - reduce work in color tint animator" into sc-dev am: d7129fc919
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14803765

Change-Id: Id0679baf604aa354dfe2013e5575193b389a07e5
2021-06-03 17:25:15 +00:00
Zak Cohen d7129fc919 Merge "RecentsView - reduce work in color tint animator" into sc-dev 2021-06-03 17:09:45 +00:00
Jon Miranda 4981118478 Only inset widgets if workspaceTopPadding is greater than the widget padding.
This prevents widget from becoming too close to status bar.

Bug: 189724771
Test: manual
Change-Id: I86f83b6a35bd2802bdbdf175340a379b498f481d
2021-06-03 09:54:45 -07:00
Stevie Kideckel c4c42616c5 Merge "Scroll to the selected widget picker row after headers are clicked" into sc-dev am: f15214597e am: 9753e04102
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14800533

Change-Id: Ie8566f94997ebec0b2d3188fd6ed50f3b54e226e
2021-06-03 14:45:31 +00:00
Stevie Kideckel 9753e04102 Merge "Scroll to the selected widget picker row after headers are clicked" into sc-dev am: f15214597e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14800533

Change-Id: Id2eb8a264a9ecf6e7c983d6d0f513bef12f3901e
2021-06-03 14:26:13 +00:00
Stevie Kideckel f15214597e Merge "Scroll to the selected widget picker row after headers are clicked" into sc-dev 2021-06-03 14:15:00 +00:00
Shawn Lin c82756d9e1 Merge "Detach the nav once the endTarget is determined as HOME" into sc-dev am: cd0fe7b057 am: 05fb88806e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14811742

Change-Id: Ia2dd12600eb40e5b72f289e083f548b0f9948d48
2021-06-03 12:20:01 +00:00
Shawn Lin 05fb88806e Merge "Detach the nav once the endTarget is determined as HOME" into sc-dev am: cd0fe7b057
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14811742

Change-Id: Ie2d67370b1e55393ef1530de4485d9cf15c3f663
2021-06-03 12:01:31 +00:00
Shawn Lin cd0fe7b057 Merge "Detach the nav once the endTarget is determined as HOME" into sc-dev 2021-06-03 11:47:50 +00:00
Stevie Kideckel 80d0956b75 Merge "Use the LayoutManager as the source of truth for visible positions" into sc-dev am: 5cc44eb73e am: f492620c7d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14800536

Change-Id: I7e3429c771529dc32ce4f646acf80b079dee1078
2021-06-03 11:26:11 +00:00
Alina Zaidi 435fe175e6 Merge "Update scrim in widget pickers." into sc-dev am: c599c90eaa am: 2882bf5180
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14776603

Change-Id: I6e1d10c7dbac9e8e062badad6b68e63dd709bd3e
2021-06-03 11:25:33 +00:00
Stevie Kideckel f492620c7d Merge "Use the LayoutManager as the source of truth for visible positions" into sc-dev am: 5cc44eb73e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14800536

Change-Id: I1a83d512bcf6c4778c63f672c1044613d01f9183
2021-06-03 11:05:48 +00:00
Alina Zaidi 2882bf5180 Merge "Update scrim in widget pickers." into sc-dev am: c599c90eaa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14776603

Change-Id: I3f491a8dabbdb9c086349f1db2fab8942c8c38a9
2021-06-03 11:05:43 +00:00
Stevie Kideckel 5cc44eb73e Merge "Use the LayoutManager as the source of truth for visible positions" into sc-dev 2021-06-03 11:00:32 +00:00
Alina Zaidi c599c90eaa Merge "Update scrim in widget pickers." into sc-dev 2021-06-03 10:42:29 +00:00
Stevie Kideckel eb367e471b Scroll to the selected widget picker row after headers are clicked
This keeps the row in view. Currently, this will scroll the row to the
centre-bottom of the screen due to the top padding being double counted,
but that will remedied in a future CL.

This also resolves the issue where the last row's widgets aren't visible
by handling that case specially

Fix: 188665456
Bug: 183378651
Test: verified locally
Change-Id: I9acb9087a8cdaf130ac5955c810c96462b368f36
2021-06-03 09:48:21 +00:00
Stevie Kideckel abd33b38e2 Use the LayoutManager as the source of truth for visible positions
During animations, the view group child may not correspond to the
visible views that appear at the top.

The previous logic is kept in the case that the layout manager returns
null for any reason, which can happen before layout has occurred for the
position.

Fix: 189588014
Test: verified locally
Change-Id: Ie8b5dcef50287e9e90a21f86e30a1ebcbbcba30f
2021-06-03 09:36:22 +00:00
Wei Sheng Shih e909a01164 Merge "Read the starting surface icon size from framework" into sc-dev am: 630efccd7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14609921

Change-Id: I7e9b8813fea7d2ed9cdef8c163f65875c9f026c1
2021-06-03 06:49:47 +00:00
Brian Isganitis aa6aa7bb69 Merge "Update preferences to Material Next styling" into sc-dev am: b177133e7b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14740617

Change-Id: I591b173c7c0bfdb595daea64da2f5e9e7d2c23f1
2021-06-03 06:49:14 +00:00
shawnlin 2b006fb27b Detach the nav once the endTarget is determined as HOME
Bug: 189900722
Test: manual - swipe up to home from an app and observe the nav
Change-Id: I421de17fe4d8413deaf9ebd63166a6d2d00d096e
2021-06-03 13:06:42 +08:00
Jon Spivack 9fb00f09bf Merge "TaskOverlayFactoryGo: Keep persistent instance of AssistContentRequester" into sc-dev am: b7cecf8a90 am: 47229933c7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14803962

Change-Id: I6a22b27f5d28fd2660d175b8c39d2376a5d2a32b
2021-06-03 02:52:36 +00:00
Jon Spivack 47229933c7 Merge "TaskOverlayFactoryGo: Keep persistent instance of AssistContentRequester" into sc-dev am: b7cecf8a90
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14803962

Change-Id: Ie7c8791e8a57003b176a09909a78a9474e7edd95
2021-06-03 02:33:06 +00:00
Jon Spivack b7cecf8a90 Merge "TaskOverlayFactoryGo: Keep persistent instance of AssistContentRequester" into sc-dev 2021-06-03 02:20:26 +00:00
Weilun Du 916db72512 Merge "Revert "Update preferences to Material Next styling"" into sc-dev am: 971d7fddcc am: 83e5591f21
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14805276

Change-Id: I09bf6aea8afc196ac7c624008853bb7187e12fbf
2021-06-03 00:42:16 +00:00
Weilun Du 83e5591f21 Merge "Revert "Update preferences to Material Next styling"" into sc-dev am: 971d7fddcc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14805276

Change-Id: I0b491f758466125349f0a589bc76cf0a995fbfef
2021-06-03 00:25:04 +00:00
Weilun Du 971d7fddcc Merge "Revert "Update preferences to Material Next styling"" into sc-dev 2021-06-03 00:04:49 +00:00
Jon Spivack 1bd7ccd90b TaskOverlayFactoryGo: Keep persistent instance of AssistContentRequester
Holding a reference to AssistContentRequester prevents it from being deleted by the garbage collector while it is still in use.

Bug: 189985872
Test: Manual (Pixel 3A)
Test: m -j RunLauncherGoGoogleRoboTests
Change-Id: I204aab907175a171c496c3bd146a8b23d2bbcf16
2021-06-02 16:40:09 -07:00
zakcohen da08cb2639 RecentsView - reduce work in color tint animator
Don't allocate animators when there is no animation to do. The work was
not required.

Bug: 189492167
Test: Local build, run and trace analysis
Change-Id: I111768b055ed636aa92d5d9d6b799f316a568380
2021-06-02 15:46:46 -07:00
Weilun Du 19d623d921 Revert "Update preferences to Material Next styling"
Revert "Add dependency for settings activity collapsing toolbar"

Revert submission 14740617-collapse3

Reason for revert: Build breakage
Reverted Changes:
I5ef658979:Add dependency for settings activity collapsing to...
I0ca55eecb:Update preferences to Material Next styling

Bug: 189919452
Change-Id: I4aa0bfc473334266a951d84064b4e8e406fff0a4
2021-06-02 22:04:44 +00:00
TreeHugger Robot 1eeb4c9586 Merge "AssistContentRequester move binder call to background thread." into sc-dev am: 8c46bba98e am: dde88a739e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14801431

Change-Id: I6f9f5b23bd07ef54de6f00273a3de03a8c1e327b
2021-06-02 20:59:47 +00:00
Pat Manning 2d39dfa747 End drag touch event when crossing task drag threshold, and only when task is going up (drag to dismiss) am: 49cb49b1f5 am: 765b8dc7c2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14800534

Change-Id: Ic13d8803b5a5a9ad7fd52edf431cb26db89338db
2021-06-02 20:59:42 +00:00
TreeHugger Robot dde88a739e Merge "AssistContentRequester move binder call to background thread." into sc-dev am: 8c46bba98e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14801431

Change-Id: I08dbfabda7b1c233a39618536d95acbeb53ccbcd
2021-06-02 20:39:50 +00:00
Pat Manning 765b8dc7c2 End drag touch event when crossing task drag threshold, and only when task is going up (drag to dismiss) am: 49cb49b1f5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14800534

Change-Id: I176a2014bbddf096b25130be4f5d9348c58c1b4c
2021-06-02 20:39:32 +00:00