- Don't set current page to running task when applying load plan,
if we are already settling on a new task to launch.
- When starting a new task, finish to the running app if that's
the task being started (should not happen with above change)
- When disabling free scroll mode, don't snap to a page if we're
already on it. This was setting mNextPage so the first check
was falsing.
Bug: 142068081
Change-Id: I5b392d9726a81c51718d2f94eee6cd4f78b61f69
Merged-In: I5b392d9726a81c51718d2f94eee6cd4f78b61f69
(cherry picked from commit af33f2c9d4)
Once the inputProxy (OverviewInputConsumer) was enabled, it was never
disabled. And while it was enabled, touches above the nav bar would go
through to launcher, allowing you to scroll RecentsView (for example)
during quick switch transitions. This breaks some assumptions, since
it doesn't go through our normal shared swipe state logic that cancels
the animation, updates the new end target (e.g. NEW_TASK vs LAST_TASK),
etc. Thus, if you tried returning to LAST_TASK via this route, we would
end up starting it as a new activity instead of resuming the existing
one, causing a flicker (I guess because that TaskView is hidden).
Test:
- Swipe up from task A to home (to enable input proxy)
- Open A
- Swipe to B, and during transition scroll back to A from the center of
the screen
Before, this caused a flicker, now the last scroll is ignored.
TODO: we should increase the nav region during quick switch to make it
easier to continue scrolling
Bug: 136829198
Bug: 138620399
Change-Id: I5ffb53743b728e1909066c5dd18cc9308aff2c7e
(cherry picked from commit c9654eb091)
(cherry picked from commit 2784315f7d)
This can happen in LockTask mode, after enabling Overview. In that case,
you are locked to the current task, but are allowed to go to overview
but no tasks are shown there.
Bug: 139917483
Change-Id: I2180cc5e72c343977ea53cc02907ed8dac0f8bc6
Merged-In: I2180cc5e72c343977ea53cc02907ed8dac0f8bc6
(cherry picked from commit 60bf8c117b)
Test: Manual
Bug:135864059 P4 [Live Tiles] Empty launcher
Bug:139137636 P2 Create memory tests for Launcher
Bug:139281702 P2 [Enterprise - Cloud DO] GSOC and Mobile Utilities launcher icons are in broken state
Bug:140837771 P1 Failing test: AddConfigWidgetTests and AddWidgetTests are failing
Bug:141024521 P2 Tapping nav bar during quick switch causes scroll animation to cancel and not resume
Bug:141184247 P1 Clear all button not present in fallback recents in 3-button mode
Change-Id: I99f4db995a2af5959d5be4182f4e47bb67c9cbc4
We weren't calling onSwipeUpToRecentsComplete(), which meant we kept the
disallowScrollToClearAll from prepareRecentsUi indefinitely.
Also don't update the icon scale if it is supposed to be scaled down, to
avoid it from scaling up and overlapping with the app window.
Fixes: 141184247
Change-Id: I49406764373e7121e289da7477dcbb58d0b98fd5
Users report seeing empty launcher. After adding some logging, live tile
overlay can be added twice and removed only once. I added some logic to
make sure that it can only be added once.
Test: manual
Fixes: 135864059
Fixes: 140337263
Change-Id: I9d3325c56e76654f1397cc65979b97a6c0a80aee
(cherry picked from commit d3ef57b4dd)
(cherry picked from commit 4fa6f63ffd)
Users report seeing empty launcher. After adding some logging, live tile
overlay can be added twice and removed only once. I added some logic to
make sure that it can only be added once.
Test: manual
Fixes: 135864059
Change-Id: I9d3325c56e76654f1397cc65979b97a6c0a80aee
(cherry picked from commit d3ef57b4dd)
(cherry picked from commit 4fa6f63ffd)
Test: Manual
Bug:121280703 P2 Finish implementation of PortraitLandscape annotation for tests
Bug:135633159 P3 [QPR] Promise icons on home screen
Bug:135638690 P1 [QPR] On-device app search
Bug:137106918 P2 UX: Accidental NGA triggering when hitting Undo actions in apps
Bug:137200188 P3 Home screen app title disappears during animation
Bug:138195597 P2 Wrong icon animated on return to home screen
Bug:138396187 P1 Swipe and hold from an app no longer uses spring to animate adjacent task
Bug:138729157 P1 [Flaky test] java.lang.AssertionError: http://go/tapl : want to fling backwards in widgets, flung back, but the current state is not WIDGETS; Unexpected launcher object visible: workspace
Bug:138729456 P1 [Flaky test] java.lang.AssertionError: http://go/tapl : Can't find an object with selector: BySelector [CLASS='\Qandroid.widget.TextView\E', PKG='\Qcom.google.android.apps.nexuslauncher\E', TEXT='\QShortcut 3\E'] (visible state: Workspace)
Bug:138964490 P1 Support DeviceConfig to drive ToggleableFlags
Bug:139021165 P2 [TEST TRACKER] [QPR] Promise icons on home screen
Bug:139137636 P2 Create memory tests for Launcher
Bug:139551306 P4 [Polish] Reduce shelf paddings in Overview
Bug:139885365 P3 App open animation different between launcher suggested apps and launcher home screen/drawer
Bug:139918680 P2 [a11y] Talkback shouldn't keep focusing on the background item and speak the description of the background item again after entering Widget list.
Bug:140076379 P1 Launcher ub-launcher3-qt-qpr1-dev Branch Build Keeps Crashing due to Exception
Bug:140252951 P2 Add widget launch test.
Bug:140308849 P2 Jank during swipe up to home, especially noticeable after pausing first
Bug:140311911 P2 Flake in Launcher tests: java.lang.AssertionError: Stable state != state: OverviewState, LauncherState
Bug:140405990 P2 [a11y] Unable to add shortcut to Home screen by Voice access or Switch access.
Bug:140819614 P1 If an install session is abandoned for an already installed app, the corresponding icon is removed
Bug:140823188 P1 AppPredictionsUITests failing
Bug:140837771 P1 Failing test: AddConfigWidgetTests and AddWidgetTests are failing
Change-Id: I1efae6216c53b1fee3e105c9356ed43c4bf46c6e
Previously we were using OnGlobalLayoutListener, which is only called
when AllAppsContainerView or a child is re-laid out or visibility
changes to or from GONE. Since we no longer relayout when already
scrolled to the top, we need a better hook to check whether all apps has
changed visibility for the purpose of updating predictions.
Bug: 140823188
Change-Id: I7c4a0d94c529eb86b55729c75843c8b0bd673d8c
value, refresh icon cache
Bug: 135638690
Bug: 138964490
Test: manually toggled feature flag UI on/off
$ adb shell device_config put launcher APP_SEARCH_IMPROVEMENTS [true|false]
when launcher is in foreground and also when it is in the background
Afterwards, saw if "bank" would show BofA app or not
Change-Id: I98b62bd07b14a225168217d7eb9bfdfc7f74435d
- For app open, the icon text remains where it is and only the icon moves.
- Similarly for app close, the icon text remains where it is and fades in
with the rest of the other icons text.
- With this change, the original view is always "VISIBLE"
(if BubbleTextView/FolderIcon) but we hide certain elements.
Added video to bug.
Bug: 137200188
Bug: 139885365
Change-Id: I3d20c5f05bc7c0b9d052d8074ac3bfc21531c83d
Merged-In: I3d20c5f05bc7c0b9d052d8074ac3bfc21531c83d
Calling scrollToPosition on RecyclerView internally calls
requestLayout() (to cacluate where to scroll and then go there).
Therefore, we should avoid calling that whenever possible, especially
during transitions. In particular, we can optimize scrollToTop() to not
scrollToPosition() if we are already at the top.
This makes some other workarounds unnecessary, namely setting All Apps
to GONE during system gestures.
Test: Open an app, swipe up, ensure AllAppsRecyclerView doesn't get
onLayout(). If we had scrolled to an app first, we get one layout
in prepareRecentsUi(), but not during the transition.
Bug: 140308849
Change-Id: I62ee341bf5893c121cfc013cc6542559f79d2a42
We already set the all apps content visibility = GONE at the start of
the gesture to prevent relayouts, but when animating home we were
inadvertently changing it to INVISIBLE, causing a relayout and jank.
Bug: 140308849
Change-Id: I285746f8ac8f3f857282e22ebec8eebd0b98647f
Test: manual
Bug: 137777105
Log result for swiping in and out of -1 screen.
data {
elapsed_timestamp_nanos: 597609736235111
atom {
launcher_event {
action: SWIPE_LEFT
src_state: HOME
dst_state: HOME
is_swipe_up_enabled: true
}
}
}
data {
elapsed_timestamp_nanos: 597610569783111
atom {
launcher_event {
action: SWIPE_RIGHT
src_state: HOME
dst_state: HOME
is_swipe_up_enabled: true
}
}
}
Change-Id: Ic84d3c32d1c9f780f13ec5cd6320e9f1d610f018
Test: presubmit setup on source branch
Bug: 112282235 Starting an app from Launcher sometimes takes > 10 sec
Bug: 125027540 Apps to be searchable in different languages
Bug: 132336512 Notification dots on pinned shortcuts
Bug: 135218095 Disable unnecessary services
Bug: 136277517 Widgets often don’t support scroll direction up/down, left/right and use forward/backward instead
Bug: 137777105 Make clearcut launcher logging feature parity with westworld logging
Bug: 137952354 OnResume() and onStop logging doesn't reflect the real source id for -1 screen
Bug: 137953006 Swiping/fling up from workspace logged as hotseat
Bug: 138273985 The pause app message takes more than 30 seconds to display after restarting the device.
Bug: 138683199 Pass the captured snapshot data to Launcher when recents animation is cancelled
Bug: 138729456 [Flaky test] java.lang.AssertionError: http://go/tapl : Can't find an object with selector: BySelector [CLASS='\Qandroid.widget.TextView\E', PKG='\Qcom.google.android.apps.nexuslauncher\E', TEXT='\QShortcut 3\E'] (visible state: Workspace)
Bug: 138743758 [Flaky test] java.lang.AssertionError: App still doesn't have Pause action: com.google.android.calculator
Bug: 138743792 [Flaky test] java.lang.AssertionError: ensureScrollable didn't add Chrome app
Bug: 138964490 Investigate if ToggleableFlags can be connected with DeviceConfig
Bug: 139416391 CTS tests crash when app_prediction service is disabled
Bug: 139498375 Flake: java.lang.SecurityException: Injecting to another application requires INJECT_EVENTS permission
Bug: 139540363 Launcher goes in crash loop
Change-Id: Iaba4ed67e9fe4f8f5858324201e4c4e8711f59fa
Bug: 138964490
TL;DR;; need this to be part of QQ1 or QD1 to verify if DeviceConfig
can be supported for launcher toggleableFlags.
Not handled in this CL:
- When flag is locally modified, that will override the flag value
How that scenario is handled should be discussed separately and is not
within scope of this CL.
Change-Id: I2e6694a40bee9202ed0b0d559e3b5607634071bf
It was possible to invoke the assistant accidentally. This change
adds a minimum distance threshold before we register a fling (the
same distance as used for drag, 55dp).
Bug: 137106918
Test: manual; tested that accidental flings were much more difficult,
but intentional invocations were still easy to register
Change-Id: I40c8bd43c1a28c7b161467804a1e44746b8e92ef
Test: Manual
Bug:132455160 P1 [Gesture Nav] Home to Overview Transition Improvement
Bug:133472746 P1 "Now playing History" widget can't be added to desired area.
Bug:135558924 P4 Pixel Launcher app crash after applying custom Style
Bug:136282913 P1 Swipe up from Assistant Fulfillment Card Jank
Bug:136591785 P2 Tune swipe up to home animation
Bug:138117089 P1 Random misses in GL comp on Pixel 3a/XL
Bug:138609751 P2 Trying to start an app before it was downloaded caused pixel launcher crash
Bug:138620399 P1 Quick switch flicker / artifacts
Bug:138646754 P4 Switching from 3-button to gesture nav - all apps disappeared
Bug:138793362 P4 With animation disabled, Launcher crashing on docking apps in split screen from overview screen.
Change-Id: I4f3b286ae79566fd53072df621be98646d0457d7
TreeHugger Robot
Tony Wickham
Sunny Goyal
Tracy Zhou
Hyunyoung Song
Miranda Kephart
vadimt
Jon Miranda
Andy Wickham
Becky Qiu
Felipe Leme
Pinyao Ting
