Commit Graph

23402 Commits

Author SHA1 Message Date
Xin Li b482bb92e9 Skip QD1A.190821.011 in stage-aosp-master am: 6d14b39680
am: 3fdcb43a43

Change-Id: I2b1d7d8c2f49f38f47ad85eeab233a2a5a517dfd
2019-10-23 15:51:29 -07:00
Xin Li 3fdcb43a43 Skip QD1A.190821.011 in stage-aosp-master
am: 6d14b39680

Change-Id: I467211012653848fd3c52a78533bbe78511634dc
2019-10-23 15:32:10 -07:00
Xin Li 6d14b39680 Skip QD1A.190821.011 in stage-aosp-master
Bug: 141248619
Change-Id: I6f659f61e70630236cabf7a00af39ae2c2c7264c
2019-10-16 15:19:25 -07:00
Xin Li 20067eb669 Merge "DO NOT MERGE - Merge QP1A.191005.007 into master" am: db68a15812 am: f73d33c1fc
am: a45baaa6f5

Change-Id: I64ec016aa1472ec03f5b9ce3fd758eba506ac327
2019-10-10 21:51:17 -07:00
Xin Li a45baaa6f5 Merge "DO NOT MERGE - Merge QP1A.191005.007 into master" am: db68a15812
am: f73d33c1fc

Change-Id: I36a018d3b0ca376f2afcc934e8e57381e2b46143
2019-10-10 21:38:18 -07:00
Xin Li 57f0330698 DO NOT MERGE - Merge QP1A.191005.007 into master am: 272ecdce0b am: 87ff33d584
am: ca81ca46e5

Change-Id: Ief1a288837d491c74edad5a764247d68a341cdca
2019-10-10 21:33:57 -07:00
Xin Li f73d33c1fc Merge "DO NOT MERGE - Merge QP1A.191005.007 into master"
am: db68a15812

Change-Id: I671da88e2f1229b6e61787ceff16f56fb0978fbb
2019-10-10 21:27:48 -07:00
Xin Li ca81ca46e5 DO NOT MERGE - Merge QP1A.191005.007 into master am: 272ecdce0b
am: 87ff33d584

Change-Id: Ie9a283dec133135d7d85866f4452d1ba172fc657
2019-10-10 21:21:42 -07:00
Xin Li 87ff33d584 DO NOT MERGE - Merge QP1A.191005.007 into master
am: 272ecdce0b

Change-Id: Ie04781fc9e73dac178495bbc1e031f868d36f90a
2019-10-10 21:11:18 -07:00
Xin Li db68a15812 Merge "DO NOT MERGE - Merge QP1A.191005.007 into master" 2019-10-11 02:56:39 +00:00
Xin Li 272ecdce0b DO NOT MERGE - Merge QP1A.191005.007 into master
Bug: 142297020
Change-Id: I8ee6a4e97c145226a5a943a0882925c8c9525c81
2019-10-10 22:53:35 +00:00
Tony Wickham 15280b902c Merge "Fix quickswitch flickers/ignored swipes" into qt-qpr1-dev
am: a9012ea717

Change-Id: I06b5e3b8baa2a4d1041dfe9a99ad530c02d2229d
2019-10-09 13:37:16 -07:00
Tony Wickham afbb4a8a09 Don't allow scrolling RecentsView outside navbar during quickswitch
am: 80090d579f

Change-Id: Ib26bde87b9070a1a07e5bc12c11896e9d1bf4337
2019-10-09 13:36:40 -07:00
TreeHugger Robot a9012ea717 Merge "Fix quickswitch flickers/ignored swipes" into qt-qpr1-dev 2019-10-09 20:20:25 +00:00
Tony Wickham 4d86c804ba Fix quickswitch flickers/ignored swipes
- Don't set current page to running task when applying load plan,
  if we are already settling on a new task to launch.
- When starting a new task, finish to the running app if that's
  the task being started (should not happen with above change)
- When disabling free scroll mode, don't snap to a page if we're
  already on it. This was setting mNextPage so the first check
  was falsing.

Bug: 142068081
Change-Id: I5b392d9726a81c51718d2f94eee6cd4f78b61f69
Merged-In: I5b392d9726a81c51718d2f94eee6cd4f78b61f69
(cherry picked from commit af33f2c9d4)
2019-10-09 15:28:23 +00:00
Tony Wickham 80090d579f Don't allow scrolling RecentsView outside navbar during quickswitch
Once the inputProxy (OverviewInputConsumer) was enabled, it was never
disabled. And while it was enabled, touches above the nav bar would go
through to launcher, allowing you to scroll RecentsView (for example)
during quick switch transitions. This breaks some assumptions, since
it doesn't go through our normal shared swipe state logic that cancels
the animation, updates the new end target (e.g. NEW_TASK vs LAST_TASK),
etc. Thus, if you tried returning to LAST_TASK via this route, we would
end up starting it as a new activity instead of resuming the existing
one, causing a flicker (I guess because that TaskView is hidden).

Test:
- Swipe up from task A to home (to enable input proxy)
- Open A
- Swipe to B, and during transition scroll back to A from the center of
the screen

Before, this caused a flicker, now the last scroll is ignored.

TODO: we should increase the nav region during quick switch to make it
easier to continue scrolling

Bug: 136829198
Bug: 138620399
Change-Id: I5ffb53743b728e1909066c5dd18cc9308aff2c7e
(cherry picked from commit c9654eb091)
(cherry picked from commit 2784315f7d)
2019-10-09 05:38:20 +00:00
Jon Miranda 45bf381836 Fix NPE when trying to construct WorkspaceItemInfo with null intent data.
am: 79d6b30dce

Change-Id: I79cf5d9a560fa56beec1e7a6b5ff7c4fa47da4e5
2019-09-26 13:22:11 -07:00
Jon Miranda 79d6b30dce Fix NPE when trying to construct WorkspaceItemInfo with null intent data.
We change the way we parse the install queue; so this seems to be a rare case
when trying to flush an install queue from an old apk with a launcher apk
with the new parsing changes.

Bug: 140935140
Change-Id: I14db4c3f70ed2e1bc5ad31dec7e6473cd6f8f13c
2019-09-24 18:30:44 +00:00
Tony Wickham b8f722e7d2 Don't crash when swiping up if there are no TaskViews
am: d2d58656a4

Change-Id: I251ffd2ad1103efe1313e52e05f8a027789312d4
2019-09-23 15:44:27 -07:00
Tony Wickham d2d58656a4 Don't crash when swiping up if there are no TaskViews
This can happen in LockTask mode, after enabling Overview. In that case,
you are locked to the current task, but are allowed to go to overview
but no tasks are shown there.

Bug: 139917483
Change-Id: I2180cc5e72c343977ea53cc02907ed8dac0f8bc6
Merged-In: I2180cc5e72c343977ea53cc02907ed8dac0f8bc6
(cherry picked from commit 60bf8c117b)
2019-09-21 04:10:35 +00:00
Sunny Goyal 7f29c5caf3 Merging ub-launcher3-qt-qpr1-dev, build 5884665
am: 3adf6ff5a2

Change-Id: I624913ae82d86920c2013bea175d95c32be07d1b
2019-09-20 15:19:10 -07:00
Sunny Goyal 3adf6ff5a2 Merging ub-launcher3-qt-qpr1-dev, build 5884665
Test: Manual

Bug:135864059 P4 [Live Tiles] Empty launcher
Bug:139137636 P2 Create memory tests for Launcher
Bug:139281702 P2 [Enterprise - Cloud DO] GSOC and Mobile Utilities launcher icons are in broken state
Bug:140837771 P1 Failing test: AddConfigWidgetTests and AddWidgetTests are failing
Bug:141024521 P2 Tapping nav bar during quick switch causes scroll animation to cancel and not resume
Bug:141184247 P1 Clear all button not present in fallback recents in 3-button mode
Change-Id: I99f4db995a2af5959d5be4182f4e47bb67c9cbc4
2019-09-18 13:53:36 -07:00
Tony Wickham a0aee21fcd Update mIsBeingDragged in onTouchEvent(ACTION_DOWN)
The logic to keep mIsBeingDragged when touching down during a scroll
animation was in onInterceptTouchEvent(), which we were bypassing by
using onTouchEvent() directly. Now we update mIsBeingDragged on touch
down in both onInterceptTouchEvent() and in onTouchEvent().

Bug: 141024521
Change-Id: I77abd4c36f3ccee27e160c817dadb3923e6cfc06
2019-09-18 11:04:37 -07:00
Tony Wickham 24fb1526e2 Merge "Allow scroll to clear all in 3 button+fallback mode" into ub-launcher3-qt-qpr1-dev 2019-09-18 14:54:20 +00:00
Tracy Zhou b74d814c7c Make sure that live tile overlay is added only once.
am: 757d62dcaa

Change-Id: I55c1bfbdbbacc7a9884ad3289120ff71f0ecb53f
2019-09-17 20:30:03 -07:00
Jon Miranda 6ed680258e Fix BindWidgetTests.
Broken by change I03c31bb308fc496b9fc633c2fde23ae4568f8c44.

Bug: 139281702
Test: Ran BindWidgetTest with 8/8 successful.
Change-Id: I6a03744c9cd919316ff27b12c50acc70c91d47fa
2019-09-17 19:18:02 -07:00
Tony Wickham 0638249b3e Allow scroll to clear all in 3 button+fallback mode
We weren't calling onSwipeUpToRecentsComplete(), which meant we kept the
disallowScrollToClearAll from prepareRecentsUi indefinitely.

Also don't update the icon scale if it is supposed to be scaled down, to
avoid it from scaling up and overlapping with the app window.

Fixes: 141184247
Change-Id: I49406764373e7121e289da7477dcbb58d0b98fd5
2019-09-17 15:10:33 -07:00
Vadim Tryshev a24ed7267c Merge "Support for tests that a leak is detected" into ub-launcher3-qt-qpr1-dev 2019-09-17 19:16:00 +00:00
vadimt 8c2ae545cf Support for tests that a leak is detected
Bug: 139137636
Change-Id: Ib4f02d6b3798e3fdf3d8e5758c09d2b642404af5
Merged-in: Ib4f02d6b3798e3fdf3d8e5758c09d2b642404af5
2019-09-17 18:49:42 +00:00
Jon Miranda c1322b6ac8 Key by both package and user for list of active install sessions.
This fixes the bug where items are left on the home screen for the wrong
user.

Bug: 139281702
Change-Id: I03c31bb308fc496b9fc633c2fde23ae4568f8c44
2019-09-17 11:20:35 -07:00
Tracy Zhou 757d62dcaa Make sure that live tile overlay is added only once.
Users report seeing empty launcher. After adding some logging, live tile
overlay can be added twice and removed only once. I added some logic to
make sure that it can only be added once.

Test: manual
Fixes: 135864059
Fixes: 140337263
Change-Id: I9d3325c56e76654f1397cc65979b97a6c0a80aee
(cherry picked from commit d3ef57b4dd)
(cherry picked from commit 4fa6f63ffd)
2019-09-16 21:25:51 +00:00
Tracy Zhou 6b272369e7 Make sure that live tile overlay is added only once.
Users report seeing empty launcher. After adding some logging, live tile
overlay can be added twice and removed only once. I added some logic to
make sure that it can only be added once.

Test: manual
Fixes: 135864059
Change-Id: I9d3325c56e76654f1397cc65979b97a6c0a80aee
(cherry picked from commit d3ef57b4dd)
(cherry picked from commit 4fa6f63ffd)
2019-09-16 20:52:35 +00:00
Hyunyoung Song 1d43b107b3 Merging ub-launcher3-qt-qpr1-dev, build 5872416
am: a7a1b57bc8

Change-Id: I60dd1710d7c54e2e47b926453fd79a2c2031edd4
2019-09-13 15:54:36 -07:00
vadimt b1ccbd9def Fully qualifying @Ignore
Strangely, @Ignore-s won't be recognized in ub-launcher-master

Bug: 140837771
Change-Id: Ie5e4911d4812d396826b50024943c14c6bfe3376
2019-09-12 17:46:17 -07:00
Vadim Tryshev 90f4536ae3 Merge "Disable failing widget tests" into ub-launcher3-qt-qpr1-dev 2019-09-13 00:06:56 +00:00
vadimt b59f65d2d8 Disable failing widget tests
Bug: 140837771
Change-Id: Ibba7769543e682315ea23640f68416defa85f365
2019-09-12 17:05:39 -07:00
Hyunyoung Song a7a1b57bc8 Merging ub-launcher3-qt-qpr1-dev, build 5872416
Test: Manual

Bug:121280703 P2 Finish implementation of PortraitLandscape annotation for tests
Bug:135633159 P3 [QPR] Promise icons on home screen
Bug:135638690 P1 [QPR] On-device app search
Bug:137106918 P2 UX: Accidental NGA triggering when hitting Undo actions in apps
Bug:137200188 P3 Home screen app title disappears during animation
Bug:138195597 P2 Wrong icon animated on return to home screen
Bug:138396187 P1 Swipe and hold from an app no longer uses spring to animate adjacent task
Bug:138729157 P1 [Flaky test] java.lang.AssertionError: http://go/tapl : want to fling backwards in widgets, flung back, but the current state is not WIDGETS; Unexpected launcher object visible: workspace
Bug:138729456 P1 [Flaky test] java.lang.AssertionError: http://go/tapl : Can't find an object with selector: BySelector [CLASS='\Qandroid.widget.TextView\E', PKG='\Qcom.google.android.apps.nexuslauncher\E', TEXT='\QShortcut 3\E'] (visible state: Workspace)
Bug:138964490 P1 Support DeviceConfig to drive ToggleableFlags
Bug:139021165 P2 [TEST TRACKER] [QPR] Promise icons on home screen
Bug:139137636 P2 Create memory tests for Launcher
Bug:139551306 P4 [Polish] Reduce shelf paddings in Overview
Bug:139885365 P3 App open animation different between launcher suggested apps and launcher home screen/drawer
Bug:139918680 P2 [a11y] Talkback shouldn't keep focusing on the background item and speak the description of the background item again after entering Widget list.
Bug:140076379 P1 Launcher ub-launcher3-qt-qpr1-dev Branch Build Keeps Crashing due to Exception
Bug:140252951 P2 Add widget launch test.
Bug:140308849 P2 Jank during swipe up to home, especially noticeable after pausing first
Bug:140311911 P2 Flake in Launcher tests: java.lang.AssertionError: Stable state != state: OverviewState, LauncherState
Bug:140405990 P2 [a11y] Unable to add shortcut to Home screen by Voice access or Switch access.
Bug:140819614 P1 If an install session is abandoned for an already installed app, the corresponding icon is removed
Bug:140823188 P1 AppPredictionsUITests failing
Bug:140837771 P1 Failing test: AddConfigWidgetTests and AddWidgetTests are failing
Change-Id: I1efae6216c53b1fee3e105c9356ed43c4bf46c6e
2019-09-12 15:22:35 -07:00
Pinyao Ting 39216c1533 Fix the issue deep shortcuts cannot be added to workspace via
voice/switch access

Bug: 140405990
Change-Id: Ie54d9c738fc51445f3aa49458ff4fc1dd6e4fc67
Merged-In: Ie54d9c738fc51445f3aa49458ff4fc1dd6e4fc67
(cherry picked from commit 8a739f9511)
2019-09-12 20:33:03 +00:00
Vadim Tryshev de5e5afae5 Merge "Fixing widget tests" into ub-launcher3-qt-qpr1-dev 2019-09-12 20:32:00 +00:00
vadimt 6b3cbf116d Fixing widget tests
Bug: 140837771
Change-Id: If5dcf455b1a87b06c883dd1f0d46c6748e6d1a94
2019-09-12 12:49:59 -07:00
Jon Miranda d6ae55d968 Fix failing test testPromiseIcon_addedFromEligibleSession.
Test: Ran tests on device
Bug: 140819614
Change-Id: I8ee6836d3a06f315518aa4829c8e2ddf8cf5f74d
2019-09-12 16:58:51 +00:00
Tony Wickham fc520edbc6 Merge "Replace OnGlobalLayoutListener with StateListener to update predictions" into ub-launcher3-qt-qpr1-dev 2019-09-11 23:42:23 +00:00
Xin Li 0fb01f7cf9 [automerger skipped] Merge qt-r1-dev-plus-aosp-without-vendor (5817612) into stage-aosp-master am: 923156a720 -s ours
am: 942aeb2c4c -s ours
am skip reason: change_id I157ff596deb419a57eca32a9b8d954d76294f627 with SHA1 ecb37ee845 is in history

Change-Id: Iea5018b78e870b8667b25b79029f928077172d74
2019-09-11 14:55:53 -07:00
Tony Wickham 51f2919815 Replace OnGlobalLayoutListener with StateListener to update predictions
Previously we were using OnGlobalLayoutListener, which is only called
when AllAppsContainerView or a child is re-laid out or visibility
changes to or from GONE. Since we no longer relayout when already
scrolled to the top, we need a better hook to check whether all apps has
changed visibility for the purpose of updating predictions.

Bug: 140823188
Change-Id: I7c4a0d94c529eb86b55729c75843c8b0bd673d8c
2019-09-11 14:41:52 -07:00
Jon Miranda 21d1119070 [DO NOT MERGE] Fix NumberFormatException for launcher.
am: 241cd90203

Change-Id: I4b7ba388bb96b0c3c4c8b98649e05c5dd51405e0
2019-09-11 14:15:39 -07:00
Xin Li 942aeb2c4c [automerger skipped] Merge qt-r1-dev-plus-aosp-without-vendor (5817612) into stage-aosp-master
am: 923156a720 -s ours
am skip reason: change_id I157ff596deb419a57eca32a9b8d954d76294f627 with SHA1 ecb37ee845 is in history

Change-Id: I299877eaa8613b5c246f70fa73d0e9094d911799
2019-09-11 14:08:18 -07:00
TreeHugger Robot cfdeb06205 Merge "Fix bug where existing icon is removed when install session is abandonded." into ub-launcher3-qt-qpr1-dev 2019-09-11 20:43:36 +00:00
TreeHugger Robot 791dd73217 Merge "Adding support for building a "spring like animation" with precomputed values" into ub-launcher3-qt-qpr1-dev 2019-09-11 20:16:19 +00:00
Jon Miranda 1c247cf451 Fix bug where existing icon is removed when install session is abandonded.
- Ensure we only add promise icons for apps that aren't already installed to
  our internal list of session ids.
- Ensure we only remove promise icons created from the install session when
  that session is abandonded.

Bug: 140819614
Change-Id: I3c93865b5e96a9c7a160154b45a38eb90ac9d183
2019-09-11 12:37:14 -07:00
vadimt 5e742772d0 Adding testing for opening a widget
Bug: 140252951
Change-Id: Ic1c867db602f1890b74e7b539b44b2a440267384
2019-09-11 12:36:46 -07:00