Commit Graph

19089 Commits

Author SHA1 Message Date
Kevin b2fae14ef0 Merge changes from topic "polish-app-recents-anim" into ub-launcher3-qt-dev
am: f079b277cf

Change-Id: Id7c445cd5ba6f801fb148bafe1c4406392db944f
2019-05-09 18:12:11 -07:00
Kevin cbfa4ae7a8 Merge "Use Animator cancel instead of end" into ub-launcher3-qt-dev
am: 1350be3c21

Change-Id: Id9c598d1e23a33c02a5615a65d44c827cf825d80
2019-05-09 17:07:58 -07:00
Kevin bc96edba63 Merge "Fix fallback recents not updating list from app" into ub-launcher3-qt-dev
am: f66f6aefcc

Change-Id: I92e347865038e89ddb7e01f0cd2533da65fbd039
2019-05-09 17:07:32 -07:00
TreeHugger Robot f079b277cf Merge changes from topic "polish-app-recents-anim" into ub-launcher3-qt-dev
* changes:
  Polish app => recents animation (5/5)
  Polish app => recents animation (4/5)
  Polish app => recents animation (3/N)
  Polish app => recents animation (2/N)
  Polish app => recents animation (1/N)
2019-05-10 00:07:18 +00:00
Tony f0b2d2ecf8 Merge "Add ScreenPinnedInputConsumer" into ub-launcher3-qt-dev
am: 693c5f5287

Change-Id: I8cbceafef56338891545c32ece03a41e8ff62e6d
2019-05-09 17:06:54 -07:00
Kevin 5c0ee7ca37 Polish app => recents animation (5/5)
Add the part of the animation where task views fade in from bottom to
top. For the app animating in, we only fade in the label and the icon as
the snapshot needs to be visible as the app window scales down to it.

Bug: 132112131
Test: Manual test animation
Change-Id: Ia3fb98fde0b14fa4f72b53a1941cc2ee6b9f2294
2019-05-09 16:38:54 -07:00
TreeHugger Robot 1350be3c21 Merge "Use Animator cancel instead of end" into ub-launcher3-qt-dev 2019-05-09 23:25:54 +00:00
TreeHugger Robot f66f6aefcc Merge "Fix fallback recents not updating list from app" into ub-launcher3-qt-dev 2019-05-09 23:24:53 +00:00
TreeHugger Robot 693c5f5287 Merge "Add ScreenPinnedInputConsumer" into ub-launcher3-qt-dev 2019-05-09 23:24:44 +00:00
vadimt 04d9751d4e Merge "Disabling updating All Apps during a long-press recognition" into ub-launcher3-qt-dev
am: 9104c2323a

Change-Id: I7cadb4e181ecc5c209db2d4bb6ef7aecf53ebbdb
2019-05-09 16:15:36 -07:00
Tony 918863083b Add ScreenPinnedInputConsumer
When screen pinning is active, swipe up and hold to stop it.

Bug: 130828539
Change-Id: I343050d2a224ac723143cd3be4f78bc321f1a026
2019-05-09 18:10:10 -05:00
Kevin 4ff2a278a2 Use Animator cancel instead of end
Animtor's cancel() skips some animator init logic that end() does so
we'd like to use that instead. The on end callback will still set the
animation value to its target end value so this doesn't affect
correctness.

Bug: 132285006
Test: Build and manual test endAnimations
Change-Id: I450a888c7b37a7dc74f24035d9abc5bda1cbbbd8
2019-05-09 16:08:09 -07:00
TreeHugger Robot 9104c2323a Merge "Disabling updating All Apps during a long-press recognition" into ub-launcher3-qt-dev 2019-05-09 23:04:05 +00:00
vadimt 24d31d4b6e Disabling updating All Apps during a long-press recognition
This is supposed to eliminate test flakes in the lab.

When an app gets updated while all apps is opened, all-apps will be
re-laid-out.

If the layout happens while we are recognizing a long-press on an app
icon in all Apps, the long-press won't be recognized.

In the lab, this happened so frequently that it caused considerable
flakiness. Even after we started running tests in airplane mode, this
still keeps happening. The bug refers an example with airplane mode on.

The fix will be also mildly beneficial for users.

Bug: 132177321
Change-Id: Ie7c7473fe94b8af83f04cd719286bae69e2d9de0
2019-05-09 15:48:32 -07:00
Tony 523db93ac3 Move InputConsumers to new inputconsumers package
am: 9aaa92672d

Change-Id: I208cacd95d61f0b079416eb78a882b5404654ba0
2019-05-09 14:49:53 -07:00
Tony 9aaa92672d Move InputConsumers to new inputconsumers package
Change-Id: I3318784523b8ff1b9468cbfed3a2682985274ea8
2019-05-09 14:37:37 -05:00
Kevin 4e53010917 Merge "Apply insets correctly to fallback Recents Go" into ub-launcher3-qt-dev
am: 75d2bcbe41

Change-Id: I44d4fb375f14e99032c93b39e651719922737ae0
2019-05-08 18:56:14 -07:00
Kevin 5b596328ad Merge "Fix 1.5x layout values" into ub-launcher3-qt-dev
am: 8c61598243

Change-Id: Iefbf2d6e86b8790ac7667ee4281dd7aced841689
2019-05-08 18:55:43 -07:00
Vadim Tryshev 6bbac66535 Merge "Not using magic constants for navbar height" into ub-launcher3-qt-dev
am: 94dbfb9bdb

Change-Id: I7d28814a0e06c24c77b8a0c9a32c7040f4874630
2019-05-08 18:50:44 -07:00
Kevin cde60e24b0 Fix fallback recents not updating list from app
When launching an from recents, onStop is not called until the app is
fully taken over and the remote animation finishes. As a result, if the
user hits the overview button right before the animation finishes, we
animate back to recents but never call onStart which is where we hook in
to update the recents list.

The fix naturally is to move this to onResume instead as once the
animation begins, the activity is paused.

Bug: 132293341
Test: Repro from bug, correctly updates
Change-Id: Ie6cfdc4d5aa6b1742a3bce3e14ab5ab6a4f05526
2019-05-08 18:23:52 -07:00
TreeHugger Robot 75d2bcbe41 Merge "Apply insets correctly to fallback Recents Go" into ub-launcher3-qt-dev 2019-05-09 01:21:19 +00:00
TreeHugger Robot 8c61598243 Merge "Fix 1.5x layout values" into ub-launcher3-qt-dev 2019-05-09 00:59:48 +00:00
Vadim Tryshev 94dbfb9bdb Merge "Not using magic constants for navbar height" into ub-launcher3-qt-dev 2019-05-09 00:42:15 +00:00
Kevin 249e19fde9 Fix 1.5x layout values
Some of the values in the 1.5x scale layout dimens were incorrect. This
fixes them so that they are correctly roughly 1.5x the 1.0x dimens while
still being aligned to the 4 dp grid.

Test: Test on walleye_svelte, more closely aligns mocks
Change-Id: I26d2e216c67c523799e3a159d864718da211cec1
2019-05-08 17:41:37 -07:00
Jon Miranda 5b1c210e17 Merge "Fix SDK check to use Utilities.ATLEAST_Q." into ub-launcher3-qt-dev
am: 032fe14127

Change-Id: I8d7564969f222d9afb7f60068ed3822d59d24379
2019-05-08 17:21:52 -07:00
Kevin 73dfb3fb72 Merge "Fix bug skipping certain animations from ending" into ub-launcher3-qt-dev
am: 827b8ada0d

Change-Id: I028e93ae0acd8d3a00ad99010dbaf1f018aeb74c
2019-05-08 17:21:27 -07:00
Vadim Tryshev 21323efbf0 Merge "Not starting calculator from TaplTestsLauncher3.testAppIconLaunchFromAllAppsFromHome" into ub-launcher3-qt-dev
am: 758be45bac

Change-Id: I9cfc6f63174e176fdefba311f6e92bb6cc3cc987
2019-05-08 17:21:02 -07:00
vadimt 1b383af652 Not using magic constants for navbar height
Change-Id: I6783b8a2ebb059ce35748d8c3e818cbe732ff40d
2019-05-08 17:20:34 -07:00
Kevin fe634af0c4 Apply insets correctly to fallback Recents Go
Insets were not being correctly consumed by the root view in the
fallback recents activity. This CL properly passes on the system insets
to the recents view so that tasks flow under the system insets.

Bug: 131853975
Test: Have separate default launcher, go to recents, go to landscape,
tasks scroll under status bar
Change-Id: I16f78da896522c5cf41951817747a24cd5cfe32c
2019-05-08 16:58:01 -07:00
TreeHugger Robot 032fe14127 Merge "Fix SDK check to use Utilities.ATLEAST_Q." into ub-launcher3-qt-dev 2019-05-08 23:45:41 +00:00
TreeHugger Robot 827b8ada0d Merge "Fix bug skipping certain animations from ending" into ub-launcher3-qt-dev 2019-05-08 23:36:00 +00:00
Vadim Tryshev 758be45bac Merge "Not starting calculator from TaplTestsLauncher3.testAppIconLaunchFromAllAppsFromHome" into ub-launcher3-qt-dev 2019-05-08 23:23:41 +00:00
vadimt b9300ef849 Not starting calculator from TaplTestsLauncher3.testAppIconLaunchFromAllAppsFromHome
Not sure why, but starting calculator sometimes fails. Let's see if
this changes anything.

Change-Id: I2934a388afe7e95bdaeb38151a2676b3297b6e94
2019-05-08 16:00:33 -07:00
Kevin 308759f60f Merge "Ensure Recents Go layout finishes before remote anim begins" into ub-launcher3-qt-dev
am: 09edbf3c73

Change-Id: I1039e883982e0bcb6d04e85b9787419a29e2ccdd
2019-05-08 15:54:38 -07:00
Kevin 41d3a2a1d7 Fix bug skipping certain animations from ending
endAnimations forces an end to all running animations. This also removes
it from the list which changes the list while we're iterating over it.
This fixes the issue.

Bug: 132285006
Test: Manual test w/ build forcing endAnimations
Change-Id: I0ee9917866dafe00ef3122dd9a43259d19fb9f79
2019-05-08 15:30:33 -07:00
TreeHugger Robot 09edbf3c73 Merge "Ensure Recents Go layout finishes before remote anim begins" into ub-launcher3-qt-dev 2019-05-08 22:20:53 +00:00
Kevin 07e12ee573 Polish app => recents animation (4/5)
Add the vertical ease in component to the app => recents animation. In
addition to animating over all task views, this should also animate over
the closing app surface so that the surface movement matches the
thumbnail as it moves to cover it. As a result, we take in the
transformation matrix thats passed in to the app surface and apply the
vertical motion to it.

Bug: 132112131
Test: Manual
Change-Id: I77c6716082af6ee722b96a2c362e16030cec8b8b
2019-05-08 15:11:25 -07:00
Miranda Kephart 9aecc38aef Allow fling invocation for assistant
am: 4743da3864

Change-Id: Id2e00c6c7105a70acecf2e2c7634b25352baea4b
2019-05-08 14:17:51 -07:00
Kevin e590014834 Polish app => recents animation (3/N)
This CL takes the current scale down animation and updates its
interpolators and durations to match the UX spec. In addition, we move
the core logic to a helper method as the whole remote animation will
have other animations as well in the future.

Bug: 132112131
Test: Manual
Change-Id: I68b1d623b1b2c980dc34e41bbb5460cc021b5887
2019-05-08 14:06:55 -07:00
Miranda Kephart 4743da3864 Allow fling invocation for assistant
Bug: 132269601
Test: manual
Change-Id: Ieb8fb6ade28d947ab8ca9ef901937dc7f3ca7a1d
2019-05-08 16:43:37 -04:00
Jon Miranda df94de9343 Fix SDK check to use Utilities.ATLEAST_Q.
Bug: 131315856
Change-Id: Ie1d00d85dd01da7e57f28e16f51a49962d734927
2019-05-08 10:05:57 -07:00
Jeff Chang 38b6a7f903 Hide the split-screen request for secondary display task.
am: 860b9208c1

Change-Id: I6af6d1692449fbdafcb5a57694d994ab449e517e
2019-05-08 05:57:49 -07:00
Jeff Chang 860b9208c1 Hide the split-screen request for secondary display task.
Currently, we cannot support the split-screen mode on the secondary
display. To prevent confused,disallowing split-screen request on
non-primary display tasks first.

Bug: 118266305
Test: 1. Use the ActivityViewTest to launch an application on virtual display.
      2. Check if the split-screen button exist on recent app.

Change-Id: Ifa6d70a1920aa4f33d260e37a3737e102949114e
2019-05-08 20:24:09 +08:00
Vadim Tryshev fccb0e4203 Merge "Reducing flakiness of swipe gestures" into ub-launcher3-qt-dev
am: e627accf26

Change-Id: Icb687b59cc4550d4c93faab1071de212ec027961
2019-05-07 19:39:48 -07:00
Vadim Tryshev e627accf26 Merge "Reducing flakiness of swipe gestures" into ub-launcher3-qt-dev 2019-05-08 01:30:07 +00:00
Kevin 1b4b960ff1 Polish app => recents animation (2/N)
This CL moves the core "app to overview" animation logic into
the main view as the newer animation would need to animate over several
of the main view's children and so the animation logic needs knowledge
of those children.

Bug: 132112131
Test: Build and test, functions as before
Change-Id: I9cbde55a582bee62e0a97e38c5fdf1d5841502db
2019-05-07 18:01:23 -07:00
Vadim Tryshev 080f818642 Reducing flakiness of swipe gestures
Swipe to home now injects a fixed number of points even if the test
thread wakes up irregularly, and sends model (not actual) time in
events.

Bug: 132173901
Bug: 132107664
Change-Id: I0a19bbc2a0c3312f353ad49ebe496eef1f172276
2019-05-07 17:53:24 -07:00
Kevin f95e84a385 Polish app => recents animation (1/N)
As part of building out a better remote app to overview animation, we
first separate out the logic so that we only do the default layout
animation when coming from a Launcher state (i.e. from home or all
apps) and only then, so coming from an app no longer leads to the tasks
animating.

We do this with a simple flag that indicates that recents will be
using a remote animation.

Bug: 132112131
Test: Go to app, go to recents. No layout animation.
Test: Go to home, go to recents. Layout animation works as normal
Change-Id: I30988d944571fd5317d0c9d13e2a99b167c1291b
2019-05-07 17:09:43 -07:00
Kevin 141ab952e7 Ensure Recents Go layout finishes before remote anim begins
We would like to assume a correct up-to-date layout for Go recents
before the remote animation begins to ensure correctness of the app to
overview transition and allow for animating all the newly laid out task
views in sync.

We do this by checking if recents is the remote target we are animating
to and if so, checking if the view is ready.  If it is not, then we
delay the remote animation until the layout is finished and everything
is attached.

Bug: 132112131
Fix: 132108983
Test: Run Recents Go, have no tasks in recents, open app, press
overview to go to recents
Test: Test on AOSP and NexusLauncher that animations to Launcher work as
before (both to recents and to home)
Change-Id: Id74d90cffc9fe5db1dbb5fe63b8819c7436fef21
2019-05-07 15:05:39 -07:00
Miranda Kephart 0f042741da Change haptic on Assistant gesture to '13'
am: 808cd8dfdb

Change-Id: I7f3d4d6d3cf6018e88b1a1b8b63e8f20a1e60523
2019-05-07 14:52:01 -07:00