Commit Graph

72638 Commits

Author SHA1 Message Date
Federico Baron b2cb1f87b7 Merge "Folder preview work badge theming fix" into main 2023-11-09 17:35:48 +00:00
Randy Pfohl 583e48d915 Merge "Adding insets to prevent back gesture from triggering status bar" into main 2023-11-09 16:44:05 +00:00
Uwais Ashraf 8e1e2a5155 Merge "Use instrumentation arg to prevent unnecessary delays in unit tests" into main 2023-11-09 16:03:20 +00:00
Uwais Ashraf b5d08b246e Use instrumentation arg to prevent unnecessary delays in unit tests
Bug: 308792359
Flag: NA
Test: presubmits passing
Change-Id: Ib38db86057998fcf859a44fa190e6cc4d82263dd
2023-11-09 12:07:18 +00:00
Andreas Agvard 100b77e667 Merge "Translucent apps are kept in Recents while in the foreground" into main 2023-11-09 11:30:29 +00:00
Anushree Ganjam 99349f0819 [automerger skipped] [DO NOT MERGE] Change the LPNH flag to read from server flag "ENABLE_LONG_PRESS_NAV_HANDLE_MPR". am: 75183ceed5 am: 0b780abf31 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25303662

Change-Id: I28e653e4f65a2bca925196e93c169f29bc46727a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-09 07:52:44 +00:00
Anushree Ganjam 0b780abf31 [DO NOT MERGE] Change the LPNH flag to read from server flag "ENABLE_LONG_PRESS_NAV_HANDLE_MPR". am: 75183ceed5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25303662

Change-Id: I9ef5d303c1c0ed30a02e56e039699de44307201c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-09 07:10:52 +00:00
Chris Li 6c2681049c Merge "Update PipContentOverlay usage" into main 2023-11-09 03:41:43 +00:00
Vadim Tryshev 572b5b09fd Merge "Allowing ACTION_CANCEL events to come from device 0" into main 2023-11-09 01:42:16 +00:00
Vadim Tryshev fd13b2c650 Merge "Demoting a couple of flaking tests from presubmit" into main 2023-11-09 01:40:36 +00:00
Vadim Tryshev a3f581d733 Merge "Diagnosing when Launcher is in invalid state" into main 2023-11-09 01:40:03 +00:00
Anushree Ganjam 75183ceed5 [DO NOT MERGE] Change the LPNH flag to read from server flag "ENABLE_LONG_PRESS_NAV_HANDLE_MPR".
Flag: ENABLE_LONG_PRESS_NAV_HANDLE_MPR
Test: Manual
Bug: 309689303
Change-Id: Ib695b3d6ac3f40ee53b6b64bb6b121e7b34d4b07
2023-11-08 23:43:49 +00:00
randypfohl 640e65888c Adding insets to prevent back gesture from triggering status bar
Flag: NONE

Test: Built locally verified back gesture doesn't trigger status bar

Bug: 279252552

Change-Id: I3ad325b1937b5f26278354bc8cef0c94066eed25
2023-11-08 14:53:15 -08:00
Vadim Tryshev 7a1beb559f Allowing ACTION_CANCEL events to come from device 0
Tests assert that input events come to Launcher only from tests, which
sets deviceId to 0. This way, we spot when a cable touches a lab device
and breaks the tests, in which case deviceId will be != -1.

But CANCEL event, which is programmatic, now can legitimately come from
device 0.

Bug: 308489875
Test: presubmit
Flag: N/A
Change-Id: I84ee9ed8e008043f83e82d57b17b64a10677ee8d
2023-11-08 13:20:57 -08:00
fbaron 1e360c1a92 Folder preview work badge theming fix
Currently the preview apps in a folder icon have the work badge with theming even when themed icons is off

Fix: 306665193
Test: Verify that folder with work icons has non-themed work badge when themed icons is off
Flag: NONE
Change-Id: I78ca7cb2361f6e590742fa64c88397d1ea80be68
2023-11-08 12:30:58 -08:00
Vadim Tryshev f0732e73d5 Merge "Workarounding setup wizard non-disappearance only in presubmit" into main 2023-11-08 20:29:00 +00:00
Vadim Tryshev 1c8e30b54c Merge "Making keyguard dismissal a permanent solution" into main 2023-11-08 20:24:11 +00:00
Vadim Tryshev e494c1b6e7 Demoting a couple of flaking tests from presubmit
Bug: 288939273, 309820115
Test: presubmit
Flag: N/A
Change-Id: Iea7dd435c4f6461ceb9e45ce6b3942ddc2d11347
2023-11-08 12:01:00 -08:00
Tony Wickham f57204c0dd Merge "Only run InputConsumerProxy callback for touch event" into main 2023-11-08 18:26:34 +00:00
Tracy Zhou f6fdcf10c4 Merge "Migrate HIDE_NAVBAR_WINDOW to aconfig and rename is to enable_taskbar_navbar_unification" into main 2023-11-08 18:25:48 +00:00
Charlie Anderson ee78d44eb2 Merge "Fixing polish issues with the U app shortcut popup design" into main 2023-11-08 18:08:30 +00:00
Thales Lima 55fcfacd1a Merge "Center AllApps on the screen" into main 2023-11-08 18:02:16 +00:00
Andreas Agvard a71e664a61 Translucent apps are kept in Recents while in the foreground
Translucent apps that are exluded from Recents are not kept in Recents
while they are the foreground. This is to prevent jank while going to
Recents and thus morphing to another app, and to prevent confusion as
going back to an app might end you back into the excluded app experience
in case of an app like Omnient that is "on-top" of another application.

Fix: 305650114
Test: Manual
Flag: LEGACY INVOKE_OMNI_LPH DISABLED
Change-Id: I24d583434ce62c68436e8928cf3a47a5ce73ecaf
2023-11-08 17:04:31 +00:00
Liran Binyamin 4d9157be73 Merge "Adds content description to the overflow bubble." into main 2023-11-08 15:52:58 +00:00
Thales Lima d94993ed9e Merge "Use new icon stepping logic for Folders" into main 2023-11-08 15:50:41 +00:00
Schneider Victor-tulias b55971202e Merge "Fix unresponsive swipe up after launching a non-running app from overview" into main 2023-11-08 15:11:22 +00:00
Thales Lima a25cd90b5e Center AllApps on the screen
AllApps used workspace paddings which are unbalanced in verticalBar. This changes it to always be centered. In dynamic grid AllApps now uses the whole width for the layout. In responsive grid it keeps the cell width and center the layout.

Note that this is centered on the screen but nothing could be done regarding the camera inset at this time, as it would need a refactor of how AllApps QSB is layout as well.

Bug: 269632571
Test: NexusLauncherTest
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Change-Id: I326d041bcef211d398d1a5c3210958b689414d49
2023-11-08 14:39:52 +00:00
Jordan Silva 72bc6f53f7 Merge changes from topic "comet-landscape" into main
* changes:
  Update Responsive Grid tests with aspect ratio group
  Refactoring Responsive Grid XML specs for more flexibility
2023-11-08 11:16:21 +00:00
Johannes Gallmann b503e27ae2 Merge "Catch SecurityException in SystemUIProxy" into main 2023-11-08 10:33:17 +00:00
Riddle Hsu d5512fa401 Merge "Update current rotation of recents to task transform" into main 2023-11-08 08:11:39 +00:00
Tony Wickham d1a4ff3a9b Only run InputConsumerProxy callback for touch event
The callback exists to ensure the current running animation ends
immediately on touch down, so that we can handle that touch. It
was never intended to run for other events such as HOVER. Updated
to ensure that's the case and also updated documentation/names.

Fixes: 295984940
Test: Manual with animation duration x5:
  - Swipe up followed by HOVER event, ensure animation still plays
  - Swipe to overview, tap on a tile during transition, ensure
    it animates back up
Flag: NONE
Change-Id: I29039ea10154083dcab2e29a97752b18ae8b9331
2023-11-08 00:54:24 +00:00
Vadim Tryshev 84aa57b2d1 Diagnosing when Launcher is in invalid state
Due to bugs, Launcher may end up showing incorrectly, i.e. Launcher app
is present, but no workspace, all apps etc is visible.
Improving diagnostics when this is the case.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ibd0228bd26d2ba9ad710895ed8d2e5ece294db21
2023-11-07 16:22:58 -08:00
Vadim Tryshev e5a1b89220 Making keyguard dismissal a permanent solution
Before, it was considered to be a workaround while System UI has
keyguard bugs. But these bugs will happen in future, and they are
unlikely to be prevented by presubmit tests since they are usually flakes.

The solution that this CL makes permanent is: in presubmit attempt
to unlock SysUI if it's locked. In postsubmit, just make sure it's
unlocked. This way, in postsubmit, we'll know whether tere are active
keyguard bugs.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ia9602bc6e9cc8400e939051c45aba92bc197d428
2023-11-07 14:45:58 -08:00
Tracy Zhou 6fe69f5a2a Migrate HIDE_NAVBAR_WINDOW to aconfig and rename is to enable_taskbar_navbar_unification
Bug: 309671494
Test: N/A
Change-Id: If35d807c17351146029498a876a055384eff3c2f
2023-11-07 13:51:38 -08:00
Sebastián Franco 5054899552 Merge "Moving some constants in Launcher.java to a separate file for ease of readability" into main 2023-11-07 21:22:11 +00:00
Schneider Victor-tulias a571affc9d Fix unresponsive swipe up after launching a non-running app from overview
Flag: NONE
Fixes: 308982078
Test: quickly swipe to home after tapping a non-running task from overview
Change-Id: I1fbf669368586af4e5b9319603c6a928969cb494
2023-11-07 21:15:12 +00:00
Vadim Tryshev 341e5598b5 Workarounding setup wizard non-disappearance only in presubmit
In postsubmit, we want to see the actual behavior to be aware of real e2e issues.

Bug: 309008042
Test: presubmit
Flag: N/A
Change-Id: Icedf381545dda32ea1dbdd8d215581265627bf3f
2023-11-07 12:33:21 -08:00
Vinit Nayak 38dc539f84 Merge "Unignore split tests" into main 2023-11-07 18:19:11 +00:00
Federico Baron bc1d5791cd Merge "Ensure shortcuts show up in widget picker screenshot test" into main 2023-11-07 16:53:53 +00:00
Federico Baron 8bd0aac27f Merge "Remove white background from shortcuts in widget picker" into main 2023-11-07 16:53:53 +00:00
Sebastian Franco 974cc94839 Moving some constants in Launcher.java to a separate file for ease of readability
Part of  go/launcher_SoR

Flag: N/A
Bug: 306465626
Test: compiling, no-op change
Change-Id: I5ea40acb2ba1ea5840021e297516a511b032a043
2023-11-07 10:12:26 -06:00
Robin Lee b0ed620d42 Merge "Exit Recents with HOME instead of WCT when locked" into main 2023-11-07 15:07:10 +00:00
Jordan Silva d7c7eaf837 Update Responsive Grid tests with aspect ratio group
Adding aspect ratio group and updating the responsive grid tests to match the refactored classes.

Bug: 299889733
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: AllAppsSpecsTest
Test: CalculatedAllAppsSpecTest
Test: HotseatSpecsTest
Test: CalculatedHotseatSpecTest
Test: WorkspaceSpecsTest
Test: CalculatedWorkspaceSpecTest
Test: ResponsiveFolderTest
Test: CalculatedFolderSpecTest
Change-Id: I918f4e28eb310bc9300fc6cc2b5b2af67d758a96
2023-11-07 11:51:28 +00:00
Jordan Silva f2402e25f1 Refactoring Responsive Grid XML specs for more flexibility
It merges portrait and landscape XML specs for responsive grid. This update allows the responsive grid to rely on other properties like aspect ratio and not solely the orientation from resource qualifiers.

Bug: 299889733
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: CalculatedAllAppsSpecTest
Test: CalculatedFolderSpecTest
Test: CalculatedHotseatSpecTest
Test: CalculatedWorkspaceSpecTest
Test: AllAppsSpecsTest
Test: FolderSpecTest
Test: HotseatSpecsTest
Test: WorkspaceSpecsTest
Change-Id: I39ee54d49c9d2a54fcbe91c8a1327a21a8126032
2023-11-07 11:51:28 +00:00
Riddle Hsu 5d4127ae43 Update current rotation of recents to task transform
The RemoteTargetHandle are created with default orientation state.
So it also needs to be initialized to apply correct transform.

Bug: 304408369
Bug: 308520924
Test: Enable home rotation. Put device in landscape.
      Launch Settings and press home key. And then launch
      a portrait only app and use recents to switch to Settings.
Change-Id: I489957acdaa76c689aa94dd1e5ad8824b430760c
2023-11-07 18:20:10 +08:00
Johannes Gallmann 9173fa39cf Catch SecurityException in SystemUIProxy
Bug: 305121245
Flag: NONE
Test: presubmit
Change-Id: I6e43d8c55b2fe3089254137213caefd42182fd4a
2023-11-07 10:47:09 +01:00
Himanshu Gupta 7d56e6ea23 Merge "Adding Prework for Private Space integration in Launcher" into main 2023-11-07 08:45:41 +00:00
Winson Chung fce687e699 Merge "Handle long press directly if recents transition is deferred" into main 2023-11-06 23:55:49 +00:00
Bill Yi e2bba5b8d0 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: c0ab803dfd -s ours am: 60ec6cf4ea -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25274510

Change-Id: I788f9d706af65df9f701fabf25c736723b187365
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-06 22:47:05 +00:00
Vinit Nayak 8ef38b0f9e Unignore split tests
* With the fix of b/302551868, let's
see if that fixes this issue as well

Bug: 297135374
Change-Id: I817307dbb5e70d8c8534627499d429529e33de4a
2023-11-06 14:25:35 -08:00