Commit Graph

33301 Commits

Author SHA1 Message Date
vadimt 8ecf1b3dd3 Waiting until context menu goes away after attempting to close it.
Bug: 141770616
Change-Id: I528072e830627d825906ce7c1e3dbb914e2c814e
2019-10-01 18:28:46 -07:00
Andy Wickham b9efb9ad71 Merge "Some cleanup for SwipeDetector." into ub-launcher3-qt-future-dev
am: d39f7b51c8

Change-Id: Ifadf65abe4239a703c3d15eddc6ebd51a405a5e9
2019-10-01 14:57:43 -07:00
TreeHugger Robot d39f7b51c8 Merge "Some cleanup for SwipeDetector." into ub-launcher3-qt-future-dev 2019-10-01 21:47:46 +00:00
Andy Wickham 769c795edf Some cleanup for SwipeDetector.
It is now organized as follows:
 - private constants
 - public constants
 - private final fields
 - private variable fields
 - constructors
 - public methods
 - private methods
 - public interface/abstract class

This is intended to be a functional no-op.

Bug: 141939911
Change-Id: Iad5a9b3b73b35641f8a4f1d52ada6adef3825c47
Tested: Built and sanity checked manually.
2019-10-01 14:38:56 -07:00
TreeHugger Robot ef2ef310c3 Merge "Unifying activity tracker callback" into ub-launcher3-master 2019-10-01 21:01:54 +00:00
Sunny Goyal e84c5b82be Unifying activity tracker callback
> Using a common class for both Launcher and RecentsActivity
> Removing static refenrece to LauncherModel and using a common pattern for
  tracking activities

Bug: 141376165
Bug: 137568159
Change-Id: Ic1897abe6913ec78e25725118eedf5b468d5ec70
2019-10-01 13:54:26 -07:00
Tony Wickham 32fbb634e5 Merge "Don't allow scrolling RecentsView outside navbar during quickswitch" into ub-launcher3-qt-future-dev
am: e8d064a3c1

Change-Id: I0110540875ceece81fb00d39a152377efb822b72
2019-10-01 13:25:04 -07:00
Samuel Fufa 7eb59b9f47 App title in Widget list shouldn't be actionable by a11y methods
am: 1f3a847011

Change-Id: Ib4e0b8b0c614e2b286acd3a5abdf8f7677bf81e7
2019-10-01 13:24:47 -07:00
TreeHugger Robot 08776ada1e Merge "Waiting for Launcher model load in out-of-proc tests." into ub-launcher3-qt-qpr1-dev 2019-10-01 19:48:05 +00:00
vadimt 7371e4da68 Waiting for Launcher model load in out-of-proc tests.
Not doing this seems to have caused flakes.

Bug: 141770616
Change-Id: Ia9caf20e4a2d93298adf4249ca815ad79bced802
Merged-in: Ia9caf20e4a2d93298adf4249ca815ad79bced802
2019-10-01 19:18:14 +00:00
Vadim Tryshev f7a2971530 Merge "Waiting for Launcher model load in out-of-proc tests." into ub-launcher3-master 2019-10-01 18:43:24 +00:00
Tony Wickham e8d064a3c1 Merge "Don't allow scrolling RecentsView outside navbar during quickswitch" into ub-launcher3-qt-future-dev 2019-10-01 17:52:54 +00:00
vadimt 542b7df7fd Waiting for Launcher model load in out-of-proc tests.
Not doing this seems to have caused flakes.

Bug: 141770616
Change-Id: Ia9caf20e4a2d93298adf4249ca815ad79bced802
2019-10-01 17:46:35 +00:00
Samuel Fufa 1f3a847011 App title in Widget list shouldn't be actionable by a11y methods
Bug:139913027
Test:Manual
Change-Id: I2a5d5551d09ee2bc96444164ed77225a3b4a829a
(cherry picked from commit d3720c210b)
2019-10-01 17:33:18 +00:00
Tony Wickham c9654eb091 Don't allow scrolling RecentsView outside navbar during quickswitch
Once the inputProxy (OverviewInputConsumer) was enabled, it was never
disabled. And while it was enabled, touches above the nav bar would go
through to launcher, allowing you to scroll RecentsView (for example)
during quick switch transitions. This breaks some assumptions, since
it doesn't go through our normal shared swipe state logic that cancels
the animation, updates the new end target (e.g. NEW_TASK vs LAST_TASK),
etc. Thus, if you tried returning to LAST_TASK via this route, we would
end up starting it as a new activity instead of resuming the existing
one, causing a flicker (I guess because that TaskView is hidden).

Test:
- Swipe up from task A to home (to enable input proxy)
- Open A
- Swipe to B, and during transition scroll back to A from the center of
the screen

Before, this caused a flicker, now the last scroll is ignored.

TODO: we should increase the nav region during quick switch to make it
easier to continue scrolling

Bug: 136829198
Bug: 138620399
Change-Id: I5ffb53743b728e1909066c5dd18cc9308aff2c7e
2019-10-01 10:16:26 -07:00
Pinyao Ting 44151960bf Revert "Revert "Revert "cache shourtcut image"""
am: 52908c9adc

Change-Id: I597a9e3a314887b668f482e74a4d2f548cca1da9
2019-10-01 10:09:11 -07:00
Pinyao Ting 52908c9adc Revert "Revert "Revert "cache shourtcut image"""
This reverts commit d13f0c5c45.

Reason for revert: app crashes when adding widgets automatically b/141568904

Change-Id: I5b97f440716c93b1bd93c899e3e1d40e8bbd2885
2019-10-01 09:44:11 -07:00
Vinit Nayak a62de7aa88 Merge "Set exclusion rect for launcher before it gains focus" into ub-launcher3-master 2019-10-01 15:54:05 +00:00
Sunny Goyal 045b4fab76 Removing static listeners from PackageInstallerCompat
Bug: 141376165
Change-Id: I2b49d53a05a04c622ed5a7b723109a6cc230d230
2019-09-30 23:17:15 -07:00
Vinit Nayak 9a8462117d Set exclusion rect for launcher before it gains focus
Back gesture still shows if user attempts to swipe
back while we're animating to launcher state normal.
Focus is only granted after the animation has
completed, but the user can interact w/ the back
edge panels while it's ongoing.

fixes: 138622418
Test: Open app, swipe home and quickly swipe from
the edge of the screen. Should go to -1 screen and
not see back arrow.

Change-Id: I32228370c7ec1bdb75474fdff2d1c99cb677fa6a
2019-09-30 16:04:57 -07:00
Vadim Tryshev 67138875fa Merge "Not unlocking phone on the test start" into ub-launcher3-qt-qpr1-dev am: 872a380b59
am: 4c420047cf

Change-Id: I23f87d541771baa7ba3e5857999a5e5c96c301ce
2019-09-30 14:01:37 -07:00
Vadim Tryshev 4c420047cf Merge "Not unlocking phone on the test start" into ub-launcher3-qt-qpr1-dev
am: 872a380b59

Change-Id: I6e0831a2660459803eef6c755e4fcfc9f414c94f
2019-09-30 13:54:36 -07:00
Pinyao Ting d843673434 Merge "removed extra test protocol for unit test" into ub-launcher3-qt-future-dev
am: d8aef47393

Change-Id: I0d69c2ec0e3d693d4556314fd1b74dabd0a8cbd2
2019-09-30 13:54:36 -07:00
TreeHugger Robot d8aef47393 Merge "removed extra test protocol for unit test" into ub-launcher3-qt-future-dev 2019-09-30 20:46:15 +00:00
Vadim Tryshev 872a380b59 Merge "Not unlocking phone on the test start" into ub-launcher3-qt-qpr1-dev 2019-09-30 20:31:28 +00:00
vadimt 38763eca5d fixingtypo am: 5d58d25ea3
am: 5500f3513e

Change-Id: Ie5e6f944167552c13de1320fdd161067b93a3e01
2019-09-30 13:26:32 -07:00
vadimt 5500f3513e fixingtypo
am: 5d58d25ea3

Change-Id: I7785e6162a79743b2a8c3f6851ade7bea31c1058
2019-09-30 13:19:32 -07:00
vadimt ee3db65ecc Not unlocking phone on the test start
Somehow tests unlock the phone anyways.

Bug: 141772190
Change-Id: I66de70ec10a7e9ae05ba942570bf9eff9d9e7a82
2019-09-30 12:48:47 -07:00
vadimt 5d58d25ea3 fixingtypo
Change-Id: I0d9d9f3f712fc90e82e7660c14ea31779648614a
2019-09-30 12:22:01 -07:00
Pinyao Ting ea38c25854 removed extra test protocol for unit test
Bug: 140406263
Test: run TaplTestsLauncher3
Change-Id: I73b3098bd3aa92fed41d22a94cb58fd07263d26a
2019-09-30 18:34:49 +00:00
android-build-team Robot df4ce4d6c1 Snap for 5907400 from 79d6b30dce to qt-qpr1-release
Change-Id: I31f36b0866a15da09a999ea9a2dbf7e07e32fb6f
2019-09-28 23:21:09 +00:00
android-build-team Robot ffe39f154b Snap for 5907574 from 0bf7cdc84e to rvc-release
Change-Id: Id0daa48d475bb334d4304bbc1331ce554691d4f6
2019-09-28 23:06:13 +00:00
vadimt 4d342406a2 Merge "Adding debug tracing for a flake" into ub-launcher3-qt-qpr1-dev am: 1a02173321
am: 10b1414778

Change-Id: I4e56e1f19f1eb3d48eb93978d0e544d7a26efc1d
2019-09-28 01:14:54 -07:00
vadimt 10b1414778 Merge "Adding debug tracing for a flake" into ub-launcher3-qt-qpr1-dev
am: 1a02173321

Change-Id: Id1feb3f64191475472bdfceac309b6e26869a1e6
2019-09-28 01:07:55 -07:00
TreeHugger Robot 1a02173321 Merge "Adding debug tracing for a flake" into ub-launcher3-qt-qpr1-dev 2019-09-28 04:16:23 +00:00
vadimt 3895d9b642 Adding debug tracing for a flake
Bug: 141770616
Change-Id: I6413ca6ce380eede817ae2418d5a1bc04c091270
2019-09-27 17:55:48 -07:00
Vadim Tryshev cc4a9725a9 Merge "Removing a too noisy dropbox diag" into ub-launcher3-qt-qpr1-dev am: 7cb5b73dfb
am: 75b713c71e

Change-Id: Ibd07e3d018145a2717f6e29600b8edef32045368
2019-09-27 16:27:51 -07:00
Vadim Tryshev 75b713c71e Merge "Removing a too noisy dropbox diag" into ub-launcher3-qt-qpr1-dev
am: 7cb5b73dfb

Change-Id: Iae6af5771238f8b6c13714e1e43b7a21ad38acee
2019-09-27 16:21:21 -07:00
Vadim Tryshev 7cb5b73dfb Merge "Removing a too noisy dropbox diag" into ub-launcher3-qt-qpr1-dev 2019-09-27 23:11:36 +00:00
Samuel Fufa ffec89f6da Merge "Fix notification dot scale in AllApps with grid size enabled" into ub-launcher3-qt-future-dev
am: 989c9f8b17

Change-Id: I9144ec804ee1c57de6b96ad295d07eb0fcab8a22
2019-09-27 15:27:19 -07:00
TreeHugger Robot 989c9f8b17 Merge "Fix notification dot scale in AllApps with grid size enabled" into ub-launcher3-qt-future-dev 2019-09-27 22:19:19 +00:00
Samuel Fufa c96fa247a3 Fix notification dot scale in AllApps with grid size enabled
Test: Manual
Bug: 141262820
Change-Id: I24abf822edaeeabf335ed698a3ac1a65b71be7dc
2019-09-27 14:49:54 -07:00
vadimt 41390b8eea Removing a too noisy dropbox diag
Change-Id: Ia4dee0b3f20533754b24a91a4a8d2a837bb8e60f
2019-09-27 14:24:46 -07:00
Vadim Tryshev 6254e5e246 Merge "Deprecating LauncherInstrumentation constructor with parameter" into ub-launcher3-qt-qpr1-dev am: dd079691c1
am: 1430f132f3

Change-Id: If494e30957893c4e3414ebdbd274601d16a66a98
2019-09-27 13:28:18 -07:00
Vadim Tryshev 1430f132f3 Merge "Deprecating LauncherInstrumentation constructor with parameter" into ub-launcher3-qt-qpr1-dev
am: dd079691c1

Change-Id: I7419be6416f26274bf03abfd84eedef20fd6f084
2019-09-27 13:21:46 -07:00
Vadim Tryshev dd079691c1 Merge "Deprecating LauncherInstrumentation constructor with parameter" into ub-launcher3-qt-qpr1-dev 2019-09-27 19:57:00 +00:00
vadimt 2611d79f69 Deprecating LauncherInstrumentation constructor with parameter
Change-Id: I779b4a8fde2db73cced8133f12d1356ad0b8729e
2019-09-27 12:00:09 -07:00
Sunny Goyal b32b6938fd Routing new API calls through a compat layer
Change-Id: I0bdbe99d6bc2291b370d143c6b5cb4408fe144eb
2019-09-27 08:52:08 -07:00
Hongwei Wang 655074680d Updates shelf visibility from Launcher to SysUI
We used to set shelf visibility (and its height) from Launcher to WM and
with the PiP-SysUI migration, this function will be called from Launcher
to SysUI directly since SysUI will be the new source of truth for PiP
bounds.

Bug: 139016518
Test: atest PinnedStackTests
Test: Manual
Change-Id: Id0931333da76b52ccc6fa23877c72fbe2747203b
(cherry picked from commit 95a6dba078)
2019-09-27 08:51:52 -07:00
vadimt 8bb74d4214 Removing a 'percent' parameter for scroll am: 83b03b08de
am: 79e9d0adba

Change-Id: I0b882af2be3eb961684b90385c954922151d9a20
2019-09-26 18:47:07 -07:00