Commit Graph

33301 Commits

Author SHA1 Message Date
Bill Yi 3b4c152218 [automerger skipped] Import translations. DO NOT MERGE
am: 76b2775eee -s ours
am skip reason: subject contains skip directive

Change-Id: If89a18a90a0f7a869340890b22410c25286baf81
2019-10-11 11:10:21 -07:00
Jon Miranda 1dd2e48190 Wait until listeners/end runnable is created before checking icon result.
This prevents the case where original icon is in hidden state, then the
view gets recycled and since there is no listener/end runnable the original
icon is left in the hidden state.

Bug: 142120338
Change-Id: I5f5bfa2a7c70d10869f51edf5c40bbaab1ef93bc
2019-10-11 11:03:26 -07:00
Bill Yi 20ae6826e8 [automerger skipped] Import translations. DO NOT MERGE
am: e2c21704eb -s ours
am skip reason: subject contains skip directive

Change-Id: I314f9f020aa0aadaaee6560083ec807f323d02ba
2019-10-11 10:52:21 -07:00
Bill Yi e2c21704eb Import translations. DO NOT MERGE
Change-Id: I2ce1448b6a7ee5cb455a2fc044336c37e03093aa
Auto-generated-cl: translation import
2019-10-11 08:19:31 -07:00
Bill Yi e72b993b91 Import translations. DO NOT MERGE
Change-Id: Ie268b67529ed9728f79745402d430d007f0f3286
Auto-generated-cl: translation import
2019-10-11 08:15:45 -07:00
Bill Yi 76b2775eee Import translations. DO NOT MERGE
Change-Id: I9dc5e28b5460a89b6b43f114aa4462f65f834d50
Auto-generated-cl: translation import
2019-10-11 08:11:57 -07:00
Xin Li 4a1e218bb2 [automerger skipped] Merge "DO NOT MERGE - Merge QP1A.191005.007 into master" am: db68a15812 am: f73d33c1fc am: a45baaa6f5
am: 20067eb669 -s ours
am skip reason: subject contains skip directive

Change-Id: Iab011b345d2a753c1f567b0781b3fe28b23496ab
2019-10-10 22:08:43 -07:00
Xin Li ba575a150f [automerger skipped] DO NOT MERGE - Merge QP1A.191005.007 into master am: 272ecdce0b am: 87ff33d584 am: ca81ca46e5
am: 57f0330698 -s ours
am skip reason: subject contains skip directive

Change-Id: If6510e9c22a2ecc9bb6cc420270c11cd2c410b9d
2019-10-10 21:51:47 -07:00
Xin Li 20067eb669 Merge "DO NOT MERGE - Merge QP1A.191005.007 into master" am: db68a15812 am: f73d33c1fc
am: a45baaa6f5

Change-Id: I64ec016aa1472ec03f5b9ce3fd758eba506ac327
2019-10-10 21:51:17 -07:00
Xin Li a45baaa6f5 Merge "DO NOT MERGE - Merge QP1A.191005.007 into master" am: db68a15812
am: f73d33c1fc

Change-Id: I36a018d3b0ca376f2afcc934e8e57381e2b46143
2019-10-10 21:38:18 -07:00
Xin Li 57f0330698 DO NOT MERGE - Merge QP1A.191005.007 into master am: 272ecdce0b am: 87ff33d584
am: ca81ca46e5

Change-Id: Ief1a288837d491c74edad5a764247d68a341cdca
2019-10-10 21:33:57 -07:00
Xin Li f73d33c1fc Merge "DO NOT MERGE - Merge QP1A.191005.007 into master"
am: db68a15812

Change-Id: I671da88e2f1229b6e61787ceff16f56fb0978fbb
2019-10-10 21:27:48 -07:00
Xin Li ca81ca46e5 DO NOT MERGE - Merge QP1A.191005.007 into master am: 272ecdce0b
am: 87ff33d584

Change-Id: Ie9a283dec133135d7d85866f4452d1ba172fc657
2019-10-10 21:21:42 -07:00
Xin Li 87ff33d584 DO NOT MERGE - Merge QP1A.191005.007 into master
am: 272ecdce0b

Change-Id: Ie04781fc9e73dac178495bbc1e031f868d36f90a
2019-10-10 21:11:18 -07:00
Xin Li db68a15812 Merge "DO NOT MERGE - Merge QP1A.191005.007 into master" 2019-10-11 02:56:39 +00:00
Winson Chung c039634c25 Workaround for failing test & fix scrolling in tests
- Workaround issue where instrumentation will fail to finish an activity
  causing the activity to linger longer than expected (leading to issues
  with ordering of static resources like the app widget host registration)
- Fix calculation for scrolling the screen, the previous calculation
  would result in the gesture starting at the left gesture margin due
  to rounding which can trigger a back action instead of the desired
  scroll

Bug: 142351228
Change-Id: I34bdb471030518d2b983cac2badd4d8b0e7d571b
2019-10-10 17:31:38 -07:00
Xin Li 272ecdce0b DO NOT MERGE - Merge QP1A.191005.007 into master
Bug: 142297020
Change-Id: I8ee6a4e97c145226a5a943a0882925c8c9525c81
2019-10-10 22:53:35 +00:00
android-build-team Robot 63791b9a67 Snap for 5931403 from eec392b67a to rvc-release
Change-Id: I752d199c874c1bd84ee7f08b90f00b8cb72250e5
2019-10-10 03:09:29 +00:00
android-build-team Robot d65611bf85 Merge cherrypicks of [9530040, 9530338, 9530339, 9530041, 9530042, 9530043, 9530784, 9530785, 9530786] into qt-qpr1-release
Change-Id: If7383c1979c3fb734669080f52a14f942be49341
2019-10-10 00:46:12 +00:00
Tony Wickham ddd057e87c Fix quickswitch flickers/ignored swipes
- Don't set current page to running task when applying load plan,
  if we are already settling on a new task to launch.
- When starting a new task, finish to the running app if that's
  the task being started (should not happen with above change)
- When disabling free scroll mode, don't snap to a page if we're
  already on it. This was setting mNextPage so the first check
  was falsing.

Bug: 142068081
Change-Id: I5b392d9726a81c51718d2f94eee6cd4f78b61f69
Merged-In: I5b392d9726a81c51718d2f94eee6cd4f78b61f69
(cherry picked from commit af33f2c9d4)
(cherry picked from commit 4d86c804ba)
2019-10-10 00:45:35 +00:00
Tony Wickham 05be86068f Don't allow scrolling RecentsView outside navbar during quickswitch
Once the inputProxy (OverviewInputConsumer) was enabled, it was never
disabled. And while it was enabled, touches above the nav bar would go
through to launcher, allowing you to scroll RecentsView (for example)
during quick switch transitions. This breaks some assumptions, since
it doesn't go through our normal shared swipe state logic that cancels
the animation, updates the new end target (e.g. NEW_TASK vs LAST_TASK),
etc. Thus, if you tried returning to LAST_TASK via this route, we would
end up starting it as a new activity instead of resuming the existing
one, causing a flicker (I guess because that TaskView is hidden).

Test:
- Swipe up from task A to home (to enable input proxy)
- Open A
- Swipe to B, and during transition scroll back to A from the center of
the screen

Before, this caused a flicker, now the last scroll is ignored.

TODO: we should increase the nav region during quick switch to make it
easier to continue scrolling

Bug: 136829198
Bug: 138620399
Change-Id: I5ffb53743b728e1909066c5dd18cc9308aff2c7e
(cherry picked from commit c9654eb091)
(cherry picked from commit 2784315f7d)
(cherry picked from commit 80090d579f)
2019-10-10 00:45:29 +00:00
Tony Wickham eec392b67a [automerger skipped] Merge "Fix quickswitch flickers/ignored swipes" into qt-qpr1-dev am: a9012ea717
am: 15280b902c -s ours
am skip reason: change_id I5b392d9726a81c51718d2f94eee6cd4f78b61f69 with SHA1 8e8a376a62 is in history

Change-Id: I3b50408c4c8a8aa6ec0112194ffbc44bf9223cd6
2019-10-09 13:42:26 -07:00
Tony Wickham b0ee81da4a Don't allow scrolling RecentsView outside navbar during quickswitch am: 80090d579f
am: afbb4a8a09

Change-Id: Idd9963af8223d7f88f406328956f6540d29efafe
2019-10-09 13:39:34 -07:00
Tony Wickham 15280b902c Merge "Fix quickswitch flickers/ignored swipes" into qt-qpr1-dev
am: a9012ea717

Change-Id: I06b5e3b8baa2a4d1041dfe9a99ad530c02d2229d
2019-10-09 13:37:16 -07:00
Tony Wickham afbb4a8a09 Don't allow scrolling RecentsView outside navbar during quickswitch
am: 80090d579f

Change-Id: Ib26bde87b9070a1a07e5bc12c11896e9d1bf4337
2019-10-09 13:36:40 -07:00
TreeHugger Robot a9012ea717 Merge "Fix quickswitch flickers/ignored swipes" into qt-qpr1-dev 2019-10-09 20:20:25 +00:00
Tony Wickham 4d86c804ba Fix quickswitch flickers/ignored swipes
- Don't set current page to running task when applying load plan,
  if we are already settling on a new task to launch.
- When starting a new task, finish to the running app if that's
  the task being started (should not happen with above change)
- When disabling free scroll mode, don't snap to a page if we're
  already on it. This was setting mNextPage so the first check
  was falsing.

Bug: 142068081
Change-Id: I5b392d9726a81c51718d2f94eee6cd4f78b61f69
Merged-In: I5b392d9726a81c51718d2f94eee6cd4f78b61f69
(cherry picked from commit af33f2c9d4)
2019-10-09 15:28:23 +00:00
Tony Wickham 80090d579f Don't allow scrolling RecentsView outside navbar during quickswitch
Once the inputProxy (OverviewInputConsumer) was enabled, it was never
disabled. And while it was enabled, touches above the nav bar would go
through to launcher, allowing you to scroll RecentsView (for example)
during quick switch transitions. This breaks some assumptions, since
it doesn't go through our normal shared swipe state logic that cancels
the animation, updates the new end target (e.g. NEW_TASK vs LAST_TASK),
etc. Thus, if you tried returning to LAST_TASK via this route, we would
end up starting it as a new activity instead of resuming the existing
one, causing a flicker (I guess because that TaskView is hidden).

Test:
- Swipe up from task A to home (to enable input proxy)
- Open A
- Swipe to B, and during transition scroll back to A from the center of
the screen

Before, this caused a flicker, now the last scroll is ignored.

TODO: we should increase the nav region during quick switch to make it
easier to continue scrolling

Bug: 136829198
Bug: 138620399
Change-Id: I5ffb53743b728e1909066c5dd18cc9308aff2c7e
(cherry picked from commit c9654eb091)
(cherry picked from commit 2784315f7d)
2019-10-09 05:38:20 +00:00
TreeHugger Robot 012fbc78b4 Merge "Using SpringAnimationBuilder instead of SpringObjectAnimator in StaggeredWorkspaceAnim" into ub-launcher3-master 2019-10-08 22:53:50 +00:00
Winson Chung d7269bf8b6 8/ Rename ActivityControlHelper
- ActivityControlHelper -> BaseActivityInterface
  LauncherActivityControlHelper -> LauncherActivityInterface
  FallbackActivityControlHelper -> FallbackActivityInterface
  QuickCaptureTouchConsumer -> QuickCaptureInputConsumer
- Move gestures to use the activity interface from the gesture state

Bug: 141886704
Change-Id: I6f12daeb03d564143404767dfe4576e3e5da2a1d
2019-10-08 13:39:13 -07:00
Winson Chung d3da92ac66 7/ Rename RecentsAnimationWrapper
- Move the recents animation classes out of util into base quickstep pkg
- Clean up some local var names

Bug: 141886704
Change-Id: I1556179e203cbb43b77ea58e6fe520aa9944099b
2019-10-08 13:30:27 -07:00
Sunny Goyal d7b9db7bda Using SpringAnimationBuilder instead of SpringObjectAnimator in StaggeredWorkspaceAnim
Change-Id: I3a7b38e3f866c95a92fbb314f0a79b0735f38c9d
2019-10-08 13:21:03 -07:00
Winson Chung 9e876a34ee 6/ Update recents animation classes to have their respective responsibilities
- RecentsAnimationTargets: manages information about the targets only
  RecentsAnimationCallbacks: manages callbacks from WM about the animation
  RecentsAnimationWrapper: manages calls into WM to update the animation
                           (to be renamed accordingly in a follow up CL)
- Create the Callbacks as a part of starting the recents animation, and
  have the callbacks create the controller wrapper and the targets, which
  are both notified to the listeners through the callbacks.
- Instead of passing through a callback for recents animation finished,
  have it be a part of the recents animation callbacks.

Bug: 141886704

Change-Id: I4ff26a175654e82efe059fa74d1f310e93961dc9
2019-10-08 13:15:15 -07:00
Winson Chung bfcee430fe 5/ Remove OverviewInteractionState
- We can move the background call to UiThreadHelper, the last sysui flags
  and back button alpha to SystemUiProxy (and dedupe values there as well)

Bug: 141886704

Change-Id: I22183608700c6d71355597c7a08eefa19f4381fd
2019-10-08 13:15:15 -07:00
Winson Chung 8ff53f7e65 4/ Move SystemUiProxy to its own singleton instead of routing through the model
Bug: 141886704
Change-Id: I415b9ef7b57b525407e3a341b946e3ca66125102
2019-10-08 13:15:13 -07:00
Winson Chung 629c87283f 3/ Move touch interaction log to its own class
Bug: 141886704
Change-Id: I5f27faf83ccacc2d2eb2914f15e860d07628c37c
2019-10-08 12:16:48 -07:00
James O'Leary 8d46a3dc00 Merge "Add feature flag + leftward swipe for Compose access." into ub-launcher3-master 2019-10-08 19:03:04 +00:00
TreeHugger Robot f31dab5e02 Merge "Removing static instance of LauncherAppsCompat and unnecessary wrapper classes" into ub-launcher3-master 2019-10-08 18:49:36 +00:00
Jeff Pierce e4607587ed Add feature flag + leftward swipe for Compose access.
Stole ag/9453040 from jspierce@ and added a feature flag.

ag/9453040: Exploratory prototype to test leftward swipe access to
Compose across home screen, launcher, and lock screen. Requires Compose
APK (installed separately).

Change-Id: I15a045976b1eb41392795d3a4f0743f365dec1d2
2019-10-08 14:00:53 -04:00
vadimt 4b5c1ef71b Adding support for intentionally leaking views.
Bug: 139137636
Change-Id: I923d1781daee9ae47eb306ee8fa3c44790c6993f
2019-10-08 17:04:26 +00:00
Tony Wickham 8e8a376a62 Fix quickswitch flickers/ignored swipes
- Don't set current page to running task when applying load plan,
  if we are already settling on a new task to launch.
- When starting a new task, finish to the running app if that's
  the task being started (should not happen with above change)
- When disabling free scroll mode, don't snap to a page if we're
  already on it. This was setting mNextPage so the first check
  was falsing.

Bug: 142068081
Change-Id: I5b392d9726a81c51718d2f94eee6cd4f78b61f69
(cherry picked from commit af33f2c9d4)
2019-10-08 16:55:31 +00:00
TreeHugger Robot 6369136f33 Merge changes I2ade7f48,I78485a16 into ub-launcher3-master
* changes:
  2/ Move device state logic to its own class
  1/ Renaming some classes for clarity
2019-10-08 16:42:13 +00:00
TreeHugger Robot 86017c9611 Merge "Removing access to LauncherModel.getCallbacks" into ub-launcher3-master 2019-10-08 16:26:12 +00:00
TreeHugger Robot 8ae1151387 Merge "Reduce risk of flakes in memory leak detection tests." into ub-launcher3-master 2019-10-08 16:24:34 +00:00
Winson Chung 75eb0e0f20 2/ Move device state logic to its own class
- Feed the class down to the input consumers and related gesture classes
  instead of specific sysui state flags

Bug: 141886704

Change-Id: I2ade7f48555c9d0ba0d3fac5c1f2dae694624224
2019-10-07 20:49:08 -07:00
Winson Chung 92a015f2fc 1/ Renaming some classes for clarity
- SwipeAnimationTargetSet -> RecentsAnimationTargets
- RemoteAnimationTargetSet -> RemoteAnimationTargets
- RecentsAnimationListenerSet -> RecentsAnimationCallbacks
- SwipeAnimationTargetSet.SwipeAnimationListener -> RecentsAnimationCallbacks.RecentsAnimationListener
- ClipAnimationHelper -> AppWindowAnimationHelper
- AssistantTouchConsumer -> AssistantInputConsumer

Bug: 141886704

Change-Id: I78485a1651bb360ffbac2d0c462855931a995ee1
2019-10-07 20:49:08 -07:00
Samuel Fufa 023188e424 Merge "Scale Icon badges for shortcut and widgets" into ub-launcher3-qt-future-dev
am: f2d486e5b0

Change-Id: I5c2c115b1ee42489d969ff30c48abf00d4a5a3f7
2019-10-07 18:56:02 -07:00
Samuel Fufa f2d486e5b0 Merge "Scale Icon badges for shortcut and widgets" into ub-launcher3-qt-future-dev 2019-10-08 01:41:53 +00:00
vadimt 1b92f6d964 Reduce risk of flakes in memory leak detection tests.
Now performing jreck@-style garbage collection prior to getting Launcher
PSS. The reduces PSS noise from ~700KB to ~250KB (std dev).

The tests (MemoryTests) run outside of Launcher process and
communicate with Launcher via RPC.

The change is in the RPC handler that lives in Launcher and returns
Launcher PSS to the test.

Bug: 139137636
Change-Id: I457e590b005dac53345f4223d972c7961754938c
2019-10-08 01:05:41 +00:00
Tony Wickham 1ab5de3fc8 Merge "Fix quickswitch flickers/ignored swipes" into ub-launcher3-qt-future-dev
am: 9788183962

Change-Id: I153fe569fd3f2c8ad065282eed56f9f13c5ab0d4
2019-10-07 14:27:22 -07:00