Commit Graph

6193 Commits

Author SHA1 Message Date
Vinit Nayak c609421f2a Maintain fake nav bar position in overview for landscape
NavBar defaults to display when quickswitch ends,
which is always portrait since home is now always
in portrait. We keep the same nav region that the
user used to swipe up to enter recents and reset once
they swipe to home.

Fixes: 156053957
Test: Swipe up from landscape app, then swipe up
from the same nav bar region to go home.

Change-Id: Ia4cf8172850b991aa5e145897622be3b2afa3779
2020-05-21 11:24:16 -07:00
Tony Wickham c613d9fe42 Update some TouchInteractionService logs am: c7c883a880
Change-Id: Ief38dc10c14dc628abb3a620f5793aefa1f107da
2020-05-21 07:10:43 +00:00
Tony Wickham 17312c3566 Keep recents attached to app window on continued switching
- LAST_TASK now has recentsAttachedToAppWindow = true, to match
  NEW_TASK. Though this does mean there's a small chance of
  seeing recents translating in if you swipe up and back down,
  this is preferable to seeing recents translate away if you
  swipe right and back left in two consecutive gestures.
- Until passing the touch slop for a new gesture, keep recents
  attached to the app window. This avoids cases where you
  could have recents view translate away mid-gesture, such as
  in the following case: swipe from A to B, swipe from B back
  to A, touch down during the transition back to A. Before this
  change, you would see recents translate away; with this
  change, recents instead stays in place until we get another
  signal indicating it should detach, such as swiping to home.

Bug: 157153404
Change-Id: I63a3a8b988af1aac5177f101b0b75e73e56b1ceb
2020-05-21 00:55:54 -05:00
Sreyas 1e2457743b Logging to debug Overview Actions not working.
Change-Id: Ic5571ce0c02296415f24413403cbdf62fa9b4594
2020-05-20 17:53:48 -07:00
Jon Miranda 68e1d6a060 Add all apps education tutorial. am: 517cec5344
Change-Id: I0425fd2c1fc9bff20817a40d7daeba3b54f52b30
2020-05-20 19:37:32 +00:00
Tony Wickham c7c883a880 Update some TouchInteractionService logs
- Move "finishRecentsAnimation" for NEW_TASK to where we actally
  finish the controller after onTaskAppeared()
- Add "setEndTarget" and "onSettledOnEndTarget" logs

Bug: 156412706
Change-Id: I0a0f81d3b601fc1eed72b372235bbb92368ec246
2020-05-20 14:30:31 -05:00
Jon Miranda 517cec5344 Add all apps education tutorial.
* Added FeatureFlag.ENABLE_ALL_APPS_EDU
* When user swipes up on nav bar three times and goes to hint state
  consecutively, we show the new All Apps education tutorial.
* For now we block interaction while the animation is playing,
  and we remove the view when the animation is done.
* Future CL will leave view up until user successfully reaches All Apps state.

Bug: 151768994
Change-Id: I903e0a3914d0558950ecb8cd714d97ddc10ca06b
2020-05-20 11:44:23 -07:00
Joshua Trask 41dc164d11 Merging from ub-launcher3-rvc-dev @ build 6511067
Bug:150504032
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-rvc-dev_rvc-dev_6511067.html

Change-Id: Ifc8c251ef0f03e66de3b1c9fa94bfcb980704769
2020-05-20 11:12:54 -04:00
TreeHugger Robot 892ebe10a4 Merge "Unifying swipe handling for fallback launcher" into ub-launcher3-rvc-dev am: 6928c3bc05
Change-Id: I1e6a90a23ce71bc398fc9195c137098f94e5f778
2020-05-20 05:45:34 +00:00
TreeHugger Robot 6928c3bc05 Merge "Unifying swipe handling for fallback launcher" into ub-launcher3-rvc-dev 2020-05-20 05:32:36 +00:00
Sunny Goyal 672d02cd39 Unifying swipe handling for fallback launcher
Previosuly we had a different swipe handler for 3P Launcher which
started either recents or Launcher based on the initial interaction
(horizontal or vertical). This was primarily because we had to wait
for recents transition to finish before starting another activity
which could delay going to home.

Now we always start recents transition to recentsActivity. This allows
us to use the same swipe handling logic as QuickstepLauncher. Home
activity can be started while recents transition is running and can be
controlled using onTaskAppeared callback.

Bug: 156924169
Bug: 156398988
Bug: 156295255
Change-Id: Ib9f02e0281e8d674bde2f4a81eca5fc8a5962144
2020-05-19 19:41:30 -07:00
TreeHugger Robot 8cb5a760ed Merge "Fix weird split-screen secondary task animation" into ub-launcher3-rvc-dev am: c475f28b4f
Change-Id: Ie99414430cb9f6d4f8942e5aa692416b8c6e5018
2020-05-20 02:12:27 +00:00
TreeHugger Robot c475f28b4f Merge "Fix weird split-screen secondary task animation" into ub-launcher3-rvc-dev 2020-05-20 01:57:15 +00:00
TreeHugger Robot 2ee582650f Merge "More logging for swiping to Overview instead of All Apps" into ub-launcher3-rvc-dev am: a41f9dcbe9
Change-Id: I23621d2e172af2fe1266c9cc72fbf81791187521
2020-05-19 21:08:34 +00:00
Vinit Nayak 11b1c23aa0 Merge "Increase overview thumbnail size for 2 button landscape." into ub-launcher3-rvc-dev am: a8f083b581
Change-Id: I4b395e3068d2935c26f4aa2e6de79f3b3db8316d
2020-05-19 21:08:28 +00:00
TreeHugger Robot a41f9dcbe9 Merge "More logging for swiping to Overview instead of All Apps" into ub-launcher3-rvc-dev 2020-05-19 21:04:20 +00:00
Vinit Nayak a8f083b581 Merge "Increase overview thumbnail size for 2 button landscape." into ub-launcher3-rvc-dev 2020-05-19 20:49:08 +00:00
vadimt f95cfce267 More logging for swiping to Overview instead of All Apps
Bug: 156095088
Change-Id: Ia4d59b43225c7652cfc0ae72c05a5477deeb842b
2020-05-19 12:49:17 -07:00
Vinit Nayak 88830c0657 Increase overview thumbnail size for 2 button landscape.
With shelf hidden in 2 button landscape, need to fill
in the extra space w/ larger thumbnail.

Fixes: 156442623
Test: Larger thumbnail shows up in 2 button landscape
Change-Id: Ie2856c8d248b28ae7c06cbe40c7417a827c2bd96
2020-05-19 12:07:37 -07:00
Ming-Shin Lu ce7eec0bbd Fix weird split-screen secondary task animation
As CL[1] corrects the screenBounds of remote animation target,
and we are now using RemoteAnimationTarget#localBounds to offect the
position.

Remove the offset logics in AppWindowAnimationHelper#updateSourceStack,
and TaskViewSimulator#setPreview, then refine computeSurfaceParams
with offseting the position of HOME task by localBounds.

[1]: I793f01fb290fe65af1bbf8e29e429fbca63ac255

Fix: 153581126
Test: manual as below steps:
     1) Launch a app, swipe up to overview screen.
     2) Tap app icon and pressing "Split screen" item.
     3) After entered split-screen mode, taps the task view.
     4) Make sure the secondary task animation the movement is
        correct and smoothly.

Change-Id: I0e4ed1465e80f48336908813ac694fb3aaa3c347
2020-05-19 17:07:47 +00:00
Ming-Shin Lu 1eedfc33c5 Fix weird split-screen secondary task animation
As CL[1] corrects the screenBounds of remote animation target,
and we are now using RemoteAnimationTarget#localBounds to offect the
position.

Remove the offset logics in AppWindowAnimationHelper#updateSourceStack,
and TaskViewSimulator#setPreview, then refine computeSurfaceParams
with offseting the position of HOME task by localBounds.

[1]: I793f01fb290fe65af1bbf8e29e429fbca63ac255

Fix: 153581126
Test: manual as below steps:
     1) Launch a app, swipe up to overview screen.
     2) Tap app icon and pressing "Split screen" item.
     3) After entered split-screen mode, taps the task view.
     4) Make sure the secondary task animation the movement is
        correct and smoothly.

Change-Id: I0e4ed1465e80f48336908813ac694fb3aaa3c347
2020-05-19 20:02:44 +08:00
Vinit Nayak 97a479a80e Merge "Override Rect#contains() to include bottom right" into ub-launcher3-rvc-dev am: 4ae95beb9b
Change-Id: If518db06e4049fb9487cf6a68875eed1618ccbbe
2020-05-18 22:31:50 +00:00
Vinit Nayak 4ae95beb9b Merge "Override Rect#contains() to include bottom right" into ub-launcher3-rvc-dev 2020-05-18 22:21:55 +00:00
TreeHugger Robot 42ff4eded9 Merge "Using taskView simulator for animation a task to recentsView" into ub-launcher3-rvc-dev am: d5315f8c29
Change-Id: Ifacdfd10534e09a27599dd2ffb9e87c57f28c3c2
2020-05-18 19:17:47 +00:00
TreeHugger Robot d5315f8c29 Merge "Using taskView simulator for animation a task to recentsView" into ub-launcher3-rvc-dev 2020-05-18 19:02:30 +00:00
Vinit Nayak 0b94c2736c Merge "Hide shelf in 2-Button Landscape" into ub-launcher3-rvc-dev am: 08619f8600
Change-Id: I9a23f52c7e61dbd930b4143bf0de3de274bd2b21
2020-05-17 23:45:45 +00:00
Vinit Nayak 08619f8600 Merge "Hide shelf in 2-Button Landscape" into ub-launcher3-rvc-dev 2020-05-17 23:32:00 +00:00
Vinit Nayak 23681083b2 Hide shelf in 2-Button Landscape
Disable overview rotation in 2-Button.

Fixes: 154181816
Test: Tested no button and 2 button,
overview actions worked as before.

Change-Id: Ic22c791c7a93460840d54aaf0bf32884cc110e19
2020-05-17 15:17:11 -07:00
TreeHugger Robot bc5919ee3b Merge "Log last appeared task id instead of target" into ub-launcher3-rvc-dev am: 04f476dcb0
Change-Id: Ia01dbdc7014c5d5e61e2dd9a89a112d40751c70c
2020-05-15 22:36:52 +00:00
TreeHugger Robot 04f476dcb0 Merge "Log last appeared task id instead of target" into ub-launcher3-rvc-dev 2020-05-15 22:22:43 +00:00
Tony Wickham 39f2f1029b Log last appeared task id instead of target
Might be slightly more useful (e.g. if we
need to compare against last started task id)

Change-Id: I3617be270bec6841fbd943e681de78ada549ff84
2020-05-15 16:32:04 -05:00
Sunny Goyal b9abae9f0f Using taskView simulator for animation a task to recentsView
Also applying transform params in DeviceLockedInputConsumer directly
instead of going through AppWindowAnimationHelper

Bug: 156398988
Bug: 155816922
Change-Id: I791e1a9feb07c4fb787130f8d040a4f404faf734
2020-05-15 14:07:29 -07:00
TreeHugger Robot bb907f7ced Merge "Deference mAppPredictor on destroy" into ub-launcher3-rvc-dev am: 9027a04514
Change-Id: I058c51bd5972b84ee9864c4befffd8c3f093aa87
2020-05-15 20:32:37 +00:00
TreeHugger Robot 9027a04514 Merge "Deference mAppPredictor on destroy" into ub-launcher3-rvc-dev 2020-05-15 20:17:42 +00:00
TreeHugger Robot b9c9aab27f Merge "Remove debug logs, root cause found." into ub-launcher3-rvc-dev am: 2d78b783cc
Change-Id: I524101aecd8e15eed8b0f296fa0c6cdcd1f9e9e3
2020-05-15 19:18:07 +00:00
TreeHugger Robot 2d78b783cc Merge "Remove debug logs, root cause found." into ub-launcher3-rvc-dev 2020-05-15 19:03:06 +00:00
Samuel Fufa 4dd6ab3ca1 Deference mAppPredictor on destroy
+ Also remove PredictionModel.mCachedComponentKeys

Bug: 156747920
Bug: 156041043
Test: Manual

Change-Id: I56dac1c6ac0a1bb93363342006232fc1ba42a3b4
2020-05-15 11:33:27 -07:00
Vinit Nayak 9c62e18660 Remove debug logs, root cause found.
Bug: 146964271
Change-Id: I38ed3b4b1a90fa1ff9a3aa4bb5547300ddd92358
2020-05-15 10:04:51 -07:00
TreeHugger Robot 987e375312 Merge "Prevent all apps prediction update while visible" into ub-launcher3-rvc-dev am: e241f6c243
Change-Id: I46f4afd992fd15c4c9b82a8bc4b85ba923598024
2020-05-15 10:43:06 +00:00
TreeHugger Robot e241f6c243 Merge "Prevent all apps prediction update while visible" into ub-launcher3-rvc-dev 2020-05-15 10:31:56 +00:00
TreeHugger Robot 0239366456 Merge "Switch to new protocol for hybrid hotseat" into ub-launcher3-rvc-dev am: 63cbfc6118
Change-Id: I6a5a9b07c2cc7b0d350da559bf56986d4e8a3ab8
2020-05-15 08:35:24 +00:00
TreeHugger Robot 63cbfc6118 Merge "Switch to new protocol for hybrid hotseat" into ub-launcher3-rvc-dev 2020-05-15 08:25:50 +00:00
Samuel Fufa 6793dae692 Prevent all apps prediction update while visible
Test: Manual
Bug: 156418702
Change-Id: Iaa5468d7c600e6568ac1e35108c586752d6658b6
2020-05-14 23:13:19 -07:00
Samuel Fufa d12d6ab98a Switch to new protocol for hybrid hotseat
- create predictor from items in bgModel instead of scanning views
- Launcher no longer checks for duplicates before sending pin/unpin events
- sending cached items from last prediction to reduce UI shuffle
- Switch to using UserCache to persist and read ComponentKey

Bug: 148814143
Bug: 156413231
Bug: 156200931
Change-Id: Ide6330bed8eb7f0c6fbec1d1ac21e7f67a9b2be2
2020-05-14 17:27:34 -07:00
Vinit Nayak c40352ef8c Override Rect#contains() to include bottom right
In landscape, the lowest coordinate touch registered
is the actual lowest pixel possible by the screen.
For portrait/seascape the lowest coordinate
is (lowest pixel possible - 1). The difference of the
one pixel makes Rect#contains() return false since
only top left Rect points are inclusive and bottom
right points are exclusive.

Fixes: 156333291
Test: Always able to smoothly go to overview from
landscape.

Change-Id: I6beddad99ae076a167d2a5f5e5acc6e466bff544
2020-05-14 17:26:15 -07:00
James O'Leary 3ed973c034 Merge "Compose gesture integrated fully into Launcher" into ub-launcher3-rvc-dev am: 4cb77a60aa
Change-Id: Ib138be3ddb8a1740d9ade68fa460be5bc50980c0
2020-05-14 20:26:00 +00:00
Adam Cohen ced96bbc6c Merge "Don't require the center task id to adjust status bar when swiping up" into ub-launcher3-rvc-dev am: 1682d0d71b
Change-Id: I2b6958b751180a7f176386ff28a25650c8f5f46a
2020-05-14 20:25:45 +00:00
James O'Leary 4cb77a60aa Merge "Compose gesture integrated fully into Launcher" into ub-launcher3-rvc-dev 2020-05-14 20:20:13 +00:00
Adam Cohen 1682d0d71b Merge "Don't require the center task id to adjust status bar when swiping up" into ub-launcher3-rvc-dev 2020-05-14 20:15:51 +00:00
Winson Chung d6eae2aee0 Merge "Update shelf offset earlier when in gesture nav" into ub-launcher3-rvc-dev am: 054b0ae358
Change-Id: I87925bb3e54d74c08ea35d748b207af7f30dc780
2020-05-14 19:17:10 +00:00