Commit Graph

10334 Commits

Author SHA1 Message Date
James O'Leary 74a2746b35 Compose gesture integrated fully into Launcher
- Support dismissing Compose via the reverse gesture from the appear
gesture
- Use Tony Wickham's ag/10204761 with some glue code to enable the
app below Compose panning in the same direction as the gesture as
Compose peeks in
- Add feature flag to use Compose hosted in a window (permits underlying
app panning)
- Use InterpolatingVelocityTracker to fix OtherActivityInputConsumer
processing swipes in the wrong direction ~20% of the time due to a bug
in VelocityTracker (see go/quirky-bubbles)

Change-Id: I3adbaee1763f21557fb628b60d03b0a03e7079ab
2020-05-14 14:18:19 -04:00
Winson Chung 034ce6fd94 Update shelf offset earlier when in gesture nav
- Provide a hint to Launcher to indicate it will be resumed when
  swiping home, which allows us to notify sysui before any potential
  pip invocation, reducing the likelyhood of two conflicting animations
  when entering pip

Bug: 156637223
Change-Id: Iae773e1aac88bbea6f74e1d1332417b448126471
2020-05-14 10:55:14 -07:00
Samuel Fufa 24e3b6598e Prevent AllApps scroller activation in NORMAL state
Bug: 153663434
Test: Manual
Change-Id: I859d63fff08091961970d72f56853b50433f6d44
2020-05-13 20:41:35 -07:00
thiruram f95f152971 Add LAUNCHER_FOLDER_LABEL_CHANGED events for folder label updates.
Sample Logs for all update combinations: https://docs.google.com/document/d/1CBP2yTcXdFhPdNG5ZmWFKSgd8mDbMevY-akVlUXPLDo/edit#bookmark=id.7y1p8n2dz8ge

Bug: 155410872
Bug: 152978018
Change-Id: I296b124b16aa07878f2cf7b74ab91f13b8e6cfbf
2020-05-13 17:36:10 -07:00
TreeHugger Robot 77f5efe1a3 Merge "Adds LAUNCHER_FOLDER_LABEL_CHANGED event." into ub-launcher3-rvc-dev 2020-05-13 23:44:59 +00:00
thiruram b9080c2a15 Add support to log LauncherEvent without ItemInfo.
Change-Id: I145a9500b0442c2b5d9f7f691460465b2bb13a07
2020-05-13 22:58:23 +00:00
Tracy Zhou 542b89eaa3 Merge "Don't continue rendering preview screen when binder is dead" into ub-launcher3-rvc-dev 2020-05-13 22:20:07 +00:00
Vinit Nayak bdd6522661 Merge "Update recents child views RTL handling" into ub-launcher3-rvc-dev 2020-05-13 21:41:09 +00:00
Tracy Zhou 7087a7bd91 Don't continue rendering preview screen when binder is dead
Fixes: 155365052
Test: manually quick switches between different grid options
Change-Id: I31dc14b0a50b5e3a5c81272b693303034fcf8b40
2020-05-13 14:06:05 -07:00
TreeHugger Robot 2f64428700 Merge "add null check to prevent NPE in logging app launch" into ub-launcher3-rvc-dev 2020-05-13 19:21:39 +00:00
TreeHugger Robot 650da4bbd1 Merge "Keep Predicted icon same size when dragging" into ub-launcher3-rvc-dev 2020-05-13 19:18:28 +00:00
thiruram 6524cc7237 Adds LAUNCHER_FOLDER_LABEL_CHANGED event.
Sample Log: https://docs.google.com/document/d/1CBP2yTcXdFhPdNG5ZmWFKSgd8mDbMevY-akVlUXPLDo/edit#bookmark=id.qwjknn6acmx6

Bug: 155410872
Bug: 152978018

Change-Id: Ib7641d3d42a3f4fd002d1dbb36dc4b9ea0f885fc
2020-05-13 18:40:48 +00:00
Pinyao Ting 44775ad756 add null check to prevent NPE in logging app launch
Bug: 156458241
Test: manual
Change-Id: I7327453233a1e22473967e7c0513b4e1fa282459
2020-05-13 11:39:24 -07:00
TreeHugger Robot e0fef877e4 Merge "Changing RecentsView layout based on the split screen task size" into ub-launcher3-rvc-dev 2020-05-13 18:35:05 +00:00
Samuel Fufa 167210a323 Keep Predicted icon same size when dragging
-> In addition, this also prevents the drawing of ring effect for predicted icon when view is about to be copied to drag bitmap. Icon will scale to full size (without ring) when dropped.

Video attached to bug report

Bug: 152325754
Test: Manual
Change-Id: Ibd1a5dbf76c41bdc30ae851ad914a4d0e32703c8
2020-05-13 11:22:27 -07:00
Vinit Nayak 08a8327b1d Update recents child views RTL handling
Fixes: 154928106
Test: AppIcon and clear all button
shows up as expected in LTR and RTL
configuration.

Change-Id: Idcf367b8aff53002e63a03b64b96e3602127707e
2020-05-12 22:24:26 -07:00
Tracy Zhou 9a1becebec Merge "Fade in grid preview" into ub-launcher3-rvc-dev 2020-05-13 00:45:37 +00:00
TreeHugger Robot 0276b7e2a7 Merge "Adds westworld logging events for drag and drop on target bar buttons." into ub-launcher3-rvc-dev 2020-05-13 00:31:19 +00:00
TreeHugger Robot 7839eaa9b7 Merge "Generating a long-press even only when it's expected" into ub-launcher3-rvc-dev 2020-05-12 22:22:52 +00:00
thiruram ff48451ecd Adds westworld logging events for drag and drop on target bar buttons.
This would add below set of LauncherEvents:
* LAUNCHER_ITEM_DROPPED_ON_REMOVE
* LAUNCHER_ITEM_DROPPED_ON_CANCEL
* LAUNCHER_ITEM_DROPPED_ON_DONT_SUGGEST
* LAUNCHER_ITEM_DROPPED_ON_UNINSTALL
* LAUNCHER_ITEM_UNINSTALL_COMPLETED
* LAUNCHER_ITEM_UNINSTALL_CANCELLED

Sample Logs: https://docs.google.com/document/d/1CBP2yTcXdFhPdNG5ZmWFKSgd8mDbMevY-akVlUXPLDo/edit#bookmark=id.3ndtl1dalhdt

Bug: 152978018
Change-Id: I055a1b001524753eea71384b4765522f5946fbbc
2020-05-12 15:09:28 -07:00
Tracy Zhou 0d880c876b Fade in grid preview
Fixes: 156406762
Test: https://drive.google.com/open?id=1JshUMjd1ASjHcAhnAiG3PEC-6wCRY7EE
Change-Id: I6a99650796fe64a6c11ee9fad6904b14373c6363
2020-05-12 14:43:44 -07:00
Tony Wickham f0c7966a77 Only set spring end value if animation wasn't canceled
Animations should only be canceled (as opposed to ended) if the
caller is intending to update the state from there. In that case,
we shouldn't jump to the end value.

Bug: 155335494
Change-Id: I93a21f0e2e1923ccdfab890adcb58c49ceb98a28
2020-05-12 16:22:03 -05:00
Sunny Goyal b78ea4b4fc Changing RecentsView layout based on the split screen task size
Bug: 155816922
Change-Id: I33f69d72f8a27e3621d029c6ee4045c3664f3ac9
2020-05-12 14:04:19 -07:00
Sunny Goyal 4888790bde Simplifying animation creating logic for app-to-overview
Removing optional 'shouldAnimate' flag. This was false only in 3-button mode but
the code was also handling animation, leading to inconsistent expectations. Instead
always assuming animation and finishing the animation promptly.

Change-Id: Ic56476dc5ea64c9a7d7e9744f3e33cd61dfde9e8
2020-05-12 16:37:27 +00:00
TreeHugger Robot eb0136b7c4 Merge "Abstracting out state handler logic into base classes so that it can also be used in different activity" into ub-launcher3-rvc-dev 2020-05-12 00:29:52 +00:00
TreeHugger Robot 072a6e01bc Merge "Even more logging for pause non-detection" into ub-launcher3-rvc-dev 2020-05-11 23:42:30 +00:00
TreeHugger Robot 3d668090af Merge "Resolve Test flakes" into ub-launcher3-rvc-dev 2020-05-11 23:40:43 +00:00
Sunny Goyal 35e7d38681 Abstracting out state handler logic into base classes so that it can
also be used in different activity

Change-Id: Ic5e60b21e1429c71f1cd4e7041e70bf4fc9761b7
2020-05-11 16:38:26 -07:00
vadimt d5cb9a7a18 Even more logging for pause non-detection
Bug: 156044202
Change-Id: I31fead73a6a64617aea67e66b01c365841229b92
2020-05-11 15:56:54 -07:00
Vinit Nayak 115e70ddcf Merge "Infer launcher rotation when initializing RecentsOrientedState" into ub-launcher3-rvc-dev 2020-05-11 19:07:54 +00:00
Adam Cohen 400dfe0d93 Merge "Fix animation for non-default grids when dragging icon from All Apps into a Folder" into ub-launcher3-rvc-dev 2020-05-11 18:38:28 +00:00
Adam Cohen 2438d40607 Merge "Fix issues with drag and drop from All Apps in non-default grids" into ub-launcher3-rvc-dev 2020-05-11 18:38:15 +00:00
Vinit Nayak b9522d334a Infer launcher rotation when initializing RecentsOrientedState
fixes: 154776599
Change-Id: I9b95f7f96836a974be0fd1236547efb4b405fda5
2020-05-11 11:23:49 -07:00
Hyunyoung Song e745f50128 Merge "Hookup statsd for workspace layout logging" into ub-launcher3-rvc-dev 2020-05-11 18:18:57 +00:00
vadimt 7b7e62e5eb Additional logging for pause non-detection
Bug: 156044202
Change-Id: I6d7dcdcf73722e66fcbd180c9e309c518766b9b8
2020-05-11 10:10:53 -07:00
Samuel Fufa b549819676 Resolve Test flakes
-> Synchronize calls in LoaderTask.java
issue 156041043

-> Remove non system users on setup
If a work test crashes before getting to run its teardown - we might end up with a user profile that could throw off subsequent tests.
issue 156022161

Test: Manual
Change-Id: Ife708a3de01572f7cb2187078d592d8d570dd951
2020-05-10 13:51:41 -07:00
Hyunyoung Song 7f7894e3b7 Hookup statsd for workspace layout logging
Bug: 144953948

Change-Id: I81bd42929b2d65a63c610e95e5e01179a3971493
2020-05-10 01:37:42 -07:00
Adam Cohen b70e7d1c1c Fix animation for non-default grids when dragging icon from All Apps into a Folder
Test: manual

Change-Id: I72b84ead68c6e415c91dd2b801fc05654a97cd96
2020-05-09 00:54:04 +00:00
TreeHugger Robot 9506316e21 Merge "More logging for pause non-detection" into ub-launcher3-rvc-dev 2020-05-08 23:12:40 +00:00
Adam Cohen c77bc45fa5 Fix issues with drag and drop from All Apps in non-default grids
=> Also fix the widget tray in these non-default grids, and the external shortcut addition flow. The layout was broken as it was scaling with the icon size. Instead keep it fixed which looks much better, similar to how we maintain all apps.
=> This also fixes a small jump when dragging shortcuts external to Launcher.

issue 154169001

Change-Id: Iad1e3859dd6fedccce9b5c6633e64426a4630c31
2020-05-08 16:00:08 -07:00
vadimt ad87034d1f More logging for pause non-detection
Bug: 156044202
Change-Id: I1c995b6c28f7108b96ff74aa8c3c71f70f8b3fb6
2020-05-08 15:09:37 -07:00
TreeHugger Robot 144f638fa3 Merge "Mitigate 10 minutes delay in launcher restore for work apps." into ub-launcher3-rvc-dev 2020-05-08 21:02:02 +00:00
vadimt 759f771a8d Generating a long-press even only when it's expected
I'm pretty sure that accidental long-presses are a result of fundamental
flaws in UIAutomator. The fix is tracked separately and is unlikely to
happen at all.

For now, just placing the generation under a condition.

Bug: 156113558
Change-Id: I8f369f934f9f576cf672b7fa98fbc9a63135602b
2020-05-08 13:16:25 -07:00
TreeHugger Robot 4d1203efab Merge "Fixing Fallback recents crashes when going to modal state" into ub-launcher3-rvc-dev 2020-05-08 19:46:35 +00:00
vadimt 2794f563a0 Adding tracing for switching to overview instead of all apps
Bug: 156095088
Change-Id: I1257617192e913d06edd0879396957b1e40524b7
2020-05-08 10:39:29 -07:00
Sunny Goyal 302ecabf2c Fixing Fallback recents crashes when going to modal state
> Adding robo tests to prevent such regressions
Bug: 155570625

Change-Id: I5cfbfc454849116f881322e8785dfdbad6f24d08
2020-05-08 10:12:17 -07:00
vadimt 091794671d Adding tracing for non-detection of Pause
Bug: 156044202
Change-Id: I16f196db6266a0c3a84b59b7cdeb29863a37ff0f
2020-05-07 20:06:58 -07:00
Sunny Goyal f67db3531b Moving animation configuration and definition out of state definition
This removes cross dependency between StateManager and State object so
that it can be easily generalized

Change-Id: I62851fc4b653655cb40f37023db9651055ec7c9c
2020-05-07 01:33:57 -07:00
TreeHugger Robot 7826bf52c7 Merge "Implements LAUNCHER_ITEM_DROP_FOLDER_CREATED event." into ub-launcher3-rvc-dev 2020-05-07 01:38:51 +00:00
James O'Leary ac327df55c Merge "Revert "Compose gesture integrated fully into Launcher"" into ub-launcher3-rvc-dev 2020-05-07 01:14:44 +00:00