Commit Graph

10334 Commits

Author SHA1 Message Date
TreeHugger Robot a36605ee90 Merge "Preventing parallel motion event dispatching from view system and event proxy" into ub-launcher3-rvc-dev 2020-06-16 18:20:51 +00:00
Samuel Fufa dc122e816a Merge "[WW logging] Log rankings for app launches" into ub-launcher3-rvc-dev 2020-06-16 04:41:54 +00:00
Tony Wickham 80846543b5 Fix qsb when flinging to home during gesture to overview from home
- AllAppsTransitionController should not animate alphas for atomic
  components even when failing fast (we already had this check for
  the normal flow where mProgress != targetProgress).
- Don't set state to NORMAL until both the workspace stagger anim
  and overview peek anim are finished

Test: swipe up and hold from the nav bar on the home screen, then,
without lifting finger, fling upwards to return home; ensure qsb
springs in staggered formation with rest of workspace, and alpha
matches accordingly

Bug: 154637581
Change-Id: Iafeaeac50ee8bce05492628d443c3ca4ab3d26df
2020-06-15 19:27:45 -05:00
Samuel Fufa e9c4f401bd [WW logging] Log rankings for app launches
Bug: 158219113
Change-Id: Ib6db4e73e48ff27ca9d3a5348eea42e1f534dba1
2020-06-15 17:17:47 -07:00
Hyunyoung Song 730c238b8d Call displayCompletions couple frames after selectAll is called
Bug: 158710542

Change-Id: I295adce9d84bb82c4af27b7e54693ce4c64004cc
2020-06-15 13:54:54 -07:00
Tony Wickham 9459f3101f Don't reset RecentsView in onIdpChanged()
Resetting unloads visible task data and thus will leave recents
blank if overview state is enabled. Instead, unload and reload
visible task data to take new icon shape into account.

(The reason we're getting onIdpChanged() on nav bar mode change
is because the change in nav bar height causes the computed icon
size to change very slightly.)

Also fix InvariantDeviceProfile copy constructor by copying
iconBitmapSize.

Test:
- Change between 0 button and 3 button nav modes, verify recents
  doesn't appear blank
- Change icon shape in Styles and Wallpapers and go to recents,
  verify icon shape is reflected in task icons

Bug: 156354328
Change-Id: Ife29f51e85814ff483d055005fa2645135d5ec3d
2020-06-15 14:02:12 -05:00
Sunny Goyal b10e865e48 Preventing parallel motion event dispatching from view system and event proxy
1) When view system is already dispatching an event, proxy-dispatch is restricted
   to gesture only and follow the gesture dispatching rule.
2) If a full-proxy-dispatch is going on, and view-dispatch comes in, view-dispatch
   takes over and proxy-dispatch is cancelled.
3) During gesture-only proxy dispatch, if view-dispatch already started a gesture,
   proxy dispatch is ignored. Otherwise view-dispatch is restricted to non-gesture
   dispatching only (and proxy-dispatch is already restricted to gesture only).

Bug: 158130948
Change-Id: Ied351663e16beda5acf49a52bdefea881c18b9cf
2020-06-15 11:50:54 -07:00
thiruram 8da127f175 Updates StatsLogManager to log LauncherAtom.ItemInfo directly.
This method is requied for logging tap on QSB with just container info.

Bug: 154717227

Change-Id: I0c61c86724b4faafe4073a578b92a654ca23727a
2020-06-14 02:02:08 +00:00
TreeHugger Robot 161ed5ad9b Merge "Announce folder content size with folder title" into ub-launcher3-rvc-dev 2020-06-12 21:55:33 +00:00
Tony Wickham d2d9837b3e Merge "Skip fling anim if it is a no-op, to save a frame of aniamtion" into ub-launcher3-rvc-dev 2020-06-12 21:10:29 +00:00
Tony Wickham 5112cdd30b Skip fling anim if it is a no-op, to save a frame of aniamtion
Bug: 158701272
Change-Id: Id2bc502d1caaeefeca339d5e5ad355ad8ba6d7ec
2020-06-12 14:23:46 -05:00
TreeHugger Robot a41762f846 Merge "Adding a new attribute to speficy folder label directly in layout" into ub-launcher3-rvc-dev 2020-06-12 18:48:51 +00:00
TreeHugger Robot e3a51fec39 Merge "Fixing sysui visibility changing multiple times on startup" into ub-launcher3-rvc-dev 2020-06-12 18:45:41 +00:00
Samuel Fufa 1150ab3825 Announce folder content size with folder title
Bug: 144094885
Test: Manual
Change-Id: I340f9292b62163e1d72778024f1765c7618084c2
2020-06-12 11:25:32 -07:00
Hyunyoung Song 13c2bc7303 LAUNCHER_APP_LAUNCH_TAP should log correctly for icons inside folder
Bug: 137777105

Change-Id: I5c1552481fc1b788ba41c57bfe97f126f55e5b16
2020-06-11 23:51:17 -07:00
TreeHugger Robot 368621a4bb Merge "ADD NPE check before shortcut key creation." into ub-launcher3-rvc-dev 2020-06-11 23:00:05 +00:00
TreeHugger Robot 4aef742314 Merge "Reduce launcher logs in bugreports" into ub-launcher3-rvc-dev 2020-06-11 22:41:39 +00:00
Samuel Fufa adbe9b6075 ADD NPE check before shortcut key creation.
Bug: 156871815
Change-Id: I88132a51f80062eaa76da5838d20c5fe93224635
2020-06-11 15:15:02 -07:00
Samuel Fufa 852145c9b5 Reduce launcher logs in bugreports
Bug: 158216867
Test: Manual
Change-Id: I068550f2c0b233d5c7a6c4685efb36b62ced5dde
2020-06-11 15:02:58 -07:00
TreeHugger Robot 8449aeaf6e Merge "Adding tooltip for Select button." into ub-launcher3-rvc-dev 2020-06-11 21:07:39 +00:00
Sreyas da727bbb98 Adding tooltip for Select button.
Change-Id: I3a09d20b6dd26e81b8a010e2d2da52c52408e845
2020-06-11 13:29:37 -07:00
Samuel Fufa 6fd62fde91 Migrate Hotseat logging to WW
Bug: 158218197
Change-Id: I77743b78593f169ffc30f91ab9963052417dac23
2020-06-11 09:27:36 -07:00
Tracy Zhou 3b18d41e2c Merge "Consider folder diff differently" into ub-launcher3-rvc-dev 2020-06-11 05:21:18 +00:00
TreeHugger Robot bb58efabc8 Merge "Remove unused HomeRotatedPageHandler" into ub-launcher3-rvc-dev 2020-06-11 03:10:13 +00:00
Sunny Goyal de52876a2b Fixing sysui visibility changing multiple times on startup
> During startup shelftop is updated after all-apps, causing all-apps to
set the sysuiVisibility according to it's own UI

Bug: 156422012
Change-Id: Idee06249ad45946ed0a9dc84702510ad90a305f4
2020-06-10 19:13:36 -07:00
vadimt 45564c831b Removing debug requests from non-debug test info handlers
Bug: 152629799
Bug: 153670015
Change-Id: I02776be811d1d3325b35880d19d25a6638f904ef
2020-06-10 18:48:37 -07:00
Vinit Nayak 84f30b213a Remove unused HomeRotatedPageHandler
Transfer functionality of choosing
task menu layout to PortraitPageHandler,
which is what it should have been to
begin with.

Fixes: 158484000
Change-Id: Iadda53e7e1f796c063a111823f7f6278f3fdbf58
2020-06-10 18:47:05 -07:00
TreeHugger Robot 743e25e2d2 Merge "Show discovery tip for hybrid hotseat" into ub-launcher3-rvc-dev 2020-06-10 23:22:14 +00:00
Samuel Fufa 5b2da14e72 Show discovery tip for hybrid hotseat
Doc: go/hybrid-hotseat-tips

Issue 157683315: for fully populated hotseat, count returns to home screen and show discovery tip if Tip action was not tapped.
Issue 158301717: Don't use cached items if client has predicted items.

Test: Manual
Change-Id: I4747a1148caa62a6262fb6592d5185bdf216ede6
2020-06-10 15:12:55 -07:00
thiruram ba0a6b61a3 Log folder open event into WW.
Bug: 158597506

Sample Log: https://paste.googleplex.com/5351626992779264

Change-Id: Ifb2f061924035abc84472a9a03d1b4212588428b
2020-06-10 15:00:19 -07:00
TreeHugger Robot c936fe1146 Merge "Add null check before updating animation progress" into ub-launcher3-rvc-dev 2020-06-10 21:51:45 +00:00
TreeHugger Robot 479ff47a72 Merge "Allows Accessibility to focus on specified view in AbstractFloatingView." into ub-launcher3-rvc-dev 2020-06-10 20:58:06 +00:00
Tony Wickham 779955390c Add null check before updating animation progress
Haven't been able to reproduce it locally, but seems theoretically
possible if we get an onDrag() event right after something else
cancels the animation (which clears the animation controller).

Bug: 157900227
Change-Id: Ia134aa948e62d39f71e41dd4e6b98f3227ae0522
2020-06-10 15:36:52 -05:00
Andy Wickham bc83edbf4d Allows Accessibility to focus on specified view in AbstractFloatingView.
Here, the first item in an ArrowPopup or Folder are focused on.

Note: There's another pre-existing bug where it announces
"Home screen x of y" when the floating view appears; this
change doesn't address that.

Fixes: 147470419
Change-Id: I1dc70edc21ea7c19a5742208512738d6c4a94067
2020-06-10 12:03:43 -07:00
thiruram 18c2495b8f Adds PredictedHotseatContainer to launcher_atom.proto
Used for differentiating logs from normal hotseat and predicted hotseat.

Bug: 158218197
Change-Id: I011ff724ea0916b32f680dc24e8d6090d3df766d
2020-06-10 10:44:58 -07:00
Tracy Zhou fa88a25ea4 Consider folder diff differently
Fixes: 157813770
Test: manual

Change-Id: I0e95f7d9709cacfe1c3b8384dfb15208a4c36914
2020-06-10 10:40:47 -07:00
Tracy Zhou c11a808b99 Merge "Workspace migration should start from CellY = 1" into ub-launcher3-rvc-dev 2020-06-10 17:21:16 +00:00
Tracy Zhou 51e33e187b Workspace migration should start from CellY = 1
Test: Manual
Fixes: 155828336
Change-Id: Ic262f63e5e9dc0a5738f71a84dc5cc8b0cefd321
2020-06-10 00:42:07 -07:00
thiruram 236f40d97e Update StatsLogManager to support ranking related events.
Change-Id: I238f00a782a620f704005d37c8972b5e25610c75
2020-06-10 02:47:58 +00:00
TreeHugger Robot 8984fea211 Merge "Apply PendingAnimation#mDuration to all added anims" into ub-launcher3-rvc-dev 2020-06-10 00:18:31 +00:00
Tony Wickham fe54c36822 Apply PendingAnimation#mDuration to all added anims
Doing this at the root instead of individually for all added
animators ensures none fall through the cracks.

Fixes: shelf moving too quickly in 2 button mode
Change-Id: I0de1ba9cee3fb8f1d6161371625d97e4b2305129
2020-06-09 18:35:07 -05:00
TreeHugger Robot e34b183547 Merge "Add feature flag for majority ranking." into ub-launcher3-rvc-dev 2020-06-09 23:23:49 +00:00
Tracy Zhou f917b640d0 Merge "Fix icons not rendering in folder migration" into ub-launcher3-rvc-dev 2020-06-09 22:59:31 +00:00
Jayaprakash Sundararaj f4898452f7 Add feature flag for majority ranking.
Bug: 157907222
Change-Id: I72962c3c68559ce8d40ca4137e89b9cc2913825a
2020-06-09 15:50:58 -07:00
Sunny Goyal 55e2b1635f Adding a new attribute to speficy folder label directly in layout
Bug: 158141109
Change-Id: I84dccf43981abc910c0d9e75bf316c6b27b3606b
2020-06-09 15:47:21 -07:00
Tracy Zhou 1983faca2d Fix icons not rendering in folder migration
Fixes: 157813770
Test: manual

Change-Id: I68a2685482756a2b8afa65bf652b667972158a46
2020-06-09 14:40:17 -07:00
Samuel Fufa 25afca44c4 Merge "Work profile visual polish" into ub-launcher3-rvc-dev 2020-06-09 21:21:56 +00:00
Samuel Fufa 2e59b95024 Work profile visual polish
- Calculate work profile switch height and apply it as a padding to recyclerview instead of reading height from view.
- Add solid background to work_apps paused overlay for improved crossfade animation on pause/unpause
- Don't show work paused overlay text in landscape mode

Bug 151672365
Bug 153763804
Bug 151595687

Test: Manual
Change-Id: I6c14a8a1624455181d4998555bcc3ae2bb422efe
2020-06-09 14:17:47 -07:00
Hyunyoung Song 58c936c1a2 Merge "Guard logging behind a feature flag Bug: 158442037" into ub-launcher3-rvc-dev 2020-06-09 18:47:29 +00:00
Hyunyoung Song 3b1786ce77 Merge "Add FolderInfo label source / Add instance id to snapshot logging" into ub-launcher3-rvc-dev 2020-06-09 18:26:07 +00:00