Commit Graph

3379 Commits

Author SHA1 Message Date
Sunny Goyal aeec80ddbb Creating default implementation for state lisnter method
> The transition start is used rarely

Change-Id: I0d33f0f6372eb4ef89bfbb66968612693b7c6033
2020-04-24 15:41:29 -07:00
TreeHugger Robot acafb3a287 Merge "Detects nav bar gestures to progress through Home tutorial." into ub-launcher3-rvc-dev 2020-04-24 18:58:30 +00:00
Andy Wickham 6b6287f414 Detects nav bar gestures to progress through Home tutorial.
Home gesture also exits Back and Home tutorials on the
completion screens (as does back gesture).

Test: Manually verified Back and Home tutorial flows.
Bug: 148542211
Change-Id: I8026745e875e9ccb8cfd60bc438213b2d896254d
2020-04-24 18:13:05 +00:00
Vinit Nayak 49d3fe598c Merge "Rotate Overview Task Action Menu" into ub-launcher3-rvc-dev 2020-04-24 17:48:01 +00:00
Ming-Shin Lu 4f07525417 Fix AlwaysOnTop stack may covered by RemoteAnimation
Now with hierarachical animation, the layer of
RecentsAnimation / RemoteAnimation are controlled by system.

Now Launcher side don't need to have other way to set layer for ZBoost
case, so remove setLayer & withLayer related logics for cleaning up.

Fix: 151024899
Test: manual, launch google map app -> enter PiP mode,
      swipe up to overview screen or launch activity from shortcut,
      make sure the PiP window is not covered by other apps.

Change-Id: I8028cd50d66f7d77e5d1ec6514e953c8be9935d6
(cherry picked from commit 99f7da7dd2)
2020-04-24 02:18:16 +00:00
TreeHugger Robot d73d39b45a Merge "Makeshift analog of Strictmode leak detector" into ub-launcher3-rvc-dev 2020-04-23 03:22:31 +00:00
vadimt b3e8ae8230 Makeshift analog of Strictmode leak detector
Strictmode leak detector is still a goal, but we might not be able to
achieve it in R. Strictmode has several framework-side bugs that perhaps
hide Launcher-side strictmode violations, while the time to fix
everything is limited, and new leaks get introduced all the time.

For now, implementing a check that is slightly more relaxed than
Strictmode, but still ensures the absence of leaks. I’ll keep
eliminating Strictmode violations as well as keep strengthening the
makeshift checker conditions until we’ll be able to enable Strictmode in
continuous testing.

I’m disabling Strictmode checks for now so that they don’t generate
unnecessary hprof dumps, but leaving the code dealing with strictmode.

Bug: 139137636
Change-Id: Ib10136b0d4e9892f70a19cd052ae5a54cf0a4efb
2020-04-22 19:00:12 -07:00
TreeHugger Robot 8d5a000071 Merge "Always return RecentsView to translation 0 on drag end" into ub-launcher3-rvc-dev 2020-04-23 01:25:06 +00:00
TreeHugger Robot 1bb37acb5d Merge "Don't allow swiping from overview to all apps in 3 button mode" into ub-launcher3-rvc-dev 2020-04-23 00:04:35 +00:00
Tony Wickham 6a6301c569 Always return RecentsView to translation 0 on drag end
After reaching overview, we let the user translate RecentsView
if they continue dragging around. But when they let go, we need
to return RecentsView to translation 0 since that's no longer
part of the state machine.

Change-Id: I30b51485339a3b6c3dd52bda113b1a05b6e885fa
2020-04-22 18:42:40 -05:00
TreeHugger Robot cea3ed48e5 Merge "Stop computing scroll if handler is invalidated" into ub-launcher3-rvc-dev 2020-04-22 23:39:11 +00:00
TreeHugger Robot 2309597c9a Merge "[Overview Actions] Update the navigation mode immediately when switch." into ub-launcher3-rvc-dev 2020-04-22 23:34:00 +00:00
Tony Wickham 22757e840c Don't allow swiping from overview to all apps in 3 button mode
Bug: 154761926
Change-Id: I155faec27f3b96e2f11aaec318d6846a893885e6
2020-04-22 23:13:48 +00:00
Becky Qiu 72c53af896 [Overview Actions] Update the navigation mode immediately when switch.
This would fix the issue that overview actions UI visibility was not set correctly.

Test: local
Bug: 152047880
Change-Id: Ia335c5c8947b39e580403090f461f87e78645af1
2020-04-22 15:57:34 -07:00
TreeHugger Robot 3e60577fa1 Merge "Fixing recentsView getting translated in NavBarToHomeTouchController" into ub-launcher3-rvc-dev 2020-04-22 22:42:46 +00:00
TreeHugger Robot 65a0cc72ae Merge "Assistive chip: Adjusting chip UI" into ub-launcher3-rvc-dev 2020-04-22 21:50:02 +00:00
Sunny Goyal de4815bdad Fixing recentsView getting translated in NavBarToHomeTouchController
Bug: 154657409
Change-Id: I4d7f3cac52b563370d612dd29d5e7322645b5cbe
2020-04-22 14:23:55 -07:00
Vinit Nayak e553e380d0 Rotate Overview Task Action Menu
Fixes: 153371258
Test: Tap on icon in portrait,
landscape and seascape. Open menu
then rotate phone.

Change-Id: I38b018371561b502fe211a3c2ddea4ff7fde4274
2020-04-22 14:16:05 -07:00
TreeHugger Robot cf3bed973c Merge "Fixing animation player not overshooting spring animation; tuning springs" into ub-launcher3-rvc-dev 2020-04-22 20:52:35 +00:00
Sreyas 71a091fe8a Assistive chip: Adjusting chip UI
Change-Id: I2970107f4324a5f01e0df4a6adf21875412582c6
2020-04-22 13:33:36 -07:00
Sunny Goyal 7f9e8e2d27 Fixing animation player not overshooting spring animation; tuning springs
=> setCurrentPlayTime is bounded between [0, duration] by the animation framework
Instead using interpolator so that we can go outside the bounds

=> Tune spring stiffness and dampening for overview card dismiss animations

Bug: 154061408
Change-Id: Iaa31491fff499db916b36d9779ec159b8a89a2de
2020-04-22 12:54:31 -07:00
TreeHugger Robot 6db6a59f86 Merge "Moving various orientation related config in RecentsOrientaedState" into ub-launcher3-rvc-dev 2020-04-22 19:19:34 +00:00
TreeHugger Robot cee56f039e Merge "Adding common code for instrumentation and robolectric tests" into ub-launcher3-rvc-dev 2020-04-22 17:49:22 +00:00
Sunny Goyal b7833f8193 Moving various orientation related config in RecentsOrientaedState
> Fixing RecentsOrientationState values for fallback recents
> Using proper rotation in task simulator

Change-Id: I770e7c8850e469f5dc0ce6f89889672f2decdc0d
2020-04-22 10:49:02 -07:00
Jonathan Miranda 8451542a25 Merge "Ensures that the swipe up to home animation is ended prior to view recycling." into ub-launcher3-rvc-dev 2020-04-22 05:31:37 +00:00
TreeHugger Robot 585628e270 Merge "Fixing activity leak via ActivityInitListener" into ub-launcher3-rvc-dev 2020-04-22 03:07:01 +00:00
TreeHugger Robot 947905d28b Merge "Fixing crash when emptyView gets added twice" into ub-launcher3-rvc-dev 2020-04-22 00:30:43 +00:00
vadimt 5a804dcbaf Fixing activity leak via ActivityInitListener
Bug: 139137636
Change-Id: I49ac81dfc69f63211d832bf558517c534f51eab8
2020-04-21 15:35:23 -07:00
Jon Miranda d08f8ac409 Ensures that the swipe up to home animation is ended prior to view recycling.
Bug: 154163960
Change-Id: I70b2c6290a2a17be8b80ba0209528173d6627332
2020-04-21 15:12:40 -07:00
Tony Wickham 9df3f0cebf Stop computing scroll if handler is invalidated
Bug: 153589287
Change-Id: I0282ec82fe4ae1f74a0f4342471ffd53f43095d7
2020-04-21 16:24:47 -05:00
Winson Chung 674e38fdb6 Merge "Disable blurs while in multiwindow mode" into ub-launcher3-rvc-dev 2020-04-21 19:39:17 +00:00
Sunny Goyal f2393f1d20 Adding TaskViewSimulator for simulating taskView layout on a remote target
1. Tanslating contents of RecentsView instead of recentsView itself. When
   translating, we keep the current TaskView from moving. This allows
   the remoteTarget to follow an individual taskView.
2. Removing translationY in recentsView and setting the pivot instead
3. Using TaskViewSimulator for swipe handler. This allows using similar
   animation creation as Launcher window animation.

Change-Id: I0b7b16c367d9d8cd8dd0ed59061e46853e2f8c83
2020-04-21 11:16:21 -07:00
Vinit Nayak 0755ac908c Merge "Rotate overview only if system rotation allowed" into ub-launcher3-rvc-dev 2020-04-21 17:57:00 +00:00
Winson Chung b330d6e6f8 Disable blurs while in multiwindow mode
- With hierarchical animations, the split-secondary shell root
  is moved above the split-primary shell root immediately during
  transitions, which means that setting the blur on the launcher
  surface will also affect the primary docked surface

Bug: 154125518
Change-Id: I21dd01738ee9bc974d41e5964364917a30143a2a
2020-04-21 10:28:43 -07:00
Vinit Nayak 94541b99b9 Rotate overview only if system rotation allowed
Don't rotate overview if all of launcher can
be rotated.

Fixes: 154243745, 154299710
Test: Toggled system rotation while overview
was showing. Also toggled home rotation to
ensure no intermediate overview rotation
animation.

Change-Id: I49acf2dafb84e7f05c46f8908ba9ffdd43f1d1e7
2020-04-20 23:22:47 -07:00
TreeHugger Robot 0f6ecb675e Merge "Removes Sandbox from gesture-excluding activities." into ub-launcher3-rvc-dev 2020-04-21 00:19:46 +00:00
Samuel Fufa 1b3f77724f resolve syntax issue introduced by ag/11174880
Change-Id: I46911fb32384c40dac42459bb391001be8774ae8
2020-04-20 16:56:14 -07:00
TreeHugger Robot fe68150f35 Merge "Predicted icon ring embellishments" into ub-launcher3-rvc-dev 2020-04-20 23:47:11 +00:00
Samuel Fufa 9b7d913901 Predicted icon ring embellishments
Screenshot: https://screenshot.googleplex.com/yFfiDbHiyq6

- Wrap ring around badge
- Add shadow to ring

Bug: 153201272
Bug: 152560070
Test: Manual
Change-Id: Ic1f726d080a8e6768417e5174a855a57f3241166
2020-04-20 16:46:14 -07:00
Andy Wickham 7a478e25a2 Removes Sandbox from gesture-excluding activities.
Not needed now that Sandbox runs in Launcher's process/task.

Change-Id: I9e3e03be89d5305a3a7afe201164512d59aea470
2020-04-20 23:35:13 +00:00
TreeHugger Robot e922b06cf4 Merge "Don't show shelf bounce when there's no shelf in Overview" into ub-launcher3-rvc-dev 2020-04-20 22:30:40 +00:00
Sunny Goyal 34ff8cb3c1 Adding common code for instrumentation and robolectric tests
Change-Id: Ia338f0565868bb174ef5f6721924944792866be6
2020-04-20 14:42:30 -07:00
Winson Chung f66e7c19bd Merge "Dedupe non-perceptable depth updates" into ub-launcher3-rvc-dev 2020-04-20 21:10:20 +00:00
TreeHugger Robot 19b873d0bd Merge "Dump nav mode with TIS" into ub-launcher3-rvc-dev 2020-04-20 21:10:08 +00:00
Tony Wickham 853ac99e47 Don't show shelf bounce when there's no shelf in Overview
Bug: 154513651
Change-Id: Ia31fd46dc174fcb6362b11e5970f92f4acff66ac
2020-04-20 21:05:19 +00:00
TreeHugger Robot f5a10fe9c2 Merge "Update predicted icon outline drawing" into ub-launcher3-rvc-dev 2020-04-20 19:17:49 +00:00
Samuel Fufa 28f1db6dfa Update predicted icon outline drawing
Video: b/153203071#comment2
Bug: 153203071
Test: Manual
Change-Id: I786300f953553c98c63c8b48e40354b1672e930c
2020-04-20 11:27:28 -07:00
Sunny Goyal 01d8541f14 Fixing actions view getting visible sometimes
> Linking actions view to state flags
> Creating multiple visibility channels that can be controlled separately

Bug: 153906903
Change-Id: I33d20f5fdc8bcdf0520dae3aac986548eb7e0058
2020-04-20 09:59:13 -07:00
Vinit Nayak 8699bf5626 Merge "Re-enable home screen rotation" into ub-launcher3-rvc-dev 2020-04-18 05:22:26 +00:00
Winson Chung 20aeddd853 Dedupe non-perceptable depth updates
Bug: 154304487
Change-Id: I6d96aca555932f4a51aed576d25f7150952bb562
2020-04-17 16:16:44 -07:00