Commit Graph

22399 Commits

Author SHA1 Message Date
Sunny Goyal aeec80ddbb Creating default implementation for state lisnter method
> The transition start is used rarely

Change-Id: I0d33f0f6372eb4ef89bfbb66968612693b7c6033
2020-04-24 15:41:29 -07:00
Tracy Zhou 879d3ade68 Merge changes from topic "grid-size-migration" into ub-launcher3-rvc-dev
* changes:
  fix GridBackupTableTest in comply with grid size migration
  Turn on V2 migration algorithm feature flag
2020-04-24 19:26:44 +00:00
TreeHugger Robot acafb3a287 Merge "Detects nav bar gestures to progress through Home tutorial." into ub-launcher3-rvc-dev 2020-04-24 18:58:30 +00:00
Andy Wickham 6b6287f414 Detects nav bar gestures to progress through Home tutorial.
Home gesture also exits Back and Home tutorials on the
completion screens (as does back gesture).

Test: Manually verified Back and Home tutorial flows.
Bug: 148542211
Change-Id: I8026745e875e9ccb8cfd60bc438213b2d896254d
2020-04-24 18:13:05 +00:00
Vinit Nayak 49d3fe598c Merge "Rotate Overview Task Action Menu" into ub-launcher3-rvc-dev 2020-04-24 17:48:01 +00:00
TreeHugger Robot 7e0a1ac606 Merge "Fix AlwaysOnTop stack may covered by RemoteAnimation" into ub-launcher3-rvc-dev 2020-04-24 15:06:28 +00:00
Adam Cohen 59d305fefe Merge "Cleanup reorder animations to not require layout on every frame" into ub-launcher3-rvc-dev 2020-04-24 02:50:23 +00:00
Ming-Shin Lu 4f07525417 Fix AlwaysOnTop stack may covered by RemoteAnimation
Now with hierarachical animation, the layer of
RecentsAnimation / RemoteAnimation are controlled by system.

Now Launcher side don't need to have other way to set layer for ZBoost
case, so remove setLayer & withLayer related logics for cleaning up.

Fix: 151024899
Test: manual, launch google map app -> enter PiP mode,
      swipe up to overview screen or launch activity from shortcut,
      make sure the PiP window is not covered by other apps.

Change-Id: I8028cd50d66f7d77e5d1ec6514e953c8be9935d6
(cherry picked from commit 99f7da7dd2)
2020-04-24 02:18:16 +00:00
Adam Cohen 1d13c0bf13 Cleanup reorder animations to not require layout on every frame
=> Extending on previous CL to separate multiple translation properties
   and avoiding expensive layout pass

Test: manual

Change-Id: I058da7367fb320b9f432bef9482be2966d3a7d42
2020-04-24 01:28:39 +00:00
Tracy Zhou f4e5a1a119 Merge "Special handling when a db for one grid option is not setup yet" into ub-launcher3-rvc-dev 2020-04-23 17:47:29 +00:00
vadimt 0703464556 Checking that there are no more than 2 live activities at any moment
This is tightening the makeshift strictmode criteria.

Starting with this moment, we will know that there is
no memory growth during tests execution, which is a big deal.

Big: 139137636

Change-Id: I5edc84524463bd1736d727496ad0fc031bb9624c
2020-04-23 16:35:09 +00:00
Pinyao Ting 26c4e23e9a fix GridBackupTableTest in comply with grid size migration
Bug: 154166808
Test: GridBackupTableTest
Change-Id: I7af35ceed7edb77ac0d9c443d7eccbcef19ae476
2020-04-23 09:18:46 -07:00
Tracy Zhou 219426f870 Turn on V2 migration algorithm feature flag
This flag is behind grid options master flag, so it won't go to all dogfood users yet.
I will turn on grid options flag after enough bug bash, hopefully at the end of this week.

Bug: 154154093
Test: N/A
Change-Id: I608af1cd3c5613f7cc33a940a145309ac90a6c00
2020-04-23 09:18:46 -07:00
TreeHugger Robot d73d39b45a Merge "Makeshift analog of Strictmode leak detector" into ub-launcher3-rvc-dev 2020-04-23 03:22:31 +00:00
vadimt b3e8ae8230 Makeshift analog of Strictmode leak detector
Strictmode leak detector is still a goal, but we might not be able to
achieve it in R. Strictmode has several framework-side bugs that perhaps
hide Launcher-side strictmode violations, while the time to fix
everything is limited, and new leaks get introduced all the time.

For now, implementing a check that is slightly more relaxed than
Strictmode, but still ensures the absence of leaks. I’ll keep
eliminating Strictmode violations as well as keep strengthening the
makeshift checker conditions until we’ll be able to enable Strictmode in
continuous testing.

I’m disabling Strictmode checks for now so that they don’t generate
unnecessary hprof dumps, but leaving the code dealing with strictmode.

Bug: 139137636
Change-Id: Ib10136b0d4e9892f70a19cd052ae5a54cf0a4efb
2020-04-22 19:00:12 -07:00
TreeHugger Robot 8d5a000071 Merge "Always return RecentsView to translation 0 on drag end" into ub-launcher3-rvc-dev 2020-04-23 01:25:06 +00:00
Tracy Zhou ed5f3082b0 Special handling when a db for one grid option is not setup yet
- Init KEY_MIGRATION_SRC_WORKSPACE_SIZE and KEY_MIGRATION_SRC_HOTSEAT_COUNT
- Load default workspace only when default db is created, not when peeking into dbs of other grid options during grid preview / migration

Fixes: 154184711
Test: run grid preview and migration right after a cleared cache Pixel Launcher
Change-Id: I86c7072b8c4a9da76e289c55ab440071f192fc38
2020-04-22 18:13:42 -07:00
TreeHugger Robot 1bb37acb5d Merge "Don't allow swiping from overview to all apps in 3 button mode" into ub-launcher3-rvc-dev 2020-04-23 00:04:35 +00:00
Tony Wickham 6a6301c569 Always return RecentsView to translation 0 on drag end
After reaching overview, we let the user translate RecentsView
if they continue dragging around. But when they let go, we need
to return RecentsView to translation 0 since that's no longer
part of the state machine.

Change-Id: I30b51485339a3b6c3dd52bda113b1a05b6e885fa
2020-04-22 18:42:40 -05:00
TreeHugger Robot cea3ed48e5 Merge "Stop computing scroll if handler is invalidated" into ub-launcher3-rvc-dev 2020-04-22 23:39:11 +00:00
TreeHugger Robot 2309597c9a Merge "[Overview Actions] Update the navigation mode immediately when switch." into ub-launcher3-rvc-dev 2020-04-22 23:34:00 +00:00
Tony Wickham 22757e840c Don't allow swiping from overview to all apps in 3 button mode
Bug: 154761926
Change-Id: I155faec27f3b96e2f11aaec318d6846a893885e6
2020-04-22 23:13:48 +00:00
Becky Qiu 72c53af896 [Overview Actions] Update the navigation mode immediately when switch.
This would fix the issue that overview actions UI visibility was not set correctly.

Test: local
Bug: 152047880
Change-Id: Ia335c5c8947b39e580403090f461f87e78645af1
2020-04-22 15:57:34 -07:00
TreeHugger Robot 3e60577fa1 Merge "Fixing recentsView getting translated in NavBarToHomeTouchController" into ub-launcher3-rvc-dev 2020-04-22 22:42:46 +00:00
Hyunyoung Song 16a626cc1a Merge "Updates folder creation logging." into ub-launcher3-rvc-dev 2020-04-22 22:05:19 +00:00
TreeHugger Robot b615875716 Merge "Removing tracing for a fixed bug" into ub-launcher3-rvc-dev 2020-04-22 21:51:42 +00:00
TreeHugger Robot 65a0cc72ae Merge "Assistive chip: Adjusting chip UI" into ub-launcher3-rvc-dev 2020-04-22 21:50:02 +00:00
Sunny Goyal de4815bdad Fixing recentsView getting translated in NavBarToHomeTouchController
Bug: 154657409
Change-Id: I4d7f3cac52b563370d612dd29d5e7322645b5cbe
2020-04-22 14:23:55 -07:00
Vinit Nayak e553e380d0 Rotate Overview Task Action Menu
Fixes: 153371258
Test: Tap on icon in portrait,
landscape and seascape. Open menu
then rotate phone.

Change-Id: I38b018371561b502fe211a3c2ddea4ff7fde4274
2020-04-22 14:16:05 -07:00
TreeHugger Robot cf3bed973c Merge "Fixing animation player not overshooting spring animation; tuning springs" into ub-launcher3-rvc-dev 2020-04-22 20:52:35 +00:00
Sreyas 71a091fe8a Assistive chip: Adjusting chip UI
Change-Id: I2970107f4324a5f01e0df4a6adf21875412582c6
2020-04-22 13:33:36 -07:00
vadimt 99939d3b0d Removing tracing for a fixed bug
Bug: 139891609
Change-Id: Ic7c988f06022b82685a3216154a47783ef2ec98b
2020-04-22 13:32:03 -07:00
Sunny Goyal 7f9e8e2d27 Fixing animation player not overshooting spring animation; tuning springs
=> setCurrentPlayTime is bounded between [0, duration] by the animation framework
Instead using interpolator so that we can go outside the bounds

=> Tune spring stiffness and dampening for overview card dismiss animations

Bug: 154061408
Change-Id: Iaa31491fff499db916b36d9779ec159b8a89a2de
2020-04-22 12:54:31 -07:00
TreeHugger Robot 6db6a59f86 Merge "Moving various orientation related config in RecentsOrientaedState" into ub-launcher3-rvc-dev 2020-04-22 19:19:34 +00:00
TreeHugger Robot cee56f039e Merge "Adding common code for instrumentation and robolectric tests" into ub-launcher3-rvc-dev 2020-04-22 17:49:22 +00:00
Sunny Goyal b7833f8193 Moving various orientation related config in RecentsOrientaedState
> Fixing RecentsOrientationState values for fallback recents
> Using proper rotation in task simulator

Change-Id: I770e7c8850e469f5dc0ce6f89889672f2decdc0d
2020-04-22 10:49:02 -07:00
thiruram f065fdf311 Updates folder creation logging.
After ag/11020901, folder creation process will not open gboard and hence drag and drop events resulting in folder creation should send additional folder creation event.

Fixes NPE with ItemInfo.java.

Bug: 153768241

Change-Id: I52c996a62dee52bf07feef4252aadc2a28c79752
(cherry picked from commit 9a3671e80e)
2020-04-22 17:36:07 +00:00
Sunny Goyal d8cec211a2 Merge "Fixing SecondaryDisplay Launcher" into ub-launcher3-rvc-dev 2020-04-22 17:13:54 +00:00
TreeHugger Robot 8eddd129b3 Merge "add CHAR LIMIT for home settings menu" into ub-launcher3-rvc-dev 2020-04-22 07:10:23 +00:00
TreeHugger Robot 220a9b461d Merge "Update shortcut icons according to new accessibility standards" into ub-launcher3-rvc-dev 2020-04-22 06:42:34 +00:00
Sunny Goyal 0e7a338e8b Fixing SecondaryDisplay Launcher
> All apps layout broken in landscpae UI
> Crash when manager profile is added
> Wrong icon size on low resolution

Change-Id: If01dacf9f62a0384ebd8b31b62500178416d3ab4
2020-04-21 23:19:11 -07:00
Samuel Fufa 39e7c25b92 add CHAR LIMIT for home settings menu
Bug: 153972057
Change-Id: Ic6d9104a8b27bcdcc7fe6440b7d26d0baf0f473c
2020-04-21 22:52:12 -07:00
Jonathan Miranda 8451542a25 Merge "Ensures that the swipe up to home animation is ended prior to view recycling." into ub-launcher3-rvc-dev 2020-04-22 05:31:37 +00:00
Samuel Fufa 07919c63f2 Update shortcut icons according to new accessibility standards
Bug: 152273720
Bug: 152272310
Test: Manual
Change-Id: If9e1c30a27046674cae4189a7cfc6bcfc2e288e9
2020-04-21 21:03:37 -07:00
TreeHugger Robot 585628e270 Merge "Fixing activity leak via ActivityInitListener" into ub-launcher3-rvc-dev 2020-04-22 03:07:01 +00:00
TreeHugger Robot 947905d28b Merge "Fixing crash when emptyView gets added twice" into ub-launcher3-rvc-dev 2020-04-22 00:30:43 +00:00
TreeHugger Robot af560750d0 Merge "Make all apps scrim solid color" into ub-launcher3-rvc-dev 2020-04-21 23:12:39 +00:00
vadimt 5a804dcbaf Fixing activity leak via ActivityInitListener
Bug: 139137636
Change-Id: I49ac81dfc69f63211d832bf558517c534f51eab8
2020-04-21 15:35:23 -07:00
Jon Miranda d08f8ac409 Ensures that the swipe up to home animation is ended prior to view recycling.
Bug: 154163960
Change-Id: I70b2c6290a2a17be8b80ba0209528173d6627332
2020-04-21 15:12:40 -07:00
Tony Wickham 9df3f0cebf Stop computing scroll if handler is invalidated
Bug: 153589287
Change-Id: I0282ec82fe4ae1f74a0f4342471ffd53f43095d7
2020-04-21 16:24:47 -05:00