Commit Graph

79553 Commits

Author SHA1 Message Date
Wen-chien Wang ad0b62daad Merge "pin-shortcut: Add pin shortcut to the context menu" into main 2024-12-13 17:00:42 -08:00
Wen-Chien Wang 2badfc7ebc pin-shortcut: Add pin shortcut to the context menu
This cl adds the pin shortcut option to the context menu, where
it works on Home launcher, hotseat, and pinned apps on the
taskbar.
Currently the option is a no-op.

Bug: 375648361
Test: Manual. Recording uploaded to buganizer
Flag: com.android.launcher3.enable_pinning_app_with_context_menu
Change-Id: I5d1284a6e909fd75f14e81c3ae713da3cdc01ce3
2024-12-13 22:49:52 +00:00
Treehugger Robot 5849df4002 Merge "[-1] Fix flicker of -1 when swipe up to exit -1 isn't fast enough" into main 2024-12-13 14:02:46 -08:00
Fengjiang Li b8b16bd288 [-1] Fix flicker of -1 when swipe up to exit -1 isn't fast enough
Fix: 381017761
Flag: NONE - released code
Test: manual - record a video
Change-Id: I5bda4a234cdcc8227d4feb9a92a174d07e46f7a2
2024-12-13 12:11:41 -08:00
Treehugger Robot 9b6c58e6a9 Merge "Do not rely on getTaskViewCount to iterate TaskViews" into main 2024-12-13 11:59:41 -08:00
Sebastián Franco 6f3213b260 Merge "Prevent Hotseat jank when switching Fixed Landscape setting" into main 2024-12-13 11:51:46 -08:00
Stefan Andonian 4e3d6a5d6e Merge "Log.wtf if DeleteDropTarget "canRemove", but doesn't remove item from the database." into main 2024-12-13 11:33:34 -08:00
Sebastian Franco f2b9190c64 Adding logs to see what is triggering rotation changes
Bug: 380940677
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: I393232b410a4b961d3cbdd39766a403f994610e7
2024-12-13 11:08:43 -08:00
Sebastián Franco 24e9e55bca Merge "Setting mIsFixedLandscape as the first if condition while fixing 380940677" into main 2024-12-13 11:08:09 -08:00
minch 8cf0df7f96 Do not rely on getTaskViewCount to iterate TaskViews
Using `getChildCount` to iterate TaskViews instead of
`getTaskViewCount` when indices are used. As it is not safe to assume
the TaskView starts from index 0.

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Manual
Change-Id: I599b5117f0848e429ebf83fc4b85451e52b4bcab
2024-12-13 10:12:34 -08:00
Treehugger Robot 4d295d0867 Merge "Migrate to TaskViewsIterable & TaskViewsIterator - [2/n]" into main 2024-12-13 09:49:39 -08:00
Charlie Anderson 9a2e3a715b Merge "Add new failsafe to disable new archiving broadcast" into main 2024-12-13 07:33:49 -08:00
Charlie Anderson e18eac02b9 Merge "Fix user for InstallSessionHelperTest HSUM failures" into main 2024-12-13 07:31:23 -08:00
Schneider Victor-tulias 0b9deb2d0d Merge "Update ProtoLogProxy classes to only log to protolog when protolog has been initialized" into main 2024-12-13 06:43:57 -08:00
Treehugger Robot f340be6e4f Merge "Replacing all int lookup flags and boolean overrides with an object to make it easier to extend options" into main 2024-12-13 06:20:44 -08:00
Alex Chau fa39d7478d Merge "Pass RecentsView reference to RecentsViewUtils to simplify code" into main 2024-12-13 06:12:31 -08:00
Johannes Gallmann b5d923f17a Merge "Add depth animation to predictive back to home" into main 2024-12-13 05:43:35 -08:00
Artsiom Mitrokhin 4c7663768d Merge "Add haptics for opening taskbar pinning popup view from anywhere" into main 2024-12-13 05:34:00 -08:00
Alex Chau ec1883b261 Pass RecentsView reference to RecentsViewUtils to simplify code
- RecentsViewUtils is owned by RecentsView, it's safe to have an instance of RecentsView to simplify a lot of call sites

Fix: 383999010
Test: presubmit
Flag: EXEMPT refactor
Change-Id: I69f991ea137b30e0297df825b78ad431f6388af8
2024-12-13 12:21:47 +00:00
Johannes Gallmann 998e11e0a5 Add depth animation to predictive back to home
Setting the depth when predictive back to home is started. This will be animated to NORMAL state by ScalingWorkspaceRevealAnim on back gesture commit.

Bug: 382453424
Flag: com.android.launcher3.predictive_back_to_home_polish
Test: Manual, i.e. testing predictive back-to-home animation on device
Change-Id: Id33f49d78aae268b7d89035cce58065f6a60a8bf
2024-12-13 11:44:06 +00:00
Johannes Gallmann 9b524b0f60 Merge "Play workspace reveal animation for predictive back-to-home" into main 2024-12-13 02:10:17 -08:00
Sihua Ma 48db4ef770 Move model tests to multivalent
Test: atest NexusLauncherRoboTests
Test: SysUI studio
Flag: EXEMPT test only
Change-Id: I751c449561175d3c7c5a770b7b30bc4f24c1cd44
2024-12-13 05:51:51 +00:00
Sunny Goyal 18e480838a Replacing all int lookup flags and boolean overrides with an object to make it easier to extend options
Bug: 381897614
Bug: 366237794
Flag: EXEMPT refactor
Test: atest CacheLookupFlagTest
Change-Id: Ic89d48dd1c5dc8b0a89b1898cd7b00d9c61d6513
2024-12-12 18:32:55 -08:00
Sebastian Franco dabf02fd86 Prevent Hotseat jank when switching Fixed Landscape setting
Fix: 380998389
Test: HomeScreenImageTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: I6e7334b9f5b3d6abab57d461987db64fe3700ac4
2024-12-12 17:32:11 -08:00
Stefan Andonian b64026135f Log.wtf if DeleteDropTarget "canRemove", but doesn't remove item from the database.
Bug: 379606516
Test: Verified locally that these logs show when hard-coded to appear. Also verified that normal usage doesn't cause crashes.
Flag: EXEMPT bug logs
Change-Id: Iadc67f4a063f5924c758468c6b227b23368fc192
2024-12-13 00:41:06 +00:00
Liran Binyamin 0f0394c597 Merge "Fix bubble bar visibility issue" into main 2024-12-12 15:36:42 -08:00
Liran Binyamin 138dd0bc5f Fix bubble bar visibility issue
Update the bubble bar visibility for the initial bubble if the animation
is suppressed, e.g. if we're creating the bubble when the shade is open.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 382693837
Test: manual
       - enable bubbles
       - remove all conversations from the list of allowed to bubble
       - create notification
       - open shade and click on the bubble button to bubble the notification
       - observe bubble bar becomes visible

Change-Id: If771c28998b2b091f4f1ab38001e9485ed1ed849
2024-12-12 15:36:29 -08:00
Sunny Goyal daf46a09b2 Merge "Moving WMProxy to dagger" into main 2024-12-12 15:27:19 -08:00
Schneider Victor-Tulias 7fb1d6d53b Update ProtoLogProxy classes to only log to protolog when protolog has been initialized
Flag: com.android.launcher3.enable_active_gesture_proto_log
Flag: com.android.launcher3.enable_recents_window_proto_log
Flag: com.android.launcher3.enable_state_manager_proto_log
Fixes: 381846204
Test: ran launcher and checked logs
Change-Id: I807326bd6c65b8e51f5302ba58eed841c23216f6
2024-12-12 15:03:56 -05:00
Brandon Dayauon 1d1bffbf0b Merge "Fix unintended scroll in all apps when using external mouse." into main 2024-12-12 11:37:31 -08:00
minch b344bc1fb6 Migrate to TaskViewsIterable & TaskViewsIterator - [2/n]
Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Manual
Change-Id: I9bd1bad7a9eb8a3cc8333f37e3b535975a5ce0b6
2024-12-12 11:29:48 -08:00
Ats Jenk 49319240dd Merge "Handle suppressed bubbles" into main 2024-12-12 10:12:45 -08:00
Johannes Gallmann c8fd3f23fe Play workspace reveal animation for predictive back-to-home
Bug: 382453424
Test: Manual, i.e. tested back-to-home and back-to-allapps animation on phones, tablets and foldables, including interruptions.
Flag: com.android.launcher3.predictive_back_to_home_polish
Change-Id: I092a74ab2340828e18067ca15c7019c44d30f40b
2024-12-12 14:18:03 +00:00
Alex Chau 179403d37d Add new Overview team members to OWNERS
Flag: EXEMPT only changing OWNERS
Change-Id: I6aab76500637404a7eb97924c4ef5743342b4a95
2024-12-12 05:55:52 -08:00
Alex Chau 74ff7af5e2 Merge "Migrating the remaining getTaskViewAt(0)" into main 2024-12-12 04:01:59 -08:00
Alex Chau f3013954a3 Merge "Introduce hasTaskViews() to RecentsView" into main 2024-12-12 04:01:07 -08:00
Treehugger Robot 41d5494a4e Merge "Fix for split animation" into main 2024-12-12 01:55:55 -08:00
Charlie Anderson cdd763d466 Fix user for InstallSessionHelperTest HSUM failures
Bug: 383452367
Test: InstallSessionHelperTest
Flag: EXEMPT test fix
Change-Id: I942c6c78e5986a960859e5c6b1458a46ec6a2bd6
2024-12-11 19:12:43 -08:00
Treehugger Robot 24218845df Merge "Introduce TaskViewsIterator and TaskViewsIterable" into main 2024-12-11 17:53:47 -08:00
Brandon Dayauon 1fb2d7815f Fix unintended scroll in all apps when using external mouse.
The reason is because when ag/29152694 was introduced, the accessibilityEvent that would
trigger is TYPE_VIEW_HOVER_ENTER that would eventually always have the list scrolling depending
on where the mouse would be. Gating it to TYPE_VIEW_ACCESSIBILITY_FOCUSED would be fix this as
this should still work for talkback when traversing the A-Z list as TYPE_VIEW_ACCESSIBILITY_FOCUSED is whats is always used
during this case.

bug: 372965379
Test: manually
Flag: EXEMPT bug fix
Change-Id: I249cee8036216f93aab53efc3d77fad047f7e408
2024-12-11 16:53:16 -08:00
Ats Jenk bcc12470b7 Handle suppressed bubbles
Hide or show bubble based on suppression signals from shell.
If this is the only bubble, hides or shows the bubble bar.

Bug: 273316505
Test: have a single bubble in the bubble bar, suppress the bubble,
  observe that bubble is hidden and bubble bar is not shown,
  unsuppress the bubble, check that bubble bar and bubble is shown
  again, perform check with transient and persistent taskbar
Test: have multiple bubbles, suppress one bubble, check that this bubble
  is not shown, but the bubble bar remains visible with other bubbles,
  perform the check with transient and persistent taskbar
Test: have a single bubble in bubble bar that is suppressed, receive
  notifications to trigger new bubbles, observe bubble bar is shown for
  new bubbles, check that after unsuppressing bubble, it is added back,
  perform the checks with tranient and persistent taskbar
Test: suppress a bubble and rotate the device to trigger launcher
  recreation, check that after unsuppress, the bubble is added back

Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I17e5cec750a2666feecc62213a3e8fc204ee510a
2024-12-11 16:02:32 -08:00
Charlie Anderson 2885a6639c Add new failsafe to disable new archiving broadcast
Bug: 322314760
Test: presubmit and LoaderTaskTest
Flag: com.android.launcher3.enable_first_screen_broadcast_archiving_extras

Change-Id: I7c7b94a81dd717ed6f32de2ae986616b93dbbcc0
2024-12-11 18:59:05 -05:00
minch c7a66bd4af Migrating the remaining getTaskViewAt(0)
Migrating the remaining `getTaskViewAt(0)` to `getFirstTaskView()`.

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Manual
Change-Id: I083626b0ca62b88d06f508dfc15d9f64112f1a6a
2024-12-11 23:50:53 +00:00
minch 3695c7a64c Introduce hasTaskViews() to RecentsView
- This function is going to replace all the call sites that compares
  `getTaskVieCount()` and `0`.
- This is based on the fact that this count can not be a negative
  number.
- Introduce `getLastTaskView()` to get the last TaskView inside the
  RecentsView.

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Manual
Change-Id: Iefb107d1aba61549a870f14c18e025c34b19a1b5
2024-12-11 23:44:16 +00:00
Bill Yi 8da7f25ccb Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-12-11 14:44:09 -08:00
Bill Yi ec65d8e153 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-12-11 14:44:09 -08:00
Bill Yi ab76a45616 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-12-11 14:44:09 -08:00
minch 37ed08215d Introduce TaskViewsIterator and TaskViewsIterable
- Create TaskViewsIterator to iterate all the current TaskViews inside
  RecentsView.
- Create TaskViewsIterable with TaskViewsIterator as its iterator.
- Create `mTaskViewsIterable`, an instance of TaskViewsIterable that
  used to make the TaskViews iterable.
- Current `getTaskViews()` return `mTaskViewsIterable` directly.
- Change `getTaskViews()` to be a public function, thus it can be
  used outside of the RecentsView.

Some follow-up work includes:
- Replace all the call sites of `getTaskViewAt(0)` with
  `getFirstTaskView()`
- Replace `0` as the index of the first TaskView  with
  `getFirstTaskViewIndex()`
- Audit all the call sites of iterating the TaskViews, let them use
  `getTaskViews()` or IterableTaskViews.iterator() if index is needed.

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Ensure the TaskViews required are correct in the following
      scrnarios:
      1. Swiping up from home screen to enter overview with empty or
         multiple tasks
      2. Swiping up from a fullscreen app to enter overview with
         one or multiple tasks
      3. Dimissing one or multiple tasks, exit and enter overview w/o
         newly opened tasks
      4. Remvoing all the tasks, reenter overview w/o newly opened
         tasks
Change-Id: I930ce92b7e0bc37005af74a58fd4c0ce3013e5cb
2024-12-11 21:48:34 +00:00
Treehugger Robot 5a5cf9e698 Merge "Fixing nullpointer error in genering error description" into main 2024-12-11 13:37:05 -08:00
Sunny Goyal 41e8057bbf Moving WMProxy to dagger
Bug: 361850561
Flag: EXEMPT dagger migration
Test: Presubmit
Change-Id: I9a8031037f2167658b7bc212b59c9b11abbf2f03
2024-12-11 13:24:26 -08:00