Commit Graph

47042 Commits

Author SHA1 Message Date
Sebastián Franco abd6fb7e4b Merge "Give the tests the ability to emulate other devices screens" into tm-dev am: 84051cd8bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17413625

Change-Id: I984d4e2473dee24c60f0e158ed8c8dede70a1f89
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 17:52:54 +00:00
Sebastián Franco 84051cd8bf Merge "Give the tests the ability to emulate other devices screens" into tm-dev 2022-04-27 17:25:55 +00:00
TreeHugger Robot 6d7db81e74 Merge "Remove unnecessary updatePivots" into tm-dev am: e19522bede
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17983443

Change-Id: I03703262518cf2fd060bf4d3b0a89337e9a92b8a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 16:43:22 +00:00
TreeHugger Robot d72c4cb6e5 Merge "Move spring loaded scale calculation to DeviceProfile." into tm-dev am: 84bff57d8d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17909525

Change-Id: I1b226804f91518e1a456cd07c98043706d765985
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 16:43:15 +00:00
TreeHugger Robot e19522bede Merge "Remove unnecessary updatePivots" into tm-dev 2022-04-27 14:49:12 +00:00
TreeHugger Robot 84bff57d8d Merge "Move spring loaded scale calculation to DeviceProfile." into tm-dev 2022-04-27 13:51:59 +00:00
Alex Chau 2a6e364e91 Remove unnecessary updatePivots
- Follow-up of http://ag/17888303 to remove extra code that didn't get clean up

Bug: 209981696
Test: manual
Change-Id: I37f68dd52adacfd033eaeaeca52c98a4a06d556d
2022-04-27 13:57:39 +01:00
András Klöczl d76d384c36 Merge "Change home dragging logic for dead zones" into tm-dev am: 143b71203f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17217228

Change-Id: Ifeadfc3720befd28a17394ae71e9fa586834c732
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 12:47:26 +00:00
Alex Chau c7fee694e7 Merge "Update overview actions alignment" into tm-dev am: a80efcee9f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17888303

Change-Id: Ie7496af60cde34345324140511a7b2f7b255f10f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 12:47:17 +00:00
András Klöczl 143b71203f Merge "Change home dragging logic for dead zones" into tm-dev 2022-04-27 12:44:34 +00:00
Alex Chau a80efcee9f Merge "Update overview actions alignment" into tm-dev 2022-04-27 12:24:24 +00:00
Sunny Goyal f3ea842d7c Revert^2 "Removing some unused code from All-Apps" am: 52f4c16a94
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17923858

Change-Id: Ie929b8153ee8bc60442192319f3212641bb13ad2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 06:36:42 +00:00
Jerry Chang 448ae578f9 Merge "Fix divider bar won't fade-in as the other splitting tasks" into tm-dev am: 59939e9e94
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17935107

Change-Id: I523efffd571c815efe94836f3560d3b1c60788b7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 03:50:22 +00:00
Sunny Goyal 52f4c16a94 Revert^2 "Removing some unused code from All-Apps"
13ae6784b5

Change-Id: I06a4c9cc6beba4fc87b4a9375872c68e71e1c5f6
2022-04-27 03:22:58 +00:00
Jerry Chang 59939e9e94 Merge "Fix divider bar won't fade-in as the other splitting tasks" into tm-dev 2022-04-27 03:02:57 +00:00
Bill Yi 87028ebc39 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 5f02b2d52c -s ours am: a2d3bbe27e -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17937863

Change-Id: I1fb21e9b613ce68b08e6466deb833bb23c377e46
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 23:10:41 +00:00
Bill Yi a2d3bbe27e [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 5f02b2d52c -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17937863

Change-Id: Ibef2d2371414b7d35b903df4892506dca573cc85
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 23:01:53 +00:00
Tracy Zhou 7148e74f1e Merge "Add originalView of the menu to SystemShortcut" into tm-dev am: 7183e4b460
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17677218

Change-Id: Ic6378b71451cafcf02ece812c93a240123cd2c03
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 17:53:25 +00:00
Tracy Zhou 7183e4b460 Merge "Add originalView of the menu to SystemShortcut" into tm-dev 2022-04-26 17:28:40 +00:00
TreeHugger Robot 14615df286 Merge "Refactors Search results into separate RV for Toast." into tm-dev am: 0a6e9b4751
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17699868

Change-Id: I86545cb56dac22db803cacfdc893f82efcecefd5
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 15:36:46 +00:00
Andras Kloczl 0056e95d8e Change home dragging logic for dead zones
- If a dragged item is not over a valid drop target
then we don't highlight anything and on drop we move
it back to its original position.
- Instead of checking if the dragged item is over the
hotseat view, now we check if the item is over the hotseat
shortcuts.
- Smartspace is a dead zone

Test: drag items from different workspaces, allapps, widget
  picker etc. to all parts of the screen and verify which
  view is targeted and where the item gets dropped.
  Check on phone/foldable/tablet.
Bug: 228201267
Change-Id: I18de576ea300d58ae645e511b238e0b946b5595a
2022-04-26 16:28:11 +01:00
TreeHugger Robot 0a6e9b4751 Merge "Refactors Search results into separate RV for Toast." into tm-dev 2022-04-26 15:06:49 +00:00
Pablo Gamito 4a8d162888 Merge "Use shared background color animation for settings activity" into tm-dev am: 7379074007
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17875203

Change-Id: I8c53fb1f523bab006a4a70870c81d9e47995804f
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-25 21:44:14 +00:00
Pablo Gamito 7379074007 Merge "Use shared background color animation for settings activity" into tm-dev 2022-04-25 21:22:21 +00:00
Alex Chau a2fc764405 Update overview actions alignment
- Align overview actions to the top with a defined margin below task thumbnail, except for vertical bar layout
- In modal state, use task view's bottom as pivot, and expand using all the space about pivot
- Simplified overview actions margin calculation and moved some logic to DeviceProfile

Bug: 209981696
Test: manual on various devices
Change-Id: I4c96cb02c6f3d6adf30633ddeb883bc4eec16f36
2022-04-25 19:20:21 +01:00
Pat Manning a2e1499a2f Move spring loaded scale calculation to DeviceProfile.
Fix: 229838395
Test: manual
Change-Id: I6dbbc850e88aaacceb1363e342404b06104f8c10
2022-04-25 18:58:09 +01:00
Sebastian Franco 00aff95ac0 Give the tests the ability to emulate other devices screens
This code contains utility clases that can change the display
of a device and make it look like another device.
The function DisplayEmulator#emulate receives a DeviceEmulationData
a certain grid to emulate and a callback, everyting that happens
inside of the callback will happen when the device is being emulated
and can be used by other tests.

Example test:
package com.android.launcher3.deviceemulator;
import androidx.test.ext.junit.runners.AndroidJUnit4;
import androidx.test.filters.MediumTest;
import com.android.launcher3.deviceemulator.models.DeviceEmulationData;
import com.android.launcher3.ui.AbstractLauncherUiTest;
import org.junit.Test;
import org.junit.runner.RunWith;
import java.util.concurrent.TimeUnit;

@MediumTest
@RunWith(AndroidJUnit4.class)
public class TestTest extends AbstractLauncherUiTest {
    @Test
    public void testEmulation() throws Exception {
        String deviceCode = "pixel6pro";
        DeviceEmulationData deviceData = DeviceEmulationData.getDevice(deviceCode);
        String grid = "normal";
        DisplayEmulator displayEmulator = new DisplayEmulator(mTargetContext);

        displayEmulator.emulate(deviceData, grid, () ->{
            TimeUnit.SECONDS.sleep(10);
            return true;
        });
    }
}

Test: You could use the test above to make your device look like a
Pixel6 pro for 10 secons.
Fix: 229028257

Change-Id: Icd79be405a2e14dda0bc5f555b0e46149e16f912
2022-04-25 11:57:58 -05:00
Jerry Chang c3865b86e4 Fix divider bar won't fade-in as the other splitting tasks
Bug: 226271407
Test: manual check the divider bar fade-in animation after launchTasks
Change-Id: I5ea7c6ea5ac3f3550b28e9c0f854e70edcfc97b0
2022-04-25 15:41:28 +00:00
Bill Yi 5f02b2d52c Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ibf24622e458e5b2029a3cb0486f51cefa16372d2
2022-04-25 02:43:37 +00:00
Andy Wickham 73dfd548ca Merge "Adds Search Onboarding count and renames existing edu pref." into tm-dev am: 833b0a0b5b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17876281

Change-Id: I58f6fbef62ad446c4c0e9f0d923dc15f3a125b87
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-25 00:51:38 +00:00
Andy Wickham 6729f0b950 Refactors Search results into separate RV for Toast.
This will help enable transitions between A-Z apps lists and
search results because both can be seen simultaneously and
manipulated independently.

Some high level items of the refactor:
 - SearchRecyclerView is added; logic that populated the main
   (personal) tab with search results was simply redirected to
   this RV instead.
 - BaseAllAppsContainerView added isSearching() method. Returns
   false, and ActivityAllAppsContainerView overrides (as search
   is handled there).
 - Renamed BaseRecyclerView to FastScrollRecyclerView to better
   describe what it does. SearchRecyclerView extends this, but
   returns false for supportsFastScrolling().
 - AlphabeticalAppsList#mAllAppsStore is now optional, so the
   Search RV doesn't need to store/listen to apps. Note this
   doesn't affect the predicted app row which is still updated
   if one of the predicted apps is uninstalled (I tested this).

Future work:
 - Determine why dispatchRestoreInstanceState is not called for
   BaseAllAppsContainerView. Save is called, e.g. on rotation.
   Effect of restore not called: rotating while searching goes
   back to A-Z list.
 - Keep suggested apps in Header while searching. Currently they
   are rendered in the SearchRV above search results, as before.
 - Potentially extract Personal/Work tabs to move independently of
   header.
 - AlphabeticalAppsList is a misleading name because it can also
   contains search results. However, things are pretty intertwined
   between that and BaseAllAppsAdapter (effectively a circular
   dependency), so I figured cleaning all that up was out of the
   immediate scope of this refactor, which is mainly meant to
   unblock transition work.

Bug: 206905515
Test: Manually checked for regressions, ran tests.
Change-Id: I4d3757c8a8f9b774956ca6be541dd4fcdad1de13
2022-04-24 17:36:48 -07:00
Andy Wickham 833b0a0b5b Merge "Adds Search Onboarding count and renames existing edu pref." into tm-dev 2022-04-25 00:26:51 +00:00
TreeHugger Robot 9c3bd94b48 Merge "Provide more accurate feedback on nav bar region gestures during the back gesture tutorial." into tm-dev am: 1582aafbc0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921423

Change-Id: I3083e1b4d5e9556b0152b8229658575e403ca76a
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-23 03:24:58 +00:00
TreeHugger Robot 1582aafbc0 Merge "Provide more accurate feedback on nav bar region gestures during the back gesture tutorial." into tm-dev 2022-04-23 02:51:20 +00:00
Tony Wickham cc10db044f Defer onIsStashedChanged() until all controllers are initialized am: aed0c4d73e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921731

Change-Id: Id798f042e7cc39d76fb3e4ce8c7ffbf2a54184fd
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-23 01:18:24 +00:00
Tony Wickham aed0c4d73e Defer onIsStashedChanged() until all controllers are initialized
Test: N/A
Fixes: 230133882
Change-Id: I27df993a08327d28669963e3cecfaa133daf11c9
2022-04-22 17:28:35 -07:00
Schneider Victor-tulias 04169cd3fc Provide more accurate feedback on nav bar region gestures during the back gesture tutorial.
Test: manual
Fixes: 221192860
Change-Id: Id9f912e7db2d89fc948566f5cd16f4b641cdfa31
2022-04-22 16:37:49 -07:00
Tony Wickham 9de10ff889 Merge "Address a couple small followups for TaskbarInsetsController" into tm-dev am: 357c622572
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17873349

Change-Id: I6c01f58f282234ce2e85a582a25a442ba7c7d9d2
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 23:19:24 +00:00
Tony Wickham 357c622572 Merge "Address a couple small followups for TaskbarInsetsController" into tm-dev 2022-04-22 22:55:10 +00:00
Santiago Etchebehere 78194ca6ad Merge "Revert "Use new onStartSplitLegacy when starting split from overview"" into tm-dev am: 8340cb6d7d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17918609

Change-Id: I7e56d7a2f10052f9cb0a3ef6e83e33aa4024f493
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 21:11:04 +00:00
Santiago Etchebehere 8340cb6d7d Merge "Revert "Use new onStartSplitLegacy when starting split from overview"" into tm-dev 2022-04-22 21:07:18 +00:00
Sunny Goyal d99aee90ef Merge "Removing fade in logic during load." into tm-dev am: 84151d2bca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17768817

Change-Id: Id8a4e2f0a5b45267b8386f22b15639f232e93460
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 21:03:22 +00:00
Santiago Etchebehere b8ad6e08cf Revert "Use new onStartSplitLegacy when starting split from overview"
Revert submission 17779173-startSplitLegacy

Reason for revert: Broken build: b/230129218
Reverted Changes:
I01590e53c:Remove check for preventing re-parenting non-split...
I696749f76:Use new onStartSplitLegacy when starting split fro...

Change-Id: I6d81e0584bbfda3694772dcf293a4d064b2e8517
2022-04-22 21:02:22 +00:00
Sunny Goyal 84151d2bca Merge "Removing fade in logic during load." into tm-dev 2022-04-22 20:29:34 +00:00
Jeremy Sim cca5e510fd Merge "Fix crash bug when splitting with animations disabled" into tm-dev am: 602b46c399
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17807433

Change-Id: I18ac8925b7cf520d4d123c6648dc0e7cbaf2a862
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:10:47 +00:00
TreeHugger Robot e17589f4b8 Merge "Use new onStartSplitLegacy when starting split from overview" into tm-dev am: 8aead5503f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17779173

Change-Id: If978a1789f76f0edbc8259031c42f9fe94438dc9
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:10:37 +00:00
Jeremy Sim 602b46c399 Merge "Fix crash bug when splitting with animations disabled" into tm-dev 2022-04-22 20:05:09 +00:00
TreeHugger Robot 8aead5503f Merge "Use new onStartSplitLegacy when starting split from overview" into tm-dev 2022-04-22 20:03:36 +00:00
Sunny Goyal fdda22953d Merge "Revert "Removing some unused code from All-Apps"" into tm-dev am: b1f6a3fe97
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17917348

Change-Id: I100804cf91d0fd450557c6e6f8cbd02a777778c1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:02:59 +00:00
Tony Wickham 44e65099c2 Merge "Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets" into tm-dev am: 741e4aeb95
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17778392

Change-Id: I437518bf5b439cf7918ffe42d4bfdf9971207e3c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:02:21 +00:00