When there are no bubbles and the taskbar is not present on the screen,
the bubble bar drop target needs to be shown for the dragged taskbar
icon. To show the drop target, the view is added to the bubble bar's
parent layout. When the drop target should be hidden, the view is
removed.
The issue was caused by an incorrect parent container being passed to
the BubbleBarPinController. Instead of the bubble bar container, the
entire drag layer was used. Removing the view from the drag layer
interrupted the drag gesture.
Adding/removing the drop target view directly to the bubble bar
container does not affect the drag.
Bug: 397459664
Flag: com.android.wm.shell.enable_create_any_bubble
Test: Manual. Be on the overview screen with no bubbles present. Drag
the taskbar over the bubble drop zone and then back. Observe that the
drag is not interrupted.
Change-Id: I116883117b3da39528a4586a2436a10838625600
If taskbar is shown on home screen, have the taskbar all apps button
toggle the launcher activity version of all apps UI. This makes the
behavior consistent with how all apps system action (keyboard shortcut)
works, and addresses a gap in functionality where users are unable to
drag apps from the taskbar all apps UI to the workspace.
Bug: 392118517
Flag: com.android.window.flags.enter_desktop_by_default_on_freeform_displays
Test: On desktop device, toggle all apps from taskbar on home screen,
drag and app from all apps to workspace.
Change-Id: Ida0f230bf38c6e1e35041556f33de1be85daf785
Added logic to track whether the drop target handled the app icon drop,
in order to prevent the fly-back animation in those cases.
Bug: 397459664
Flag: com.android.wm.shell.enable_create_any_bubble
Test: Manual. Drop a taskbar icon onto the bubble bar. Observe that no
fly-back animation is performed for the dropped icon.
Change-Id: If439d7280fe9f713c181531ac899ac8ad37ed481
Refactor from ag/31915496 was wrong. We should skip the transparent
activity tiles when there is a visible task already found not when
visible tasks are not found.
Bug: 397190111
Test: Enter any app, trigger circle to search, see only one tile
produced.
Flag: EXEMPT Bug fix
Change-Id: Ic19710a7d1f5be78e96aa5ac25553358732acf3b
The invisible proxy view was preventing anything below it from being
accessible.
Flag: EXEMPT bugfix
Fix: 377526512
Test: #14 in bug.
Change-Id: I9d4596ebbbc4317a9ff7ded37b43b5fa1885e6ea
A drop target for the BubbleBarLocation has been added. This
implementation enables the Launcher process to handle application
drag-and-drop actions onto the bubble bar.
Known issues:
1) Upon dropping, the dragged icon animates back to its original taskbar
position from the top-left corner.
2) The expanded view drop target is not presented.
3) When an icon is dropped on the opposite side of the bubble bar, the
resulting location does not change, even though the drop target is
correctly displayed.
Bug: 397459664
Flag: com.android.wm.shell.enable_create_any_bubble
Test: Manual. Navigate to the overview screen, drag a taskbar icon to
the left or right side, targeting the bubble bar drop zone. Verify the
drop target's appearance. Then, drop the icon and observe that a new
application bubble is added.
Change-Id: I0f64a664620959f2503ac3fd711476b354a09348
Async widget inflation may complete after the updates have been deferred,
leading the widget to a broken state.
Reapply widget if its root content changed while deferred
Bug: 375442765
Bug: 327696338
Test: Verified manually
Flag: EXEMPT bugfix
Change-Id: I78d0f4ce92ee9bd2ee001de3a0e181f2e727218c
As Launcher3 is installed in system_ext, com_android_launcher3_flags
is in the system_ext container. Aconfig flags must set the same
container with their declaration.
Bug: 385213580
Test: "adb shell aflags list" must not be changed.
Flag: EXEMPT refactor
Change-Id: I433756dda120de253909db663a6ecfd47d26c65d
Background drawable is not associated with any folder view, and as a
result invalidating the drawable doesn't cause it to be redrawn on the
screen
Fix: 392617057
Bug: 399674389
Test: Manual
Flag: EXEMPT bug fix
Change-Id: I6d2bd97f66b53cdbeb4a715e53ff89b3450546f0
This cl inlcudes: while user is in desktop mode, we will add state description(active, minimized) of each app icon to it's content description.
Test: Manual
Bug: 397555157
Flag: EXEMPT bugfix
Change-Id: Iaec18e7099108e8b076b76c637a41e29ed837265
- Eventually we should remove circular geometry from ClippedFolderIconLayoutRule altogether
Bug: 392610664
Test: changing shapes with different size folders
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: I15c854c19186a3e4262e8d2b40960f3519ec2729
- Introduced MultiPropertyDelegate to delegate Kotlin var to MultipPropertyFactory, allowing easy creation of var for MultiPropertyFactory
- Introduced KFloatProperty to map any Kotlin var to a FloatProperty, which simplify the code to creaet FloatProperty a lot
- Combined the above to refactor usage of MultipPropertyFactory, use var to simplfiy things, and expose them as FloatProperty directly when needed
Fix: 399635468
Test: Smoke test main flow of enter Overview, task launching etc.
Test: presubmit
Flag: EXEMPT REFACTOR
Change-Id: Ie7dd8b69da7e3bda9026a0ef7b0377c26a78a332
Move SandboxContext to a separate class.
Remove all MainThreadInitializedObject references in Launcher3 and tests.
Remove ObjectSandbox interface and make RoboApplication extend
SandboxContext
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I1a8af5e6ae59df44d8ad6732b4d6e949ac402d6c
mpodolian
Treehugger Robot
Sihua Ma
Brian Isganitis
Charlie Anderson
Toni Barzic
Federico Baron
Justin Yun
Orhan Uysal
Xin Li
Jagrut Desai
Alex Chau
Sunny Goyal
Anushree Ganjam
minch
Saumya Prakash