Commit Graph

76036 Commits

Author SHA1 Message Date
Anushree Ganjam a77c28cd78 Merge "Add 0-state web data loader logs" into main 2024-05-14 23:13:03 +00:00
Holly Jiuyu Sun 5334c82136 Merge "[omni] Dynamically configure timeout for LPAA." into main 2024-05-14 21:45:03 +00:00
Stefan Andonian d82bf659d3 Merge "Use ItemInfo with correct position when adding to Workspace via Accessibility." into 24D1-dev am: 531ede6f45
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27345160

Change-Id: I934d089a73eec96c68be1520af285c443a3461c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-14 20:25:08 +00:00
Stefan Andonian 531ede6f45 Merge "Use ItemInfo with correct position when adding to Workspace via Accessibility." into 24D1-dev 2024-05-14 20:09:21 +00:00
Holly Sun 8b38295fb2 [omni] Dynamically configure timeout for LPAA.
Video: https://drive.google.com/file/d/1N7qOIolcSYM9n3z40FO9O6S_IdLJav9l/view?usp=sharing

Bug: 335018496
Test: manual
Flag: legacy CUSTOM_LPAA_THRESHOLDS disabled
Change-Id: I5b0f7cc7815ecd85c51254ad34f2be521c44795c
2024-05-14 12:42:28 -07:00
Charlie Anderson 22f9e52689 [automerger skipped] Merge "Fix blank pink loading icons by ensuring that cache entry won't downgrade existing icon." into 24D1-dev am: 9f03ea256d -s ours
am skip reason: Merged-In I8aac643ec5ca3162cd62bf1051cc751800c626dd with SHA-1 d073ab0b39 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27303311

Change-Id: I5c3305484a46bc16840703323d82cf7a64feaca9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-14 19:37:28 +00:00
Charlie Anderson 8f6a97a8e1 [automerger skipped] Fix blank pink loading icons by ensuring that cache entry won't downgrade existing icon. am: 0e4ebc9ff2 -s ours
am skip reason: Merged-In I8aac643ec5ca3162cd62bf1051cc751800c626dd with SHA-1 d073ab0b39 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27303311

Change-Id: I8e5a45ccc7436c5fdf9ae8cd351827b81f57c760
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-14 19:37:24 +00:00
Charlie Anderson 9f03ea256d Merge "Fix blank pink loading icons by ensuring that cache entry won't downgrade existing icon." into 24D1-dev 2024-05-14 19:21:06 +00:00
Charlie Anderson 8aa2898a58 Merge "Fix blank pink loading icons by ensuring that cache entry won't downgrade existing icon." into main 2024-05-14 18:57:09 +00:00
Shamali Patwa 8a5eddb923 Merge changes from topic "update-strings" into main
* changes:
  Add comments on suggestion category related strings
  Clean-up unused categories (follow up cleans up strings)
2024-05-14 18:38:54 +00:00
Stefan Andonian 68686cdfec Use ItemInfo with correct position when adding to Workspace via Accessibility.
Bug: 332651703
Flag: NA
Test: Verified that the issue isn't reproducible with the fix. The issue
was 100% reproducible before.
Change-Id: I01207396e19b4f7d14d6a147e5e5fb98bae9ea99

Change-Id: I81aad9758ee33b8acc2d6a1242e54f2a47124374
(cherry picked from commit 86d3c8814b)
2024-05-14 17:11:55 +00:00
Liran Binyamin 0d8b2206af Merge "Deflake BubbleBarViewAnimatorTest" into main 2024-05-14 16:53:28 +00:00
Chris Göllner fa09b12443 Merge "Convert SysUiState flags from int to long" into main 2024-05-14 10:44:40 +00:00
Luca Zuccarini de2e793f53 Merge "Tune the window to icon and home scaling animation." into main 2024-05-14 09:12:24 +00:00
Orhan Uysal 3da07952c5 Merge "Disable drag from taskbar while in desktop." into main 2024-05-14 09:02:45 +00:00
Ben Lin aca7b1cb19 Merge "Update SystemUiProxy signature." into main 2024-05-14 02:22:02 +00:00
Liran Binyamin 097261619b Deflake BubbleBarViewAnimatorTest
Fix an issue where we were verifying the status of the animator on the
test thread, which may have been modified on the main thread.

100x runs: https://android-build.corp.google.com/abtd/run/L42700030003806035/

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Fixes: 339437686
Test: abtd link above
Change-Id: I7e0d67e6ca4b2f905ff80f317355d8d5ed0a912b
2024-05-14 00:22:00 +00:00
Shamali P d07ed6b49b Add comments on suggestion category related strings
Also, deletes unused strings.

Bug: 339570620
Test: N/A
Flag: N/A
Change-Id: I3c53f9788c9734b6962b61d2a13b4445b91892ca
2024-05-13 23:23:34 +00:00
Shamali P 4f492626bd Clean-up unused categories (follow up cleans up strings)
Bug: N/A
Test: Unit tests
Flag: N/A
Change-Id: Id3bd76858d731b9e0eb977c094ebd3b19e1338ce
2024-05-13 23:13:56 +00:00
Bill Yi ca277a0bf0 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-05-13 20:34:51 +00:00
Bill Yi 0e63467ae1 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-05-13 20:34:51 +00:00
Treehugger Robot 878a547f54 Merge "Convert GroupedTaskView to Kotlin" into main 2024-05-13 20:28:00 +00:00
Jeremy Sim 6243da4667 Merge "Fix bug with flickering actions bar" into main 2024-05-13 19:27:02 +00:00
Treehugger Robot d931dd7d2f [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev am: 4d484ce86d -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27317538

Change-Id: I626956e8bf8bdecab62b253fcbf2862ea749ba8d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-13 18:34:41 +00:00
Bill Yi 8b8f48fcc1 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 0079ddf92a -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27317538

Change-Id: Ica2b5b8d9db729edb41729c0c2312ad4d7cce937
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-13 18:34:38 +00:00
Brandon Dayauon 4024e25622 [automerger skipped] Merge "Make all apps text focusable by accessibility." into 24D1-dev am: 66176c745c -s ours
am skip reason: Merged-In Ibabb92bd9d202221fdc9cfacb585755167898187 with SHA-1 98e150ba7a is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27240541

Change-Id: Ice59f5940d43876d5763ca67e8298893db44f502
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-13 18:31:26 +00:00
Brandon Dayauon 79ab0a43b6 [automerger skipped] Make all apps text focusable by accessibility. am: deb2e2c35e -s ours
am skip reason: Merged-In Ibabb92bd9d202221fdc9cfacb585755167898187 with SHA-1 98e150ba7a is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27240541

Change-Id: I58ed2bd5bcfb189000c0b085ffca880e22fa27dd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-13 18:31:23 +00:00
Brandon Dayauon a4c33bfbaa Merge "Remove comment on workProfileTest" into main 2024-05-13 18:28:06 +00:00
Treehugger Robot 4d484ce86d Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev 2024-05-13 18:16:18 +00:00
Treehugger Robot 0d4567b57b Merge "Remove COLLECT_SEARCH_HISTORY" into main 2024-05-13 18:15:58 +00:00
Brandon Dayauon 66176c745c Merge "Make all apps text focusable by accessibility." into 24D1-dev 2024-05-13 18:10:22 +00:00
Alex Chau 74804ae560 Merge "Remove unused @ScreenRecord and @Stability for closed bug" into main 2024-05-13 18:03:27 +00:00
Charlie Anderson 0e4ebc9ff2 Fix blank pink loading icons by ensuring that cache entry won't downgrade existing icon.
Bug: 326607598
Test: manually tested B&R
Flag: N/A
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:d073ab0b3922eb0320a6bc2141cd4a57593a0cac)
Merged-In: I8aac643ec5ca3162cd62bf1051cc751800c626dd
Change-Id: I8aac643ec5ca3162cd62bf1051cc751800c626dd
2024-05-13 17:58:24 +00:00
Charlie Anderson d073ab0b39 Fix blank pink loading icons by ensuring that cache entry won't downgrade existing icon.
Bug: 326607598
Test: manually tested B&R
Flag: N/A
Change-Id: I8aac643ec5ca3162cd62bf1051cc751800c626dd
2024-05-13 13:55:15 -04:00
Saumya Prakash 43e0ffafca [automerger skipped] Merge "Move the Done button in gesture navigation tutorial" into 24D1-dev am: a876ea9eda -s ours
am skip reason: Merged-In I2f2a7be0bf365727cff030f827e539add8533c18 with SHA-1 b8782e7341 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27285491

Change-Id: I8df6cf83e4ba734a80b66ebbfea9e27136529722
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-13 17:51:20 +00:00
Saumya Prakash 423e4628a6 [automerger skipped] Move the Done button in gesture navigation tutorial am: 72be60694f -s ours
am skip reason: Merged-In I2f2a7be0bf365727cff030f827e539add8533c18 with SHA-1 b8782e7341 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27285491

Change-Id: Idd6453d9f70889bf504f1e8dc3260ad5b77904f7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-13 17:51:18 +00:00
Jeremy Sim 6198cf6544 Fix bug with flickering actions bar
This CL fixes a bug caused by ag/27148514. The bug occurred because:

1) The new way we use FloatProperty to set the alpha did not have a working `get()` function, so it just returned a junk value, set to `-1f` (I didn't think `get()` would ever be called meaningfully for this property).

2) However, during certain UI interactions, `RecentsView#updateActionsViewFocusedScroll()` is called many times in a loop, which repeatedly tries to re-start the fade-in animation for actions bar. Pre ag/27148514, even though the fade-in animation was called repeatedly, it would start and then immediately stop running because it realized that it was already set to the desired alpha. However now that we return a junk value for `get()`, it didn't know to skip and just ran the full fade-in animation again and again.

Fixed by refactoring FLOAT_SETTER (now ALPHA_PROPERTY) and creating a new data class, OverviewActionsAlphaProperty, that handles some of the intricacies of this increasingly complicated alpha system.

Fixes: 339545510
Test: Swipe to Overview, move tiles around, actions bar does not flicker.
Flag: ACONFIG com.android.wm.shell.enable_app_pairs NEXTFOOD
Change-Id: I1093363780db5e0780deda2ff14b4f7361d63940
2024-05-13 10:40:31 -07:00
Saumya Prakash a876ea9eda Merge "Move the Done button in gesture navigation tutorial" into 24D1-dev 2024-05-13 17:37:00 +00:00
Saumya Prakash 72be60694f Move the Done button in gesture navigation tutorial
To align with updated UX specs, this change moves the Done button in
each gesture's tutorial from the middle of the screen to the bottom
right.

Fix: 293285057
Test: Run through the gesture tutorial in all font/display sizes for
different form factors and check that the Done button after each step is
in the new location.
Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED

Change-Id: I2f2a7be0bf365727cff030f827e539add8533c18
(cherry picked from commit b8782e7341)
Merged-In: I2f2a7be0bf365727cff030f827e539add8533c18
2024-05-13 17:36:43 +00:00
Liran Binyamin 3fcdc0a39f Merge "Handle touch on bubble bar while animating" into main 2024-05-13 17:30:40 +00:00
Charlie Anderson bf98cc95b6 [automerger skipped] Fix NPE for where intent.package is null but targetpkg is not. am: 024bf4627a -s ours
am skip reason: Merged-In I77e17901f4754c301ca20b3c6f93bbe29bead59b with SHA-1 ce255ff6fd is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27300555

Change-Id: Ifd0adb87872e6dc769f8db1222330dad8ea123ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-13 16:54:55 +00:00
Andrew Cole f3fe08388c Merge "Always Return Adaptive Icon" into main 2024-05-13 16:42:35 +00:00
Alex Chau 5867d8e175 Convert GroupedTaskView to Kotlin
Bug: 339787593
Test: Manual
Flag: None
Change-Id: I18522f8cadbfe5a0c0a74a5fa9c498a7fb3ce30f
2024-05-13 17:38:04 +01:00
Treehugger Robot b28f611163 Merge "Removing old workaround" into main 2024-05-13 15:53:22 +00:00
Chris Göllner 0cd995e4ef Convert SysUiState flags from int to long
We already reached the limit of 32 flags for an int. To be able to have
more, changing from int to long.

This is needed, as new flags have to be added.

Flag: NONE
Test: Manually running SysUI and Launcher
Test: Unit tests in CL
Bug: 335625543
Change-Id: Iec1d40218264c7c64c50fd09764aa07c0caa7787
2024-05-13 14:47:33 +01:00
Liran Binyamin 6097a29158 Handle touch on bubble bar while animating
This change handles touches on the bubble bar while the bubble bar is animating.
We now update the taskbar touch region during the animation to make the bubble bar touchable.
When the bubble bar is touched during the animation, we now cancel the animation and allow dragging or clicking to expand.

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/gtGS6FCrygN5RKueFtPs5E

BubbleBarTest 100x run: https://android-build.corp.google.com/abtd/run/L42600030003675041
Note that in the abtd run above there's a flake but that's for a different test which I'll look into separately.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605790
Bug: 280605846
Bug: 339066271
Fixes: 339244038
Test: See demo
Test: atest BubbleBarViewAnimatorTest
Change-Id: Icb8f4fa46ae4bb8c94ca931193d4a3cc49c5b718
2024-05-13 09:41:23 -04:00
Luca Zuccarini 50a7190efa Merge "Update alpha animation for All Apps / Divider icon." into main 2024-05-13 13:32:23 +00:00
Luca Zuccarini a152f8f044 Tune the window to icon and home scaling animation.
Result of several rounds of testing with UX and product. Ready to start
rolling out after this CL.

Bug: 298089923
Flag: ACONFIG com.android.launcher3.enable_scaling_reveal_home_animation DISABLED
Test: tested with the help of UX and PM
Change-Id: I2bcdfa5a314aeeb60acf7b38f3f3d463fedc277e
2024-05-13 13:31:20 +00:00
Pat Manning f0bff25b1e Merge "Unstash taskbar after timeout when cursor hovers bottom edge." into main 2024-05-13 12:44:21 +00:00
Alex Chau f1c402ad89 Remove unused @ScreenRecord and @Stability for closed bug
Fix: 309820115
Test: None
Flag: None
Change-Id: I7739c3eccb72e8c20e71ed85f5464e1619f8ea3f
2024-05-13 12:22:28 +01:00