Commit Graph

79460 Commits

Author SHA1 Message Date
Bill Yi a4b92fc641 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I7594928bfaf00ae47e4e03398e6570a36cb2dfad
2024-12-10 15:01:26 -08:00
Mykola Podolian 9763990e9e Merge "Align hotseat drop target with the adjusted hotseat" into main 2024-12-10 18:50:22 +00:00
Sam Cackett 6593622db5 Disable "MissingClass" lint check in QuickstepResLib
QuickstepResLib just contains resources. The code implementation for custom views is in NexusLauncher, so the linter doesn't know about this and falsely thinks a custom view resource is added without a corresponding class.

Change-Id: Icfe57c82af679c22428319e20d4c0e29b5c374fe
Fix: 383318069
Bug: 376817827
Flag: EXEMPT trivial build config change
Test: Add a custom view resource to QuickstepResLib, add code for custom view to NexusLauncher, run presubmits, check lint warning isn't there
2024-12-10 16:40:19 +00:00
Johannes Gallmann 9899283045 Merge "Don't cancel or commit predictive back on multi touch in 3-button-nav" into main 2024-12-10 13:33:00 +00:00
Johannes Gallmann 200ee94279 Don't cancel or commit predictive back on multi touch in 3-button-nav
Bug: 381054861
Test: Manual, i.e. verify that tapping the taskbar while predictive back is in progress does not cancel or commit it
Flag: com.android.window.flags.predictive_back_three_button_nav
Change-Id: I4117aca74216849519a0cabcbd3cb14f7fc5b38f
2024-12-10 13:28:36 +00:00
Alex Chau 20ed6de98b Merge "Revert "Don't recreate taskbar in Overview"" into main 2024-12-10 10:33:30 +00:00
Treehugger Robot ea27c11334 Merge "Use ViewStub for TTV creation to prevent double inflation (TTVDeprecated then TTV)." into main 2024-12-10 10:20:46 +00:00
Uwais Ashraf ca8a53911a Use ViewStub for TTV creation to prevent double inflation (TTVDeprecated then TTV).
Bug: 381317629
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Performance tests
Test: Open single, split and desktop tasks with flag combinations for TTV refactor and app chip.
Change-Id: Ie43955ddf6c9fac162974077a37e8448c5ef1781
2024-12-10 08:19:22 +00:00
Brian Isganitis 9c0552e09d Merge changes from topic "taskbar-view-recents-changes" into main
* changes:
  Move recents divider if hotseat is set after recents.
  Animate out/in the correct task view when recents change.
  Implement initial LayoutTransition for Taskbar recents.
2024-12-10 02:18:53 +00:00
Treehugger Robot 74cc80d239 Merge "Introduce a function getFristTaskView()" into main 2024-12-10 01:51:26 +00:00
Treehugger Robot 278ab17033 Merge "Fixing missing userId in various shell commands" into main 2024-12-10 00:50:10 +00:00
Treehugger Robot 9bb546953c Merge "Adapt TaskbarOverflow tests to check items added overflow view" into main 2024-12-10 00:21:18 +00:00
Treehugger Robot 07e6109dc6 Merge "Add logs to output intent string for NPE in DbEntry." into main 2024-12-09 23:41:08 +00:00
minch 0933ba83d8 Introduce a function getFristTaskView()
- Introduce a function `getFirstTaskView()` in RecentsView to get the
  first TaskView inside RecentsView.
- Replace `getTaskViewAt(0)` with this newly introduced function.
- Let `RecentsView.isTaskInExpectedScrollPosition()` accept a TaskView
  instead of index of the TaskView. This can avoid using the index at
  the callsites of this function.
- Change `getTaskViews()` to be a public function, thus it can be
  used outside of the RecentsView.

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Ensure the TaskViews required are correct in the following
      scrnarios:
      1. Swiping up from home screen to enter overview with empty or
         multiple tasks
      2. Swiping up from a fullscreen app to enter overview with
         one or multiple tasks
      3. Dimissing one or multiple tasks, exit and re-enter overview
         w/o newly opened tasks
      4. Remvoing all the tasks, re-enter overview w/o newly opened
         tasks
Change-Id: If63ad6dc9f5106be08d867090fdaf616117dcd82
2024-12-09 22:43:14 +00:00
Randy Pfohl 6cbf910d9a Merge "initial commit for multicontext management for recent windows" into main 2024-12-09 22:27:52 +00:00
Stefan Andonian e2c19253b2 Add logs to output intent string for NPE in DbEntry.
Bug: 380555381
Test: No tests, just changed log string.
Flag: EXEMPT bug fix logs
Change-Id: I0b0a36ebce0db38c89afb22a89b7e969fdc16bd9
2024-12-09 13:41:57 -08:00
Stefan Andonian 3d76150128 Merge "Convert SpringLoadedDragController to Kotlin" into main 2024-12-09 21:04:16 +00:00
Brian Isganitis c7f6cd6062 Move recents divider if hotseat is set after recents.
Fixes a bug where updateItems is first called with recents and then with hotseat. This causes the Taskbar to first be All Apps, Divider, and then Recents. The layout transition path assumes though that the Divider after All Apps is not for recents in this case, which is wrong. Due to this assumption, it skips over the divider and then adds the hotseat items after it (should be added before). Added a test for this case.

Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: Ia690c71fe482709e35ab302a7b497bf547eb4478
2024-12-09 15:35:43 -05:00
Brian Isganitis 3c24c421f6 Animate out/in the correct task view when recents change.
Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: I6c7708ed9f03eff8469b5f2e75ce00e545b03f54
2024-12-09 15:35:43 -05:00
Brian Isganitis 8e2b850df7 Implement initial LayoutTransition for Taskbar recents.
The animations mostly match the spec, though the recents indicators scale/fade with icon currently.

The change transitions need to incorporate translateX since that changes based on the number of icons in Taskbar. We need the translateX for pinning update to happen before TaskbarView lays out its children so that the animator computes the correct start and end values.

Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: I13aa49abf80ddc09fab890f78bde924a8f7f1d6e
2024-12-09 15:35:43 -05:00
Alex Chau e8aa9a383c Revert "Don't recreate taskbar in Overview"
This reverts commit 7a14d1b7b9.

Reason for revert: b/383084557
Bug: 343882478

Change-Id: Ia9b13964df7d85cfee441f4163f41e198c283021
2024-12-09 19:05:39 +00:00
Sunny Goyal 3dfaba2d8c Fixing missing userId in various shell commands
Bug: 380276168
Test: atest TaplMemoryTests
Flag: EXEMPT testfix
Change-Id: I87026eaf6340a2a43cbc899d262879259e339fc5
2024-12-09 10:36:06 -08:00
Treehugger Robot b172e86472 Merge "Loading generated preview on-demand instead of keeping everything in memory" into main 2024-12-09 17:26:02 +00:00
Treehugger Robot cea1888874 Merge "Update SystemUiProxy to support RemoteTransition when moving a task to desktop" into main 2024-12-09 12:50:20 +00:00
Treehugger Robot 45e274977d Merge "Some test fixes where default user is assumed to be user 0" into main 2024-12-07 08:11:56 +00:00
Brandon Dayauon 5d69c5c505 Merge "Fix workUtilityView receiving touch for pause work apps button." into main 2024-12-07 07:28:02 +00:00
Sunny Goyal 9c58954488 Some test fixes where default user is assumed to be user 0
CheckLongPressHelper: Cancelling view longpress which inturn also cancels self
This ensures that long press is properly cancelled if the default timeout for system longpress is same as ours

Bug: 379777736
Bug: 379807782
Bug: 379805363
Bug: 379805788
Bug: 379777734
Bug: 379774350
Flag: EXEMPT bugfix
Test: Presubmit
Change-Id: Ic4d9d6c4f79325a5d7ab98eafa1c86db4c2e67a5
2024-12-06 22:23:51 -08:00
Treehugger Robot cc0e19d298 Merge "Add more logs to investigate empty launcher restore" into main 2024-12-07 05:13:33 +00:00
Treehugger Robot c531c9fb90 Merge "Minor kotlin cleanup" into main 2024-12-06 23:49:12 +00:00
Shamali Patwa 5fb8180b00 Merge "Remove the elevation on the DragView to avoid shadows underneath" into main 2024-12-06 23:40:38 +00:00
Treehugger Robot ddaf0bbd7a Merge "Modify the accessibility tree to move the searchbox to the top." into main 2024-12-06 23:37:45 +00:00
Stefan Andonian 0c057f7df9 Convert SpringLoadedDragController to Kotlin
Bug: 379798547
Test: Verified that this works well on device.
Flag: EXEMPT kotlin conversion
Change-Id: Icaf874557e86a8231614ab75e55aedc8c3718703
2024-12-06 15:11:30 -08:00
mpodolian 06fb33ceb3 Align hotseat drop target with the adjusted hotseat
Added logic to adjust the drop target to account for changes in the
hotseat position when accommodating the bubble bar.

Fixes: 382348730
Test: all tests in package src.com.android.launcher3.celllayout
Test: Manual. Ensure bubbles are present, and the hotseat width is
adjusted. Long-press any icon in the hotseat, begin dragging it over
other hotseat icons, and observe that the drop target is drawn
appropriately.
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: Ice961f40ace03077ab8c9312a93eda1a16d7da34
2024-12-06 14:57:31 -08:00
Sunny Goyal ee15f52a7c Loading generated preview on-demand instead of keeping everything in memory
Bug: 369906121
Test: atest GeneratedPreviewTest
Flag: EXEMPT bugfix
Change-Id: Idd7610e8a5c577d2c7b0a1d7d2a1f1efde40b11f
2024-12-06 22:25:40 +00:00
Charlie Anderson bad2be4944 Add more logs to investigate empty launcher restore
Flag: EXEMPT logs
Test: presubmit
Bug: 377510898
Change-Id: I1c05b90c9e1337663c4c06703ad14b6c0d00aa07
2024-12-06 22:14:19 +00:00
Brandon Dayauon 8143b69cec Fix workUtilityView receiving touch for pause work apps button.
bug: 382501851
Test manually video:
before: https://drive.google.com/file/d/1I6av4cFoYex6QhzYAdlzJWCBwd2ilgzT/view?usp=sharing
after: https://drive.google.com/file/d/1hMDELNTqUvoI7oI-lw0sLifcGyIalbS_/view?usp=sharing
Flag: com.android.launcher3.work_scheduler_in_work_profile

Change-Id: I9dfead6deac7f3dbcb66c961bea4a1828f20478d
2024-12-06 14:05:03 -08:00
Anushree Ganjam 8335b9790a Modify the accessibility tree to move the searchbox to the top.
This change fixes both quickstep and pixel launcher variants.

Before
A11y traversal order : https://paste.googleplex.com/4735370693181440
Video: http://recall/-/cYrER3oshUB9gisWlEhySV/fGSVr7vsAToApiYzywptQ6

After
A11y traversal order : https://paste.googleplex.com/6464092613902336
Video: http://recall/-/cYrER3oshUB9gisWlEhySV/cEEPIPidHGP4tg9Hng7Ra6

Bug: 378610191
Test: Manual
Flag: EXEMPT a11y Bugfix
Change-Id: I95fbdc2db02f2957db461769e0d9a0556adbb760
2024-12-06 13:13:15 -08:00
Shamali P cc21323af2 Remove the elevation on the DragView to avoid shadows underneath
In b/297952359 we are seeing that widgets with clipped outline
 elements end up showing shadows below their drag view. Which
 due to not maintaining clipping looks further bad.

It seems like, we don't really need the elevation for drag
view anymore - and presumably it was added for older android
 versions for shadow for folders. But, they don't have them
  anymore, so, removing elevation now.

 Note: The issue that during drag and drop, the dragged preview
 not showing clip to outline or shadows within widget's views is
 a separate issue related to the Picture API usage during drag
  and drop.

Bug: 297952359
Test: Screen record in comments
Flag: EXEMPT Bugfix

Change-Id: If31a0275938afe374d269a46cc950970033323f9
2024-12-06 21:10:51 +00:00
Bill Yi 3f04014298 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-12-06 21:09:52 +00:00
Treehugger Robot bd203f948d Merge "Fix icon flicker from home-> overview when 3 button navigation is enabled in 3P launcher." into main 2024-12-06 19:52:26 +00:00
Toni Barzic 7bea1821d4 Adapt TaskbarOverflow tests to check items added overflow view
Adds a step to verify that TaskbarOverflowView items get set to the list
of the least recent tasks. Adds test cases for an edge case where
taskbar hits max number of items event without recent tasks
(b/379774843).
Has a fix for a further edge case where taskbar overflow view could be
created with a single item (in which case we can just show that item
directly).

Bug: 379774843
Flag: com.android.launcher3.taskbar_overflow
Test: atest TaskbarOverflowTest

Change-Id: I004676da3e17f26b8110d14d39589c84a9f384d8
2024-12-06 19:39:47 +00:00
Treehugger Robot 07bf3c3085 Merge "Restore fallback Overview state when restarted by theme changes" into main 2024-12-06 19:35:07 +00:00
randypfohl 81962e6fac initial commit for multicontext management for recent windows
Test: Built and ran locally

Flag: com.android.launcher3.enable_fallback_overview_in_window

Bug: 379746094

Change-Id: Ic48b4ef2471a3d6d5eb2e9bacdf00e7d71a87778
2024-12-06 11:17:01 -08:00
Jordan Silva 8ec11ab65f Update SystemUiProxy to support RemoteTransition when moving a task to desktop
This CL updates the methods and APIs to match the updated API from DesktopTasksController in WM Shell.
We've introduced RemoteTransition to be used for animating a task when it's moved into a desktop task.

Bug: 333524374
Fix: 379620787
Flag: com.android.window.flags.enable_desktop_windowing_mode
Test: TaplTestsOverviewDesktop
Test: OverviewDesktopTaskImageTest
Change-Id: I63cd094b3956ebe8fe7acda7da30ca73e1098ea0
2024-12-06 19:08:46 +00:00
Treehugger Robot 3e159f5654 Merge "Generalizing monochrome icon into Theme icons" into main 2024-12-06 18:29:07 +00:00
Alex Chau c76d4a8971 Restore fallback Overview state when restarted by theme changes
- Moved RUNTIME_STATE_RECREATE_TO_UPDATE_THEME to StatefulActivity
- Handle uiMode in RecentsActivity
- When RecentsActivity is recreated due to theme changes, restore previous state

Fix: 382072029
Test: Manual: Change light/dark them from QuickSettings while in fallback Overview, Overview stay open
Flag: EXEMPT bugfix
Change-Id: Ia596150afa1436c4a25e94fd2b6930a8ded0b0d4
2024-12-06 17:10:03 +00:00
Winson Chung 3660fe4505 Merge "Add some debug names to various remote transitions" into main 2024-12-06 17:00:32 +00:00
Liran Binyamin 56a173c1de Minor kotlin cleanup
Use regular function instead of expression functions for Unit return
types.
go/kotlin/practices/expression-functions#unit-functions

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 281083629
Test: no-op change. just verify this builds
Change-Id: Ie13fdad5f33bb4cda9e5e85e2fb4394131d3c63f
2024-12-06 10:30:40 -05:00
Shamali Patwa 0bcafa66d4 Merge "Use outline color token for bottom sheet." into main 2024-12-06 15:23:45 +00:00
Treehugger Robot 2173882ec6 Merge "Revert "Recycle tasks that are split when split select anim complete for reuse"" into main 2024-12-06 14:37:28 +00:00