Commit Graph

78027 Commits

Author SHA1 Message Date
Treehugger Robot a2dd2d2b28 Merge "Fix an issue where the bubble bar was visible after theme change" into main 2024-09-17 02:02:21 +00:00
Mady Mellor e736b9c0c5 Fix an issue where the bubble bar was visible after theme change
Don't set the alpha to 1 in the drag reset method unless the bar
is actually expanded.

When theme changes, everything gets recreated... so the location of
the bubble bar gets set which triggers drag reset which would make
the bar visible when it shouldn't be.

Flag: com.android.wm.shell.enable_bubble_bar
Test: manual - have bubbles in app (stashed), change theme, observe
               that bubbles are not visible
             - test dragging bubbles from left  to right via expanded
               view, individual bubble, and collapsed stack
Bug: 358304168 (not exact bug but noted in the video of comment#13)
Change-Id: I291cdb206532efe386684e36a78b9d66018f3cb1
2024-09-16 16:59:09 -07:00
Treehugger Robot 98d85d6dc0 Merge "Revert "Add screenrecord to testDragIconToPage2"" into main 2024-09-16 21:50:40 +00:00
Mykola Podolian 56cda496c6 Merge "Update placement of the nav bar in persistent taskbar for 3 button nav" into main 2024-09-16 21:49:54 +00:00
Federico Baron 9045632654 Revert "Add screenrecord to testDragIconToPage2"
This reverts commit cf55a30dcf.

Reason for revert: no longer needed

Change-Id: I08a9a0c90e1298d7206c7544de08b557fd89b58e
2024-09-16 20:03:10 +00:00
Bill Yi 9c749aaf2d Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-09-16 19:03:32 +00:00
Bill Yi 95ac9c17fa Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-09-16 19:03:32 +00:00
Sunny Goyal 98001dd1dc Merge "Migrating prediction_undo to aconfig" into main 2024-09-16 17:26:58 +00:00
Ats Jenk 29496de39d Merge "Show bubble bar when hotseat icons are visible" into main 2024-09-16 15:41:03 +00:00
Charlie Anderson ccd58ab97b Merge "Add additonal logging around PackageUpdatedTask to detect app updates for User" into main 2024-09-16 13:39:59 +00:00
Liran Binyamin 34351f690e Merge "Fix bubble tx when the bar is collapsed" into main 2024-09-16 13:31:56 +00:00
Treehugger Robot 34b535c76d Merge "Don't wait for thumbnails to update if updatedThumbnails are empty" into main 2024-09-16 12:57:12 +00:00
Treehugger Robot 9e3fbf1611 Merge "Revert "Adds new log constant to track overview select tooltip misalignment"" into main 2024-09-16 12:23:01 +00:00
Dennis Shen 41f4546aae Merge "Replace system_ext container with system" into main 2024-09-16 12:20:15 +00:00
Treehugger Robot 196422d6cc Merge "Revert "Add screenrecording for testOverview"" into main 2024-09-16 11:47:52 +00:00
Alex Chau 03aa04d45b Revert "Adds new log constant to track overview select tooltip misalignment"
This reverts commit cbc8bf0443.

Reason for revert: b/332485341 is fixed, revert logging constant previous added

Change-Id: I970a3af9905037a51bd9748324f35ac80de9b06b
2024-09-16 10:37:50 +00:00
Alex Chau 88f4eb48b1 Revert "Add screenrecording for testOverview"
This reverts commit 01fc975288.

Reason for revert: b/355042336

Change-Id: I1a5038e1608624dc1bc774940d84aea09381da87
2024-09-16 09:59:01 +00:00
Alex Chau 8b692c356b Don't wait for thumbnails to update if updatedThumbnails are empty
Fix: 366205521
Test: Double tap recents button in -1 screen
Test: RecentsViewModelTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I3eb854c8068fe70473bde32c5f7706af8d17a3cf
2024-09-16 10:39:23 +01:00
Treehugger Robot bacfdcd39a Merge "Add FLAG_DELAY_TASKBAR_BG_TAG to restrict when taskbar bg anim gets delayed." into main 2024-09-14 04:15:31 +00:00
Sunny Goyal d94100a223 Migrating prediction_undo to aconfig
Flag: com.android.launcher3.enable_dismiss_prediction_undo
Test: atest SystemShortcutTest
Bug: 270394476
Change-Id: I5daef5d168c301115d860a1ae1d3c96f70a0f18f
2024-09-13 20:21:32 -07:00
Treehugger Robot e738e4bf07 Merge "Revert "Add screenrecord for testDragAppIcon"" into main 2024-09-14 02:21:30 +00:00
Treehugger Robot 2ff010dfbe Merge "Revert "Adding screen record to testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty"" into main 2024-09-14 02:18:53 +00:00
Jon Miranda 86a4b653b9 Add FLAG_DELAY_TASKBAR_BG_TAG to restrict when taskbar bg anim gets delayed.
We set it only when user swipes up to unstash.

Fixes: 360778703
Test: swipe up to home, long click on taskbar icon before it settles
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Change-Id: I24ff466ee6730e3739d85307363567cfa1455cbf
2024-09-13 19:08:46 -07:00
Federico Baron c4bb97b64e Revert "Adding screen record to testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty"
This reverts commit 2b724ec00d.

Reason for revert: cleanup

Change-Id: I59140f34ac86ef1d25e707509bd52ddeb3ddf061
2024-09-14 00:13:59 +00:00
Federico Baron 375c88b05e Revert "Add screenrecord for testDragAppIcon"
This reverts commit 701eef07ab.

Reason for revert: cleanup

Change-Id: I489e8e79924c402ed5228781af4bd4065daca42e
2024-09-14 00:13:22 +00:00
Treehugger Robot 925edf7906 Merge "Add tapl test for isTablet" into main 2024-09-14 00:12:27 +00:00
Treehugger Robot 41d2d507a3 Merge "Revert "Add screen recording to TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet"" into main 2024-09-13 23:57:50 +00:00
Ats Jenk 61d45eb8d2 Merge changes I3cfdb715,Ic194afdb into main
* changes:
  Fix initial alpha when unstashing bubble bar
  Set additional bubble translation during stash
2024-09-13 22:38:24 +00:00
Schneider Victor-tulias ef404a786e Revert "Add screen recording to TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet"
This reverts commit 600c508569.

Reason for revert: test no longer fails
Fixes: 358607191

Change-Id: Ie944a7d79dab03fcb61ca62926929b0b462c1ba6
2024-09-13 21:49:24 +00:00
Treehugger Robot eb269053ba Merge "Remove unecessary uses of LauncherActivityInterface.INSTANCE" into main 2024-09-13 21:47:40 +00:00
Liran Binyamin b30d0b49c7 Fix bubble tx when the bar is collapsed
The previous behavior positioned the second bubble correctly but all
other bubbles behind the second bubble.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 366254467
Test: manual
       - create multiple bubbles in the bubble bar
       - expand and collapse the bubble bar and observe bubbles
         move correctly from right to left when expanding and from
         left to right when collapsing
Change-Id: I1db6daf629826af8d079a27d582e0c7e89fe2289
2024-09-13 16:19:57 -04:00
Bill Yi 6f8075222b Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ifc2d4959dd29cf6abf0268d6d86bbfd2e574f20b
2024-09-13 12:00:01 -07:00
Bill Yi 0827952dc0 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic09ee793191a3a0f92fb2d297338a850b5cf6ff3
2024-09-13 11:59:10 -07:00
Ats Jenk 9b4484c974 Show bubble bar when hotseat icons are visible
Fixes a flicker with bubble bar briefly attempting to stash when swiping
up on home screen.
Keeps bubble bar visible when dragging an icon on home screen.

Bug: 365561149
Flag: com.android.wm.shell.enable_bubble_bar
Test: swipe up on home screen, check that bubble bar does not stash
Test: drag a home screen icon, check that bubble bar does not stash
Change-Id: Ic8f4bf6051ed437167f369e8581a631b73e839b2
2024-09-13 11:28:37 -07:00
fbaron 6a65aebcc6 Add tapl test for isTablet
Bug: 366237798
Test: TaplIsTabletTest
Flag: EXEMPT TEST_ONLY
Change-Id: I806caa5e98b39fc6475c8807003646540f32b509
2024-09-13 11:11:06 -07:00
Ats Jenk 9639315baa Fix initial alpha when unstashing bubble bar
For the stash and unstash animation we use separate timings for the
Bubble views and background. In other animations we animate the entire
bubble bar alpha as one.
To achieve this during unstash animation we set the bubble views and
background alpha to 0. And then set the bar alpha to 1.
Since alpha animation has a delay during unstash, we need to set the
initial values as the start of the entire animation and not just the
alpha part. Otherwise there are flickers in the animation.

We also need to set initial values for the alpha animator that the
AnimatedFloat creates. AnimatedFloat uses the current values as the
start value. If we update it later, the animator was already created and
it won't have an effect. To fix this, we set the start and end values
for the alpha animators created by AnimatedFloat.

Bug: 345488489
Flag: com.android.wm.shell.enable_bubble_bar
Test: slow down animations and unstash bubble bar, check that bubbles
  alpha slowly animates in

Change-Id: I3cfdb715e1703bd2195c809fd77751a216558176
2024-09-13 10:51:11 -07:00
Dennis Shen d80efafdc0 Replace system_ext container with system
Bug: b/365135457
Test: m
Flag: EXEMPT refactor
Change-Id: I5521307c4b816d9802cb5f676d11c0b89cdfa862
2024-09-13 12:41:58 +00:00
Anushree Ganjam b41def0366 Merge "Add LauncherAppSingleton & LauncherActivityScope to dagger graph (3/n)" into main 2024-09-13 00:45:28 +00:00
Treehugger Robot ec5d7a0924 Merge "Cleaning up some enabled features" into main 2024-09-13 00:26:54 +00:00
mpodolian 04088ebef7 Update placement of the nav bar in persistent taskbar for 3 button nav
Implemented nav bar placement update to be located opposite to the
bubble bar.
When bubble bar is moved to the other side of the bar, 3 button nav will
swap sides (without animation).
If taskbar has to be repositioned it does that with the animation.

Test: TaskbarViewControllerTest
Bug: 346381754
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Id031706183c60cbd9c67537b01530acb43bae614
2024-09-12 16:42:15 -07:00
Sunny Goyal 5ee3d98641 Cleaning up some enabled features
Flag: EXEMPT LEGACY
		CONTINUOUS_VIEW_TREE_CAPTURE
		ALL_APPS_GONE_VISIBILITY
		ENABLE_BACK_SWIPE_HOME_ANIMATION
		ENABLE_DYNAMIC_TASKBAR_THRESHOLDS
		PREEMPTIVE_UNFOLD_ANIMATION_START
		ENABLE_NEW_GESTURE_NAV_TUTORIAL
		ENABLE_ENFORCED_ROUNDED_CORNERS
		ENABLE_TRACKPAD_GESTURE
		ENABLE_KEYBOARD_QUICK_SWITCH
		ENABLE_KEYBOARD_TASKBAR_TOGGLE
		ENABLE_ALL_APPS_RV_PREINFLATION
Test: Presubmit
Bug: 270395171, 291651514, 270393426, 294252473,
     270397209, 270396257, 270393258, 271010401,
     270396844, 281726846, 288161355

Change-Id: I6ef1e12dfc2203a4cca8e91aa291485f1ff24c42
2024-09-12 15:12:08 -07:00
Kevin Lim f1b5855af7 [Testing] Renamed incorrectly named FloatingHeaderViewTest
FloatingHeaderviewTest was named with ...Tests (plural), preventing it from
being excluded from launcher-testing-helpers-robo and getting included
in some unintended tests.

Bug: b/341795751
Flag: EXEMPT test renaming.
Test: Running FloatingHeaderViewTest
Change-Id: I8149f0a5548e77674bb2a23a34bd7671e0a3b371
2024-09-12 20:57:14 +00:00
Alex Chau 98af6a906e Merge "Revert "Separate desktop and fullscreen carousel"" into main 2024-09-12 15:50:41 +00:00
Chaitanya Cheemala (xWF) a555f4ca1b Revert "Separate desktop and fullscreen carousel"
This reverts commit 9420ba7515.

Reason for revert: Likely culprit for b/366196741 and b/366191730

Bug: 353950224
Fix: 366196741
Fix: 366191730
Change-Id: Icc84aaaae1a6bd8b21f059331715fb25163793b8
2024-09-12 15:48:28 +00:00
Treehugger Robot b6332b9947 Merge "Fixing back animation for container views" into main 2024-09-12 13:57:02 +00:00
Liran Binyamin 6138138d99 Merge "Initial screenshot tests for bubble bar view" into main 2024-09-12 13:33:50 +00:00
Alex Chau 9420ba7515 Separate desktop and fullscreen carousel
- setRunningTaskHidden now changes attachAlpha only, stableAlpha is untouched as part of the attach animation, so both alpha can be set independently without interferring with each other
- During swipe up, hide task of differnt type (fullscreen/desktop) from the carousel, apply unhide when the gesture settles
- Update the min/max alpha calculation when a type of task is hidden from the carousel

Fix: 353950224
Test: Quick switch, swipe up, and scroll in Overview with and without Desktop tile, on phone and tablet
Test: presubmit test on quickswitch and swipe up
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: I0a63da3ee3e55f4d1edbc53b2a4c5fccda2af387
2024-09-12 09:30:46 +00:00
Vinay Joglekar b3189d8404 Merge "Add keyboard navigation for all large tiles" into main 2024-09-12 09:09:02 +00:00
Sunny Goyal b55d9ca407 Fixing back animation for container views
> Looking up views during back instead of holding the reference
  This allows back animation even if Launcher restarts
> Fixing back animation not working with progressive back
> Fixing container animation overriding Launcher cookie used be gestureNav

Bug: 365866488
Test: Verified manually by enabling flag
Flag: com.android.launcher3.enable_container_return_animations
Change-Id: Ic235b238cca6a31e9a5502200ff6b07c72b4e4d7
2024-09-12 00:51:07 -07:00
Treehugger Robot f60ebdfa9d Merge "Add logs for 4x4 to 4x5 missing row bug" into main 2024-09-12 06:34:37 +00:00