Commit Graph

31382 Commits

Author SHA1 Message Date
Tracy Zhou 9d706b1ada Fix failed test in order to enable Live Tile (in the next change)
Live tile changes certain assumptions we have for tests, for example
- Launcher will not be in the resumed state after swiping up to Overview

Also, disable live tile for 3rd party launcher for now

Test: presubmit
Fixes: 169694902
Change-Id: Ifd466db0354f59290c4f66a0a2ad4c82f1169f29
2021-03-25 19:44:36 -07:00
Tracy Zhou 29c1e8437e Merge "Fix a memory leak" into sc-dev 2021-03-25 16:48:46 +00:00
Rajeev Kumar f23ea3b067 Merge "Add OWNERS to Launcher3/go" am: 278edf2938 am: dc71c0178a am: ee9a99a6a8
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/1653167

Change-Id: I227d47f2ba807e4b5de60fba8dbad60f279bdba4
2021-03-25 16:30:13 +00:00
Pierre Barbier de Reuille 119b7a6a12 Merge changes Ib7ce422d,I977e7750 into sc-dev
* changes:
  Added rounded corner to bitmap Widget Preview
  Correct RoundedCorner enforcements.
2021-03-25 16:25:18 +00:00
Rajeev Kumar ee9a99a6a8 Merge "Add OWNERS to Launcher3/go" am: 278edf2938 am: dc71c0178a
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/1653167

Change-Id: Id3e60d2015fc099461d8ac18767bb909b75d3165
2021-03-25 16:03:04 +00:00
Rajeev Kumar dc71c0178a Merge "Add OWNERS to Launcher3/go" am: 278edf2938
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/1653167

Change-Id: I313a119d7e67f142d04e254e57d1cabcefc60921
2021-03-25 15:24:57 +00:00
Rajeev Kumar 278edf2938 Merge "Add OWNERS to Launcher3/go" 2021-03-25 14:50:06 +00:00
Pierre Barbier de Reuille adc23265dc Added rounded corner to bitmap Widget Preview
This applies to the widget picker and the initial Widget drop.

Bug: 183615331
Test: Manually using top preinstalled widgets
Change-Id: Ib7ce422dc485396c2aceec6f43e83529d642ecc7
2021-03-25 14:09:18 +00:00
Samuel Fufa c699c01812 Merge "[Search] Resolve work/personal tab overlap with A-Z list" into sc-dev 2021-03-25 13:34:17 +00:00
Samuel Fufa df3fa3bfec Merge "[String][Work profile] Update work profile strings" into sc-dev 2021-03-25 13:34:04 +00:00
Alex Chau 5d225245b6 Merge "Fix taskbar crash after cleanup" into sc-dev 2021-03-25 11:28:55 +00:00
Alex Chau 06452a427d Merge "Move numAllAppsColumns to displayOptions" into sc-dev 2021-03-25 11:16:00 +00:00
Pierre Barbier de Reuille a750f8cdca Correct RoundedCorner enforcements.
The feature status will not, in the end, depend on the widget, so
removed the argument.

Bug: 183097166
Test: Manual test

Change-Id: I977e775072cf1724f3e31b848d3ac4c862d23e00
2021-03-25 11:10:08 +00:00
Alex Johnston ad4c83ad36 Merge "Block recent work profile apps content capture" into sc-dev 2021-03-25 09:14:05 +00:00
Tracy Zhou 773050d228 Fix a memory leak
Currently we pass a callback from AbsSwipeUpHandler to TaskAnimationManager to render task view launch animation, exposing the launcher activity to the static TouchInteractionService, which causes the leak. To not only fix the leak, but consider a better place for this functionality semantically, RecentsView is a better home.

Fixes: 183458638
Test: Run presubmit

Change-Id: Id35d0ad22005003d2516c34515a5cb338605be0b
2021-03-24 23:47:55 -07:00
Jon Spivack 6914f93f8e Merge "TaskOverlayFactoryGo: Minor updates for testability" into sc-dev 2021-03-25 05:08:49 +00:00
Jonathan Miranda 33f22c4e60 Merge "Refactor device padding to be set per grid option" into sc-dev 2021-03-25 01:18:24 +00:00
Samuel Fufa e0b8c8396a [String][Work profile] Update work profile strings
Bug: 183517121
Test: Manual
Change-Id: I334854170dca6ecf321da0ec2094ab993404c229
2021-03-24 19:35:11 -05:00
Winson Chung 394ede6fe6 Merge "Fix activity NPE when clearing flags" into sc-dev 2021-03-24 23:28:58 +00:00
Jon Spivack ea0463d243 Merge "Change label for Search button in Go Overview" into sc-dev 2021-03-24 20:06:10 +00:00
Alex Chau 7c43972c50 Move numAllAppsColumns to displayOptions
- Allow different number of columns per screen size

Bug: 171915986
Test: Manual
Change-Id: I7b7d518289ea56624dc87512f639e92f10f6b586
2021-03-24 19:36:11 +00:00
TreeHugger Robot 365c3c8f09 Merge "Fix scrolling in WidgetsBottomSheet" into sc-dev 2021-03-24 19:34:50 +00:00
TreeHugger Robot 0249710308 Merge "Remove MultiValueAlpha Mode, as all usages are BLEND" into sc-dev 2021-03-24 19:02:52 +00:00
Jon Miranda c9e69fa98d Refactor device padding to be set per grid option
- Fixes bug where devices with scaled grids were not
  getting the correct deivce padding.
- Also fix bug where device padding was invalid.
  Added validation check when processing paddings to prevent
  this from happening again.

Bug: 175329686
Test: manual, enable debug flag,
      run and verify no crash from validation check

Change-Id: I35b019c40667c08de4fad95ac4b05b2d8f8a0e74
2021-03-24 14:58:44 -04:00
Jon Spivack 177cff38fa Add OWNERS to Launcher3/go
The code in this directory only impacts the Go Launcher variants, so it would make sense for the owners to be from the Go team.

Bug: 183627385
Test: N/A
Change-Id: Iab09be2d590d25bce6de07048befa2e832a54623
2021-03-24 11:47:54 -07:00
Alex Chau dedbc8ac36 Remove grid scaling in Overveiw
- Grid scaling has problem that scales task icon and menu, which makes it hard to control icon size and text size in the manula
- Replaced the whole concept with dedicated Task size calculation in grid layout
- Support different icon size in TaskView in grid and removed task_thumbnail_top_margin
- Removed grid progress in TaskViewSimulator as well
- Refactored how ClearAllButton scroll and translations are calcualted to align clear all properly in grid
- Make page center calculation aware of PagedView pivot and scaling

Bug: 174464863
Test: Manual on two screens
Change-Id: I47b13ef6e55c6e16c52ea04225f5bde02ed82fc2
2021-03-24 18:46:32 +00:00
Zak Cohen 21aa7042c0 Merge "Overview - Adds first pass at making landscape layout real." into sc-dev 2021-03-24 18:44:29 +00:00
TreeHugger Robot 45393a561f Merge "Add a button for reconfiguring widgets." into sc-dev 2021-03-24 17:50:54 +00:00
Jon Spivack 387e65e3c4 Change label for Search button in Go Overview
The visual search button on the Recents screen (on Go devices) will be renamed to Lens.

Bug: 183618164
Test: Manual
Change-Id: I86371e604bd0204510737e5088c95404129818bb
2021-03-24 17:23:32 +00:00
Tony Wickham 11bc3118c9 Merge "Remove dead taskbar code" into sc-dev 2021-03-24 17:20:18 +00:00
Winson Chung 6151a34543 Fix activity NPE when clearing flags
- If the activity is already destroyed then skip setting flags

Bug: 183400378
Test: Just adding a null check
Change-Id: Id2fddb5adb3b68302fb58fce340abd29237ca731
2021-03-24 10:01:44 -07:00
TreeHugger Robot a0d299f5ad Merge "Clear focus from search bar whenever a header is clicked in search adapter." into sc-dev 2021-03-24 16:28:56 +00:00
Steven Ng 02c4f65e67 Fix scrolling in WidgetsBottomSheet
Popup container shouldn't intercept the scroll event if its child
scroll view isn't scrolled to the top yet.

Test: manual
Bug: 183599207
Change-Id: I434ba5e91b154e9862f22c08cd01c9d459e6707b
2021-03-24 14:51:19 +00:00
Zak Cohen 334efebaba Overview - Adds first pass at making landscape layout real.
Adds dynamic sizing to margins around task view, also creates space in the
overview actions view in landscape to make space for the proactive chips if
needed.

Bug: 182529089
Test: Local build and run on two devices
Change-Id: I447de3564a3249ede4e8e8a4d3e5d1c177f6be61
2021-03-24 14:45:48 +00:00
Yogisha Dixit 73c8a366a8 Add a button for reconfiguring widgets.
Test: manual
Bug: 183316993
Change-Id: I17bec121e3d07d65979c2b92c285e487a7d64d65
2021-03-24 13:34:29 +00:00
Andras Kloczl a4cb0f02de Fix staggered animation on right panel home screen
Recently we have added support for multiple panels
on the home screen but the current StaggeredWorkspaceAnim
logic only supports animation for the leftmost panel.

Test: manual
Bug: 183032642
Change-Id: I539e1c1a26292b75801eb3070e22f0fbde1ebc7e
2021-03-24 12:37:22 +01:00
Jon Spivack 375a1bbb92 TaskOverlayFactoryGo: Minor updates for testability
Made a few things public and marked them as @VisibleForTesting.

Bug: 179738220
Test: atest -v LauncherGoGoogleRoboTests
Change-Id: I231316ecf9282ad4d54038e218f44f062b3fa413
2021-03-24 04:05:03 -07:00
TreeHugger Robot 59230c3cdd Merge "Fix scrolling in widgets picker tapl tests" into sc-dev 2021-03-24 10:35:20 +00:00
Alina Zaidi 2cff164be2 Clear focus from search bar whenever a header is clicked in search adapter.
Test: Manually checked
Bug: 183398749
Change-Id: Ie91312ae1e62c6427e3397d1e5f60bc812a790ee
2021-03-24 09:52:45 +00:00
Alina Zaidi 305a44c935 Merge "Bug fixes for widget picker search (2/n)" into sc-dev 2021-03-24 09:47:26 +00:00
TreeHugger Robot bbfef42e48 Merge "Prevent setting task thumbnail during swipe to overview" into sc-dev 2021-03-24 01:46:34 +00:00
TreeHugger Robot 9187337d15 Merge "Fix spring loaded scale when taskbar is present" into sc-dev 2021-03-24 00:43:33 +00:00
TreeHugger Robot cb6dff62d9 Merge changes I6ce23251,I56fca1b7 into sc-dev
* changes:
  Update the resize frame to use the forced radius.
  Enforce rounded corners on App Widgets.
2021-03-24 00:39:17 +00:00
TreeHugger Robot acb3cac938 Merge "Update Pin widget dialog UI according to mocks." into sc-dev 2021-03-24 00:29:41 +00:00
TreeHugger Robot b9d201a5d6 Merge "Remove some unused hotseat/qsb scaling code" into sc-dev 2021-03-24 00:16:01 +00:00
Steven Ng 6c5e02ac27 Fix scrolling in widgets picker tapl tests
If the search bar and the target widget item intersect, scroll up to
make the target widget item clickable.

Test: run AddWidgetTest, AddConfigWidgetTest

Bug: 183403949
Change-Id: I847cc34757cb02b1a12e18e511fda749873ad5da
2021-03-24 00:01:53 +00:00
Tony Wickham aea0cbf9d3 Fix taskbar crash after cleanup
- Set LayoutTransition after adding initial views
- End running transitions in cleanup
- Only run update listener if LayoutTransition is active

Test: No crash after taskbar cleanup()
Bug: 182512211
Change-Id: I1049857935d09235388c1ef1fe4d89ef53b79aa5
2021-03-23 15:35:46 -07:00
Jonathan Miranda 0fa5225d57 Merge "Updating deep shortcut container to new width." into sc-dev 2021-03-23 21:30:46 +00:00
Pierre Barbier de Reuille 452df2d5bb Update the resize frame to use the forced radius.
When forcing the rounded corners, the radius may be smaller than the
default one. When this happens, we should change how the frame is drawn
to only use that reduced radius, or this looks weird.

Bug: 183097166
Test: Manual tests with top 1P App Widgets
Change-Id: I6ce232515ce14059e1168e16735719ea2370132c
2021-03-23 20:57:33 +00:00
Pierre Barbier de Reuille 298526e812 Enforce rounded corners on App Widgets.
The feature is controlled by the ENABLE_ENFORCED_ROUNDED_CORNERS flag
(currently set to false).

If does not yet handle P/H flags to control its behavior.

Bug: 183097166
Test: Manual tests with top 1P App Widgets (See bug for results)
Change-Id: I56fca1b717f37ad518588115409f2144a71d4b98
2021-03-23 20:57:33 +00:00