Commit Graph

13735 Commits

Author SHA1 Message Date
Stefan Andonian 510a818521 Show an 'Undo' snackbar when users dismiss a predicted hotseat item.
Bug: 200841778
Test: Hard-coded the flag to be true, and verified that the snack bar
is shown with the correct text. Also verified that talkback announces
"Item Removed" properly and that the correct log event is produced by
the AppEventProducer which AiAi needs to process the user action.

Change-Id: Ifbb9cf7aecf26cd4bcebf48d4fb07fb3d5af46bb
2022-04-06 17:22:40 +00:00
Alex Chau c83ea5f8fb Make AllApps bottom sheet follow finger and snap after 30% progress
Bug: 220336617
Test: manual
Change-Id: I0b6296cf5abf0f0a5f34fc2a0b5be93dc93ebf3f
2022-04-06 13:30:41 +01:00
Pat Manning 08610ca583 Adjust workspace grid and cellLayout paddings.
This is a partial revert of ag/17540098

Bug: 202971709
Test: manual
Change-Id: Ia49e48f336bcca906aae6b014d88f10421b83d0c
2022-04-06 13:10:50 +01:00
Pat Manning 52307a4604 Adjust grid cell visualizations.
This is a partial revert of ag/17540098

Bug: 202971709
Test: manual
Change-Id: Ia6f863701c169709053980766337b3caae6fba76
2022-04-06 13:07:08 +01:00
Pat Manning de25c0db36 Adjust edit state drop targets and workspace scaling per device type and orientation.
This is a partial revert of ag/17540098

Bug: 202971709
Test: manual
Change-Id: I0a642f932afd75e47ce11a2c1ee94643d1a67e0c
2022-04-05 20:56:03 +00:00
Brandon Dayauon d20011be15 Change work_app_edu to be like T spec: https://screenshot.googleplex.com/43ThiCnqrAqAQgE
Fixed the button to show on Portrait mode..streamline added for work_mode_fab.
Took out unneccessary attributes such as textColor for the button and took out background.

How it looks in landscape: https://screenshot.googleplex.com/AVaUEztqsXYA28N
How it looks in portrait: https://screenshot.googleplex.com/3oTG3j7yZLCxkLz
Apk: https://drive.google.com/file/d/1qLeiJSF3lHf7tZzoHWwBHGxDgbveTIYX/view?usp=sharing

Test: Manual - Tested on local Pixel device (Raven)
Bug: 224731116
Bug: 224731300
Change-Id: If1392806adecf1ce02723d20686ca6bf524f6464
2022-04-05 11:50:18 -07:00
Alex Chau 9d8eeabfec Reset touch state when removing all tasks in RecentsView.applyLoadPlan
Fix: 223245248
Test: com.android.quickstep.FallbackRecentsTest#goToOverviewFromHome
Change-Id: I1cc8952e077b9cc79a93d909b80e215e61e8deab
2022-04-05 17:13:56 +01:00
Alex Chau f9aa367324 Merge "Override statusBar top inset in Launcher" into tm-dev 2022-04-05 10:19:26 +00:00
Stefan Andonian bae4a72d30 Merge "Show correct drop targets for All-apps predicted item drags." into tm-dev 2022-04-04 20:13:29 +00:00
Brian Isganitis 9417012064 Merge "Add utility for isWallpaperSupported." into tm-dev 2022-04-04 19:57:25 +00:00
Stefan Andonian c62a4dae5f Show correct drop targets for All-apps predicted item drags.
This change fixes a bug where, after a user drags and drops a
predicted app from the all apps page once, dragging that item again
results in the "Remove" drop target being shown rather than the
"Do Not Suggest" drop target.

Bug: 221057278
Test: Verified correct drop down targets were present after fix when
dropping all apps prediction item on workspace multiple times in a row.

Change-Id: I95940eeebbd547861fcdfbb5d02769b82446184d
2022-04-04 17:32:32 +00:00
Alex Chau 20af9304cb Override statusBar top inset in Launcher
Fix: 227600170
Test: manual on small and large screen devices
Change-Id: I1b0dacaf555db966d1e2a837310d9cebe3e60d7a
2022-04-04 17:39:31 +01:00
Thales Lima 612230dbd3 Make hotseat RTL aware
Fix: 217567306
Test: manual, turning on "Force RTL"
Change-Id: I1369cfc6e9afd328a1a6945469064d4cd54f31ea
2022-04-04 13:32:10 +01:00
Sunny Goyal 59c535bb71 Merge "Adding a feature flag to disable icon overrides" into tm-dev 2022-04-01 17:26:09 +00:00
Pat Manning 5575dfeaad Merge "Revert "Adjust edit state drop targets, workspace scaling, and m..."" into tm-dev 2022-04-01 02:05:41 +00:00
Vinit Nayak c8b2fdbc6a Merge "Add metrics for taskbar 3 button nav" into tm-dev 2022-03-31 23:22:33 +00:00
Vinit Nayak 26b6b577b9 Add metrics for taskbar 3 button nav
Fixes: 221075063
Test: wwlogcat shows right events,
new events show up on aster dashboard

Change-Id: I3864ac02ea00f281d33ccb26b95a4916bd8b6be9
Merged-In: I3864ac02ea00f281d33ccb26b95a4916bd8b6be9
2022-03-31 19:36:47 +00:00
Jon Miranda 39055bebc9 Merge "Avoid closing PopUpContainer immediately after view is clicked." into tm-dev 2022-03-31 17:08:33 +00:00
Sebastián Franco 89804c42d4 Merge "Fix widget drop animation in 4x5 grid" into tm-dev 2022-03-31 17:05:16 +00:00
Alex Chau 5f8386cf26 Merge "Using the WindowMetrics API instead of display.getRealSize" into tm-dev 2022-03-31 10:58:40 +00:00
Thales Lima c1ea50a43d Merge "Make inline qsb part of grid attrs" into tm-dev 2022-03-31 08:30:10 +00:00
Vinit Nayak 254c77e279 Merge "Fix translation for secondary split thumbnail in RTL" into tm-dev 2022-03-31 04:19:42 +00:00
Jerry Chang 8eba01dca3 Merge "Fix wrong split percentage after split layout been pushed up" into tm-dev 2022-03-31 04:07:15 +00:00
Sebastian Franco b6b4069aa4 Fix widget drop animation in 4x5 grid
For the 4x5 grid we add insets to the widget and the
 animation wasn't accounting for it.

I'm using this shell function to quickly change the
animation speed

```
function anim-speed() {
	adb shell settings put global window_animation_scale $1
	adb shell settings put global transition_animation_scale $1
	adb shell settings put global animator_duration_scale $1
}
```

anim-speed 1 # for regular speed
anim-speed 10 # for really slow speed

Fix: 194227752
Test: Put down a widget in 4x5 and the animation should match,
sometimes is to fast but you can slow the animations with adb and see
the difference

Change-Id: I182729de39c0d0b12231d07e337dddca6fccf5c0
2022-03-30 21:18:18 +00:00
Sunny Goyal 36c0f76e21 Using the WindowMetrics API instead of display.getRealSize
Bug: 221961069
Bug: 195408476
Bug: 198965093
Test: Verified locally and presubmit
Change-Id: I4dac9c19df4c43e6a38ba5c05f27d25f4cfcb071
2022-03-30 21:07:23 +00:00
Thales Lima 12d0eff037 Make inline qsb part of grid attrs
This should make it more configurable, and be independent of the screen size set by the user.

Fix: 223726518
Test: atest Launcher3Tests:HotseatSizeTest
Test: atest Launcher3Tests:InlineQsbTest
Change-Id: If04f3fb0f556103f60b580c757a9fc06da561516
2022-03-30 20:57:57 +01:00
Vinit Nayak 1322fc3710 Fix translation for secondary split thumbnail in RTL
Fix: 225157531
Test: Swipe up in RTL shows both thumbnails
were expected.

Change-Id: I87d286b6ce6542c7cffadf86e3d4d99a3618f984
2022-03-30 10:32:51 -07:00
András Klöczl aa35c39167 Merge "Separate workspace item finding logic" into tm-dev 2022-03-30 16:43:32 +00:00
Thales Lima ececa893b7 Merge "Add border space to all apps cells" into tm-dev 2022-03-30 16:42:46 +00:00
Jerry Chang f5d90b9ec2 Fix wrong split percentage after split layout been pushed up
The task thumbnails of splitting task might not start with (0, 0), like
the case when IME panel pushing up split layout. Updated to consider
different start position while calculating split percentage.

Fix: 218704243
Test: enter split in portrait, toggle on IME panel, observed task
      thumbnails been placed properly after swiped up to overview.
Change-Id: I5b0d9710b56e9d77b86369c7fff4bc3ca75d9c7e
2022-03-30 14:03:55 +00:00
Luca Zuccarini 4e813d37c0 Merge "Refactor the floating header's positioning." into tm-dev 2022-03-30 13:03:48 +00:00
Thales Lima 080d890383 Add border space to all apps cells
Also remove tablet condition, phones should also follow the workspace size.

Fix: 218638090
Test: visual and HSV
Change-Id: Ib201011391c28c0f1dcd0ce8645c3191655a7227
2022-03-30 11:56:27 +01:00
Jon Miranda 10b5d68045 Avoid closing PopUpContainer immediately after view is clicked.
When an item is clicked, we start an app launch animation
from the icon in the container to the full app. The issue is that
we close the container too early, which causes a janky experience.

Tested that we already handle closing the container in all click
instances (ie. when launcher is in background).

Bug: 185510490
Test: click on all the different view types within PopupContainer
      ensure that the container does get closed via logs

Change-Id: I4fef24b911137d0abd24746fa49f466f5183176c
2022-03-29 11:12:48 -07:00
Tony Wickham b2aa48cad6 Merge "Fix problems with taskbar floating views on rotation" into tm-dev 2022-03-29 16:36:16 +00:00
Stefan Andonian 1d57706125 Update monochrome theme icon notification dot color
Bug: 189498337
Test: Hard-coded the notification dots to be visible, and verified they were the correct color.
Screenshot: https://screenshot.googleplex.com/AVbbW6P2bm6jYNS
Change-Id: I38a78cda056273eb300d458e663f79ccdd28f36a
2022-03-29 16:21:32 +00:00
Andras Kloczl 68e1af2bc2 Separate workspace item finding logic
Extract the item finding logic from AddWorkspaceItemsTask
to a separate class and write tests.

Test: AddWorkspaceItemsTaskTest.kt , WorkspaceItemSpaceFinderTest.kt
Bug: 199160559
Change-Id: Ie1bc4fcd4f94cd7cb0601c21bbdf273452b9dd1f
2022-03-29 13:31:31 +01:00
Luca Zuccarini 0c3961c367 Refactor the floating header's positioning.
Maintains the existing behavior while simplifying the overall layout.

See go/all-apps-qsb-positioning for details.

Bug: 221418522
Test: manual
Change-Id: I25a737cdfa431e8eb3a00b639984caed70819252
2022-03-29 10:18:33 +00:00
Sebastián Franco 9d5eef80cd Merge "Brighten theme-icons when in Dark mode and add dark color for taskbar" into tm-dev 2022-03-29 00:00:33 +00:00
Tony Wickham 538c9a0b52 Fix problems with taskbar floating views on rotation
- Close all views except TYPE_REBIND_SAFE
- Make All Apps TYPE_REBIND_SAFE again
- Reapply fullscreen to ensure any remaining floating views such as taskbr edu are laid out correctly upon rotation

Test: Rotating with folder and/or popup closes them; rotating with all apps stays open; rotating with all apps + popup closes popup but not all apps; rotating taskbar edu lays out correctly; opening shortcut or notification from all apps popup still closes all apps
Fixes: 220074790
Fixes: 219981733
Change-Id: I1dfea4ed0a636ab84bcc4e33304c80a689da01cd
2022-03-28 14:48:20 -07:00
Pat Manning e372366bb3 Revert "Adjust edit state drop targets, workspace scaling, and m..."
Test: manual

Revert submission 17004675-edit-state

Reason for revert: b/226274309
Reverted Changes:
Ib50509b6f:Adjust edit state drop targets per device type and...
Id1817cd3c:Adjust edit state drop targets, workspace scaling,...

Change-Id: I22863d7735f49f6a040a17cf56cc66f20a3e0986
2022-03-28 08:24:54 -04:00
Jeremy Sim db92b5d73f Merge "Fix issue with camera overlapping split staging UI" into tm-dev 2022-03-26 19:41:48 +00:00
Jeremy Sim b8eeb41ee0 Fix issue with camera overlapping split staging UI
Fixes an issue on some devices where initiating a split in Overview would cause an icon to be placed partly under the camera cutout.

Fixed by adding some padding to FloatingTaskView#mSplitPlaceHolderView, so that it always respects the device's insets.

Fixes: 220997064
Test: Manual
Change-Id: I7270bde3320f562519ea8e36a38e49609e0d6cd7
2022-03-25 16:31:46 -07:00
Abhilasha Chahal a35179d4ea Merge "Use numAllAppsColumns to calculate height of all apps icons" into tm-dev 2022-03-24 11:02:31 +00:00
TreeHugger Robot b8e0d2c052 Merge "Aligning Hotseat and Workspace icons in vertical bar mode" into tm-dev 2022-03-24 09:23:50 +00:00
Sunny Goyal eeca859bc9 Adding a feature flag to disable icon overrides
Bug: 226388663
Test: Verified locally by disabling the feature
Change-Id: Icfbe790046209b15dbdc0e44dcf1a14f1f50de62
2022-03-23 15:31:38 -07:00
Abhilasha Chahal dfd154f18d Use numAllAppsColumns to calculate height of all apps icons
Additionally opens up access of some fields to allow them to be overridden.

Test: Manually verified that Launcher3 layout does not change

Launcher3 APKs: https://drive.google.com/drive/folders/1hBcZU9xou4tZJxbTmkya_LyBbD2oYuwV?resourcekey=0-R0I1IQ2rSUIEfPjW8S_ppA&usp=sharing

Bug: 216150572

Change-Id: I4b97a7e9e15973fc5aa70a4b98f0b73dd5bf3c17
2022-03-23 21:09:54 +00:00
Sihua Ma 38bb3b0c5c Aligning Hotseat and Workspace icons in vertical bar mode
Changing the padding of the Hotseat Bar to align the hotseat icons with the Workspace icons.

Test: Manual
Fix: 223553482
Change-Id: I7939c3a900dfe22d2ce3f71d408f1d2778a0af2a
2022-03-23 18:27:41 +00:00
Sebastian Franco 5282efddc9 Brighten theme-icons when in Dark mode and add dark color for taskbar
Bug: 217247494
Test: change between dark and light mode and transition in and out of apps
Change-Id: Ia5e38d674a56eb95a48cb1e8c2688586594a69f9
2022-03-23 10:47:52 -07:00
Pat Manning 85eeb4e62e Merge "Add workspace page translations for edit state." into tm-dev 2022-03-23 11:35:20 +00:00
Luca Zuccarini 6f962f9357 Merge "[Toast] Flip the QSB motion flag to true by default." into tm-dev 2022-03-23 10:27:05 +00:00