Commit Graph

13735 Commits

Author SHA1 Message Date
Shikha Malhotra fefafe5aa9 Putting back generics for Workspace
This got over-written in merging files

Bug: b/218186705
Test: Manually tested Launcher3 works.
Change-Id: I55287e110d067a338204924337091ead044b34ec
2022-04-14 15:35:33 +00:00
kholoud mohamed 9db305478e fix broken build on erorrprone
Bug: 229190745
Test: m -j out/soong/.intermediates/packages/apps/Launcher3/Launcher3/android_common/lint/lint-baseline.xml
Change-Id: I8fc801b0051a7e14578fa331b22653f109c1dcc6
2022-04-14 14:18:30 +01:00
Alex Chau a74a8595fb Creaet separate pull back animation for AllApps
- In tablet, only animate recyclerView on pullback to be consistent with widget bottom sheet, and avoid showing a gap below mAppsView

Fix: 220345008
Test: manual on small and large screen
Change-Id: I1f7d03b6bd16af7a91a51a0985ef163d9e365261
2022-04-14 11:01:25 +01:00
Sihua Ma da8759ae29 Showing alert dialog when shortcut version higher than the App
Creating an AlertDialog when the disabled reason of the shortcut is DISABLED_REASON_VERSION_LOWER, which happens when the backed-up shortcut was created from an application that has a version higher than the one installed on the device. The AlertDialog will direct the user to the play store and update the application.

Test: Manual
Fix: 224796975
Change-Id: I0125fada60b48176775de6782ba03ee6790904aa
2022-04-14 01:34:44 -07:00
Alex Chau 59120581e4 Dismiss keyboard when leaving AllApps state
Fix: 221024791
Test: Launcher3 dismiss keyboard when leaving AllApps
Test: NexusLauncher can still open keyboard automatically in AllApps
Change-Id: I61b50e3fc4c6ed83bd5234c5daef3b2cb428b520
2022-04-13 18:48:23 +01:00
András Klöczl fed1182660 Merge "Change page snapping logic for large screen devices" into tm-dev 2022-04-13 11:18:39 +00:00
Shikha Malhotra 80a315e50f Merge "Review comments followup" into tm-dev 2022-04-13 08:00:31 +00:00
Andras Kloczl 07111f25f4 Change page snapping logic for large screen devices
Use 15% of the screen width instead of 40% of the page
width currently used for phones.

Test: try page snapping on Launcher home
Bug: 213305066
Change-Id: I6a525100bf942c5089f580a27250c425ca95cf00
2022-04-12 20:23:23 +01:00
Shikha Malhotra f78da1bae3 Review comments followup
These are review comments followup from ag/17399997

Bug: b/218187058
Test: manually test thet Launcher3 features work correctly
Change-Id: I9865a37c1ed663370dc28e7678994f3d961e3cd1
2022-04-12 14:33:07 +00:00
Pat Manning 7013ee716d Add drop target button overlap correction to second button only.
Bug: 228311837
Bug: 228311837
Test: manual.
Change-Id: Ib9256deadd58c7350143221bf98c79415aaf9bc4
2022-04-12 12:54:15 +01:00
Pat Manning 4349d21246 Merge "Adjust grid cell visualizations." into tm-dev 2022-04-12 11:50:38 +00:00
Tracy Zhou c2538d748a Add originalView of the menu to SystemShortcut
Split from home animation needs to originate from the app icon instead of the menu item icon. This can be useful for other animations in the future.

Bug: 226395821
Test: N/A
Change-Id: If45d80e347ba275bd550b6acd6ad81b319e753a3
2022-04-11 17:13:35 -07:00
TreeHugger Robot 2b80d6f813 Merge "Fixing potential ANR when fetching for wallpaper info" into tm-dev 2022-04-11 22:43:43 +00:00
TreeHugger Robot 2c9195b988 Merge "Don't use double padding in DeferredAppWidgetHostView if that would result in negative width" into tm-dev 2022-04-11 20:33:30 +00:00
Sunny Goyal ba7cf0dc7d Fixing potential ANR when fetching for wallpaper info
Bug: 214581894
Test: Manual
Change-Id: I616b34b0ce6c96ed360073b2e8ff4eed81190add
2022-04-11 13:21:35 -07:00
Brian Isganitis 5b89b31b12 Log taskbar all apps entrypoint, launches, and drags
Test: wwdebug, wwlogcat, ensure container is formatted as follows:
    container_info {
      all_apps_container {
        taskbar {
        }
      }
    }
Bug: 204696617
Change-Id: I2492b133f95fccb059010bc9e5ed6cce73c211f9
2022-04-11 12:14:14 -07:00
Alex Chau e8a60abc83 Don't use double padding in DeferredAppWidgetHostView if that would result in negative width
Fix: 203530620
Test: manual
Change-Id: I4aeff08e4fafec74e6a1bb031dfa14ae9d59e87e
2022-04-11 18:39:40 +01:00
Josh Tsuji 538581639e Merge "Add the staggered ring appear animation!" into tm-dev 2022-04-11 14:32:44 +00:00
Jeremy Sim 5d2a1f47c0 Merge "Fix placement bug with split staging icon in RtL" into tm-dev 2022-04-10 01:48:53 +00:00
Jeremy Sim e15927eec7 Merge "Implement splitting from Taskbar long-press" into tm-dev 2022-04-09 01:21:14 +00:00
Jeremy Sim 43c79704ed Fix placement bug with split staging icon in RtL
Fixes a bug where switching the phone to RtL caused Overview's split staging icon to be placed incorrectly.

The bug was caused by the fact that FrameLayout margins were not working consistently in RtL. This may be another bug; more investigation required (b/201920967).

This fix makes it so that the icon is positioned using setX and setY rather than margins.

Fixes: 227372971
Test: Manual
Change-Id: I6e5371d20e8e2e4e6f41ba93d0dfa36ed085c103
2022-04-08 18:05:05 -07:00
Sunny Goyal c317d925f7 Improving folder icon drawable
> Only clearing bitmap for foreground layer.
  Background and dot have only one draw command and is waster without rasterizing
> Moving bitmap creation to background thread
> Removing folder clipping since the folder draws outside bounds anyway
> Fixing the size of the foreground layer to what is actually needed

Bug: 224945025
Test: Manual
Change-Id: I72a8149ce4c44c266d5bdf45368d3dda5a960ac2
2022-04-08 14:41:40 -07:00
Shikha Malhotra 6d6f62c462 Merge "Added provision to switch the PageIndicator in specific Launchers" into tm-dev 2022-04-08 20:17:44 +00:00
Jeremy Sim abdf25d226 Implement splitting from Taskbar long-press
Implements the ability to split the screen by long-pressing a Taskbar icon.

Bug: 217964720
Test: Manual
Change-Id: I5d324d8ca912c10cc3c3de21cae98fad546b85ac
2022-04-08 12:15:16 -07:00
Brian Isganitis d3d6f0d6db Merge "Add separate AFV type for options popup dialog." into tm-dev 2022-04-08 17:46:07 +00:00
Luca Zuccarini 45c43c7058 Merge "[Toast] Polish the layout of the QSB, tabs and header protection." into tm-dev 2022-04-08 17:21:32 +00:00
Stefan Andonian 24125503c1 Merge "Simplify AbstractFloatingView.closeOpenViews usage." into tm-dev 2022-04-08 16:06:26 +00:00
Shikha Malhotra 0f2e1b6714 Added provision to switch the PageIndicator in specific Launchers
Please see the related CL in LauncherLilyGoogle where pagination is
implemented as persistent dots.

Bug: b/218187058
Test: manually test thet Launcher3 features work correctly
Change-Id: Ic20aa92249b1bbe3c4ab7810683b54648a181722
2022-04-08 11:47:46 +00:00
Brian Isganitis 7ef4fe42cb Add separate AFV type for options popup dialog.
Now that we close all non rebind safe AFVs onResume, the options popup dialog is getting closed. This dialog is rebind safe, but currently using TYPE_OPTIONS_POPUP which isn't.

Test: Dialog stays open on activity recreate. Also ran affected tests.
Bug: 227142635
Change-Id: Ibbac925ce5dd2de5c7770cb8f5bd8c5e438449cf
2022-04-07 16:29:44 -07:00
Stefan Andonian d123fbd15d Simplify AbstractFloatingView.closeOpenViews usage.
This is a follow-up code review to ag/1754638 to address a comment that was missed before the CR was pushed.

Bug: 227142635
Test: Folders still close when launcher is paused.
Change-Id: Ib6724dc3a6ba49e259ba7de655f6810d6a692d16
2022-04-07 22:19:26 +00:00
Sebastián Franco 608b5cd5d8 Merge "Make the text for the drop target buttons fit if it's too long." into tm-dev 2022-04-07 22:14:07 +00:00
TreeHugger Robot b26c5b9741 Merge "Removing line submited by mistake." into tm-dev 2022-04-07 21:57:05 +00:00
Sebastián Franco c2d37e042d Merge "Make the widget option on the PopupContainer full width" into tm-dev 2022-04-07 21:49:35 +00:00
Schneider Victor-tulias 2ff0a66b8e Merge "Add logging to debug incorrect taskbar states caught by flaky tests." into tm-dev 2022-04-07 21:05:39 +00:00
Stefan Andonian 52eaebead4 Merge "Close open folders when pausing launcher." into tm-dev 2022-04-07 18:53:45 +00:00
Sebastian Franco dfa88d55f5 Make the widget option on the PopupContainer full width
The width of the PopupContainer grows if there are multiple
SystemShortcuts and we where not updating the width of all the
options.

Fix: 227538975
Test: Long press an app like Google Maps on the HomeScreen to see
the menu. All the options should have the same width.

Change-Id: I25310d74aa1af17be37b53c27d2334f86bef325a
2022-04-07 10:00:30 -07:00
Luca Zuccarini a5e95419f5 [Toast] Polish the layout of the QSB, tabs and header protection.
Specs and screenshot in the bug.

Fixes: b/227902759
Test: manual
Change-Id: Ia713c923a71207cfaab7068f20c8606d816f8b43
2022-04-07 16:53:53 +00:00
Sebastian Franco d2d8e97a65 Make the text for the drop target buttons fit if it's too long.
The text "Don't suggest app" is too long when the device language
is GE or JA, or if you make the text bigger in settings.

Before truncating the text completely we are going to try to make
the text smaller until it gets to a predefined value
(button_drop_target_min_text_size).

Test: Change the language to German (Deutch) and install a new app and drag it to the workspace to see the button "App nicht vorschlagen"
Test: Also, a nice way to test is to go to SecondaryDropTarget#setupUi and hardcode the option to always show "Don't suggest app"
Fix: 221480721
Change-Id: I99def4e23cd17109a297aecaa620cef7a0d137e7
2022-04-07 16:39:29 +00:00
TreeHugger Robot 833c210550 Merge "Clone mInsets when copying DeviceProfile to taskbar" into tm-dev 2022-04-07 13:44:14 +00:00
Alex Chau 9e9dd8fa43 Merge "Make AllApps bottom sheet follow finger and snap after 30% progress" into tm-dev 2022-04-07 09:50:04 +00:00
TreeHugger Robot e633cca3bc Merge "Adding finish signal to GestureNavContract." into tm-dev 2022-04-07 03:24:01 +00:00
Thiru Ramasamy aa49200100 Merge "Log LAUNCHER_ALLAPPS_QUICK_SEARCH_WITH_IME event." into tm-dev 2022-04-07 01:07:28 +00:00
Sebastian Franco dac0769af1 Removing line submited by mistake.
Fix: 228327426
Test: Click the Notification dots
Change-Id: I3712e07eee5d4e5194b86de4fa1d45e1ef511dae
2022-04-06 15:25:34 -07:00
Stefan Andonian 253c23b2e8 Close open folders when pausing launcher.
Previously, folders wouldn't close after launching an app and quickly navigating back the launcher.
This is because the onStop state which contains a call to AbstractFloatingView.closeViews() wasn't being called.
This change adds an additional call to specifically close any open folders when the Launcher enters a paused state.

Bug: 227142635
Test: Verified that the issue is fixed after code change.
I logged the Launcher's lifecycle state to ensure my manual testing was reliable.

Change-Id: I838f992f83afdd754672ebbe85d0eb2a7e894417
2022-04-06 21:47:35 +00:00
Thiru Ramasamy d66f433cde Log LAUNCHER_ALLAPPS_QUICK_SEARCH_WITH_IME event.
Test: Manual - wwdebug && wwlogcat - http://gpaste/5690465669087232
Bug: 210792253
Change-Id: Ibe0c762a9e40e1af85a4d18051ba2a74e9f6106a
2022-04-06 14:32:34 -07:00
Schneider Victor-tulias 1823bdba6e Add logging to debug incorrect taskbar states caught by flaky tests.
- Various TAPL tasts are flaking because the taskbar is present when navigating home. Several TAPL taskbar tests are also flaking because the taskbar is missing when opening an app. Adding logging to catch when FLAG_IN_APP is being set and why it isn't being applied.

Bug: 227657604
Bug: 225205246
Test: manual
Change-Id: Ia976bb0a6c7764e571fab3ac98ee21ff22ef7674
2022-04-06 14:26:47 -07:00
Sunny Goyal 5c20fdd73f Adding finish signal to GestureNavContract.
Also fixing also-closing behavior for FloatingSurfaceView for Android S

Bug: 228260232
Test: Verified manually on device
Change-Id: I83f6417a756c1459533294d681e83abba6ea58aa
2022-04-06 13:42:59 -07:00
Brandon Dayauon e3589debfd Merge "Change work_app_edu to be like T spec: https://screenshot.googleplex.com/43ThiCnqrAqAQgE" into tm-dev 2022-04-06 20:41:24 +00:00
Alex Chau e0227551cf Clone mInsets when copying DeviceProfile to taskbar
- Set mInsets with windowBounds.insets when initialized, and set windowBounds.insets when cloning DeviceProfile
- Added more bottom sheet / all apps in DeviceProfile dump
- Also dump taskbar's device profile in dumpsys

Fix: 226968237
Test: Taskbar AllApps should have correct top padding
Test: adb shell dumpsys activity com.google.android.apps.nexuslauncher
Test: adb shell dumpsys activity service com.google.android.apps.nexuslauncher/com.android.quickstep.TouchInteractionService
Change-Id: I7739c699fb16544b92dc820354a643f745694c25
2022-04-06 19:44:43 +01:00
Josh Tsuji feb31ca567 Add the staggered ring appear animation!
Bug: 197636896
Test: a lot of unlocking
Change-Id: I9a713ac12eae5128d409166110cece0b86d89ae4
2022-04-06 14:26:50 -04:00