Commit Graph

19593 Commits

Author SHA1 Message Date
Brandon Dayauon 50f9dbd0a5 Disable two line text legacy flag.
Will now repurpose the twolinetoggle flag to be the flag that will
make twoline text enabled/disabled.

bug: 316027081
Test: presubmit
manually: https://screenshot.googleplex.com/BsZGCm7DrTZLwG4
Flag: com.android.launcher3.enable_twoline_toggle Staging
Merged-In: Idef427bad6551ae56b13e35393e076b8e000af5a
Change-Id: Idef427bad6551ae56b13e35393e076b8e000af5a
2024-03-27 17:07:04 +00:00
Jagrut Desai bc657f64c3 Merge "Remove Taskbar Pinning menu when in three button navigation mode" into main 2024-03-27 16:46:53 +00:00
Jagrut Desai 112691f2f0 Merge "Customize BubbleTextView for Taskbar Icon Size" into main 2024-03-27 16:46:16 +00:00
Uwais Ashraf 2725da5dd1 Remove unused code and fix warnings
Bug: 330326121
Test: Presubmit - change is a no-op
Flag: NA
Change-Id: If656113fce6bae82466d9482a92a15f689da00b6
2024-03-27 16:17:07 +00:00
Alex Chau 6431d6e879 Align action_buttons at bottom of OverviewActionsView
- http://ag/q/topic:%22b/329255757%22 caused a regression that in landscape, action_buttons shifted up when ShareTarget become visible, because OverviewActionsView become taller when this happens, and the topMargin is no longer valid to put actions_button at the position we want
- Bring back layout_gravity="bottom" solves the issue, as bottomMarign is always correct

Fix: 331517987
Test: manual as ShareTarget requires AiAi interaction and cannot easily be mocked
Flag: None
Change-Id: Iadcdf5731485f42f9586703e34e55ed9b4121bf9
2024-03-27 16:05:50 +00:00
helencheuk a3d40b0501 Add focus outline to overview clear all button
Use the same class BorderAnimator in TaskView to draw focus outline with padding between button and outline as UX design

Bug: 324911125
Test: Manual, launcher overview, use keyboard left arrow to show clear all button, outline should be shown
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Change-Id: I62ac2ce7a8f62170421b4318c9fa58805384187b
2024-03-27 14:15:08 +00:00
Liran Binyamin 65bf9fac38 Merge "Move PhysicsAnimator to wm/shell/shared" into main 2024-03-27 14:00:03 +00:00
Jeremy Sim 6867b18db2 Fix bug with long strings not aligning left on menu items
This CL sets gravity="start" and ellipsize="end" so that longer strings in the Overview app dropdown menu are still left-aligned and ellipsized when they are longer than the container.

Fixes: 330426535
Flag: N/A
Test: Manual
Change-Id: I1e62412c9b8be41a8dbb6b0597a69a283a56e3f0
2024-03-27 04:47:24 +00:00
Luca Zuccarini 8fe1d9c8ae Move interfaces to the shared library.
Bug: 323863002
Flag: NA
Test: NA, just a move
Change-Id: I8390bdbc226f53da2cbdf2c4321a67e7b7223bec
2024-03-27 04:42:35 +00:00
Gina Ko 5b845d2831 Reapply "Support toggling Taskbar All Apps with 3P Launcher." am: 036a83cd99
The revert was not supposed to be auto-merged.

This reverts commit 5a3bf93d82, reversing
changes made to 84f8002586.

Bug: 331384026
Change-Id: Ieb11a8544db90259aae856c4af805c37ce9e68cc
2024-03-26 15:03:31 -07:00
Liana Kazanova 5a3bf93d82 Revert "Support toggling Taskbar All Apps with 3P Launcher." am: 036a83cd99
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26720630

Change-Id: I235f6d6263be6e39a583ac7b1a0783bfc77533c9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-26 20:57:12 +00:00
Jagrut Desai c6f09490f7 Remove Taskbar Pinning menu when in three button navigation mode
Test: Manual
Bug: 331167630
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning NEXTFOOD
Change-Id: I257d1d3c0b3b37ef639578d0ccc6ec8d23d3d266
2024-03-26 13:42:09 -07:00
Liana Kazanova 036a83cd99 Revert "Support toggling Taskbar All Apps with 3P Launcher."
This reverts commit 176f186a6d.

Reason for revert: DroidMonitor: Potential culprit for http://b/331438065 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Change-Id: Ie375277ad2f65199749f0211ab50037d4b37e664
Merged-In: Ie375277ad2f65199749f0211ab50037d4b37e664
2024-03-26 20:34:09 +00:00
Sunny Goyal 62a11974fa Merge "Cleaning up some build configurations" into main 2024-03-26 20:00:51 +00:00
Jagrut Desai 8fbdf51d18 Customize BubbleTextView for Taskbar Icon Size
Test: Presubmit, manual
Flag: NONE
Bug: 322734668
Change-Id: I50503a45cdf43abed942a846c2517f49124c75e5
2024-03-26 11:31:36 -07:00
Vinit Nayak 926e03f5e5 Merge "Revert^2 "Call setOverviewDragState() whenever taskbar is recreated"" into main 2024-03-26 17:59:31 +00:00
Alex Chau c093b26a0f Merge "Ensure SAVE_APP_PAIR is only used for GroupedTaskView" into main 2024-03-26 17:28:45 +00:00
Sunny Goyal 77954bae4e Cleaning up some build configurations
> Removing Launcher3Go-without-quickstep
> Removing src_ui_overrides to src_no_quickstep
> Removing unnecessary code swpa for GO builds

Bug: 330920490
Flag: None
Test: Presubmit, everything builds
Change-Id: I5746dbc7c5a37c1d99d78b55bf2a6adce1a711c9
2024-03-26 17:16:52 +00:00
Brian Isganitis b02811f1d3 Force refresh AllAppsActionManager for tests.
Flag: NONE
Test: Manual
Fix: 330514236
Change-Id: I32990fe115c79963f9635eabacccd89e2815f098
2024-03-26 13:11:30 -04:00
Schneider Victor-tulias b4d102e75a Merge "Add debug logs to ActivityTracker" into main 2024-03-26 17:02:13 +00:00
Liran Binyamin 40bdec4710 Move PhysicsAnimator to wm/shell/shared
Flag: NONE
Bug: 280605790
Bug: 322791067
Test: no behavior change. relying on presubmits
Change-Id: Ica5e388f8fb3d07a4865e72e310f3f2bdfe01579
2024-03-26 11:50:08 -04:00
Alex Chau d1bc3b39f7 Ensure SAVE_APP_PAIR is only used for GroupedTaskView
- Check if TaskView is GroupedTaskView before casting to avoid a crash, caused by DesktopTaskView.containsMultipleTasks() is true but is not a GroupedTaskView

Fix: 331226084
Test: With Talkback on and Desktop task, go to Overview
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: Ic2f1b940bb5a6b0cf452465b9cc15ebf4c256858
2024-03-26 10:46:59 +00:00
Johannes Gallmann 360d3cd16c Merge "Play predictive animation when quickly restarting back gesture after cancel" into main 2024-03-26 08:00:57 +00:00
Jeremy Sim 46ca78ee78 Merge "Refactor how app pair icons draw" into main 2024-03-26 02:39:37 +00:00
Brian Isganitis 176f186a6d Support toggling Taskbar All Apps with 3P Launcher.
Taskbar All Apps exists regardless of the default launcher. Thus, we can
toggle it on large screen devices. This CL ties registering the system
action to default launcher and taskbar's enablement.

Test: adb shell input keyevent 117
Test: AllAppsActionManagerTest
Flag: LEGACY ENABLE_ALL_APPS_SEARCH_IN_TASKBAR ENABLED
Fix: 317259709
Change-Id: I26f0ed9e921beac762f3f9e6aaceb1002ad4801a
(cherry picked from commit c113b277e6)
2024-03-26 01:16:39 +00:00
Treehugger Robot a8efc84122 Merge "Using xml override instead of code swap for predicted icon" into main 2024-03-26 00:53:37 +00:00
Jeremy Sim b37faec287 Refactor how app pair icons draw
This changes (and cleans up) the way app pair icons are composed. Previously, the background and 2 icons were drawn individually and separately onto the canvas. Now, they are composed into a combined drawable first. This also allows the full icon drawable to be requested by external functions (which will be needed for display app pairs in folder previews).

Bug: 315731527
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Visually confirmed that app pairs loooks the same in all scenarios: rotation, disabled, themed, taskbar, pinned taskbar. Screenshot test to follow.
Change-Id: I7242e0c525ef578a54a06fb9137fcfc42c6f0e86
2024-03-25 16:43:40 -07:00
Fengjiang Li 9eee6df676 Don't toggle scrollbar during predicitve back swipe to avoid flicker
Fix: 329437430
Test: manual - attach video to bug
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Change-Id: I8c959fbb02948011be59a17752a140b1a07ca6b9
2024-03-25 16:34:44 -07:00
Treehugger Robot 43879a7256 Merge "Handle widgets added with tap-to-add in AppEventProducer" into main 2024-03-25 23:25:39 +00:00
Sunny Goyal bd7ec3335b Using xml override instead of code swap for predicted icon
Bug: 330920490
Flag: None
Test: Presubmit
Change-Id: I5ff52464b931630da003fb6aeff2a4fd9d2dd3b3
2024-03-25 15:18:48 -07:00
Schneider Victor-tulias 017af39acb Merge "Use the task background color in KQS when we are missing a thumbnail" into main 2024-03-25 21:31:50 +00:00
Schneider Victor-tulias cbdf4d3eef Merge "Add debug logs for b/321775748" into main 2024-03-25 20:26:43 +00:00
Treehugger Robot 2803ccadfb Merge "Add ExtendedLongPressTimeoutRule to all AbstractLauncherUiTest" into main 2024-03-25 19:43:51 +00:00
Schneider Victor-tulias 086758c821 Merge "Allow KQS to be reopened during the close animation for responsiveness" into main 2024-03-25 18:55:25 +00:00
Schneider Victor-tulias d3b014ea91 Add debug logs for b/321775748
Flag: N/A
Bug: 321775748
Test: FallbackRecentsTest
Change-Id: I0dde08c4e6b2942713274d2ae29e52d5504ea25d
2024-03-25 14:24:35 -04:00
Schneider Victor-tulias 18821d1c1f Add debug logs to ActivityTracker
Flag: N/A
Bug: 274280837
Test: checked logs during gestures and 3-button, and dumped Launcher logs
Change-Id: Icbb1edb0e59fa9cce9364e39823a664cda4ebf1b
2024-03-25 13:48:44 -04:00
Sunny Goyal 85b40b37c5 Merge "Removing ext_test directory" into main 2024-03-25 17:42:21 +00:00
Tracy Zhou e3720885c1 Merge "Revert "Hide task bar when folding before the new config renders the correct task bar"" into main 2024-03-25 17:39:07 +00:00
Schneider Victor-tulias 841734e091 Use the task background color in KQS when we are missing a thumbnail
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 328686729
Test: forcibly used a null bitmap in dark/light modes
Change-Id: Ie5e106d6b0e69a60a77d065b945fe036c6dd9ef9
2024-03-25 13:26:35 -04:00
Schneider Victor-tulias fe7319ec40 Allow KQS to be reopened during the close animation for responsiveness
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 327421402
Test: quickly quick switched during close animation
Change-Id: I11dad62d11afd796aadf9b6165f0b4404f344311
2024-03-25 12:52:12 -04:00
Schneider Victor-tulias 081d6f4b59 Merge "Focus the first task after the desktop task when launching overview from KQS" into main 2024-03-25 15:25:50 +00:00
Schneider Victor-tulias 02e57b3d62 Add ExtendedLongPressTimeoutRule to all AbstractLauncherUiTest
When devices run slow in pre/post-submit, it is possible for a drag to be processed at a long press before the first move event can be created and dispatched. Added a rule to artificially increase this long press timeout in tests.

Flag: N/A
Fixes: 319257820
Test: TAPL tests
Change-Id: I24e0f3baec15db7558351d0cb2bd93a4e49640e8
2024-03-25 11:22:31 -04:00
Tracy Zhou 4dbac6caa9 Revert "Hide task bar when folding before the new config renders the correct task bar"
This reverts commit dfb334f1e1.

Reason for revert: A bunch of WM fixes are in (b/291562764)

Change-Id: I9d08dab976cda112f802ee91256c09ef2026a01f
2024-03-23 19:35:50 +00:00
Vinit Nayak f1a832fa55 Revert^2 "Call setOverviewDragState() whenever taskbar is recreated"
This reverts commit 541c5d272d.

Reason for revert: test still failing w/ revert https://android-build.corp.google.com/abtd/run/L66700030002678824/

Change-Id: If3ab4bb850ee519446e6cae4160ea6271049f83a
2024-03-23 00:51:00 +00:00
Sunny Goyal 9d2ece156d Removing ext_test directory
Except for a few methods, most of the testing code was already in the main
codebase. Maintaining the additional source directory adds unnecessary overhead

Bug: 330920490
Test: Presubmit
Flag: None
Change-Id: I56c43ab7a4869b26858d622d0b8b14f286d50e90
2024-03-22 15:45:32 -07:00
Alex Chau a5d55fe5ef Revert "Log split button visibility to debug spacing issue"
This reverts commit 2d55c9c679.

Reason for revert: Logs not helpful in figuring out the issue and is too spammy
Bug: 321291049

Change-Id: I88a4350277ea3e965493da6386cf4c83c5c564e4
2024-03-22 22:19:13 +00:00
Alex Chau 30d9b190d5 Simplify OverviewActionsView layout to avoid unexpected misalignemnt
- Removed the weight=3 space on left/right and replace with gracvity=central_horizontal
- Removed unused oav_three_button_space
- Removed irrelevant layout_gravity (gravity within parent), as the LinearLayout is already taking full parent width, and its vertical alignemnt si controlled by `updateVerticalMargin` in code

Bug: 329255757
Test: OverviewImageTest
Flag: None
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2cf1a0c08d41ee7a29ea920c93850d3914ed7cd8)
Merged-In: Ice087dde7d3c36b4536d36ce82c382c31c124855
Change-Id: Ice087dde7d3c36b4536d36ce82c382c31c124855
2024-03-22 22:15:40 +00:00
Sukesh Ram a47eff5e21 Merge "Revert "Call setOverviewDragState() whenever taskbar is recreated"" into main 2024-03-22 20:31:42 +00:00
Tiger Huang ee28d64d27 Merge "Let taskbar can trigger insets resize animation" into 24D1-dev 2024-03-22 18:39:16 +00:00
Saumya Prakash dc6ec50558 Merge "Fix incorrect fragment in gesture tutorial when rotating the screen" into main 2024-03-22 18:09:47 +00:00