Commit Graph

19593 Commits

Author SHA1 Message Date
Ats Jenk 96e4511d1a Merge "Update bubble bar location in shell" into main 2024-04-03 15:51:18 +00:00
Alex Chau 75e48fc0ec Merge "Revert "Update Split button visibility based on DeviceProfile change"" into main 2024-04-03 12:56:13 +00:00
Uwais Ashraf 38bc885de9 Revert "Update Split button visibility based on DeviceProfile change"
This reverts commit 170306d54a.

Reason for revert: Cause of b/332673787

Bug: 321291049
Change-Id: Id5ae99d28a7497debaabbc5ed09cd18f9c253750
2024-04-03 12:51:42 +00:00
Alex Chau cde4ddf4a0 Merge "Update Split button visibility based on DeviceProfile change" into main 2024-04-03 10:59:02 +00:00
MrSluffy 09620278f6 Fixed crash on A9
- Closes : #4151
2024-04-03 18:39:45 +08:00
Johannes Gallmann b82a47a0e7 Use custom interpolator for predictive back system animations
Bug: 332512902
Flag: ACONFIG com.android.window.flags.predictive_back_system_anims TRUNKFOOD
Test: Manual, i.e. analysing screenrecordings and verify that there are no more animation jumps at the start/end of the back animation
Change-Id: I588a8a631e068c09e88c1f3c5af5d8970746c803
2024-04-03 10:40:17 +02:00
Vinit Nayak c9ab1dcd98 Merge "Refactor how app pair icons draw" into 24D1-dev 2024-04-03 04:12:43 +00:00
Jeremy Sim fcbef122e6 Refactor how app pair icons draw
This changes (and cleans up) the way app pair icons are composed. Previously, the background and 2 icons were drawn individually and separately onto the canvas. Now, they are composed into a combined drawable first. This also allows the full icon drawable to be requested by external functions (which will be needed for display app pairs in folder previews).

Bug: 315731527
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Visually confirmed that app pairs loooks the same in all scenarios: rotation, disabled, themed, taskbar, pinned taskbar. Screenshot test to follow.
Change-Id: I7242e0c525ef578a54a06fb9137fcfc42c6f0e86
(cherry picked from commit b37faec287)
Merged-In: I7242e0c525ef578a54a06fb9137fcfc42c6f0e86
2024-04-02 23:38:47 +00:00
Sukesh Ram d6709b0a34 Merge "Fix Taskbar Background Visibility After Entering IME then Overview." into main 2024-04-02 21:56:24 +00:00
Ats Jenk 2ae49c6cab Update bubble bar location in shell
Send wmshell updates about bubble bar position when it is dragged
across the center divide.

Bug: 330585397
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: manual
  - with bubble bar on home screen
      - long press and drag bubble bar around on same side, no drop
        target
      - release the bubble bar, it snaps back to the original position
      - long press and drag bubble bar to other side, see drop target at
        the corner
      - release bubble bar, it snaps to the new side
      - long press and drag bubble bar to other side and back, see the
        drop target visible, release, snaps back to the original
        position
  - repeat above steps from an app, swipe up taskbar for bubble bar
Change-Id: I88faf641b9c07a19cfbb7a1feb8170a64269ac1f
2024-04-02 13:38:29 -07:00
Holly Sun d1bfd56678 [omni] Read long press duration from AppSearch and override server configured value.
Notify the appsearch values to systemui through SystemUiProxy.
See http://shortn/_WqYj0buH7R  for summary

Bug: 330446188
Test: manual. Side load agsa apk to read the value from AppSearch
Flag: legacy CUSTOM_LPNH_THRESHOLDS enabled
Change-Id: I7bd2688178da48ae8eb9e62e135304cba2fec8ce
2024-04-02 19:04:53 +00:00
Sunny Goyal 9e6e3562f0 Using IHomeTransitionListener for listening for Launcher state when taskbar recreates
IHomeTransitionListener was only used when the visibility state changes, but not
when the taskbar is recreated during rotation. Instead we create a static listener
to keep track of current home visibility state

Bug: 331947346
Bug: 331947116
Flag: aconfig use_activity_overlay staging
Test: Manual
Change-Id: Icf613f7fc4f78e3f76a600202687b069d53a16dd
2024-04-02 10:36:54 -07:00
Johannes Gallmann f151bfdd53 Add vsync id to predictive back transactions
Bug: 331808052
Flag: ACONFIG com.android.window.flags.predictive_back_system_anims TRUNKFOOD
Test: Manual, i.e. recorded perfetto trace and verified that missedFrames metrics showed up
Change-Id: I3dc5900ddedcb70467de7667f1555862dee5b45d
2024-04-02 17:35:45 +02:00
Bill Yi 4046bc668b Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ib38aca104a8bd610756af4e0016a9efd9d8ad09e
2024-04-02 00:26:10 -07:00
Bill Yi b1ef45cf1f Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ida67111c12717453e5f1a68f5ef868bcc4758a9e
2024-04-02 00:25:40 -07:00
Vadim Tryshev 1c8354543a Re-enabling stress tests in presubmit
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I466ffb58fbd3bf5e7b3e0fc186aed12f75019e23
2024-04-01 17:52:50 -07:00
fbaron c0c0bdbc38 Fix null pointer in FloatingWidgetView
Flag: NONE
Test: NONE
Bug: 331868669
Change-Id: I350e6660ea1936bb9ee799c3d2c840c57876fef4
2024-04-01 13:17:49 -07:00
Shamali P 7ae51788da Update the WidgetPickerActivity to display recommendations for hub host
- Accepts a ui_surface param of format "widgets{_hub}" and existing
widgets on the surface to be excluded from predictions
- Refactored the widgets prediction update task to extract reusable
logic that maps the predictions to widget items and reused it.

http://screencast/cast/NjE1MTA5MDI0NzU2NTMxMnwzMGE3NTMwNi1hZg

Bug: 326092660
Test: WidgetsPredictionHelperTest and see screencast above.
Flag: N/A
Change-Id: I6ceeb752c167893bab4ed496cedc5e8081e1b950
2024-04-01 20:16:37 +00:00
Fengjiang Li 01cc273537 Add LAUNCHER_ALL_APPS_SEARCH_BACK jank instrumentation
Bug: 330405993
Test: prefetto trace TBD
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Change-Id: I1fb2876fb29bc360cbb8dc8c1605215f28383c3c
2024-04-01 11:12:50 -07:00
Liran Binyamin 1bc33421de Merge "Initial animation of new bubble bar bubble" into main 2024-04-01 17:54:59 +00:00
Ats Jenk 599ed3ba06 Merge "Create drop target for bubble bar" into main 2024-04-01 17:14:55 +00:00
Jeremy Sim 370d05a276 Merge "Update save app pair icon" into 24D1-dev 2024-03-30 03:36:21 +00:00
Jeremy Sim da4ba9336e Merge "Reparent folders and app pairs" into main 2024-03-30 03:06:44 +00:00
Sukesh Ram 5c34cf2d06 Fix Taskbar Background Visibility After Entering IME then Overview.
Fixed issue whereby taskbar background disappears as expected when the IME switcher is present, but does not appear again if the overview button is pressed after this state.

Flag: NONE
Test: Manually tested in Felix Landscape mode.
Bug: 297472865
Change-Id: If1074b28870c794db8a87dd6cd59f9656dc7c15d
2024-03-29 16:08:43 -07:00
Jeremy Sim 742630c2f8 Reparent folders and app pairs
Previously, app pairs and folders shared a common data model, FolderInfo. Now we need to separate them, so a new type, CollectionInfo, will serve as the parent of both types.

Bug: 315731527
Fixes: 326664798
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, unit tests to follow
Change-Id: Ia8c429cf6e6a376f2554ae1866549ef0bcab2a22
2024-03-29 15:39:28 -07:00
Treehugger Robot 124a9596b6 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-03-29 22:36:18 +00:00
Treehugger Robot 520d91f93b Merge "Don't toggle scrollbar during predicitve back swipe to avoid flicker" into main 2024-03-29 09:56:10 +00:00
Ats Jenk f221b8a7de Create drop target for bubble bar
When dragging bubble bar in launcher, show drop target when drag passes
middle of the screen.

Bug: 330585397
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: manual
Change-Id: I52c3e9ac0b7c36e2207640baf75dc44300b522ef
2024-03-28 14:21:33 -07:00
Alex Chau 170306d54a Update Split button visibility based on DeviceProfile change
- Updating Split button visibility in notifyPageSwitchListener() is sometimes too late and causes OverviewActions failed to re-center after removing Split button
- Instead, update Split button visibility based on DeviceProfile change in updateDimension(), which is the ultimate source of information impacting button visibility

Fix: 321291049
Test: Clear all tasks, fold, launch app, swipe up to Overivew
Flag: None
Change-Id: If518cb02429011fedfb8df3dd05dd7ab180d849a
2024-03-28 21:10:12 +00:00
Bill Yi 2e779a3301 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I76dd0d716268b03eddb9f4fadee7b7f186505d7b
2024-03-28 12:07:12 -07:00
Bill Yi fb288950d3 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I29eec7ffbf29c7498b9ece028ae2584d09677420
2024-03-28 12:06:48 -07:00
Liran Binyamin 074a3a66b0 Initial animation of new bubble bar bubble
This change animates a new bubble bar bubble. Currently only handles the case where the bubble is added when the bubble bar is stashed.
There's no synchronization with the stash handle yet either.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605790
Test: atest BubbleBarViewAnimatorTest
Change-Id: Ic3f5edc0dde204f871cf7e1288bd50620e6beebb
2024-03-28 11:30:56 -04:00
Uwais Ashraf 1a4052a44f Merge "Remove unused code and fix warnings" into main 2024-03-28 14:03:36 +00:00
Alex Chau 3c34c89cca Align action_buttons at bottom of OverviewActionsView
- http://ag/q/topic:%22b/329255757%22 caused a regression that in landscape, action_buttons shifted up when ShareTarget become visible, because OverviewActionsView become taller when this happens, and the topMargin is no longer valid to put actions_button at the position we want
- Bring back layout_gravity="bottom" solves the issue, as bottomMarign is always correct

Fix: 331517987
Test: manual as ShareTarget requires AiAi interaction and cannot easily be mocked
Flag: None
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:6431d6e87910bc7c7767c40d42f51961dc462134)
Merged-In: Iadcdf5731485f42f9586703e34e55ed9b4121bf9
Change-Id: Iadcdf5731485f42f9586703e34e55ed9b4121bf9
2024-03-28 13:03:03 +00:00
Alex Chau 76d04b46df Merge "Align action_buttons at bottom of OverviewActionsView" into main 2024-03-28 13:00:11 +00:00
Alex Chau 2165ad7b0e Revert "Log split button visibility to debug spacing issue"
This reverts commit 2d55c9c679.

Reason for revert: Logs not helpful in figuring out the issue and is too spammy
Bug: 321291049
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a5d55fe5efad4db1678dfe7960f82df68b664b7d)
Merged-In: I88a4350277ea3e965493da6386cf4c83c5c564e4
Change-Id: I88a4350277ea3e965493da6386cf4c83c5c564e4
2024-03-28 12:13:30 +00:00
Alex Chau c7dea26289 Merge "Revert "Log split button visibility to debug spacing issue"" into main 2024-03-28 12:12:29 +00:00
Schneider Victor-tulias 5a85b4f2df Close the KQS view when touching the gesture nav region
Also, stop handling KQS open/close during gestures

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 328689890
Fixes: 328689534
Fixes: 328692760
Test: attempted gestures while KQS is shown. attempted KQS while attempting gestures
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:14d912b062e69fe8bc4729b6f8b40e53d5b4a669)
Merged-In: Idbd1f9cef09d9fbf611350d0847d94ccf8300369
Change-Id: Idbd1f9cef09d9fbf611350d0847d94ccf8300369
24D1-dev is based on 24Q2-release. Therefore, we merged this CL to 24D1-dev.
2024-03-28 07:27:09 +00:00
wilsonshih cc39a10dd0 Do not report finish in mergeAnimation...
...if the handler don't know how to process the transition.
So the Transitions can pass that transition to next handler.

Flag: NONE
Bug: 328619216
Test: manual, use alt+tab to relaunch a task where it's activity
is destroyed.
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:7130116894eb7f756a16da6b5ff0e754a356d50d)
Merged-In: Idf3f78103a56e91806ec2f6e364c6e8e7f4e205c
Change-Id: Idf3f78103a56e91806ec2f6e364c6e8e7f4e205c
24D1-dev is based on 24Q2-release. Therefore, we merged this CL to 24D1-dev.
2024-03-28 07:21:57 +00:00
Schneider Victor-tulias 3d001dee6b Update KQS task view layouts to new specs
The small size of the screenshots and make text look odd. Implementing new UI specs to improve this.

- Updated icon position and size
- Added some blur to the thumbnail

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 328259439
Fixes: 328692456
Test: opened KQS in dark and light mode
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:dba7cbae1adfde615060598a55b5ee0edfedef9f)
Merged-In: I2b20100ddeb562291edf5f0bacbce916002eee45
Change-Id: I2b20100ddeb562291edf5f0bacbce916002eee45
24D1-dev is based on 24Q2-release. Therefore, we merged this CL to 24D1-dev.
2024-03-28 06:56:20 +00:00
Jeremy Sim de9b132f08 Update save app pair icon
This CL changes the save app pair menu icon to the latest spec. It looks good!

Fixes: 331525186
Flag: N/A
Test: Manual
Change-Id: Ic73f78a27372aca565fce2e3be3e9f3b8ef1d942
(cherry picked from commit 1d48159bd5)
2024-03-28 04:44:18 +00:00
Jeremy Sim 5f9329dccd Fix bug with long strings not aligning left on menu items
This CL sets gravity="start" and ellipsize="end" so that longer strings in the Overview app dropdown menu are still left-aligned and ellipsized when they are longer than the container.

Fixes: 330426535
Flag: N/A
Test: Manual
Change-Id: I1e62412c9b8be41a8dbb6b0597a69a283a56e3f0
(cherry picked from commit 6867b18db2)
2024-03-28 04:44:11 +00:00
Jeremy Sim 75216f9108 Merge "Fix bug with long strings not aligning left on menu items" into main 2024-03-28 01:45:15 +00:00
Jeremy Sim c61f4ede3c Merge "Update save app pair icon" into main 2024-03-28 01:44:55 +00:00
Fengjiang Li 61102b66e8 Merge "Extend CUJ_LAUNCHER_CLOSE_ALL_APPS_BACK to start as early as when user starts predictive back swipe" into main 2024-03-28 01:02:00 +00:00
Luca Zuccarini b65bc82efb Merge "Move interfaces to the shared library." into main 2024-03-28 00:17:47 +00:00
Andy Wickham d6b0dc8970 Merge "Consolidate settings for Assist." into 24D1-dev 2024-03-27 23:56:23 +00:00
Fengjiang Li 10c03e499d Extend CUJ_LAUNCHER_CLOSE_ALL_APPS_BACK to start as early as when user starts predictive back swipe
Bug: 330405993
Test: prefetto trace https://ui.perfetto.dev/#!/?s=58c0513fe0190f84ea1621a96d790a53b83fefc1ee402085b0d75bfc7b51e019
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Change-Id: I76c32975e5ae6dcb0395d2eee68417f761455262
2024-03-27 16:03:47 -07:00
Brian Isganitis 346776b4d6 Merge "Force refresh AllAppsActionManager for tests." into main 2024-03-27 19:25:43 +00:00
Jeremy Sim 1d48159bd5 Update save app pair icon
This CL changes the save app pair menu icon to the latest spec. It looks good!

Fixes: 331525186
Flag: N/A
Test: Manual
Change-Id: Ic73f78a27372aca565fce2e3be3e9f3b8ef1d942
2024-03-27 11:33:26 -07:00