Commit Graph

76729 Commits

Author SHA1 Message Date
Vinit Nayak d0fc718a0a Dismiss split selection for workspace long-press
Bug: 295426148
Test: Enter split contextual from homescreen,
long-press on empty space, split gets dismissed
Flag: ENABLE_SPLIT_WORKSPACE_TO_WORKSPACE

Change-Id: I3a893bea7b22645fe60c65c4c5ab8c2087d769da
2023-10-06 16:05:54 -07:00
Winson Chung 36a9c19487 Merge "Defer nav handle action until after the recents transition is complete" into main 2023-10-06 22:47:32 +00:00
fbaron 263644524e Add screenrecord to testOverviewActionsMenu_iconAppChipMenu
Bug: 303329286
Test: n/a
Flag: no flag
Change-Id: Iab1f9e38ef1d05d56b08f62a5b3b973e96cc6f60
2023-10-06 15:38:08 -07:00
Vinit Nayak 3a3aa518f9 Prevent workspace app icons/widgets from handling long click in split selection
Bug: 295981634
Test: Enter split selection on workspace, long pressing on
app icon or widget does nothing
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE

Change-Id: Ib439249477a7bb8bbbda9fd42e08ab02af7a831b
2023-10-06 15:13:06 -07:00
Andy Wickham 9fbc52f02d Add CUSTOM_LPNH_THRESHOLDS feature flag to customize LPNH
When this flag is enabled, new Developer Options appear which
allow you to customize the slop and timeout to invoke LPNH.

The slop is defined as a multiplier to the default edge slop
(which I discovered while looking into this - it appears to
be intended for touches along the device edge and is 50%
larger than the default touch slop; currently used by Back).

Timeout is defined in milliseconds, defaulting to 400, at least
on my device.

Bug: 301680992
Bug: 300955321
Flag: CUSTOM_LPNH_THRESHOLDS - should be no-op with default off
Test: Manual with flag on and adjusting sliders, and flag off
Change-Id: Iabc7b3706f4fdd6f0392c858b81a856e375ffd51
2023-10-06 15:06:13 -07:00
Ats Jenk 186e60e94c Merge changes from topic "overview-to-desktop" into main
* changes:
  Account for freeform tasks being visible in overview
  Enable live tile for desktop
2023-10-06 22:05:06 +00:00
Vinit Nayak 114293fb56 Disallow taskbar long click when in split selection state
* This is specifically when contextual is initiated on home
screen and then user swipes up into overview.
* We no longer want to rely on LauncherStates for split specific
management

Bug: 295981634
Test: Start split on home, swipe up to overview, long press on
taskbar app icons, nothing happens
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE

Change-Id: I9e56ddbe1f536be779d4848769a993724d5395da
2023-10-06 14:42:22 -07:00
Vinit Nayak 1525cd7269 Add method to determine if launcher is in split selection state
* Available for both launcher and taskbar via
ActivityContext

Bug: 295981634
Change-Id: I8767deea0b2432da3047209037874c966b83c3b3
2023-10-06 14:40:49 -07:00
Sunny Goyal 576f7a5e80 Removing some usage of shared prefs
Bug: 301661768
Test: Presubmit
Flag: N/A
Change-Id: I158e9a5148d2c9404ea4d2e9e239696b29dbeb20
2023-10-06 14:35:56 -07:00
Brian Isganitis 447b09057a Merge "Prevent NPE from changing all apps visibility in shared state." into main 2023-10-06 20:59:33 +00:00
Brian Isganitis f79785065b Merge "Have dragged search items return to All Apps icon if cancelled." into main 2023-10-06 20:44:06 +00:00
Federico Baron 0bd2c4ea75 Merge "Add smartspace removal option as a toggle" into main 2023-10-06 20:35:14 +00:00
Federico Baron 97789c9c5e Merge "Add flag for smartspace removal toggle" into main 2023-10-06 20:35:14 +00:00
Vadim Tryshev acfb180a3d Merge "Next batch of modifications to ignore-lists of anomaly detectors" into main 2023-10-06 20:33:52 +00:00
Schneider Victor-tulias 8265d04e0a Merge "Fix NullPointerException in OverviewInputConsumer" into main 2023-10-06 20:30:39 +00:00
Bill Yi 0754559171 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Iad07a789f62865e2a190dc47d41f2310a166f64c
2023-10-06 13:16:51 -07:00
Bill Yi 50f8bed76f Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I188b2bc905489318760cbe5869deef836d2e04b2
2023-10-06 13:16:06 -07:00
Vinit Nayak 4a926d3bfd Null reference to activity as runnable back handler
Bug: 302551868
Change-Id: Ia21c5696ef58c113a8d038cb0f8dfef413d991de
2023-10-06 11:15:14 -07:00
Vadim Tryshev 75fae9b0b4 Next batch of modifications to ignore-lists of anomaly detectors
Bug: 286251603
Test: presubmit
Flag: N/A
Change-Id: Ic5eb0a7bfa95c5a3cd890582e7ddf3de2f2bda1c
2023-10-06 11:00:01 -07:00
Brian Isganitis 96224ef755 Merge "Migrate Kotlin tests to use mockito-kotlin2." into main 2023-10-06 17:54:56 +00:00
Sunny Goyal b34296face Merge "Making AsyncClockEventDelegate a singleton" into main 2023-10-06 16:58:41 +00:00
Schneider Victor-tulias 4a0a867dcc Merge "Fix NullPointerException in RotationHelper" into main 2023-10-06 15:21:32 +00:00
Vinit Nayak 0f9d9a825f Merge "Null reference to split callback" into main 2023-10-06 14:21:18 +00:00
Xin Li 4794801b4b [automerger skipped] Merge "Merge Android 14" into main am: 691104e82e -s ours am: b80f0cf7a4 -s ours am: 5974c63c48 -s ours am: bf38b4f81d -s ours
am skip reason: Merged-In If4c6783472d7fa05a1162e2f176a613d28f7bec3 with SHA-1 20d7edb05f is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2776973

Change-Id: Id3019f036205ae016f1c05bb1ab3b090b1a5d0d3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-06 11:04:50 +00:00
Xin Li 3ef97638da [automerger skipped] Merge Android 14 am: f3d805e7f2 -s ours am: 51c4ef1a3f -s ours am: 9cb6abcd09 -s ours am: 267ff14379 -s ours
am skip reason: Merged-In If4c6783472d7fa05a1162e2f176a613d28f7bec3 with SHA-1 20d7edb05f is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2776973

Change-Id: I143a1d62f0615dadbc4d7d6bdb3a4b867a486b5d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-06 11:00:08 +00:00
Xin Li bf38b4f81d [automerger skipped] Merge "Merge Android 14" into main am: 691104e82e -s ours am: b80f0cf7a4 -s ours am: 5974c63c48 -s ours
am skip reason: Merged-In If4c6783472d7fa05a1162e2f176a613d28f7bec3 with SHA-1 20d7edb05f is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2776973

Change-Id: I5ead25f75b7bde52041674ea8038af400005f12f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-06 09:54:58 +00:00
Xin Li 267ff14379 [automerger skipped] Merge Android 14 am: f3d805e7f2 -s ours am: 51c4ef1a3f -s ours am: 9cb6abcd09 -s ours
am skip reason: Merged-In If4c6783472d7fa05a1162e2f176a613d28f7bec3 with SHA-1 20d7edb05f is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2776973

Change-Id: I55f5a7fb113fc4e66ec19ce6c87f151dd64dab6d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-06 09:50:16 +00:00
Xin Li 5974c63c48 [automerger skipped] Merge "Merge Android 14" into main am: 691104e82e -s ours am: b80f0cf7a4 -s ours
am skip reason: Merged-In If4c6783472d7fa05a1162e2f176a613d28f7bec3 with SHA-1 20d7edb05f is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2776973

Change-Id: I21f6ec292c3cf5bed714fb32beaf0a8dc5ed9085
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-06 09:03:04 +00:00
Xin Li 9cb6abcd09 [automerger skipped] Merge Android 14 am: f3d805e7f2 -s ours am: 51c4ef1a3f -s ours
am skip reason: Merged-In If4c6783472d7fa05a1162e2f176a613d28f7bec3 with SHA-1 20d7edb05f is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2776973

Change-Id: I92a8bf4e00370ef504bb5ef94e337ddffa995b44
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-06 08:58:35 +00:00
Xin Li b80f0cf7a4 [automerger skipped] Merge "Merge Android 14" into main am: 691104e82e -s ours
am skip reason: Merged-In If4c6783472d7fa05a1162e2f176a613d28f7bec3 with SHA-1 20d7edb05f is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2776973

Change-Id: I7f42cff8cb3128405ec0e4796d7c6d2ec52572f0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-06 07:56:17 +00:00
Xin Li 51c4ef1a3f [automerger skipped] Merge Android 14 am: f3d805e7f2 -s ours
am skip reason: Merged-In If4c6783472d7fa05a1162e2f176a613d28f7bec3 with SHA-1 20d7edb05f is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2776973

Change-Id: I7d5f683282814ee7027086aee356e9bf0bca3380
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-06 07:51:36 +00:00
Tracy Zhou cfbf3ff695 Set correct stashed task(nav) bar height with taskbar/navbar unification
Again caused by DeviceProfile not initiating task bar stashed and unstashed height in folded state with unification code

Test: Make sure that task(nav) bar has the correct height in both folded and unfolded state
Bug: 274517647
Change-Id: I0d86cfccc6f096bc983f87c57fdfac9800fd4d41
2023-10-05 22:51:10 -07:00
Xin Li 691104e82e Merge "Merge Android 14" into main 2023-10-06 05:34:30 +00:00
Winson Chung 4f17c97d03 Defer nav handle action until after the recents transition is complete
Bug: 303078360
Test: Force delay in finishing recents transition and verify with bug steps
Change-Id: I2021cc291204261de56ef9c912d8b5935059c7fb
Signed-off-by: Winson Chung <winsonc@google.com>
2023-10-06 03:42:35 +00:00
Vinit Nayak a7b491e35e Null reference to split callback
Bug: 302551868
Test: Ran atest NexusLauncherTests:com.android.quickstep.TaplTestsSplitscreen
which caused some regressions last time. Passed locally

Change-Id: I94b28296cf12c5087ee3e878352c057d1d1a73de
2023-10-05 17:22:46 -07:00
Tracy Zhou 0812a9495c Fix task bar crashing in small screen with task bar / nav bar unification on
A few params are not set in device profile when task bar (in large screen) is not present, and hence the calculation below causes a crash

Test: Make sure that it doesn't crash in small screen gesture nav mode
Bug: 274517647
Change-Id: I3a61a64ac931fac4aee1a3c40ed54ab9ded298a7
2023-10-05 16:40:48 -07:00
Tracy Zhou 528356e744 Merge "Fix task bar crash in gesture nav mode with task bar / nav bar unification on" into main 2023-10-05 23:38:13 +00:00
Android Build Coastguard Worker 4a28f3b164 Snap for 10909010 from bf4a08acef to udc-qpr1-release
Change-Id: Ia915aac23b5831ad65b7f214e83320cfb41db3fe
2023-10-05 23:19:19 +00:00
Ats Jenk 0927251a7b Account for freeform tasks being visible in overview
When live tiles are enabled, desktop tasks remain visible while in
overview. This is due to tasks remaining in running state.
Update DesktopVsibilityController to handle this case. If in freeform,
it should return that freeform tasks are not visible to any callers.
Also move launcher state handling to inside the controller so we don't
have this handling in other places.
Introduce separate handling of background and overview state. In
background state we want to keep the freeform task visibility state
matching the actualy visibility. And show the launcher views and resume
the activity.
In overview state we want to override the freeform visibility and show
launcher views.

Bug: 297590571
Test: open an app on desktop
      - swipe up for taskbar multiple times, observe that we remain on
        desktop
      - swipe up for taskbar and launch an app, observe it launches on
        desktop
      - swipe up to recents, observe that recents UI is shown and task
        remains running
      - swipe up to recents, launch desktop again from recents
      - swipe up to recents, launch another fullscreen app from recents
      - swipe up from a fullscreen, launch desktop from recents
Change-Id: Id5cef7111da6929c8435ef9d221db1abd8361b15
2023-10-05 15:53:42 -07:00
Xin Li f3d805e7f2 Merge Android 14
Bug: 298295554
Merged-In: If4c6783472d7fa05a1162e2f176a613d28f7bec3
Change-Id: I63fb79ae0ea2c39d65ca17fcaa34a8e3b993619f
2023-10-05 15:41:41 -07:00
Fengjiang Li 25eac1381f Double pre-inflate counts if work profile is enabled
When work profile is enabled, we will show 2 all apps recycler views, thus we should double the pre-inflated BubbleTextView count to make sure scrolling both personal and work all apps is smooth.

Traces are attached in bug.

Fix: 287462835
Test: Grab perfetto traces and compare scrolling all apps on phone with work profile enabled vs disabled
Change-Id: Iaa68ddacad0abcca0f260dd7fa21c92d2feabb03
2023-10-05 14:53:30 -07:00
Stefan Andonian 9acb884c90 Merge "Permanently provide functionality for LauncherPref items that don't need to be migrated, but are boot aware." into main 2023-10-05 21:14:24 +00:00
Andy Wickham 57fd004867 Merge "Add awickham to OWNERS file" into udc-qpr-dev am: bf4a08acef am: 3f42cf5fea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24955693

Change-Id: I592f78bb1d54027ae00ec3a101681df59cf9e405
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 21:12:33 +00:00
Sunny Goyal 6ad6cfa300 Merge "Removing unused interfaces from Launcher" into main 2023-10-05 21:00:49 +00:00
Andy Wickham 3f42cf5fea Merge "Add awickham to OWNERS file" into udc-qpr-dev am: bf4a08acef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24955693

Change-Id: I97341587170042a3731440fb3917884bac517514
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 20:42:22 +00:00
Sebastian Franco 0b30453722 Move test from TaplTestsLauncher3 to TaplUninstallRemove
Bug: 298234173
Test: atest TaplUninstallRemove
Change-Id: I80fe1c73d08fcf1e310b86a8662c13a8775ade6e
2023-10-05 20:34:06 +00:00
Sunny Goyal df178f5320 Making AsyncClockEventDelegate a singleton
RemoteViews can get inflated after the activity is destroyed during
async inflation. This can cause the delegate to loose the destroy event.

Bug: 303686041
Test: Presubmit
Flag: N/A
Change-Id: Iecb9d69d95b2c924e1189ac15515fac327d8f44d
2023-10-05 13:23:58 -07:00
Stefan Andonian 23f869f0f0 Merge "Don't show FloatingIconView during Back to Home Animation when animations are disabled." into main 2023-10-05 20:22:49 +00:00
Andy Wickham bf4a08acef Merge "Add awickham to OWNERS file" into udc-qpr-dev 2023-10-05 20:07:25 +00:00
Sebastián Franco 4823dca49e Merge "Moving tests form TaplTestsLauncher3 to TaplTestsAllAppsIconsWorking" into main 2023-10-05 19:56:58 +00:00