Commit Graph

76729 Commits

Author SHA1 Message Date
Vinit Nayak e489bd45e6 Merge "Call split finish callback if split invocation fails" into main 2023-10-11 23:33:18 +00:00
Stefan Andonian 3925bdfdf8 Merge "Remove some direct usage of getDevicePrefs()" into main 2023-10-11 23:09:26 +00:00
Stefan Andonian 2171d09fe6 Remove some direct usage of getDevicePrefs()
Bug: 261635315
Test: Manually did testing on device.
Change-Id: I47c88bdc031d330f6efa573411ab5dbf154ec8a2
2023-10-11 23:06:41 +00:00
Tracy Zhou 0dbcbfc08f Merge "Fix transient task bar not automatically stashed in app when ENABLE_TASKBAR_NO_RECREATION is enabled" into main 2023-10-11 22:19:43 +00:00
Charlie Anderson 102a06f810 Merge "Fix status bar flicker on adding widgets requiring configuration." into main 2023-10-11 22:00:40 +00:00
Treehugger Robot bcd5555863 Merge "Adding Mateusz as an OWNER for Launcher tests" into main 2023-10-11 21:53:30 +00:00
Vadim Tryshev e86761a225 Adding Mateusz as an OWNER for Launcher tests
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I07a891fe766549208e4402726ee66998db22956d
2023-10-11 14:48:17 -07:00
Jon Miranda 1e931890d1 Fix bug where All Apps button loads in late in taskbar.
We need to re-create the icon alignment controller if the
stash status changes, otherwise it will use an old value.

Bug: 296414290
Test: home to app then quickly unstash
Change-Id: I35f23842f289fce95d102a9a93dc94cd033fa8cc
2023-10-11 13:28:08 -07:00
Vadim Tryshev 9bf8a4bbc1 Merge "Moving verifyKeyguardInvisible() after other initializations" into main 2023-10-11 20:17:04 +00:00
Jeremy Sim 271fc9540c Merge "Set up to use aconfig flags from WM Shell" into main 2023-10-11 19:21:00 +00:00
Vadim Tryshev 4c3757dd2b Merge "Improving diagnostics from fallback recents tests when phone is not unlocked" into main 2023-10-11 18:50:37 +00:00
Schneider Victor-tulias 276420a869 Merge "Fix janky Alt+Tab through overview animation" into main 2023-10-11 18:28:10 +00:00
Tracy Zhou fbc01a0b4f Fix transient task bar not automatically stashed in app when ENABLE_TASKBAR_NO_RECREATION is enabled
Currently the task bar root layout consumes all the events and does not pass the events to drag layer, without explictly routing those events

Fixes: 303910224
Test: go to an app, swipe home, and then go back to the app. Make sure the task bar is stashed
Change-Id: I6f5e481c267dad25544118134ff95b0cb9bb1a45
2023-10-11 11:25:45 -07:00
Alex Chau 6ae2c4d77d Merge "Revert "Revert "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag""" into main 2023-10-11 15:38:57 +00:00
Vinit Nayak 77ce4c261e Merge "Update API for OneShotRemoteHandler" into main 2023-10-11 15:13:25 +00:00
Vinit Nayak c4f653c24c Merge "Null out context for all split controllers" into main 2023-10-11 15:12:24 +00:00
Alex Chau 4989f4f36d Revert "Revert "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag""
This reverts commit 7b5472f986.

Reason for revert: aconfig/SetFlagsRule actually works with TAPL tests (http://ag/c/platform/packages/apps/Launcher3/+/24991890/comment/8303a3c6_030ae00b/)
Bug: 270397206

Change-Id: I7529a64c3197e4c2b4d5fb1e46fb29bdea1e52e9
2023-10-11 14:08:22 +00:00
Riddle Hsu 681f340d7d Finish recents animation for standalone recents on home
There was a check from RunningTask to avoid using transient-launch
when launching recents activity on a 3rd party home. But the info
may not be updated in time (from TaskStackChangeListener) if there
are several changes happen in a short time.

Then it may misjudge that home is still on top but the current top
is a normal app. Then the app will be paused unexpected because
setTransientLaunch() is not called.

Since FLAG_MOVED_TO_TOP is introduced, task reorder will also be
collected in transition, so the check of isHomeTask is longer needed.
But RecentsTransitionHandler still needs to cooperate with it about
how to animate the merging animation while recents animation is running.
To simplify it, just finish the recents animation when recents activity
is launched on top of home activity, i.e. consider it as a regular
launch because only the recents activity is on top and there are no
other apps need to keep visible for live-tile.

Note that setTransientLaunch() is still called for the case. However
its effect will be gone after the transition is finished.

This can also fix various issues when using a 3p launcher:
 - When auto rotation is enabled and put device in landscape:
    - Unable to enter recents from gesture mode
    - System bars are disappeared when pressing recents key
 - Jump-cut when pressing home key to leave recents on home.

Bug: 302703228
Bug: 294029838
Test: WindowInsetsBehaviorTests
Test: Rapidly click navigation bar while a regular app is on top.
      The app should not receive onPause.
Change-Id: I9ba9bdb3757bbdcb1cbb363b4fe6431860dac4da
2023-10-11 18:46:35 +08:00
Hyunyoung Song e0a25fbd51 Merge "Add CUSTOM_LPNH_THRESHOLDS feature flag to customize LPNH" into main 2023-10-11 07:54:26 +00:00
Tracy Zhou 9633e5b74c Merge "Fix phone mode task bar inset values not correctly initialized" into main 2023-10-11 05:32:09 +00:00
Vinit Nayak def3e9d7f4 Call split finish callback if split invocation fails
Bug: 295981634
Test: Splitting w/ Google TV widget no longer
keeps placeholder views on screen
Flag: ENABLE_SPLIT_WORKSPACE_TO_WORKSPACE

Change-Id: I1d4df9deb9aaaaeef3741a05130429d0091293e8
2023-10-10 21:01:35 -07:00
Vinit Nayak a439c912d8 Null out context for all split controllers
* Destroy context for AppPairsController and
SplitSelectDataHolder

Bug: 302551868
Change-Id: I5636ecf50d51ad383ac89a457697984bc8d907ca
2023-10-10 20:42:42 -07:00
Vadim Tryshev f782eaba73 Improving diagnostics from fallback recents tests when phone is not unlocked
Failing earlier so that we don't get strange messages from the middle of the test.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I1e3c70623e6f907bcc6bd0486b6c75afecb610e3
2023-10-10 19:18:22 -07:00
Krzysztof Kosiński c1d05a7101 Merge "Clean up obsolete aliases for Truth." into main am: a4bc505d01 am: 6247399c9b am: f56d690e22 am: 42c39649a7 am: b085f9e819
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2778094

Change-Id: Id239979be76a11ce08d564c13f174aa5d02deb3f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-11 00:16:49 +00:00
Automerger Merge Worker d12de08601 Merge "[automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 53bc743c58 -s ours am: 2e3aea5133 -s ours am: 2d42f8724e -s ours" into udc-qpr-dev-plus-aosp am: 281ad63c31 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24975341

Change-Id: I45649ea677a532e7c31ba7e8f3b779c2b7728bb0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-10 23:42:43 +00:00
Bill Yi 67af07f460 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 53bc743c58 -s ours am: 2e3aea5133 -s ours am: 2d42f8724e -s ours am: 5adb4d0f59 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24975341

Change-Id: Ie4fbc3742037475b5009b0fe84df57856b7d93c5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-10 23:42:31 +00:00
Vadim Tryshev 3c1def4810 Moving verifyKeyguardInvisible() after other initializations
verifyKeyguardInvisible can fail, and then tear down will be called,
potentially accessing fields that currently get assigned after this
call, causing crashes.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I865dfd70ce1821cee26800f57a13fb202626ea84
2023-10-10 16:37:14 -07:00
Automerger Merge Worker d31ef63ae0 Merge "[automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 53bc743c58 -s ours am: f145e084cc -s ours am: a2a4b84db1 -s ours" into udc-qpr-dev-plus-aosp am: 644a5bd5b4 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24975341

Change-Id: I5aedd906a161051723f5cb660fea2be59de69c2a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-10 23:35:19 +00:00
Bill Yi 2c74d95768 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 53bc743c58 -s ours am: f145e084cc -s ours am: a2a4b84db1 -s ours am: 9909efb8d5 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24975341

Change-Id: I6ef62cbff5140a69698bf3cf90bcdd3230265040
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-10 23:35:05 +00:00
Android Build Coastguard Worker 3ab5d0697b Snap for 10928679 from a2a4b84db1 to udc-qpr1-release
Change-Id: I42d51b3e663c6f962023a0d195cb497bf5528be2
2023-10-10 23:20:18 +00:00
Bill Yi b0a593cffe [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 53bc743c58 -s ours am: f145e084cc -s ours am: 4113114d9c -s ours am: f0f05a30dc -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24975341

Change-Id: Ibed3e3b47ec08feed404da7a6347258ab780dc45
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-10 23:19:49 +00:00
Automerger Merge Worker 39c1a9ab23 Merge "[automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 3b26a6ef18 -s ours am: dae4fd731e -s ours" into udc-qpr-dev-plus-aosp am: 1ba2273553 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24975342

Change-Id: I5f0e857aae34bdbe00f30d17cab2abdd6be668c3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-10 23:17:00 +00:00
Bill Yi f9a36cf5bc [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 3b26a6ef18 -s ours am: dae4fd731e -s ours am: e96a39e257 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24975342

Change-Id: I41b94e6402197a150495cc1b347db53e30f0e5b6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-10 23:16:45 +00:00
Bill Yi ab83e65451 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 3b26a6ef18 -s ours am: 4c74dcb8f2 -s ours am: b621499fde -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24975342

Change-Id: I53293b4c4d35f567095db16dbd8ba2cf8ea2bd97
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-10 23:08:30 +00:00
Jagrut Desai 8e4077f8cd Adding test protocol support for getting num all apps columns
Test: Presubmit
Bug: 303257279
Flag: not needed
Change-Id: I9c6299fb3ff077bc42ca22609d2ff0232377a370
2023-10-10 16:07:51 -07:00
Vinit Nayak e83b08ff6e Update API for OneShotRemoteHandler
* All no-ops except SplitSelectStateController

Bug: 295981634
Change-Id: Idabe80951ceb2b0a980f3179366d75fc064c69ec
2023-10-10 15:41:26 -07:00
Jeremy Sim 9e44e378bb Set up to use aconfig flags from WM Shell
This CL allows Launcher and Launcher test files to use aconfig flags from WM Shell.

Bug: 304597782
Test: N/A
Change-Id: I291b744207ec07d5955814879987c15f4aa13140
2023-10-10 15:16:53 -07:00
Krzysztof Kosiński b085f9e819 Merge "Clean up obsolete aliases for Truth." into main am: a4bc505d01 am: 6247399c9b am: f56d690e22 am: 42c39649a7
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2778094

Change-Id: Idc45788d21959e1569e0fd33686536a9675442ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-10 21:50:07 +00:00
Krzysztof Kosiński 42c39649a7 Merge "Clean up obsolete aliases for Truth." into main am: a4bc505d01 am: 6247399c9b am: f56d690e22
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2778094

Change-Id: Ief1a7711ee66ce89708ed9bb0daed55471383329
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-10 21:17:18 +00:00
Krzysztof Kosiński f56d690e22 Merge "Clean up obsolete aliases for Truth." into main am: a4bc505d01 am: 6247399c9b
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2778094

Change-Id: I60a48030963d6f2e9ddd090e0438bd3b0ba714ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-10 20:10:09 +00:00
Tracy Zhou de28c115b2 Fix phone mode task bar inset values not correctly initialized
We rely on contentHeightToReportToApps and tappableHeightToReportToApps (that ultimately call into DeviceProfile) of TaskbarStashController to initialize the insets. However, DeviceProfile only initializes those values when isTaskbarPresent is true. Rather than completely changing the initialization of DeviceProfile, we special case in TaskbarStashController that uses the bar height for inset

Bug: 274517647
Test: turn on FLAG_HIDE_NAVBAR_WINDOW and TASKBAR_NO_RECREATION, make sure the insets are correct in both 3 button and gesture nav mode
Change-Id: I164a6e2c9f9d24888155b45325ee8ce46ca2c39f
2023-10-10 13:02:16 -07:00
Krzysztof Kosiński 6247399c9b Merge "Clean up obsolete aliases for Truth." into main am: a4bc505d01
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2778094

Change-Id: Ic9eed67c9957d2702a0b01319dc63688189f3963
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-10 19:36:40 +00:00
Bill Yi 9f34a29d0e Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-10-10 19:29:49 +00:00
Bill Yi 7991a8ed41 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-10-10 19:29:49 +00:00
Jeremy Sim df55a762fe Merge "App Pairs: Implement app pairs icon" into main 2023-10-10 19:15:20 +00:00
Sunny Goyal cd44740567 Moving onboarding prefs to use LauncherPrefs
Bug: 301661768
Test: Presubmit
Flag: N/A
Change-Id: Iec8a5e739f394a152d5ffc57b01e0449e94b4084
2023-10-10 11:47:33 -07:00
Sunny Goyal b834d6eca8 Merge "Removing some usage of shared prefs" into main 2023-10-10 18:44:15 +00:00
Krzysztof Kosiński a4bc505d01 Merge "Clean up obsolete aliases for Truth." into main 2023-10-10 18:28:25 +00:00
Jagrut Desai 3872759957 Merge "Stop Active Gesture Error Detection for Non Gestural Navigation Mode" into main 2023-10-10 17:32:47 +00:00
Federico Baron e221945296 Merge "Add NullPointerException to try/catch since it's possible to have such an error" into main 2023-10-10 17:01:15 +00:00