In SplitScreenController#onStartingSplitLegacy, it also ignores:
if (ENABLE_SHELL_TRANSITIONS) return null;
This avoids a latency from the 2-way IPC in
RecentsAnimationListener#onTasksAppeared.
Bug: 275508603
Test: Capture trace when switching app by quickstep.
Change-Id: Ia11cbca0d38cdc2bfd676dfa3d59a5c8931a2d6e
When the dark night mode switch is triggered,systemui calls binder
to the onNavigationBarSurface method in the launcher and applies the
surfaceController.
Keep switching,you will keep applying,resulting in more surface
objects. The behaviour would cause that SurfaceFlinger couldn't
remove the unnecessary navigationbar layers timely and the
navigationbar layer would leak in SF.
Actively release the SC after using the SC in the launcher.
Bug: 317336417
Test: 1.Launch the settings app
2.Click Display menu
3.click the dark theme menu multiple times
4.Check whether the surfaceController is released
adb shell "ls -l/proc/904/fd|wc -l"
Change-Id: Ic449de9dbe0c52e0053be91e67ee9081a574581b
This change adds RTL support for the back gesture icon on the main menu
of the gesture tutorial menu. In RTL mode, it was previously rendering
in the middle of the screen.
Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 309564541
Test: ran the tutorial in RTL mode in different form factors.
Change-Id: I24def01ed205355ced23060068ddd74af61134ab
lintable modules currently pick up files named "lint-baseline.xml" to use as the
lint baseline implicitly. This is confusing because you could end up using the
baseline files in more modules than intended. Lint also has a feature where it
requests you remove unnecessary findings from the baseline file, so something
could be necessary for one module, but unnecessary for another that accidentally
picked up the baseline.
We're removing the implicit detection of the baseline file, which requires
all modules using it to list the baseline file explicitly.
Bug: 272769514
Test: Presubmits
Change-Id: Idcd6b8c8868b05a34fe621c5c05aa21cc1f149ea
Merged-In: Idcd6b8c8868b05a34fe621c5c05aa21cc1f149ea
The change around configuration and display cutout to support flexible
display setup is making the received display info is not calculated as
the hard-coded way in taskbar. It will cause the taskbar recreated when
the device reaches a given rotation for the first time.
The recreation is not necessary as it is only a hint of taskbar's
estimation doesn't match the result. Block the recreation in that case
to avoid user visible animation issue.
Bug: 302387383
Test: Rotate a device with movable cutout and no recreation happens
Flag: ACONFIG com.android.window.flags.allows_screen_size_decoupled_from_status_bar_and_cutout TRUNKFOOD
Flag: ACONFIG com.android.window.flags.movable_cutout_configuration DEVELOPMENT
Change-Id: I1aa6add57ec49a49cc7473bfaada6d9212c1fc4b
Previously this used the content description which was generally the
same as the displayed text with whitespace adjustments + additional
text (e.g. "Play Store has 7 notifications").
That worked fine, but I thought it would be a bit more robust to work
with the text directly. Specifically, we consider it a match if all
of the non-whitespace characters are there, along with optional added
whitespace between characters. See TaplUtilityTests for examples.
More importantly for the other change in this topic, this Pattern is
also used for search result icons, to allow those tests to pass with
multiline labels enabled.
Bug: 315053839
Flag: LEGACY ENABLE_TWOLINE_DEVICESEARCH ENABLED
Test: Manual and TaplTestsTaskbarSearch + other unit tests
Change-Id: I4ad52840d743f06576d415f4e5ea6d8870e5dd2c
This CL fixes several issues:
- When launching an app pair on top of the exact same app pair, Overview no longer enters a broken state
- When launching another app quickly after launching an app pair, splitscreen no longer breaks
Fixes: 315190686
Test: Launch app pair and then launch same app pair again from Taskbar -- Overview does not break
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Change-Id: I0d474dd89359e1a10a881c5cf8deee64754219c3
lintable modules currently pick up files named "lint-baseline.xml" to use as the
lint baseline implicitly. This is confusing because you could end up using the
baseline files in more modules than intended. Lint also has a feature where it
requests you remove unnecessary findings from the baseline file, so something
could be necessary for one module, but unnecessary for another that accidentally
picked up the baseline.
We're removing the implicit detection of the baseline file, which requires
all modules using it to list the baseline file explicitly.
Flag: None
Bug: 272769514
Test: Presubmits
Change-Id: Idcd6b8c8868b05a34fe621c5c05aa21cc1f149ea
There is a 1dp gap on left/top/right/bottom between widget resize frame and widget background. Increasing the margin by 1dp will fill this gap.
Fix: 291104076
Test: See https://b.corp.google.com/issues/291104076#comment9
Flag: NA
Change-Id: I05143d76c98de7bbcfdca5cfacb21b3ace669861
A slow UI thread can cause the first ACTION_DOWN motion event to be handled as a long click before the pointer can be moved for a swipe. Directly using ACTION_SCROLL instead of the usualy ACTION_DOWN/MOVE/UP flow that is sensitive to lag.
Flag: N/A
Bug: 315379864
Test: TaplWorkspaceTest, TaplTwoPanelWorkspaceTest
Change-Id: Ib7fa8c88c953a55b8923ce6a104b5c205c129173
Before we only checked if live tile drawing was enabled at the
start of the dismiss animation, and didn't add the frame callback
listener at all if not. Now we always add the frame callback
listener when dismissing the running task, and check if live tile
drawing is enabled within the listener in case there is a race.
Fixes: 312261719
Test: Swipe up to Overview from an app, immediately swipe up to
dismiss the app; ensure it always follows your finger
Flag: None
Change-Id: Ia12b02d5989c09d2104edd202f8c016f202f76b8
Fengjiang Li
Vadim Tryshev
Android Build Coastguard Worker
Yunfan Chen
Bill Yi
Saumya Prakash
Brandon Dayauon
Uwais Ashraf
Riddle Hsu
chuanghua.zhao
Tony Wickham
Treehugger Robot
Cole Faust
Liran Binyamin
Johannes Gallmann
Jeremy Sim
Andy Wickham
Shamali Patwa
Schneider Victor-tulias
Brian Isganitis
Pat Manning
Jagrut Desai