Commit Graph

76729 Commits

Author SHA1 Message Date
Tony Wickham c5d4e4dcf5 Fix KI in test and re-enable for postsubmit.
- The taskbar stashing logic with hardware keyboards was different
  between tests and user experience; aligned the test to be the
  same.
- There is still a previous test failure that only occurred in
  post submit, so also add ScreenRecord to diagnose it
- Once that is resolved, can promote the test to PRESUBMIT.

Test: testQuickSwitchToPreviousAppForTablet
Flag: NA
Fixes: 318544733
Bug: 314873201
Change-Id: Ia813eb0294d759c40d90cec7a8e9a7e0aea2d917
2024-01-03 23:27:18 +00:00
Vinit Nayak e363a611d2 Null out launcher reference to prevent leak
Bug: 314806687
Flag: None
Test: Enabled flag and played with taskbar/home transitions,
seemed fine

Change-Id: I86ab417eccf1fd6255195025890a1b93bf5d3bb4
2024-01-03 15:08:47 -08:00
Andy Wickham 60dcb19a48 Merge "Better handling of insets for All Apps." into main 2024-01-03 22:34:36 +00:00
Federico Baron 8d23a6762d Merge "Fix IllegalArguemntException for ClipIconView#update" into main 2024-01-03 22:28:00 +00:00
Charlie Anderson 1fcf8da4e5 Adds restore metrics to RestoreDbTask.java
Bug: 307527314
Flag: ACONFIG enable_launcher_br_metrics TEAMFOOD
Test: locally verified
Change-Id: I105b17276cf7e2c270c819854a8fbc269b7c81b4
2024-01-03 22:06:44 +00:00
Tracy Zhou e1c3332532 Merge "Correct contextual button width, height and touch area" into main 2024-01-03 21:11:24 +00:00
Vadim Tryshev 6741d1affc Ignoring testQuickSwitchToPreviousAppForTablet
It fails on some targets

Test: presubmit
Flag: N/A
Bug: 318544733
Change-Id: Ia6e34f81942b3e911b637cd66eae4362e633eee5
2024-01-03 12:58:57 -08:00
fbaron 3b894e1f70 Fix IllegalArguemntException for ClipIconView#update
The scale was infinity sometimes which means that the view minSize is probably getting set to 0 due to lp height and width being 0, so we do not update the views as they are no longer laid out

Flag: NONE
Test: Opening apps should work fine, but i wasn't able to repro this exception before or after this fix
Fix: 318099222
Change-Id: I1c08346c7ee1d4e89d9c3ba23ee2aa51a451cb31
2024-01-03 12:44:10 -08:00
Sergey Pinkevich 9b6587d80f Wrong app icon position in seascape mode for RTL layout
Bug: 317072320
Test: manual
Flag: NONE

Change-Id: If998033d6008626941eb766dcc96803c25b8bf02
2024-01-03 19:28:52 +00:00
Andy Wickham 99d7d4f2cb Better handling of insets for All Apps.
Changes:
 - For tablet, always center All Apps without applying additional
   insets for things like cutouts.
 - For tablet, allow the panel to span the full height of the
   screen (minus system bars), rather than 5.5 app rows. This also
   ensures the panel fully closes even if there are cutouts.
 - Remove additional padding for vertical bar mode (landscape on
   phones). This was double counting the cutout insets, but only
   for some views, so things were not aligned. Now the apps line
   up with the search bar, and the scroll bar still makes room for
   any side insets.

Before and after examples:
https://drive.google.com/drive/folders/1k0vSzisf4ZuGyp-qR-IF0QwM-IcHBFrZ?resourcekey=0-uxjzuVQ1KA3WwOQ4v6Dh2w&usp=drive_link

Bug: 299923399
Bug: 259617884
Fix: 300761324
Test: Manual
Flag: NA
Change-Id: I136d516260a1343b1198693c73fa389fe0e11cc9
2024-01-03 19:21:01 +00:00
Sergey Pinkevich c7dcb95b4c Java crash on RecentsView.isTaskViewVisible method
Bug: 316567614
Flag: NONE
Test: manual

Change-Id: I8e7a47a06a94ce0d9eb5921020cb19097873e8c4
2024-01-03 19:20:46 +00:00
Helen Cheuk df20ea0ed4 Merge "Update BubbleTextView height to match parent so focus outline drawn could be fully displayed" into main 2024-01-03 18:38:29 +00:00
Vinit Nayak 05d5424049 Merge changes I21801b63,I017f1d55 into main
* changes:
  App pairs: themed icons
  Fix bug where app pair icons were appearing empty
2024-01-03 18:26:04 +00:00
Vadim Tryshev 943843a239 Merge "Re-promoting some tests to postsubmit" into main 2024-01-03 18:25:59 +00:00
Rohit Goyal 2e6010c421 Add support for progress bar during unarchival of app.
* With this change, progress bar should appear whenever app update for archived app reaches non-zero progress.
* Once the update is cancelled, the progress bar should also disappear.

Test: PromiseIconUiTest and manually tested the progress bar using Play Store
Bug: 302115555
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: Iacf7a0fd865dba34915fa09f59c63a1da6e47315
2024-01-03 23:44:52 +05:30
Sunny Goyal 05dc6db762 Merge "Fix launcher holds a surfaceController" into main am: 4b48398352 am: 507cccdb17 am: cb1fc471bb
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2891611

Change-Id: Ib1b0eae5c1664f202312109da2391a250607108b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-03 17:59:03 +00:00
Sunny Goyal cb1fc471bb Merge "Fix launcher holds a surfaceController" into main am: 4b48398352 am: 507cccdb17
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2891611

Change-Id: I5a9c74659439b1dd04e124f9191796bc348d97f6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-03 17:25:19 +00:00
Jagrut Desai 39e4b611b5 Merge "Refactor TaskbarDividerPopup Open/close animation" into main 2024-01-03 17:00:52 +00:00
Sunny Goyal 507cccdb17 Merge "Fix launcher holds a surfaceController" into main am: 4b48398352
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2891611

Change-Id: I1b9beba5e4ff06b338bc10ed618f60338e6e8d3d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-03 16:54:23 +00:00
Sunny Goyal 4b48398352 Merge "Fix launcher holds a surfaceController" into main 2024-01-03 16:21:06 +00:00
Sergey Pinkevich efc5d81209 Merge "Select task is broken on display large size" into main 2024-01-03 16:19:15 +00:00
Johannes Gallmann 436b9939e3 Hide app icon during predictive back to home
Bug: 311337169
Flag: ACONFIG com.android.systemui.predictive_back_qs_dialog_anim DEVELOPMENT
Test: Manual, i.e. testing predictive back to home on device and verifying visually that app icon behaves correctly
Change-Id: I91491d91d004d81f4abc67c361c8824eba8dfdcd
2024-01-03 16:45:16 +01:00
Schneider Victor-tulias 97eee72e6e Merge "Use ACTION_SCROLL to scroll TAPL workspace objects" into main 2024-01-03 15:24:14 +00:00
Jeremy Sim 14424e9e1f App pairs: themed icons
App pairs now use themed icons when theming is enabled.

Fixes: 312452183
Test: Manual and presubmit tested
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I21801b63bc3b52da9b2dfff02cc9ec70e679b300
2024-01-03 15:14:31 +00:00
Jeremy Sim d36d4f3f94 Fix bug where app pair icons were appearing empty
Using similar logic as other BubbleTextViews, checks for PlaceholderIconDrawables and redraws the icons if needed.

Fixes: 316041983
Test: Manual and presubmit tested
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I017f1d5597fd28d37ca9a8a5758f33468e46f384
2024-01-03 15:13:48 +00:00
Vinit Nayak a85fa48883 Merge "Improve null safety for app pairs" into main 2024-01-03 15:11:27 +00:00
Sergey Pinkevich 638ee17821 Select task is broken on display large size
The update of the focus task overlay should be at last, cause otherwise the first time the "Select" button doesn't work - the text is not highlighted.

Also, we need to update pivot of the selected task only if there is a grid overview enabled. Otherwise the bug is still reproducible on Felix.

Bug: 305125147
Flag: NONE
Test: Manual (both on Tangor and Felix in Portrait/Landscape mode with small/medium/large Display size)
Change-Id: Id928cee0949b9124aeb27cc8210a53993e72ba19
2024-01-03 14:44:12 +00:00
helencheuk 2174b0ad2e Update BubbleTextView height to match parent so focus outline drawn could be fully displayed
Design doc: go/launcher-focus-outline
Before: BubbleTextView height is larger than its parent, outline is cropped
https://screenshot.googleplex.com/dYXjWAHS4VzPQdJ
After: BubbleTextView has the same height as its parent Prediction Row, outline is fully shown
https://screenshot.googleplex.com/3eMxPwxiHs9JTTq

Bug: 310953377
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_focus_outline Development
Change-Id: I7bfa4da3b67b4a4abc4dfe9df560dda8d7e9b1bd
2024-01-03 12:14:25 +00:00
Tracy Zhou 650000f68f Correct contextual button width, height and touch area
Side note: this is unrelated to NearestTouchFrame

Bug: 313371759
Bug: 230395757
Test: https://screenshot.googleplex.com/6mF4ZPSob6z55Nh
Change-Id: I7e5217bef4b2cfb6d14d62d107e75b1267ffd2f4
2024-01-02 23:05:53 -08:00
Riddle Hsu 78611ea4ca Merge "Reduce redundant IPC when switching app by navigation bar" into main 2024-01-03 06:30:44 +00:00
Vinit Nayak d6493f4558 Improve null safety for app pairs
- Improves crash safety in AppPairIcon.java. An app pair should never have more or fewer than 2 app members, but if it happens somehow and there is an app pair on the home screen, the device will enter a crash loop that is hard to recover from. Added some safety checks so that it doesn't happen.

Fixes: 317283244
Test: Manual and presubmit tested
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I2cbd90f028f7c31af6e832b5515502ba992f0b54
2024-01-02 22:22:02 -08:00
Andy Wickham 6ab98924f3 Merge "Update Launcher3 TAPL "find app icon" logic to allow whitespace." into main 2024-01-03 06:05:50 +00:00
Fengjiang Li 772675ed11 Merge "Revert "Fix small gap between widget resize frame and widget background."" into main 2024-01-03 00:51:44 +00:00
Ikram Gabiyev 221457f00b Send app bounds to Shell via stopSwipePipToHome
Send app bounds used for content overlay by launcher
to Shell's PiP component. This is used by Shell to
reset overlay scale and offset properly after the enter animation
but before the overlay fades out to avoid icon shifts.

We observed that app bounds can be different depending on
whether we are at 90 deg or 270 deg before fixed rotation.
Moreover, the presence of the taskbar can also alter the app bounds.
So supplying the app bounds we take from task view simulator to Shell
should solve the issue in general.

Flag: NONE
Bug: 316993346
Test: manually enter PiP w/ fixed rotation in 90 or 270 deg
Change-Id: I0a26b0c69020dae399d6794d36a9f3bc8425f40b
2024-01-02 16:50:48 -08:00
Android Build Coastguard Worker 9e67d0b523 Snap for 11265615 from 756da982fc to 24Q2-release
Change-Id: I2a5e2cbb86b0bd309058a6aba46ed89ce0a9ee66
2024-01-03 00:22:00 +00:00
Tracy Zhou 9742e603b5 Merge "Adjust the layout of nav buttons in 3 button mode with task bar / nav bar unification" into main 2024-01-03 00:12:56 +00:00
Charlie Anderson 81b6b21faf Merge "Adding extensions for backup restore test" into main 2024-01-02 23:30:55 +00:00
Jagrut Desai 25cb918a37 Refactor TaskbarDividerPopup Open/close animation
Test: Manual
Bug: 315848479
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED
Change-Id: I3c43bd718cef24ec334f7f4884167ecb2ce0cfd5
2024-01-02 15:25:42 -08:00
Fengjiang Li e81f4b8dc5 Revert "Fix small gap between widget resize frame and widget background."
This reverts commit 1e6bbf368b.

Reason for revert: b/317375712 TAPL is failing

Change-Id: Ib6b200f99c9feb7986ffca50015c02f3e558fc84
2024-01-02 23:00:03 +00:00
Tracy Zhou 5ad10ff6f6 Adjust the layout of nav buttons in 3 button mode with task bar / nav bar unification
In nav bar, we assign layout weight 0.25:0.5:1(for home but the content width of home is set to 80dp):0.5:0.25 with a LinearLayout. Since we use a FrameLayout for taskbar (to support both folded and unfolded task bar), in this change we are matching the layout by manually calculating the width of each section (since we are already manipulating like so in different layoutters)

Bug: 230395757
Test: https://screenshot.googleplex.com/3P6vDrgb6geqTUm
Change-Id: I6ba201477621f173e42c5211fcc68b24e3022122
2024-01-02 14:34:51 -08:00
Vadim Tryshev 365adb289d Making testAllAppsFromHome platinum
This test has a search for Youtube, which makes it possible for this test to replace android.platform.test.scenario.launcher.integration_tests.ScrollDownToSearchYoutubeFromAllApps#scrollDownToYouTube

Removing ScrollDownToSearchYoutubeFromAllApps#scrollDownToYouTube would move close to a state where the only Platinum tests outside of Launcher projects are ones that use 1P apps. This will make it easier to divide responsibilities between the IW and the Launcher teams.

Test: presubmit
Flag: N/A
Bug: 187761685
Change-Id: I889b1b23e5fe0a543eba24a922dc6908ac887305
2024-01-02 14:27:11 -08:00
Vadim Tryshev 756da982fc Merge "Always waiting for launcher stop from launchIntoSplitScreen()" into main 2024-01-02 21:49:09 +00:00
Charlie Anderson d6fc23f230 Adding extensions for backup restore test
Bug: 294386159
Test: presubmit
Flag: N/A
Change-Id: I4acc48c0bdd967d3c5463c85acd275a57d4a28ba
2024-01-02 16:19:32 -05:00
Fengjiang Li afbf61a150 Merge "Add assertion error message so test failure is more descriptive" into main 2024-01-02 21:18:40 +00:00
Vadim Tryshev 5cc6b2ba52 Re-promoting some tests to postsubmit
Excluding TaplDragTest#testDragToFolder, which is failing on some devices

Will watch their stability; may further promote to presubmit

Bug: 187761685
Test: presubmit, abtd
Flag: N/A
Change-Id: I6fd9a6fb315dc9ab7bcac788edfac95cc3e9b93f
2024-01-02 13:14:08 -08:00
Jagrut Desai 2107717252 Merge "Change Tracking Bug for Taskbar pinning feature flag" into main 2024-01-02 20:52:50 +00:00
Vadim Tryshev b36f70a8e3 Always waiting for launcher stop from launchIntoSplitScreen()
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I7f3c818355d43def7a29fbc1f087f2bdd150da0d
2024-01-02 12:40:04 -08:00
Vadim Tryshev fdf79d917d Merge "Waiting for NORMAL state after removing work profile" into main 2024-01-02 20:33:32 +00:00
Fengjiang Li abd3d6ddcc Merge "Revert " ALLAPPS PREINFLATION to TEAMFOOD"" into main 2024-01-02 20:00:35 +00:00
Hyunyoung Song 0c2204dcbe Merge "Fixing UserHandle for AppTarget Event from Launcher." into main 2024-01-02 18:22:18 +00:00