Commit Graph

76729 Commits

Author SHA1 Message Date
Uwais Ashraf 810a82f13e Merge "Extract GroupedTaskView size calcs to a method to prevent measure calls" into main 2024-02-05 11:35:11 +00:00
Uwais Ashraf 0d355abe38 Extract GroupedTaskView size calcs to a method to prevent measure calls
Bug: 313644427
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Test: OverviewImageTest
Change-Id: I494f09455104372209b9087d13a704a4fe52bb62
2024-02-05 10:27:12 +00:00
Cliff Wang dd2222749b Merge "Revert "Make sure TAPL waits for Launcher activity to stop each time it stops"" into main 2024-02-05 08:21:54 +00:00
Cliff Wang ac82e995ca Revert "Make sure TAPL waits for Launcher activity to stop each time it stops"
This reverts commit dd33b64a64.

Reason for revert: “DroidMonitor: Potential culprit for Bug b/323619378 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.”.

Bug:323619378
Change-Id: Iadaa80f2cc51f39ae3ab73cdd49a98d05835506e
2024-02-05 04:46:17 +00:00
Jeremy Sim c8ab1c7081 Snap to saved app pair
This CL makes it so that LauncherAccessibilityDelegate properly calls snapToPage() when saving a new app pair.

Fixes: 322758994
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I9b571989761c36ce1c1de1e1eec6a4f559cb6428
2024-02-04 02:22:50 -08:00
Android Build Coastguard Worker ec3e11fde7 Snap for 11401641 from 6474a3b455 to 24Q2-release
Change-Id: I607bcd18234cebc07efda6f3de5c389b4d3b9ba9
2024-02-03 22:20:25 +00:00
Tracy Zhou e9f4635426 Show hotseat instead of stashed taskbar handle after entering stage split from fullscreen app via keyboard shortcut
Besides finishing the recents animation from fullscreen app, we also need to update the taskbar state

Fixes: 323561157
Test: Go to a fullscreen app, trigger the split shortcut, make sure the hotseat icons are visible on the home screen
Change-Id: I36f47846ed0bc7f7036ae22452a28efc9cb09bc7
2024-02-03 06:04:00 +00:00
Tracy Zhou 6474a3b455 Merge "Add split instructions to stage split from keyboard shortcut" into main 2024-02-03 06:02:48 +00:00
Vadim Tryshev f9eced5768 Merge "Make sure TAPL waits for Launcher activity to stop each time it stops" into main 2024-02-03 02:33:53 +00:00
Android Build Coastguard Worker 2ffbd0df8e Snap for 11399958 from cac7c6f682 to 24Q2-release
Change-Id: I9a5c16bf02104ffbb1e47a8b3e9b0f340f44955c
2024-02-03 02:20:38 +00:00
Zak Cohen 379b5b0467 Merge "Hide widgets in the Work Profile tab when Work apps are paused." into main 2024-02-02 23:51:01 +00:00
Vadim Tryshev dd33b64a64 Make sure TAPL waits for Launcher activity to stop each time it stops
This helps to ensure that the test doesn't proceed while the activity is
still stopping and it's state hasn't settled.

We introduce a count of STOP events and make sure it's 0 except for
cases where stops are safe to ignore or we have waited for them.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I51c73c89854fcaa390d47a57389da18b2ce0ee6c
2024-02-02 15:21:20 -08:00
Tony Wickham cac7c6f682 Merge "Send finish callback even if there is no icon to animate to" into main 2024-02-02 22:37:44 +00:00
Vinit Nayak 92dd621d8e Merge "Intercept clicks for non-supported split targets on workspace" into main 2024-02-02 22:07:53 +00:00
Zak Cohen 3ae06bf4ca Hide widgets in the Work Profile tab when Work apps are paused.
The filter was missing from the refactor in ag/25502473.
There aren't currently WidgetPicker tests that would catch this behavior
but there should be.

Bug: 317452407
Test: Ran existing widget tests, looking at adding work profile tests.
Flag: none
Change-Id: I2ce8464a1c76505bfe7ce8cf4280bb5b576cdb1d
2024-02-02 13:28:39 -08:00
Shamali Patwa e66a001ed6 Merge "Fix the horizontal margins on the left panel in the two pane picker." into main 2024-02-02 21:16:55 +00:00
Mady Mellor 5912d0f6d9 Merge "Launcher: use aconfig flag for bubble bar" into main 2024-02-02 21:04:32 +00:00
Vadim Tryshev 94477b23e9 Send finish callback even if there is no icon to animate to
Fixes: 321297170
Test: TaplAllAppsIconsWorkingTest#testAppIconLaunchFromAllAppsFromHome
Flag: none
Change-Id: Ia6084dd14715bab36c7dd1c983fabedcf9b10630
2024-02-02 20:42:02 +00:00
Tracy Zhou d0b9aae52c Add split instructions to stage split from keyboard shortcut
Fixes: 319098298
Test: When launching split from fullscreen app via keyboard shortcut, the split instruction shows
Change-Id: Ie64e5e65384a24825edc7ae6c8dea3203e2bd916
2024-02-02 11:29:10 -08:00
Vadim Tryshev 3f4401aa7e Merge "Adding text messages to some asserts in TaplAddConfigWidgetTest" into main 2024-02-02 18:21:35 +00:00
Shamali P 5e855d7912 Fix the horizontal margins on the left panel in the two pane picker.
The recycler view when displayed in single pane picker, for large screen
gets a larger padding. But when displayed in two pane picker, it is not
needed - so we override it.

Foldable's unfolded portrait doesn't seem to have screenshot test
- will look into if we can add one in follow up.

Bug: 322719955
Test: Screenshot test for existing modes & manual (see bug)
Flag: ACONFIG com.android.launcher3.enable_unfolded_two_pane_picker DEVELOPMENT

Change-Id: Ibd72146e7e5230eec0d2ce01c3917819a73d8f32
2024-02-02 18:20:38 +00:00
Sebastián Franco fe5c308a11 Merge "Adding unit test to makeSpaceForHotseatMigration" into main 2024-02-02 17:52:52 +00:00
helencheuk 04cd8f2852 Show taskbar when external keyboard is attached, in 3 button nav mode and desktop windowing mode
Bug: 280497051
Test: Manual, turn on desktop windowing mode. Enter input mode in an app, drag it from the top to be  window mode. Verify if taskbar is present
Flag: N/A
Change-Id: I31dc922c480cd0b39a64763155777b906e3bd14a
2024-02-02 17:31:13 +00:00
Vinit Nayak ec52ed9f99 Intercept clicks for non-supported split targets on workspace
* If we're in split selection state we disable the following
- G icon on PSB
- Lens icon on PSB
- Smartspace
- Widgets

Bug: 295467097
Test: Enter split contextual and observe split instructions
view going boing when tapping on unsupported target
Flag: com.android.wm.shell.enable_split_contextual

Change-Id: Ia7783472f3de9359c2784788be5f35596cbc8deb
2024-02-02 08:17:13 -08:00
Sam Cackett 8b997289f0 Merge "Fix issue with IconAppChipView animated states" into main 2024-02-02 12:27:45 +00:00
samcackett fee52acb29 Fix issue with IconAppChipView animated states
Cancel in progress animations and resume from previous position.
Display TaskMenuView once.

Fixes: 322813710
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: I73410d6116876ca83f3b16311d2e9eb372308295
2024-02-02 11:08:47 +00:00
Himanshu Gupta 65f1f81300 Making PS container tappable when locked.
Currently only the lock button in contianer
is tappable when PS is locked.
This change makes both the container and
button tappable.
In unlock state, the container is not tappable.

Bug: 313859437
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space TRUNKFOOD
Test: Launcher3 test.
Change-Id: I1ae267d50a999e723932136dffa3ae8243d439c0
2024-02-02 10:53:52 +00:00
Rohit Goyal e807bdc26a Merge "UI Improvement: Persist archived app icon on workspace in case app uninstallation is cancelled." into main 2024-02-02 08:37:49 +00:00
Anushree Ganjam 61036608d1 Merge "Add logs for IME search button tap." into main 2024-02-02 07:58:28 +00:00
Fengjiang Li 2aaccefecb Merge changes I471c27b8,I602cf29b into main
* changes:
  Fix small gap between widget resize frame and widget background.
  Update TaplAddWidgetTest#testResizeWidget() and WidgetResizeFrame#resize() API to pass launcher's cellBoarderSpace and use its height to expand widget
2024-02-02 03:31:13 +00:00
Vinit Nayak 8b78849c44 Revert "Prevent taskbar animation for contextual split from home"
This reverts commit febd61fb3f.

Reason for revert: b/323418145, testing to see if this is the culprit

Change-Id: Ie72ce0d24c6008e93340c1868b18bce68902c7cc
2024-02-02 01:55:18 +00:00
Holly Sun ac84289439 [PS] Update PS icon.
Now we have a specific icon for Private Space in material icon lib (https://fonts.corp.google.com/icons?icon.query=private+space&icon.platform=android).
Figma: https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?type=design&node-id=20135-133573&mode=design&t=hXFY1ODhROG362hc-0

Screenshot: https://screenshot.googleplex.com/4YwYyeupJWt2Lq5

Bug: 323434770
Test: unit + manual
Flag: aconfig com.google.android.apps.nexuslauncher.enable_inject_private_space_tile teamfood
Change-Id: I175c16d61ad9d263684c345622f17301eba4472d
2024-02-01 16:47:25 -08:00
Rohit Goyal c475f22d8b UI Improvement: Persist archived app icon on workspace in case app uninstallation is cancelled.
Test: verified bugfix locally.
Bug: 319213296
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: Id9ba2ea833e8360ac8aa2c765beff402cff12ae2
2024-02-02 00:27:16 +00:00
Fengjiang Li b9ba4b9813 Fix small gap between widget resize frame and widget background.
There is a 1dp gap on left/top/right/bottom between widget resize frame and widget background. Increasing the margin by 1dp will fill this gap.

Fix: 291104076
Test: See https://b.corp.google.com/issues/291104076#comment9
Flag: NONE
Change-Id: I471c27b8b5d59850a4bf342fc2d8fee50d6fd65d
2024-02-01 16:24:18 -08:00
Fengjiang Li 387fea9731 Update TaplAddWidgetTest#testResizeWidget() and WidgetResizeFrame#resize() API to pass launcher's cellBoarderSpace and use its height to expand widget
To expand widget vertically, the drag distance has to be >= 0.66 * (cellHeight + cellBoarderSpace.y). The TAPL test should add cellBoarderSpace.y onto the vertical drag distance to make test less flaky.

Bug: 291104076
Test: Postsubmit passed https://android-build.corp.google.com/builds/abtd/run/L49100030001703948
Flag: NA
Change-Id: I602cf29b83df6875abd8eadfe255a2adb13f03cb
2024-02-01 16:24:14 -08:00
Sunny Goyal b2f38376c4 Merge "Blocking gestureNav on taskFragments within the Launcher activity" into main 2024-02-02 00:23:29 +00:00
Rohit Goyal ffb266462b Merge "UI Improvement: Do not add archived app icon to workspace when unarchival starts in case the icon already doesn't exist." into main 2024-02-02 00:21:21 +00:00
Android Build Coastguard Worker e45637d4e3 Snap for 11392706 from 3458141a9e to 24Q2-release
Change-Id: I30e0a032bfdf748d6181435a3f9196a2348c3a5e
2024-02-02 00:20:43 +00:00
Mady Mellor cc138663ca Launcher: use aconfig flag for bubble bar
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DISABLED
Test: make & enable / disable flag to check if it works:
      adb shell device_config put multitasking
         com.android.wm.shell.enable_bubble_bar true
Test: PlatformScenarioTests:
      android.platform.test.scenario.sysui.bubble.BubbleBarTest
Bug: 286246694
Change-Id: I0820973848675e8596e0e1605c7e43158d870382
2024-02-01 23:18:53 +00:00
Federico Baron 08b2acf898 Merge "Fix indexoutofbounds in Folder" into main 2024-02-01 23:07:17 +00:00
Brandon Dayauon ff89c5c9dc Fix color contrast in All Apps text by setting the color to onSurfaceVariant
bug: 322293478
Test:
All Apps divider:
before lightTheme: https://drive.google.com/file/d/1MTL1iEX_icYWfT52WeZIgqLK46koLM_s/view?usp=sharing
after lightTheme: https://drive.google.com/file/d/1ME1Gk8bUIXIe1P_Z5pvcpi3VS0_L0mVK/view?usp=sharing
before darkTheme: https://drive.google.com/file/d/1MLcv32M2JWyVqPklMdZLJAkj8KnyXwtB/view?usp=sharing
after darkTheme: https://drive.google.com/file/d/1MJjgP42xgp7SCifHAfREzgWvw6KupvlR/view?usp=sharing
All Apps text:
before light theme:https://drive.google.com/file/d/1MCu6xtpCMCxtDpnAv3fhCDSafBJGX4rx/view?usp=sharing
after light theme:https://drive.google.com/file/d/1M6ilveUw2q0FIlo-NSxt8KEWKRbQvwhk/view?usp=sharing
before dark theme:https://drive.google.com/file/d/1MCOxt9MeWxgN65T2s0OKzybiPu4qI4PD/view?usp=sharing
after dark theme: https://drive.google.com/file/d/1MAXnRmG8NVMu1bCseVWn6GC2322gQ0sX/view?usp=sharing
Flag: None

Change-Id: Iedb12d7b11b215c6668e7b5e6637189da3d67ebc
2024-02-01 14:55:23 -08:00
Sunny Goyal 2829c361f3 Blocking gestureNav on taskFragments within the Launcher activity
Bug: 273828110
Flag: aconfig use_activity_overlay disabled
Test: Verified on device
Change-Id: Ie812e17012feb8e99e06d0593207a87ef0c768e3
2024-02-01 13:35:30 -08:00
fbaron 1f265cc907 Fix indexoutofbounds in Folder
Flag: NONE
Test: n/a
Fix: 322875847
Change-Id: I14f6ebe135014c806aee310e5919a72a6e8820f7
2024-02-01 13:09:55 -08:00
fbaron f183b36c14 Fix pagination animation when removing a page
Flag: NONE
Test: verified on device
Fix: 323384413
Change-Id: I43443f815990df4014b4cfad05f68a445d44a5f4
2024-02-01 12:56:52 -08:00
Rohit Goyal 25ef2e1eca UI Improvement: Do not add archived app icon to workspace when unarchival starts in case the icon already doesn't exist.
Test: verified bugfix locally.
Bug: 319213296
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: Iad3cc1a254b1543511976469c444eeaf869c7d50
2024-02-01 20:52:19 +00:00
Vadim Tryshev 1784a329e6 Adding text messages to some asserts in TaplAddConfigWidgetTest
Bug: 187761685
Flag: N/A
Test: presubmit
Change-Id: Ia8164f60f49b377e41db72f97c4f90d167292574
2024-02-01 11:33:23 -08:00
Brandon Dayauon 3458141a9e Merge "Add Utility method in userCache to get badgeDrawables" into main 2024-02-01 18:02:17 +00:00
Schneider Victor-tulias 3dafeb2d09 Merge "Update KQS overview launch animation" into main 2024-02-01 17:55:54 +00:00
Sebastian Franco 2d8be10856 Adding unit test to makeSpaceForHotseatMigration
Flag: NA
Bug: 318417510
Test: atest HotseatReorderUnitTest
Change-Id: If4fe388d00138b2d43693df0cf79abb16f354291
2024-02-01 17:08:52 +00:00
Schneider Victor-tulias 8b9ca27cb8 Merge "Handle slow gesture handling" into main 2024-02-01 16:27:21 +00:00