Commit Graph

76729 Commits

Author SHA1 Message Date
Fengjiang Li 7f827e1527 Merge "[Predictive Back] Replace legacy flag with aconfig flag in launcher" into main 2024-02-06 21:57:34 +00:00
Shamali Patwa efebbb21fe Merge "Update prediction task to provide categorized suggestions." into main 2024-02-06 21:36:14 +00:00
Tracy Zhou b7efb5cb49 Merge "Only hide back button in SUW when ime is rendering it" into main 2024-02-06 20:24:29 +00:00
Sunny Goyal d1176bccf9 Merge "Using system API for rotating DisplayCutout instead of rotating it ourselves" into main 2024-02-06 20:20:47 +00:00
Shamali P 55fded376b Remove the "expand/collapse" actions on the apps list in 2 pane picker.
In a single pane picker, apps list is expandable / collapsable, but,
its not applicable for 2-pane variant. in 2-pane one, it should just
say "double tap to activate".

Also opened b/324073588 to make it clear from a11y perspective that it
is two pane and on click, right pane change should be announced.
(just like it does in settings with talkback).

see screencast/cast/NTQ1Mjk0MjIzOTg1ODY4OHw4OTc5ZjAzNS0wOQ

Bug: 319195592
Flag: None
Test: WidgetsListHeaderAccessibilityTest & manual.
Change-Id: I9ae3fbacc29364bd7459f6e6d85e0a1e919de3f8
2024-02-06 20:07:41 +00:00
Jagrut Desai 77d2e7860a Fixing NPE android.platform.test.scenario.launcher.overview testcases
Test: Presubmit, run staging platinum test on this change
Bug: 303256981
Flag: NONE
Change-Id: I9f807b008bb08909b4a08e750b4357b7d23eba39
2024-02-06 11:41:44 -08:00
Priyanka Advani 26b2e4810e Merge "Revert "Fix widget restore for pre-archived apps"" into main 2024-02-06 19:11:06 +00:00
Priyanka Advani eace95ab94 Revert "Fix widget restore for pre-archived apps"
Revert submission 26049200-widget-restore-fix

Reason for revert: Build breakage in b/324091151

Reverted changes: /q/submissionid:26049200-widget-restore-fix

Change-Id: I8a43650ba3f4590f49f038691d34238231f0747c
2024-02-06 19:00:55 +00:00
Piyush Mehrotra 2e094493c2 Merge "Fix widget restore for pre-archived apps" into main 2024-02-06 18:36:26 +00:00
Sunny Goyal a90500d233 Using system API for rotating DisplayCutout instead of rotating it ourselves
Bug: 321913010
Flag: NONE
Test: Manual
Change-Id: Iebbc8c17dc3b92a73866b7e22dfbde18eb3a52ff
2024-02-06 10:26:18 -08:00
Shamali P 57c1eedbc6 Update prediction task to provide categorized suggestions.
Also adds a helper in popup data provider to provide categorized
suggestions. Used in follow up CL to update the UI.

Bug: 318410881
Test: WidgetsPredictionUpdateTaskTest and manual with follow up changes
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Change-Id: Ie80e8ba7bbe874f7c4b0e579446edf571036555e
2024-02-06 18:14:49 +00:00
Federico Baron a5d7ae6c84 Merge "Fix pagination animation when removing a page" into main 2024-02-06 17:52:14 +00:00
Liana Kazanova 0a7b0022da Revert "Add TAPL test cases for KQS from taskbar all apps."
This reverts commit 853d7d3b4c.

Reason for revert:Probable culprit for b/323976612. Will be running through ABTD for verification and before submitting the revert.

Change-Id: Ie334d4ec7d8cdad7245610b9384cd3a61f44dc9e
2024-02-06 17:13:53 +00:00
Luca Zuccarini a2dd8a2629 Rename a few more animations classes to cover transitions in general.
Soon they will be used for both launches and returns, so these names
are more accurate.

Bug: 323863002
Flag: NA
Test: still builds (no functionality change)
Change-Id: I618780f0416a466a6672a2e694cb3e3ffd3f1396
2024-02-06 17:06:26 +00:00
Alex Chau 1380459097 Merge "Fix Select mode problem with animation off" into main 2024-02-06 16:55:56 +00:00
Ram Muthiah 87b5785548 Revert "Add unit test for StatusBarTouchController.java"
This reverts commit 1f0465e9f2.

Reason for revert: Droidmonitor investigation of test suite failure

Bug: 323976612
Change-Id: I07895d5c10984def103c240664755b96b79f1fb5
2024-02-06 16:50:10 +00:00
Jakob Schneider fb2bb9425c Merge "Add the archiving sysprop check to launcher3." into main 2024-02-06 16:34:53 +00:00
Johannes Gallmann 2441874a75 Merge "Fix crash for predictive back to home fallback animation" into main 2024-02-06 16:13:30 +00:00
Jakob Schneider 328c32235e Add the archiving sysprop check to launcher3.
This system property will be used to test the feature
in DVT. This is required because the new device is built on U QPR3, not V. See
https://docs.google.com/document/d/1h8sLlnnhwGP4uZssglBqTShMoQcEq5dvR7jsJmmp0Cw/edit?resourcekey=0-KTFHkPKTdtMN-5kQYBWJig&tab=t.0#heading=h.x9snb54sjlu9  for more details.

Test: tested manually
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving TEAMFOOD

Change-Id: Ie64a40ba799c81057258dd7de3872a0494cff2d8
2024-02-06 14:29:07 +00:00
Alex Chau 55b8b43fef Fix Select mode problem with animation off
- Avoid calling resetTaskVisuals when entering Modal state with animation off, it should only be called when leaving Overview, to be consistent with animation on case
- Use a separate property to control alpha for modalness, to avoid being overridden by other transition

Fix: 320314839
Test: presubmit
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: I12a35682e25c3a70bc263afdc90a7895d6c56f11
2024-02-06 14:16:43 +00:00
Luca Zuccarini 1fcfe364ba Rename ActivityLaunchAnimator to cover transitions in general.
Soon it will be used for both launches and returns, so this name is
more accurate.

Bug: 323863002
Flag: NA
Test: still builds (no functionality change)
Change-Id: Iaff2589401af24c6e9f604b3d7fa11e819fc941a
2024-02-06 14:07:44 +00:00
Vinit Nayak bc663baab0 Merge "Fix bug with portrait-fold devices animating app pairs launch wrongly" into main 2024-02-06 13:15:33 +00:00
Jakob Schneider 02d93b8463 Merge "Refactor API syntax based on API council feedback. This is a noop." into main 2024-02-06 12:44:55 +00:00
Jeremy Sim 2d0fd0780a Fix bug with portrait-fold devices animating app pairs launch wrongly
This CL makes it so that isLeftRightSplit is correctly called instead of isLandscape when animating an app pair launch.

Fixes: 318756992
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: Id766a3f9bd315abc277e36a118fd233156cf3898
2024-02-06 18:40:03 +08:00
Himanshu Gupta b3e03b5461 Merge "Making PS container tappable when locked." into main 2024-02-06 08:01:42 +00:00
Vinit Nayak d471844135 Merge "Revert^2 "Prevent taskbar animation for contextual split from home"" into main 2024-02-06 03:53:38 +00:00
Vinit Nayak c5376624c8 Merge "Update split with self test since it didn't account for contextual split" into main 2024-02-06 03:47:17 +00:00
Jeremy Sim 0c94fbc66f Merge "Snap to saved app pair" into main 2024-02-06 02:54:15 +00:00
Fengjiang Li cd60d191a8 [Predictive Back] Replace legacy flag with aconfig flag in launcher
Fix: 323971106
Flag: ACONFIG launcher.enable_predictive_back_gesture DISABLED
Test: manual
Change-Id: Ie8051af2540699a7d75f1ed05132584d0b40d17d
2024-02-05 16:41:29 -08:00
Android Build Coastguard Worker 8b5ebcece7 Snap for 11406759 from 562fe01e5e to 24Q2-release
Change-Id: Ia4234f037868c836faf33cdb5fd33ec2e9a034b8
2024-02-06 00:25:44 +00:00
Vinit Nayak fe35d069d2 Update split with self test since it didn't account for contextual split
* Right now we split from all apps and we stay in all apps with
contextual split.
* We now have 2 paths, if we are in contextual split then we
should select the same app from all apps again

Fixes: 323418145
Change-Id: I3bde59847b9e47951a6acdc93660b600114c3ddd
2024-02-05 16:08:30 -08:00
Schneider Victor-tulias 05511943c2 Merge "Add TAPL test cases for KQS from taskbar all apps." into main 2024-02-06 00:01:48 +00:00
Vinit Nayak 5f2b7242f3 Revert^2 "Prevent taskbar animation for contextual split from home"
This reverts commit 8b78849c44.

Reason for revert: Did not fix failing test b/323418145

Change-Id: Ic0897dda930a76aa27fba6e9de925b653d63a7f4
2024-02-06 00:00:35 +00:00
Saumya Prakash 548add276e Merge "Increase the character limit for translations in taskbar pinning edu" into main 2024-02-05 23:44:58 +00:00
Jordan Silva d5df5b3e11 Merge "Refactoring TAPL functions for OverviewTask" into main 2024-02-05 23:03:49 +00:00
Fengjiang Li 3088ae55d1 Merge "Add unit test for StatusBarTouchController.java" into main 2024-02-05 22:29:35 +00:00
Saumya Prakash 1613fe6b13 Increase the character limit for translations in taskbar pinning edu
The current character limit for the taskbar pinning edu subtitle does
not fit many translations. We are increasing the character limit to
enable proper translations.

Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TRUNKFOOD
Fix: 323943380
Test: N/A
Change-Id: I56225711c475e617451e5db0b1c226e3603e5c02
2024-02-05 21:40:38 +00:00
Schneider Victor-tulias 853d7d3b4c Add TAPL test cases for KQS from taskbar all apps.
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 323218341
Test: TaplTestsKeyboardQuickSwitch
Change-Id: Ie8f23ad14e4a32abbc5b49edc05ce407bbb774e6
2024-02-05 15:41:19 -05:00
Vinit Nayak 562fe01e5e Merge "Update fail fast check logic" into main 2024-02-05 20:00:08 +00:00
Fengjiang Li 1f0465e9f2 Add unit test for StatusBarTouchController.java
Test: this one
Flag: NONE
Bug: 282945183
Change-Id: I76eb4389d71d7a03e038ed6b01b6f5b7923fd11a
2024-02-05 11:51:01 -08:00
Android Build Coastguard Worker 8a8797ba8a Merge cherrypicks of ['googleplex-android-review.googlesource.com/26137350'] into 24Q2-release.
Change-Id: I5951fa0cfd04b316ab9efd731f122528bbd9262a
2024-02-05 19:47:13 +00:00
Neha Jain 8e79419cc4 Revert "Intercept clicks for non-supported split targets on work..."
Revert submission 25983910-disableSplitTargets

Reason for revert: b/323785395

Reverted changes: /q/submissionid:25983910-disableSplitTargets
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:158cc2505f242abc11375d947d960febb7038bb2)
Merged-In: I82bb808809e0be08803f3d5dd3ac779257bb64d0
Change-Id: I82bb808809e0be08803f3d5dd3ac779257bb64d0
2024-02-05 19:46:49 +00:00
Vinit Nayak ccab39e714 Merge "Revert "Prevent taskbar animation for contextual split from home"" into main 2024-02-05 19:39:00 +00:00
Anushree Ganjam 9858a3e0f4 Add Unit tests for System Shortcut.
Update SystemShortcut<T extends ActivityContext> and remove dependency on Launcher so we can write unit tests.

Introduce TestSandboxModelContextWrapper , wrapper around SandboxModelContext and ActivityContext.

Use SandboxModelContext for testing since we need UserCache, AllAppsContainerView, AllAppsStore to be spied and verified for function calls.

StatsLogManager is not verified in this cl, We can do as follow up.

Bug: 319250810
Test: Manual.
Flag: aconfig com.android.launcher3.enable_private_space TEAMFOOD

Change-Id: If767128a502e40d2016a331db4a342f20f24c588
2024-02-05 10:59:52 -08:00
Vadim Tryshev 3517550379 Merge "Starting measuring displacement from the edge of the slop zone" into main 2024-02-05 18:22:12 +00:00
Vinit Nayak 628a039721 Update fail fast check logic
* Incorrectly wasn't erroring out when flag was not enabled

Bug: 295467097
Change-Id: I5716309f832d1170ea92ad357897299c0438d2d0
2024-02-05 10:21:26 -08:00
Anna Zhuravleva a42e9d4410 Update icon for install to private shortcut
Bug: 316118005
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space_install_shortcut DEVELOPMENT
Test: https://b.corp.google.com/issues/316118005#comment5
Change-Id: I4f5316be5117be09510cac6922c43abe946e9938
2024-02-05 17:10:44 +00:00
Jagrut Desai c5be03f062 Merge "Change Persistent/Pinned Taskbar App Icon Size to 40dp" into main 2024-02-05 16:54:32 +00:00
Piyush Mehrotra b41d0634af Fix widget restore for pre-archived apps
Widgets which were expected to be restored, were missing for apps which were pre-archived.
The fix adds checks for archived apps when processing widgets and ensures that icon with cloud overlay is present on the widget.

Test: Flashed device with build containing this fix.
    Screenshot right after SuW- http://shortn/_LoLudMXEaT
Bug: 321297173
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: I32bc51ead2870670efc8eba24f17896aedcc3b9f
2024-02-05 15:53:19 +00:00
Jordan Silva ebd71c6cc9 Refactoring TAPL functions for OverviewTask
This CL refactors some methods in OverviewTask to rely on OverviewSplitTask. It also changes the BaseOverview getTasks function to retrieve the parent task and support cases where only the bottomright_snapshot is available in the recent tasks.

Bug: 320633351
Test: TaplTestsSplitscreen
Flag: N/A
Change-Id: I226f895810ce3b46cc107f76cd85e2918abf7088
2024-02-05 13:50:23 +00:00