Commit Graph

76729 Commits

Author SHA1 Message Date
Anushree Ganjam 9ea1724245 Merge "Add InteractionJankMonitor for backpress from allapps CUJ_LAUNCHER_CLOSE_ALL_APPS_BACK." into main 2024-02-17 00:23:11 +00:00
Anushree Ganjam 06c98fd685 Add InteractionJankMonitor for backpress from allapps CUJ_LAUNCHER_CLOSE_ALL_APPS_BACK.
Jank CUJ's cannot be added in LauncherState since it's aosp code.
Introduced `onBackPressComplete` method so the LauncherState subclasses can override this method to get back press complete call after back press animation is successful. Here we can add necessary jank CUJ's.

Perfetto trace : https://ui.perfetto.dev/#!/?s=3fc6eed848bdd692949ddb3afbdcdf04a7ef0d99cb9a83804ce9e1840492ed66

Test: Perfetto trace. https://screenshot.googleplex.com/5yviY5LxKusnKvF.png
Bug: 319132905
Flag: NA. Adding jank CUJ.

Change-Id: Ia418f06cb76fe4e14c2032c62c2250e9143442f2
2024-02-16 14:35:20 -08:00
Jon @ d3693424f5 Merge "Notify home is visible when launching a translucent app." into main 2024-02-16 21:43:28 +00:00
Treehugger Robot 821715127d Merge "Prevent taskbar reset animation from playing when gesture is in progress." into main 2024-02-16 21:36:59 +00:00
Treehugger Robot c7f9baee08 Merge "Disabling hidden API checks for Launcher3 tests" into main 2024-02-16 19:53:40 +00:00
Ats Jenk ca99653959 Merge "Create bubbles input consumer before nav bar long press" into main 2024-02-16 19:52:08 +00:00
Himanshu Gupta 4499fa60f9 Preventing installed PS apps from moving to home screen
During app install in PS, promise app icons and the
installed app icons are added automatically on home screen.
In this change we restrict the same.
Also, checked that enabling `PROMISE_APP_IN_ALL_APPS` still
works for PS apps after this change.

Bug: 325057835
Test: Launcher3 tests
Flag: ACONFIG com.android.launcher3.Flags.private_space_restrict_item_drag TEAMFOOD
Change-Id: Iecff850bcc1cd17a123553a4258943da1ee61fcc
2024-02-16 19:28:58 +00:00
Federico Baron 94c16073d3 Merge "Fix import for screenrecord" into main 2024-02-16 19:26:06 +00:00
Alex Chau c302daec2f Avoid resetting RecentsAnimationController and RemoteTargetHandle without clear ownership
- RecentsView only see itself owning RecentsAnimationController and RemoteTargetHandle after live tile is enabled via onGestureAnimationEnd to RECENTS
- RecentsView will finish recents animation if it owns RecentsAnimationController and is leaving RecentsView
- Otherwise, reset() would not reset RecentsAnimationController or RemoteTargetHandle
- Added logging for interaction between gesture and RecentsView to aid future debugging

Bug: 288557298
Test: manual
Flag: None
Change-Id: Icdcb91b98b2bb5d6d3bc30070f533ea79915bc09
2024-02-16 19:23:08 +00:00
Shamali P b3a4d65bb7 Initial UI changes for displaying categorized suggestions.
Ordering changes and some more UI changes in follow-up.

Bug: 318410881
Test: See screenshots
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Change-Id: I77e7f4dcdda32e2921ae56721cddbe261832f0d8
2024-02-16 18:43:20 +00:00
Vadim Tryshev 183614ca32 Disabling hidden API checks for Launcher3 tests
This makes atest config functionally identical to the GCL one that's used to run tests in the lab, and will help eliminating test errors in Launcher3 tests.

Bug: 271324404
Test: presubmit
Flag: N/A
Change-Id: I35003bc7e7edd41c3db9c0ff7562f608a21b886e
2024-02-16 18:08:41 +00:00
Vadim Tryshev 8d657cb911 Merge "Adding screen recording for FallbackRecentsTest.testOverview" into main 2024-02-16 18:07:33 +00:00
Tracy Zhou 0c801cbd20 Merge "Guard taskbar / navbar unification logic with whether the device is a phone on top of the flag" into main 2024-02-16 17:51:03 +00:00
Tracy Zhou e34a1b647d Merge "Update phone gesture nav test in NavButtonLayoutFactoryTest" into main 2024-02-16 17:50:18 +00:00
Jakob Schneider 6ad28a568e Merge "Fix two flag usages that I missed the last time around when I refactored it into the utilities class." into main 2024-02-16 17:47:34 +00:00
fbaron bb13d787f0 Fix import for screenrecord
accidentally imported the wrong screenrecord

Bug: 322228038
Flag: NONE
Test: TaplOpenCloseAllAppsTest#testAllAppsFromHome
Change-Id: I80f0b3a9b376144ff4f75f5ce0fb98b1aed5985d
2024-02-16 09:15:46 -08:00
Alex Chau 1ae5e169b0 Update pivots after taskSize is updated
- For case that there are no TaskViews, onLayout is not called, so updatePivots isn't called when folding

Fix: 325314248
Test: Manual
Flag: None
Change-Id: If7377f2e4fcbe4a874f823bb99b0b197cd5f7b87
2024-02-16 15:23:35 +00:00
Alex Chau 60ad90e519 Always run animateClose when closing TaskMenuView
- This avoid diverging code path when animation is off
- Also made sure menuTranslationX and Y always reset when not needed
- Also remove AnimatedVectorDrawable in favour of scale animation in code, as AnimatedVectorDrawable doesn't work well when animation is off

Bug: 319086207
Test: OverviewMenuImageTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: I4a18cf4aac3237031095c2600c777b6c4c3e518f
2024-02-16 14:58:14 +00:00
Jakob Schneider f45d7f3450 Fix two flag usages that I missed the last time around when I refactored
it into the utilities class.

Test: N/A
Flag: NA
Change-Id: If2c0824d7dd076bda68ee7d9c4f48889f4c8f4e1
2024-02-16 13:03:59 +00:00
bvineeth e8bdf16b65 Add tag for cuj OPEN_ALL_APPS when swiping to open all apps
Test: Checked trace
Bug: b/270128536
Flag: None
Change-Id: I0d5f562fc156423af2b5ce7e54e1bff54a522aa6
2024-02-16 10:41:15 +00:00
Treehugger Robot 3d7e1c290e Merge "Revert "Use instrumentation arg to prevent unnecessary delays in unit tests"" into main 2024-02-16 08:40:03 +00:00
Tracy Zhou b263e2d94a Update phone gesture nav test in NavButtonLayoutFactoryTest
I think the test was written in the first version of NavButtonLayoutFactoryTest where phone gesture nav layouter didn't exist (verified with the revision history), hence updating the logic here

Bug: 324989451
Test atest NavButtonLayoutFactoryTest

Change-Id: I325a5d47db86add8d094e61b1de923f50a2db309
2024-02-15 23:42:21 -08:00
Tracy Zhou 89f72882ce Guard taskbar / navbar unification logic with whether the device is a phone on top of the flag
Test: Rerun the tapl tests
Bug: 325162802
Change-Id: Iffeeb0a60b634e66bc80e4ba45db816cdc8ba564
2024-02-15 22:06:33 -08:00
Vineeth Bhende e2a76cee2b Merge "Add CUJ-LAUNCHER_OPEN_ALL_APPS instrumentation from taskbar" into main 2024-02-16 04:02:24 +00:00
Treehugger Robot bd265a24cc Merge "Adding logging for for the case whe Launcher activity is not resumed after Back" into main 2024-02-16 03:19:02 +00:00
Vadim Tryshev 334e9f38e2 Revert "Use instrumentation arg to prevent unnecessary delays in unit tests"
This reverts commit b5d08b246e.

Reason for revert: A similar G3 CL was reverted: cl/582384131

Change-Id: If3e3d6f1aacd297ef357d6330ca3e98e857ea71d
2024-02-16 02:01:20 +00:00
Android Build Coastguard Worker 74f6c1e2e2 Merge "Snap for 11456215 from 7e9bea446a to 24Q2-release" into 24Q2-release 2024-02-16 01:40:34 +00:00
Android Build Coastguard Worker 60634b0a05 Merge "Snap for 11456215 from 7e9bea446a to 24Q2-release" into 24Q2-release 2024-02-16 01:33:09 +00:00
Android Build Coastguard Worker f90587f006 Snap for 11456215 from 7e9bea446a to 24Q2-release
Change-Id: I78fa0b73d622dd96ca6707e825cd7350fd3fcdd1
2024-02-16 00:51:37 +00:00
Android Build Coastguard Worker 0c483a723d Snap for 11456215 from 7e9bea446a to 24Q2-release
Change-Id: Ib6e9d00e2379f48a06ed7c246c98a83a8e79f1a5
2024-02-16 00:39:34 +00:00
Android Build Coastguard Worker d28ec81d9a Snap for 11456215 from 7e9bea446a to 24Q2-release
Change-Id: I3d0079e790f7d96252e5a3bb88a3d1b378b25d59
2024-02-16 00:37:54 +00:00
Ikram Gabiyev 1979abe353 Merge "Move IPip and IPipAnimationListener to common" into main 2024-02-15 23:42:51 +00:00
Vadim Tryshev bd85c258aa Merge "Adding screen record for for the case when quick switch gesture doesn't do anything" into main 2024-02-15 23:31:41 +00:00
Bill Yi 242595cd09 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev am: 84192f29d3 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26240574

Change-Id: Ic68a18454e453f4d5b7eff50c8252e0259b2c3f4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-15 22:16:39 +00:00
Bill Yi c7596bea0b [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 2ae543dfd6 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26240574

Change-Id: I17f377c4f7326aeeacf04745d604026a9d305297
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-15 22:16:34 +00:00
Bill Yi 0e7a93222a [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 826c012382 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26240573

Change-Id: I8ce36d8f0c65bcc3c9ad6925eb4cf3f603e075ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-15 22:16:21 +00:00
Jon Miranda 26447ddc98 Notify home is visible when launching a translucent app.
To fix the taskbar stash delay when launching an app, ag/18875100
sets the state so that the taskbar stashes immediately after
app is launched.

Since we cannot know if the app is translucent at that point,
we have to check after the animation is started so we can update the
launcher visibility state.

Bug: 314792981
Flag: ACONFIG ENABLE_HOME_TRANSITION_LISTENER TRUNKFOOD
Test: HomeObserverTest
Change-Id: Ifc3a6559d7a8c6fda4c08a0fc2d6791da46b38d6
2024-02-15 13:55:42 -08:00
Bill Yi 84192f29d3 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev 2024-02-15 21:28:55 +00:00
Vadim Tryshev 6999ed124d Adding screen record for for the case when quick switch gesture doesn't do anything
Bug: 313464374
Test: presubmit
Flag: N/A
Change-Id: I08e3f964cc0fbaebe4b077f08145dc54b967f936
2024-02-15 13:22:27 -08:00
Schneider Victor-tulias 00a484bf03 Merge "Fix alt-tab initial focus in overview on phones" into main 2024-02-15 21:06:08 +00:00
Sunny Goyal cc1dad0cae Merging multiple implementations of CancellableTask
Bug: 318539160
Flag: None
Test: Manual
Change-Id: Ie855427c2676e0ce76655e4dd67472c0b5e435d8
2024-02-15 13:01:10 -08:00
Vadim Tryshev 451eebd450 Adding logging for for the case whe Launcher activity is not resumed after Back
Bug: 322823209
Test: presubmit
Flag: N/A
Change-Id: I4e9b26ab142f4d69f906eeb6d5ab487babbcbca1
2024-02-15 12:39:27 -08:00
Ikram Gabiyev f32c27f773 Move IPip and IPipAnimationListener to common
Move IPip.aidl and IPipAnimationListener.aidl to common.pip
package as a part of PiP2 refactoring.

Make sure users of these Binder interfaces in Launcher
also reference the updated classname and package.

The plan is to use these interfaces to implement
PiP2 <-> Launcher IPC to facilitate transitions and animations
for gesture nav and auto-enter PiP for instance.

Note: this CL shouldn't yield any behavioral changes.

Flag: NA
Bug: 325481148
Test: mp droid
Change-Id: I065334f6777cd1489c739d95abf0fab8285860ed
2024-02-15 11:17:36 -08:00
Vadim Tryshev 266ca6005d Adding screen recording for FallbackRecentsTest.testOverview
Bug: 321775748
Test: presubmit
Flag: N/A
Change-Id: I7dddefcf46afde35d86b9f9271c34d46a257281e
2024-02-15 10:41:14 -08:00
Shamali P 62339981db Use full-width two picker in both orientations in tablets
The change is really for enabling display of categorical suggestions,
so using the same flag.

Bug: 315055849
Bug: 318410881
Test: See screenshots
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Change-Id: Ia98fdd6b827f31a63264128617f6a16ee0716bcc
2024-02-15 18:32:21 +00:00
Shamali P 5fbb0cccad Use derived padding instead of static 300dp for large portrait displays
In tablet, portrait mode, a padding of 300dp was applied to make it
less elongated, but that doesn't scale well across different devices.

So, we use 1/6th of height as the additional padding. This fixes the
existing logic.

Bug: 318410881
Bug: 315055849
Flag: N/A
Test: Screenshot update in cl chain.
Change-Id: Ia9cfe481131f086b66f625069cbf9a7c0343c2c9
2024-02-15 18:32:21 +00:00
Shamali P 933a05a2be Align items in the center within each table row within suggestions.
When differently-sized widgets OR widgets of same size but not filling
space in previews are shown side by side, the top alignment looks odd.

Besides, in the updated UX, we want them to be center aligned.

Bug: 318410881
Bug: 319152349
Flag: N/A
Test: Screenshot update in cl chain.
Change-Id: I52cd7d6a1b5397a3c4c9dea8b072792b3211a8d3
2024-02-15 18:32:21 +00:00
Bill Yi 7e9bea446a Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-02-15 18:10:21 +00:00
Bill Yi 6ea90c84cc Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-02-15 18:10:21 +00:00
Vadim Tryshev 754f4ffa50 Merge "Add logs for uninstallWorkspaceIcon() test" into main 2024-02-15 18:10:10 +00:00