Commit Graph

19452 Commits

Author SHA1 Message Date
TreeHugger Robot 4da033b59b Merge "Use a property instead of a getter function for key in BubbleBarBubble. Using a property here is more Kotlin idiomatic." into udc-dev am: 35f5bfea4c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23058990

Change-Id: Ia43c7821f7ff4de0b489b64e8bd84d15bb797e6d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-08 19:27:26 +00:00
Schneider Victor-tulias feb24668e5 Merge "Fix null-pointers in SurfaceTransactionApplier constructor." into udc-dev am: a40de23f04 am: b4d421d37a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22973611

Change-Id: I13ac4a170468dd195802264aef7aabb159a62286
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-08 19:08:14 +00:00
TreeHugger Robot 35f5bfea4c Merge "Use a property instead of a getter function for key in BubbleBarBubble. Using a property here is more Kotlin idiomatic." into udc-dev 2023-05-08 18:52:25 +00:00
Schneider Victor-tulias 1e898351ea Merge "Fix null-pointers in SurfaceTransactionApplier constructor." into udc-dev am: a40de23f04
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22973611

Change-Id: I3b5ad1facf2ddf4ee7f17131f49e2f209898485c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-08 18:40:28 +00:00
Lucas Silva 85c6e6d3b2 Merge "Update QuickstepTransitionManager to allow remote transitions to be overridden" into udc-dev am: 39e28c9190 am: 676950a91a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22992541

Change-Id: Iddc021d7a93e9febd4d0835ac87221e7e2aec59b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-08 18:38:53 +00:00
Lucas Silva c499df2142 Merge "Update QuickstepTransitionManager to allow remote transitions to be overridden" into udc-dev am: 39e28c9190
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22992541

Change-Id: Idedad51ef52dfb099ec07fdc52e18f5808b5dc2d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-08 17:41:48 +00:00
Schneider Victor-tulias b4d421d37a Merge "Fix null-pointers in SurfaceTransactionApplier constructor." into udc-dev am: a40de23f04
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22973611

Change-Id: Icd979852965966821f0dfdc9babeef548cbfe340
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-08 16:57:26 +00:00
Lucas Silva 676950a91a Merge "Update QuickstepTransitionManager to allow remote transitions to be overridden" into udc-dev am: 39e28c9190
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22992541

Change-Id: I14186dee9f80c2852db4724eee27764e561ee017
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-08 16:57:06 +00:00
Schneider Victor-tulias a40de23f04 Merge "Fix null-pointers in SurfaceTransactionApplier constructor." into udc-dev 2023-05-08 16:50:13 +00:00
Lucas Silva 39e28c9190 Merge "Update QuickstepTransitionManager to allow remote transitions to be overridden" into udc-dev 2023-05-08 14:20:36 +00:00
Mady Mellor 3dcfa8c23c Merge "Adds BubbleControllers to TaskbarControllers" into udc-dev am: 764608263f am: f4f2f99af7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22534247

Change-Id: I7afe65fa653e40aae6632879d92c4f304c2de8b8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 18:40:49 +00:00
Mady Mellor 68ab5c995e Merge "Add Bubbles and BubblesListener to SystemUiProxy and use it" into udc-dev am: b7dce64db5 am: 0608101d80
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22534246

Change-Id: Id3da590b6b4aa94feeaa851aa4f0d18ba6a14451
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 18:40:41 +00:00
Mady Mellor f4f2f99af7 Merge "Adds BubbleControllers to TaskbarControllers" into udc-dev am: 764608263f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22534247

Change-Id: I4cc2a84665537989860e27603f82605f0e61fcc2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 18:03:13 +00:00
Mady Mellor 0608101d80 Merge "Add Bubbles and BubblesListener to SystemUiProxy and use it" into udc-dev am: b7dce64db5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22534246

Change-Id: Ib36c26a055c24797c8e7f012a605d450dd5a2a5d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 18:03:03 +00:00
Mady Mellor 8b29c533ca Merge "Adds BubbleControllers to TaskbarControllers" into udc-dev am: 764608263f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22534247

Change-Id: I32c85ead8fc190796847d9fe07698bdf5a4a7753
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 17:59:08 +00:00
Mady Mellor 442ce74f39 Merge "Add Bubbles and BubblesListener to SystemUiProxy and use it" into udc-dev am: b7dce64db5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22534246

Change-Id: I55366cf639ea62888d1689338617944e1a5ea43a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 17:58:58 +00:00
Mady Mellor 764608263f Merge "Adds BubbleControllers to TaskbarControllers" into udc-dev 2023-05-06 17:22:21 +00:00
Mady Mellor b7dce64db5 Merge "Add Bubbles and BubblesListener to SystemUiProxy and use it" into udc-dev 2023-05-06 17:22:06 +00:00
Brian Isganitis ce079a8a5e Merge changes I35fe528b,Ia612c1b5 into udc-dev am: 0b53332c31 am: 50d31f5530
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22419061

Change-Id: I658d7f2e9621476f60c3e2b204c24eb754f3b335
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 16:13:54 +00:00
Brian Isganitis 50d31f5530 Merge changes I35fe528b,Ia612c1b5 into udc-dev am: 0b53332c31
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22419061

Change-Id: I25ddaa428ca3fd58f079e93b7430b0528fda2f06
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 15:35:43 +00:00
Brian Isganitis fe933305c3 Merge changes I35fe528b,Ia612c1b5 into udc-dev am: 0b53332c31
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22419061

Change-Id: Ia47f7ed39378ba4bc7b37026ff8d8feecb05b093
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 15:31:40 +00:00
Brian Isganitis 0b53332c31 Merge changes I35fe528b,Ia612c1b5 into udc-dev
* changes:
  Don't close AFVs when opening Taskbar folder.
  Keep persistent Taskbar visible over Taskbar All Apps.
2023-05-06 14:42:54 +00:00
Winson Chung 2c8dcd44bc Merge "Try to detect and handle delayed quickswitch task launch failure" into udc-dev am: 8e7e159645 am: 1f205bb22d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22841404

Change-Id: I781f08174ab99b2d50be6649ae03e791713821fe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 08:34:00 +00:00
Winson Chung 1f205bb22d Merge "Try to detect and handle delayed quickswitch task launch failure" into udc-dev am: 8e7e159645
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22841404

Change-Id: Ia14f1de012521784b37c4b412f7268e22cbdabd6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 07:56:35 +00:00
Winson Chung c0d4768083 Merge "Try to detect and handle delayed quickswitch task launch failure" into udc-dev am: 8e7e159645
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22841404

Change-Id: Ic56a7295e03f04c5b0f0613e9a025352929ac064
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 07:52:28 +00:00
Winson Chung 8e7e159645 Merge "Try to detect and handle delayed quickswitch task launch failure" into udc-dev 2023-05-06 07:12:18 +00:00
Treehugger Robot 1e0a0534b8 Merge "Updating SurfaceTransactionApplier to handle view not being attached" into udc-dev am: 8b0fcbffb0 am: 4f00ae9e76
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23066497

Change-Id: I14b23b570a9a63dd085ff9ad62dc8ffc856e7d3d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 03:21:11 +00:00
Treehugger Robot 4f00ae9e76 Merge "Updating SurfaceTransactionApplier to handle view not being attached" into udc-dev am: 8b0fcbffb0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23066497

Change-Id: Id7faac43f67f98127b8fa223fa3dbd62b3a3d502
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 02:42:17 +00:00
Treehugger Robot 1815a4c555 Merge "Updating SurfaceTransactionApplier to handle view not being attached" into udc-dev am: 8b0fcbffb0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23066497

Change-Id: Ie0d5beaaedb14adba33ee1f24a6c5c867b5f0780
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 02:38:25 +00:00
Treehugger Robot 8b0fcbffb0 Merge "Updating SurfaceTransactionApplier to handle view not being attached" into udc-dev 2023-05-06 01:57:51 +00:00
Saumya Prakash 2a4a5202c5 Merge "Remove unused Sandbox Mode in the gesture navigation tutorial" into udc-dev am: 958eabcd8f am: a6e71d3cf4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23002490

Change-Id: Ia3ae03f51af73f26a7828fe3915615b5a1c3528d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 00:14:55 +00:00
Mady Mellor c37bf46381 Adds BubbleControllers to TaskbarControllers
* BubbleControllers is optionally available (gated behind a flag).
* The bubble bar controllers follow init & onDestroy after the taskbar
  controllers.
* Adds the relevant views used by the bubble controllers to the
  transient taskbar layout.

Bug: 253318833
Test: manual, with other CLs, see go/bubble-bar-tests
Flag: WM_BUBBLE_BAR
Change-Id: I685163cdcc912768b1a720952762f4cbc602b14b
2023-05-05 17:02:38 -07:00
Winson Chung df51c1ada8 Try to detect and handle delayed quickswitch task launch failure
- The main issue arises when a task is successfully launched from
  overview, but the activity later finishes (ie. during resume) which
  prevents the usual logic of resetting Launcher to a good state
  (ie. it can get stuck in overview with a blank or empty snapshot)

  In this case, the Launch will "succeed" so that onTaskLaunchFailed
  is not called, but then also silently fail (launched task finishes
  and Launcher is again resumed) before Launcher stops, which does the
  usual resetting of the state back to normal state after quickswitching.

  This change checks for this case by listening for the activity and
  transition state, and in the case where Launcher has not been stopped
  or is resumed again after the transition finishes, returns the
  user to the default home state.

  This primarily only affects quickswitch for now, as other launch
  failures leave the user in a valid state (ie. overview) while this
  issue will leave the user in background state while quickswitching.

Bug: 268448123
Test: Quickswitch to an activity that finishes when resumed
Change-Id: I7d554f8fd521f7bc480dc06930ad91eeef0f1a1a
2023-05-05 23:55:22 +00:00
Saumya Prakash a6e71d3cf4 Merge "Remove unused Sandbox Mode in the gesture navigation tutorial" into udc-dev am: 958eabcd8f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23002490

Change-Id: Ia3d62df5f0585c84c18cb8eed34e87144113954e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-05 23:30:54 +00:00
Saumya Prakash 93a0cc9f01 Merge "Remove unused Sandbox Mode in the gesture navigation tutorial" into udc-dev am: 958eabcd8f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23002490

Change-Id: I66a932e91d9969f284d6c978a3a901670acbf669
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-05 23:26:38 +00:00
Sunny Goyal 63cf4d07a8 Updating SurfaceTransactionApplier to handle view not being attached
Bug: 278833389
Test: Presubmit
Flag: N/A
Change-Id: I88c240a1a7bdfe2e68c858c30e91cc5d06bc7bcf
2023-05-05 15:57:42 -07:00
Saumya Prakash 958eabcd8f Merge "Remove unused Sandbox Mode in the gesture navigation tutorial" into udc-dev 2023-05-05 22:52:54 +00:00
Schneider Victor-tulias d86c5657e0 Fix null-pointers in SurfaceTransactionApplier constructor.
A recurring class of null pointers are caused by using views with no view root implementation in SurfaceTransactionApplier from QuickstepTransitionManager. This can happen when we use launcher views after it has been destroyed.

- No longer using mDragLayer in getFallbackClosingWindowAnimators; simply applying the transaction immediately.
- Forcefully using getFallbackClosingWindowAnimators when launcher is destroyed.

Flag: not needed
Bug: 278833389
Test: launches and closed several apps in 3-button and gesture nav mode
Change-Id: I83b3aec1488fe9666bd0301a6044a181bb05dbdd
2023-05-05 21:53:50 +00:00
Mady Mellor 50e8d0ff60 Add Bubbles and BubblesListener to SystemUiProxy and use it
Adds a method to call into WMShell to set the listener and
indicate when a bubble is shown or when the expanded state
changes.

BubbleBarController sets or clears out the listener.

BubbleBarViewController calls SystemUiProxy when bubbles are shown
or when the expanded state changes.

Bug: 253318833
Test: manual, with other CLs, see go/bubble-bar-tests
Flag: WM_BUBBLE_BAR
Change-Id: I2364b9bbdea237fc268b0999d9c896585c194a86
2023-05-05 14:18:00 -07:00
Qiao Yang 9a2b648a04 Merge "Revert "Revert "Listen for hover events over stashed taskbar.""" into udc-dev am: 1aee68df56 am: 5079b44fad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23063440

Change-Id: I933714897c03dfb221ea390ce5bd27da83a82bb8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-05 19:52:58 +00:00
Liran Binyamin b7d3d64d68 Use a property instead of a getter function for key in BubbleBarBubble. Using a property here is more Kotlin idiomatic.
https://kotlinlang.org/docs/coding-conventions.html#functions-vs-properties
go/kotlin/practices/properties#when

Bug: 281083629
Test: Verified on a physical device
Change-Id: I4c003c6633bf1913ee5e1e86224a679ff3442e2b
2023-05-05 19:43:43 +00:00
Qiao Yang 5079b44fad Merge "Revert "Revert "Listen for hover events over stashed taskbar.""" into udc-dev am: 1aee68df56
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23063440

Change-Id: Id81af4051c206031901b560102f6c3e3d2bc9a47
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-05 19:35:36 +00:00
Qiao Yang b4204df189 Merge "Revert "Revert "Listen for hover events over stashed taskbar.""" into udc-dev am: 1aee68df56
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23063440

Change-Id: Ia2eb0ba323c37ccbd6694209f35695c80e9c4a21
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-05 19:34:38 +00:00
Qiao Yang 9482945a20 Merge "Revert "Listen for hover events over stashed taskbar."" into udc-dev am: 51669b612f am: 854b0bda4d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23048070

Change-Id: I32d94b805a6b41b778a071f5e31ada6c65319ad4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-05 19:32:19 +00:00
Qiao Yang 1aee68df56 Merge "Revert "Revert "Listen for hover events over stashed taskbar.""" into udc-dev 2023-05-05 19:09:44 +00:00
Qiao Yang 2482c8dcd4 Revert "Revert "Listen for hover events over stashed taskbar.""
This reverts commit c27605099c.

Reason for revert: DroidMonitor-triggered revert due to breakage <https://android-build.googleplex.com/builds/quarterdeck?branch=git_udc-dev&target=cf_x86_64_phone-userdebug&lkgb=10076607&lkbb=10076982&fkbb=10076788>, bug <281093059>

Change-Id: I71e7fd07232c27a004243df0ffb0457fe53fe13b
2023-05-05 19:07:17 +00:00
Qiao Yang 611dca65e1 Merge "Revert "Listen for hover events over stashed taskbar."" into udc-dev am: 51669b612f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23048070

Change-Id: I7ae65fafd4fbab42b8137e25bd7b07e3ef4d94ac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-05 18:51:15 +00:00
Qiao Yang 854b0bda4d Merge "Revert "Listen for hover events over stashed taskbar."" into udc-dev am: 51669b612f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23048070

Change-Id: Id347f25441e8551e19f17796b5304365dec7084e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-05 18:50:08 +00:00
Stefan Andonian 128b8a56ed Merge "Enforce setting up SystemUIProxy on the main thread." into udc-dev am: 5882e97857 am: f6925ba287
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23045938

Change-Id: I405518772027f74f20fc98905c5e223fc22f9cc8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-05 18:26:45 +00:00
Qiao Yang 51669b612f Merge "Revert "Listen for hover events over stashed taskbar."" into udc-dev 2023-05-05 18:05:16 +00:00