Commit Graph

19452 Commits

Author SHA1 Message Date
Treehugger Robot fb085e6393 Merge "Animate the position of the selected bubble arrow in the expanded bubble bar." into udc-dev 2023-05-10 16:49:09 +00:00
Fengjiang Li 177e9b6832 Merge "[5/n] Log cardinality to StatsLogManager" into udc-dev am: d382a4880b am: 77f1806491 am: 9c8e386d85 am: ac374fa2b5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23088599

Change-Id: I80cdca32635accffba42947e0fbc23fb7394b0e0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 12:58:51 +00:00
Jagrut Desai bd8a4276d4 Merge "Un-Split TaplTestsTaskbar" into udc-dev am: 53b4435b7e am: 7644472fa4 am: 22c8174392 am: d7f5282082
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22821856

Change-Id: I0d053891792657e8755190f21485866bb0e360cb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 12:57:11 +00:00
Schneider Victor-tulias 6d5cf3c59d Merge "Fix tutorial menu layout issues" into udc-dev am: 458971616d am: 6a4bd3b6b5 am: 8fed7a9b1f am: 3520eea285
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23089641

Change-Id: Ibb5b06cf538052c5c03eec26ce1a2140ecc1c6c4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 12:57:01 +00:00
Vinit Nayak 8227231dd8 Merge "Restore Recents TaskView based on all taskIDs, not first" into udc-dev am: 5f475a2f48 am: 5fd826d4d2 am: e0b0c18b46 am: dfce80f064
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22998399

Change-Id: I5afdb5ddbd6b8d8c1ceef9872baa7cf25dade7ce
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 12:56:45 +00:00
Liran Binyamin 3e368b0bf3 Merge "Wire up the important conversation bit in BubbleBarController." into udc-dev am: a72094ad66 am: dbb218b0bd am: cfe4f2b7fc am: ec0db4d268
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23039499

Change-Id: Iecc3e7afd8f4537a9a33cce0bdcc737783e12bb3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 09:45:15 +00:00
Bill Yi 6c71dd98bd Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I135bf2eb01ecd6eab0ac44071cdb56df235efbbb
2023-05-09 18:36:31 -07:00
Bill Yi cd5558fcd9 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If7588e84680dbc8f4fcc616af06914ab7c57d1a7
2023-05-09 16:04:17 -07:00
Fengjiang Li 4f767cfc5b Merge "[5/n] Log cardinality to StatsLogManager" into udc-dev am: d382a4880b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23088599

Change-Id: I729273082342f4559c32eff5408e765720bcf154
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 22:02:46 +00:00
Fengjiang Li 77f1806491 Merge "[5/n] Log cardinality to StatsLogManager" into udc-dev am: d382a4880b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23088599

Change-Id: Ie4234f9196ca701c78bf7393a0072d7a4147c3c0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 21:57:19 +00:00
Jagrut Desai 4aa44e5169 Fixing NPE in TransfromParams.java
- we were not actually using mRecentsSurface so we no longer need to compute that. By removing this we will also fix the NPE.

Test: Pre-Submit
Fixes: 269716918
Flag: not needed
Change-Id: Ief4be341061a1c914456d6740f175662ccebc364
2023-05-09 14:45:17 -07:00
Fengjiang Li d382a4880b Merge "[5/n] Log cardinality to StatsLogManager" into udc-dev 2023-05-09 21:33:36 +00:00
Jagrut Desai 22c8174392 Merge "Un-Split TaplTestsTaskbar" into udc-dev am: 53b4435b7e am: 7644472fa4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22821856

Change-Id: I28feff640481a154fb1141622f589c1364f4506e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 21:33:19 +00:00
Schneider Victor-tulias 8fed7a9b1f Merge "Fix tutorial menu layout issues" into udc-dev am: 458971616d am: 6a4bd3b6b5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23089641

Change-Id: Ib2408817c05e198fe6b5590bb049f6139016bf0a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 21:33:12 +00:00
Vinit Nayak e0b0c18b46 Merge "Restore Recents TaskView based on all taskIDs, not first" into udc-dev am: 5f475a2f48 am: 5fd826d4d2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22998399

Change-Id: Ib78ef57f38653663a07dfb49b9191c14abba5469
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 21:33:04 +00:00
Jagrut Desai 0414930150 Merge "Un-Split TaplTestsTaskbar" into udc-dev am: 53b4435b7e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22821856

Change-Id: I8abc321724b901da201214975309690cf844ff41
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 20:55:14 +00:00
Schneider Victor-tulias 9bdeeb9f18 Merge "Fix tutorial menu layout issues" into udc-dev am: 458971616d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23089641

Change-Id: Ieffbff7adf222645c66dc9e6f6ad1a3e251f333e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 20:55:05 +00:00
Vinit Nayak 4656cd1846 Merge "Restore Recents TaskView based on all taskIDs, not first" into udc-dev am: 5f475a2f48
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22998399

Change-Id: I603fef8494698880c08f253b261e5c6b2a29345b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 20:54:56 +00:00
Jagrut Desai 05af38cb53 Merge "Un-Split TaplTestsTaskbar" into udc-dev am: 53b4435b7e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22821856

Change-Id: I3f369a4c362bc06d26b6f5b52cd6c6c871456c6b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 20:50:54 +00:00
Schneider Victor-tulias 4f9ddc0db4 Merge "Fix tutorial menu layout issues" into udc-dev am: 458971616d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23089641

Change-Id: I6c5a6ae225028f269be2976a57405adeeb7f38aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 20:50:44 +00:00
Vinit Nayak 1529c40e6a Merge "Restore Recents TaskView based on all taskIDs, not first" into udc-dev am: 5f475a2f48
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22998399

Change-Id: I4b5d6f902fc34967c72db5fd790b0328243b2512
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 20:50:26 +00:00
Jagrut Desai 53b4435b7e Merge "Un-Split TaplTestsTaskbar" into udc-dev 2023-05-09 20:43:01 +00:00
Liran Binyamin 4e909d07ac Animate the position of the selected bubble arrow in the expanded bubble bar.
Fixes: 280605070
Test: Tested on a physical device
Change-Id: I961254527ba9a26d211c2c348a937a424fa2fb4d
2023-05-09 16:35:30 -04:00
Schneider Victor-tulias 458971616d Merge "Fix tutorial menu layout issues" into udc-dev 2023-05-09 20:18:07 +00:00
Vinit Nayak 5f475a2f48 Merge "Restore Recents TaskView based on all taskIDs, not first" into udc-dev 2023-05-09 20:15:01 +00:00
Liran Binyamin b4d3315caa Merge "Wire up the important conversation bit in BubbleBarController." into udc-dev am: a72094ad66
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23039499

Change-Id: Icb686c04bea438aa9bc5bdf6d741f7336229b142
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 19:44:19 +00:00
Mady Mellor 7344766886 Modify Taskbar code to accommodate bubble bar gesture to stash/unstash
* Bubble bar typically follows the behavior of taskbar - if taskbar
  is shown, the bubble bar is shown, if taskbar hides, bubble bar
  hides.
* The bubble bar has 3 states: stashed, collapsed (unstashed but
  the bubbles are not expanded), and expanded. When bubbles are
  expanded, this means WMShell is rendering the bubble
  expanded view. In this situation taskbar becomes collapsed.

Bug: 253318833
Test: manual, with other CLs, see go/bubble-bar-tests
Flag: WM_BUBBLE_BAR
Change-Id: Ic210c382e7482c259ae543a0dc083fe9305cbf5b
2023-05-09 12:37:14 -07:00
Liran Binyamin cfe4f2b7fc Merge "Wire up the important conversation bit in BubbleBarController." into udc-dev am: a72094ad66 am: dbb218b0bd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23039499

Change-Id: Icf4927c14ff52a0b1905d827b0727d0edea92927
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 19:19:21 +00:00
Liran Binyamin 6e6705a6bd Merge "Wire up the important conversation bit in BubbleBarController." into udc-dev am: a72094ad66
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23039499

Change-Id: Iccf82ac63ea13c11a35f217ad223c4c6ce676a06
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 18:09:48 +00:00
Liran Binyamin a72094ad66 Merge "Wire up the important conversation bit in BubbleBarController." into udc-dev 2023-05-09 18:02:53 +00:00
Jagrut Desai 1516b2b912 Merge "Taskbar All Apps Icon Shortcuts Popup Accesiiblity" into udc-dev am: 75109c7abc am: a5df34e1c8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23035380

Change-Id: Ic832ae5d1ee57b204b4ece4e2b21b24295e6585e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 17:38:23 +00:00
Jagrut Desai cc9375ce15 Merge "Taskbar All Apps Icon Shortcuts Popup Accesiiblity" into udc-dev am: 75109c7abc am: d015685ec7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23035380

Change-Id: I3fb8d59ac870ea0efcebe20d9c84162c008be59d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 17:38:22 +00:00
Jagrut Desai 9349dc9e1d Merge "Taskbar All Apps Icon Shortcuts Popup Accesiiblity" into udc-dev am: 75109c7abc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23035380

Change-Id: I5b674580376f99dd1eebb8926f7303b098c7e569
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 17:00:51 +00:00
Jagrut Desai a5df34e1c8 Merge "Taskbar All Apps Icon Shortcuts Popup Accesiiblity" into udc-dev am: 75109c7abc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23035380

Change-Id: I4a0253c3bd37820dfaf0d4f46592d87d5b7b9215
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 16:57:57 +00:00
Jagrut Desai 9569ce86a2 Un-Split TaplTestsTaskbar
Before we use TaskbarModeSwitch but had a drawback where we would not know which variant of taskbar the test failed for. So, we split the taskbar tests into transient and persistent for better error logs and debugging.
But, now we can use Parameterized Test Runner to achieve the same and do not have to duplicate test code for testing two different variants of Taskbar.

There can be instances where we only want to test certain taskbar variant only, we have separated files for that.

Test: Presubmit
Bug: 267648422
Flag: not needed
Change-Id: I4322498f13d257a5f1793b008f45b09ac9b9f3ff
2023-05-09 09:36:09 -07:00
Jagrut Desai 75109c7abc Merge "Taskbar All Apps Icon Shortcuts Popup Accesiiblity" into udc-dev 2023-05-09 16:19:44 +00:00
Vinit Nayak f13afc3d58 Enable flag ENABLE_SPLIT_LAUNCH_DATA_REFACTOR am: b33a2e0762 am: 3c5a757b24
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22958378

Change-Id: Ibe3157b16ed9a47ea44ffe08d48cf59376cf8e55
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 10:46:30 +00:00
Vinit Nayak 3c5a757b24 Enable flag ENABLE_SPLIT_LAUNCH_DATA_REFACTOR am: b33a2e0762
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22958378

Change-Id: I9e5a7f273d0d17f2c8c979fa943f52d4a728c3e6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 08:00:35 +00:00
Vinit Nayak 2a077e73cf Enable flag ENABLE_SPLIT_LAUNCH_DATA_REFACTOR am: b33a2e0762
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22958378

Change-Id: Iff36d989bdcaae465b2e9a59e3a0d67588b4da8b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 07:12:26 +00:00
Winson Chung 4eee2abb49 Merge "Potential fix for end callback not being run in 3-button" into udc-dev am: 606c4bfc59 am: 047f92d81e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23019205

Change-Id: I5a7abb345f02ba06462350010364d0a98a58f1a4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 01:06:29 +00:00
Vinit Nayak b33a2e0762 Enable flag ENABLE_SPLIT_LAUNCH_DATA_REFACTOR
Flag: ENABLE_SPLIT_LAUNCH_DATA_REFACTOR
Bug: 279494325
Change-Id: I9c58ba50f0269c69a12f548a1873c2d8251f6243
2023-05-08 17:27:03 -07:00
Winson Chung 11ace3672a Merge "Potential fix for end callback not being run in 3-button" into udc-dev am: 606c4bfc59
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23019205

Change-Id: Ie5f14a244232f96171e158932f4f4c06740b21de
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 00:18:51 +00:00
Winson Chung 047f92d81e Merge "Potential fix for end callback not being run in 3-button" into udc-dev am: 606c4bfc59
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23019205

Change-Id: I6ab89a4f13d85c02b14608e74291ba2892484d6d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 00:17:26 +00:00
Jagrut Desai 29fcd9a636 Taskbar All Apps Icon Shortcuts Popup Accesiiblity
Before we were only applying the icon.clearAccessibilityFocus() only on normal popup and not material u popups, since the flag is turned on for udc, we can move it outside.

There seems to be a bug associated with either nested abstract floating views or the accessibility service where upon opening a nested abstract floating view from another the icon get the focus. This change make the bug littl less visible to use but users will still see this bug if they open the shortcut pop agian withought closing taskbar all apps.

The accessibility delegate was always null when using the TaskbarOverlayContext, now we use TaskbarActivityContext Delegate when in TaskbarOverlayContext.

Test: Manual
Bug: 280657266
Flag: not needed
Change-Id: I631e3aa6e54748c4c8ea2ac7daf5473b198e47d6
2023-05-08 16:25:53 -07:00
Fengjiang Li d9253224b3 [5/n] Log cardinality to StatsLogManager
Test: app builds
Bug: 278271805
Change-Id: Ia0180815509759caf867296a7941fa32402d8f45
2023-05-08 16:13:05 -07:00
Schneider Victor-tulias c50f870625 Fix tutorial menu layout issues
- Fixed back button image padding (and updated all other images to prevent hidden padding)
- fixed done button size
- padding top and bottom insets for status bar and nav bar

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fixes: 281121442
Fixes: 281121138
Test: launched the tutorial menu on handheld, foldable and tablet, compared before/after pictures
Change-Id: I61bce2fc4a8d3824048229e0d48f9a429c80a204
2023-05-08 15:43:39 -07:00
Vinit Nayak f46fa7ac49 Restore Recents TaskView based on all taskIDs, not first
* Return a copy of taskIds in TaskView#getTaskIds() to
prevent accessors from getting clobbered values
* In RecentsView#applyLoadPlan we overwrite values in that
array, so callers using it to cache old values would read
incorrect values when reading it after a TaskView has been
bound to new tasks.
* Load/Unload visible task data for all tasks in a given
TaskView, not just single task <-- probably not necessary for
bug fix, but seems sensible

Flag: none
Fixes: 266905177
Test: Quickswitch works as expected. Currently
unable to test thumbnails (created b/281582106)
Change-Id: Ifd4d8a856976ab9cc200b0f61eca1c68897f343c
2023-05-08 22:34:29 +00:00
TreeHugger Robot b841d5267c Merge "Use a property instead of a getter function for key in BubbleBarBubble. Using a property here is more Kotlin idiomatic." into udc-dev am: 35f5bfea4c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23058990

Change-Id: I9e4d381b1f43ec435e8dc5c94c627d69281c576b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-08 21:35:14 +00:00
TreeHugger Robot ad8865524d Merge "Use a property instead of a getter function for key in BubbleBarBubble. Using a property here is more Kotlin idiomatic." into udc-dev am: 35f5bfea4c am: 4da033b59b am: aa5076a8a6 am: 1d55dcb4f2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23058990

Change-Id: Ia9de27233f2caeed768a123f9b68e476a7014d95
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-08 21:17:27 +00:00
Winson Chung 606c4bfc59 Merge "Potential fix for end callback not being run in 3-button" into udc-dev 2023-05-08 21:13:01 +00:00