Commit Graph

19452 Commits

Author SHA1 Message Date
Winson Chung 0da5208bb3 Merge "Workaround for handling the restart of an already visible task" into udc-dev 2023-06-28 05:51:59 +00:00
Winson Chung 57c2a79e47 Workaround for handling the restart of an already visible task
- If a task is already visible, then startActivity is a no-op and the
  remote transition that launcher expects to run is not started. As a
  workaround (until restarts are an actual transition), listen for
  the case where a task is restarted and invoke the end callbacks

Fixes: 286016555
Test: Repro steps on the bug
Change-Id: Iec3ab97c8817a5e95399cec90f891d65f369d234
2023-06-28 05:51:54 +00:00
Jerry Chang 3651051182 Polish home-key from split to pip transition
Includes WINDOWING_MODE_MULTI_WINDOW closing target to the condition of
playing fallback animation. So the remaining splitting task won't be
play with iconview animation when home-key to auto-pip consumed another
splitting task in pip transition handler.

Bug: 281476331
Test: repro steps of the bug
Test: pass existing tests
Video: http://recall/-/fLARJNt42LVxc3tt86SneW/eelqATeE1REoOtOEDxeDVR
Change-Id: If05d8841a6a940e61f71683422ef1a3d4e3597c7
2023-06-28 02:10:34 +00:00
Jerry Chang 8a7181d45e Prevent exception when quick switching between two split pairs
When switching in between two split pairs just quick enough, it is
possible to send the second entering split transition while it is
animating the first entering split transition which is merged to a
recents-during-split transition. The split parents might not be
collected into the second transition because the split parents are
already visible at that time, and there is no recents transition to
merge to. So updates to not throwing when there is no split parent when
composing a recents-to-split animation.

Bug: 236226779
Test: repro steps of the bug and the Launcher won't throw
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:97eb471f2efda1eccce7eba8c68301b2fa34c5e7)
Merged-In: I3a595722721186e8de7d60c9fb8c099ec799804a
Change-Id: I3a595722721186e8de7d60c9fb8c099ec799804a
2023-06-28 01:27:37 +00:00
Winson Chung 18f815a7fd Restore strong reference to animation runner
- The remote animation factory needs to be strongly referenced since
  the only other reference is a weakly held one from
  LauncherAnimationRunner, and if a gc happens in between starting
  the animation and the onAnimationStart() callback, then the
  animation will not play.

Fixes: 284106887
Test: Force a gc after creating a remote app launch animation and ensure
      that the runner still exists when the animation starts
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:6cfe2e6cbe52f5fc9aa0eb94afaeb7679810cc13)
Merged-In: I5f584451b41c666916801b8ea0cb470c7ab9fc51
Change-Id: I5f584451b41c666916801b8ea0cb470c7ab9fc51
2023-06-28 01:27:30 +00:00
Tracy Zhou 0b767c91b5 Use DisplayController.Info to determine if it's a tablet
Fixes: 286942201
Test: N/A
Change-Id: Iabcceaee45f885f1dd188d3ab9039ffd3a036a0e
2023-06-28 00:20:12 +00:00
TreeHugger Robot 9b78cb79a1 Merge "Removing explicit target SDK for launcher" into udc-qpr-dev am: d5b3a0a099 am: 7cccf75c64
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23783071

Change-Id: Icda07370205a231fbb8e6535ff2aef757074586c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 23:15:40 +00:00
TreeHugger Robot 7cccf75c64 Merge "Removing explicit target SDK for launcher" into udc-qpr-dev am: d5b3a0a099
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23783071

Change-Id: Id58dbf1f9cd64148cac79bb464ad2752f6ea3de3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 22:34:54 +00:00
TreeHugger Robot d5b3a0a099 Merge "Removing explicit target SDK for launcher" into udc-qpr-dev 2023-06-27 22:34:40 +00:00
Vadim Tryshev 2ba42ef94d Removing ViewCaptureAnalysisRule
Bug: 286251603
Test: presubmit
Flag: N/A
Change-Id: I0123ed3892bbfd6d0e880141ace878b6204dbd81
2023-06-27 22:12:45 +00:00
Andy Wickham 5555ce326d Disable all apps from overview in some cases.
Specifically, whenever floating search bar would not show in
Overview, we also disable this all apps gesture. This covers
cases such as:
 - Landscape on phones
 - Tablets where taskbar shows in Overview

Note this does not depend on ENABLE_FLOATING_SEARCH flag state.
Just reuses the same LauncherState logic used for that.

Bug: 275132633
Test: Manual on tablet, phone, foldable
Flag: ENABLE_ALL_APPS_FROM_OVERVIEW
Change-Id: I6d6cc404a7dfef7c78b45ac830878032027156d8
2023-06-27 14:53:19 -07:00
Jerry Chang 84d1f66990 Merge "Prevent exception when quick switching between two split pairs" into udc-dev am: 26d5493e69 am: 71fe404fd1 am: 8017561997
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23792388

Change-Id: Ie842fb4759b7c9d5c8955446649c9827c4d33fbb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 19:57:14 +00:00
Jerry Chang c2bac08fac Merge "Prevent exception when quick switching between two split pairs" into udc-dev am: 26d5493e69 am: 71fe404fd1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23792388

Change-Id: If3b1a1a4bef71e51c70d072f9f4c5c6a03ea78ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 19:10:19 +00:00
Jerry Chang 8017561997 Merge "Prevent exception when quick switching between two split pairs" into udc-dev am: 26d5493e69 am: 71fe404fd1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23792388

Change-Id: I1353ee8448b455e905cab194ea9070d42a72af5f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 19:08:17 +00:00
Jerry Chang 6c1b484ef3 Merge "Prevent exception when quick switching between two split pairs" into udc-dev am: 26d5493e69 am: 6789ed4838
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23792388

Change-Id: I7e9847edc6dceafa207d065f4fc721475337d043
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 19:07:59 +00:00
Jerry Chang 6789ed4838 Merge "Prevent exception when quick switching between two split pairs" into udc-dev am: 26d5493e69
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23792388

Change-Id: I54d305b705fbc8b9f94fdfe21710f5ff89ba64aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 18:26:23 +00:00
Mady Mellor 5eed242647 Merge changes Iaee9aeb0,I76587cf6 into udc-qpr-dev am: d8cb90f010 am: 637148f7c1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23709211

Change-Id: I0a843cc85d2e6f152b95498f526bebc29bfcfa16
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 18:24:32 +00:00
Mady Mellor 637148f7c1 Merge changes Iaee9aeb0,I76587cf6 into udc-qpr-dev am: d8cb90f010
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23709211

Change-Id: I1b9adea75976af4ef9c186ec69277bf51b5dfa31
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 17:43:35 +00:00
Jerry Chang 26d5493e69 Merge "Prevent exception when quick switching between two split pairs" into udc-dev 2023-06-27 17:42:42 +00:00
Mady Mellor d8cb90f010 Merge changes Iaee9aeb0,I76587cf6 into udc-qpr-dev
* changes:
  Fade the bubble bar arrow in and out when the bubble bar expands and collapses.
  Animate the bubble bar width and the bubbles within it as it expands and collapses.
2023-06-27 17:35:58 +00:00
Anvesh Renikindi d8af5abcfd Merge "Update renamed util function M3HCTToColor in launcher code" into udc-dev-plus-aosp 2023-06-27 14:54:49 +00:00
TreeHugger Robot bb96bfdcfa Merge "Restore strong reference to animation runner" into udc-dev am: 1f3c56af5b am: 7733c11623 am: 796c3bbd02
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23793397

Change-Id: I5271737bd92ddabdf19dcc8d48e769f84f715b9e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 04:42:53 +00:00
TreeHugger Robot 796c3bbd02 Merge "Restore strong reference to animation runner" into udc-dev am: 1f3c56af5b am: 7733c11623
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23793397

Change-Id: I5f485e204fa56b319f250a467eb448622be9f01f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 03:54:56 +00:00
TreeHugger Robot a262c0afaa Merge "Restore strong reference to animation runner" into udc-dev am: 1f3c56af5b am: 0d8c02d68b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23793397

Change-Id: I823e60fe5da6337a5b789a46ce4eb46a5fe052c9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 03:50:41 +00:00
Randy Pfohl 325bd83a1e Merge "Updating content description for accessibility no matter the state" into udc-qpr-dev am: 2310a890c2 am: 72c638fb9c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23815319

Change-Id: Id278367bfc9117da2193f4e9ec726dc49bd3f4a3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 03:07:21 +00:00
TreeHugger Robot 0093120979 Merge "Restore strong reference to animation runner" into udc-dev am: 1f3c56af5b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23793397

Change-Id: Ibc13e029b1d318f501e1cc787f2ee7724b686538
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 03:05:09 +00:00
TreeHugger Robot 0d8c02d68b Merge "Restore strong reference to animation runner" into udc-dev am: 1f3c56af5b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23793397

Change-Id: Ib400f66303c40a4af5ce57e00ec70cf73accc501
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 03:04:10 +00:00
TreeHugger Robot f6d2f1e85f Merge "Restore strong reference to animation runner" into udc-dev am: 1f3c56af5b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23793397

Change-Id: I70d2136553f594147ba92ddd09a3afd25163b7d4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 03:04:07 +00:00
TreeHugger Robot 1f3c56af5b Merge "Restore strong reference to animation runner" into udc-dev 2023-06-27 02:13:00 +00:00
Randy Pfohl 72c638fb9c Merge "Updating content description for accessibility no matter the state" into udc-qpr-dev am: 2310a890c2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23815319

Change-Id: I94f66b0347354edde1ac42218faa72ae3b6c5b13
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-27 01:57:23 +00:00
Randy Pfohl 2310a890c2 Merge "Updating content description for accessibility no matter the state" into udc-qpr-dev 2023-06-27 01:13:53 +00:00
Winson Chung 5148c096e1 Fix NPE due to invalid RecentsView access
Fixes: 288829919
Test: N/a, reorganizing code behind null check
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:cdf410f1349edf3451e1a8af64ea2d8cd676ffaa)
Merged-In: I9efe48cab239b521f7e729af06706c352be2499c
Change-Id: I9efe48cab239b521f7e729af06706c352be2499c
2023-06-27 00:42:01 +00:00
Winson Chung 6cfe2e6cbe Restore strong reference to animation runner
- The remote animation factory needs to be strongly referenced since
  the only other reference is a weakly held one from
  LauncherAnimationRunner, and if a gc happens in between starting
  the animation and the onAnimationStart() callback, then the
  animation will not play.

Fixes: 284106887
Test: Force a gc after creating a remote app launch animation and ensure
      that the runner still exists when the animation starts

Change-Id: I5f584451b41c666916801b8ea0cb470c7ab9fc51
2023-06-26 23:55:23 +00:00
randypfohl 442b93c9c9 Updating content description for accessibility no matter the state
Test: built and tested locally by opening apps and then turning on talkback to verify content description is set

Bug:280908761

Change-Id: I9ed015bdd375e2cedf5e068a77bd4b4dcb5f9488
2023-06-26 13:24:58 -07:00
Winson Chung cec8dcaa5c Merge "Fix NPE due to invalid RecentsView access" into udc-dev am: fa3434fc37 am: b578dac96e am: bb4c513353
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23810649

Change-Id: I008ca0f7b6ef75730e3666f7eff2b79d70d4795a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-26 20:20:42 +00:00
fbaron ed79206e4b Update renamed util function M3HCTToColor in launcher code
Bug: 288120001
Test: none
Change-Id: If4c6783472d7fa05a1162e2f176a613d28f7bec3
Merged-In: If4c6783472d7fa05a1162e2f176a613d28f7bec3
(cherry picked from commit 911be164b3)
2023-06-26 20:17:17 +00:00
Winson Chung 23fb63f09e Merge "Fix NPE due to invalid RecentsView access" into udc-dev am: fa3434fc37 am: b578dac96e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23810649

Change-Id: I3ee6069ad3664c32ed9a042270fc836a59b0a44b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-26 19:31:58 +00:00
Winson Chung 6cd794b8b8 Merge "Fix NPE due to invalid RecentsView access" into udc-dev am: fa3434fc37 am: 63090e9506
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23810649

Change-Id: I01ab56e4355dd7caca41a68001bda1dc97684296
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-26 19:30:57 +00:00
Winson Chung bb4c513353 Merge "Fix NPE due to invalid RecentsView access" into udc-dev am: fa3434fc37 am: b578dac96e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23810649

Change-Id: I536eb6c420d7643f588e2c2a2ae638bc32d5df7c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-26 19:29:33 +00:00
Winson Chung 24fe986f33 Merge "Fix NPE due to invalid RecentsView access" into udc-dev am: fa3434fc37
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23810649

Change-Id: I0b9effb60c025ea9708455033c3a8d02e92bb85d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-26 18:25:56 +00:00
Winson Chung 63090e9506 Merge "Fix NPE due to invalid RecentsView access" into udc-dev am: fa3434fc37
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23810649

Change-Id: I9eed5f3291a942f9067573bcf4e92ea23d326779
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-26 18:25:10 +00:00
Winson Chung a19fd9e47d Merge "Fix NPE due to invalid RecentsView access" into udc-dev am: fa3434fc37
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23810649

Change-Id: I03007bf70522634a20ccaffc03738bc051304012
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-26 18:25:03 +00:00
Schneider Victor-tulias 7ce03b3d82 Merge "Remove unnecessary method from StatefulActivity" into udc-qpr-dev am: a4d1e9aa99 am: ff9dd63c0c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23783063

Change-Id: I7de2d67e8c701fc0bb6bf7f9490b96227491c65b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-26 18:04:04 +00:00
Winson Chung fa3434fc37 Merge "Fix NPE due to invalid RecentsView access" into udc-dev 2023-06-26 17:47:49 +00:00
Winson Chung cdf410f134 Fix NPE due to invalid RecentsView access
Fixes: 288829919
Test: N/a, reorganizing code behind null check
Change-Id: I9efe48cab239b521f7e729af06706c352be2499c
2023-06-26 17:47:33 +00:00
Schneider Victor-tulias ff9dd63c0c Merge "Remove unnecessary method from StatefulActivity" into udc-qpr-dev am: a4d1e9aa99
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23783063

Change-Id: I059ef019493ef7cfe8411b134a113405f839c93c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-26 17:47:19 +00:00
Sunny Goyal b02dafc1d4 Removing explicit target SDK for launcher
> It will automatically target the latest SDK it was compiled with

Bug: 284349887
Test: Presubmit and manual
Flag: N/A
Change-Id: I32629b0dd710c3c04d8f70f988b7279e7cae6731
2023-06-26 10:15:14 -07:00
Schneider Victor-tulias a4d1e9aa99 Merge "Remove unnecessary method from StatefulActivity" into udc-qpr-dev 2023-06-26 16:41:12 +00:00
Jerry Chang 97eb471f2e Prevent exception when quick switching between two split pairs
When switching in between two split pairs just quick enough, it is
possible to send the second entering split transition while it is
animating the first entering split transition which is merged to a
recents-during-split transition. The split parents might not be
collected into the second transition because the split parents are
already visible at that time, and there is no recents transition to
merge to. So updates to not throwing when there is no split parent when
composing a recents-to-split animation.

Bug: 236226779
Test: repro steps of the bug and the Launcher won't throw
Change-Id: I3a595722721186e8de7d60c9fb8c099ec799804a
2023-06-26 13:49:37 +00:00
Bill Yi fe3d456941 Merge "Import translations. DO NOT MERGE ANYWHERE" 2023-06-24 01:58:20 +00:00