Commit Graph

19452 Commits

Author SHA1 Message Date
Treehugger Robot dd262b4617 Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev am: 2c3c1e46c0 am: 4de15620c2 am: 120c78d24f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23852178

Change-Id: I852fc4d1f95af8ef5be6fa02dd1d1d404b8cd92a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 19:28:58 +00:00
Holly Jiuyu Sun bdd0859b8a Merge "[a11y] Fix crash when using talkback to add to home screen." into udc-qpr-dev am: 18e0e1e50a am: d91ee8f9af
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23849395

Change-Id: I2c5cc943205c9fb6528090ee64d539e0f0dca3a5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 19:06:02 +00:00
Treehugger Robot 957d46ae52 Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev am: 2c3c1e46c0 am: 4de15620c2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23852178

Change-Id: Idbb6ded338cf1fe3db8142ba75d54844a9bf1382
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 19:05:32 +00:00
Treehugger Robot 120c78d24f Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev am: 2c3c1e46c0 am: 4de15620c2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23852178

Change-Id: I1302f2aeaeb17fa95a1a64cb2e095febadcacba1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 19:03:05 +00:00
Treehugger Robot 20fa45a004 Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev am: 2c3c1e46c0 am: 67b5bc8c4c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23852178

Change-Id: Iab9ff4080c4f4d36918538c686dec5ea4af35fbe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 19:03:05 +00:00
Holly Jiuyu Sun d91ee8f9af Merge "[a11y] Fix crash when using talkback to add to home screen." into udc-qpr-dev am: 18e0e1e50a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23849395

Change-Id: I677a0e430b79b13a85f955a85421d78c5a166969
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 18:27:19 +00:00
Treehugger Robot 67b5bc8c4c Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev am: 2c3c1e46c0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23852178

Change-Id: I68510c624c597e572dd4e06b0e36c6d994c60ce1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 18:22:29 +00:00
Holly Jiuyu Sun 18e0e1e50a Merge "[a11y] Fix crash when using talkback to add to home screen." into udc-qpr-dev 2023-06-30 17:56:16 +00:00
Treehugger Robot 2c3c1e46c0 Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev 2023-06-30 17:45:50 +00:00
Holly Sun 35b9960b63 [a11y] Fix crash when using talkback to add to home screen.
1. Fix a crash from http://cs/android-internal/packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=1928;rcl=d677caa75de74f1c3a88367cad67ae405fd2903d. It can also be `ITEM_TYPE_SEARCH_ACTION`. Remove the `itemType` check and just use the `PendingAddItemInfo` class type.
2. Override `startConfigActivity` in `PinShortcutRequestActivityInfo`, so that `Launcher#onActivityResult` can be triggered properly from `Launcher#processShortcutFromDrop` (http://cs/android-internal/packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=1939;rcl=d677caa75de74f1c3a88367cad67ae405fd2903d )
3. Then we call to `Launcher#completeAdd` -> `completeAddShortcut`. The original `info` passed to `processShortcutFromDrop` doesn’t have a `componentName` (new code), so remove the component non-null check from `completeAddShortcut`.

Bug: 287166186
Bug: 287167527
Bug: 287166771
Test: manual
Flag: N/A
Change-Id: Id3e1444de188f2d2af760f58e3d9814a2b7abd88
2023-06-30 08:42:31 -07:00
Jerry Chang 4fdf5684fe Polish home-key from split to pip transition
Includes WINDOWING_MODE_MULTI_WINDOW closing target to the condition of
playing fallback animation. So the remaining splitting task won't be
play with iconview animation when home-key to auto-pip consumed another
splitting task in pip transition handler.

Bug: 281476331
Test: repro steps of the bug
Test: pass existing tests
Video: http://recall/-/fLARJNt42LVxc3tt86SneW/eelqATeE1REoOtOEDxeDVR
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:365105118220b218005225b038142273524877cc)
Merged-In: If05d8841a6a940e61f71683422ef1a3d4e3597c7
Change-Id: If05d8841a6a940e61f71683422ef1a3d4e3597c7
2023-06-30 03:17:29 +00:00
Treehugger Robot 5bd1453eb7 Merge "Disable all apps from overview in some cases." into udc-qpr-dev am: 1b565681fe am: 5a56f8f111
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23835679

Change-Id: I80826678c725308991bbf234528fa624735371a2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 00:35:42 +00:00
Treehugger Robot 5a56f8f111 Merge "Disable all apps from overview in some cases." into udc-qpr-dev am: 1b565681fe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23835679

Change-Id: I02604078e3f4dcfc6413916a8c47f7c6cce934bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 00:11:09 +00:00
Treehugger Robot 1b565681fe Merge "Disable all apps from overview in some cases." into udc-qpr-dev 2023-06-29 23:52:09 +00:00
Brandon Dayauon 70cda84fd7 Merge "Fix prediction row title consistency" into udc-qpr-dev am: aa9332af88 am: 69be4ccd17
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23815838

Change-Id: I05bf5293621c520d13ef248609f87e46b6d703d0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 23:00:02 +00:00
Brandon Dayauon 69be4ccd17 Merge "Fix prediction row title consistency" into udc-qpr-dev am: aa9332af88
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23815838

Change-Id: I38ea618a57778e567608de1c5ecbc8e76d02030c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 22:38:46 +00:00
Brandon Dayauon aa9332af88 Merge "Fix prediction row title consistency" into udc-qpr-dev 2023-06-29 21:45:40 +00:00
Hongwei Wang e359184522 Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a am: 93551e9496 am: 263aceeeea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485

Change-Id: I55f4709943f4373b71a7dff8fbcd7c1f660a9a40
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 18:23:48 +00:00
Hongwei Wang 49b9fbd188 Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a am: 93551e9496
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485

Change-Id: I0a6ef4eee4dfc6244b5ee4a7716c1e625923d4b8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 17:58:16 +00:00
Hongwei Wang b2cefbeaed Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a am: 036ed78e3b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485

Change-Id: I0910e0a8ada84d015cfee8e80581a4e86915ab8a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 17:56:59 +00:00
Hongwei Wang 263aceeeea Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a am: 93551e9496
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485

Change-Id: I6d23eca98f12691d3f87af8fedf8049f27125194
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 17:56:29 +00:00
Hongwei Wang 036ed78e3b Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485

Change-Id: If80e354c9e21be74828936960176353e0cea7179
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 17:36:05 +00:00
Hongwei Wang ca08d75e4a Merge "Polish home-key from split to pip transition" into udc-dev 2023-06-29 17:17:03 +00:00
Winson Chung 5cdfa120df Workaround for handling the restart of an already visible task
- If a task is already visible, then startActivity is a no-op and the
  remote transition that launcher expects to run is not started. As a
  workaround (until restarts are an actual transition), listen for
  the case where a task is restarted and invoke the end callbacks

Fixes: 286016555
Test: Repro steps on the bug
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:57c2a79e47bc583306bd77ea3039d821a8d33dde)
Merged-In: Iec3ab97c8817a5e95399cec90f891d65f369d234
Change-Id: Iec3ab97c8817a5e95399cec90f891d65f369d234
2023-06-29 03:39:15 +00:00
Tracy Zhou a334a1aca3 Merge "Use DisplayController.Info to determine if it's a tablet" into udc-qpr-dev am: 96fc36f614 am: afd4eec779
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23835676

Change-Id: I33f8c753238d3dc70033e6c82cc70a0ed2623ea1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 03:12:43 +00:00
Jon Miranda 3bad3ebaad Cleans up bad state when transient taskbar shows on home.
Bug: 279514548
Test: open transparent activity on top of launcher
      unstash taskbar
      go home

Change-Id: I13ab79b334e1f8feda441a82cc4d035c0142f513
2023-06-29 02:51:38 +00:00
Tracy Zhou afd4eec779 Merge "Use DisplayController.Info to determine if it's a tablet" into udc-qpr-dev am: 96fc36f614
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23835676

Change-Id: Ia4b95d8ace26619a0993eddbdb4139f872035cc1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 02:29:46 +00:00
Tracy Zhou 96fc36f614 Merge "Use DisplayController.Info to determine if it's a tablet" into udc-qpr-dev 2023-06-29 01:34:00 +00:00
Jeremy Sim ef603e6ddd Add logcat logs for splitscreen launch failures
This patch makes it so that splitscreen launch failures (when app doesn't support splitscreen, or multi-instance, or if app crashes) are logged in logcat.

Fixes: 280494204
Test: Manual
Change-Id: If12a0c71e88b7b783be505e8a4caabeecc241dd9
2023-06-28 23:36:54 +00:00
Jeremy Sim d2255f2b79 Remove flag ENABLE_LAUNCH_FROM_STAGED_APP
This patch makes it so that the "launch from staged app" feature, which has been enabled since TQPR3, has its flag removed.

Fixes: 270395567
Test: None
Change-Id: I46878475c0dac5a3d64938ec9dfa5ca4123c7bb4
2023-06-28 22:45:32 +00:00
Jagrut Desai 53d953ccd2 Taskbar All Apps Shortcut Menu Acccessibility Focus
Bug: 280657266
Test: manual
Flag: not needed
Change-Id: I2426636067ce3635b8b24b9f5d093dad7d9ddf4c
2023-06-28 14:48:54 -07:00
Brandon Dayauon f2ea399ec6 Fix prediction row title consistency
There's an inconsistency with prediction row in 0-state and all apps page.
This happens because we change the number of lines (to 1 line) after calculating and rendering the two lines.
Which is why if you look at the photos, in all apps, Amazon app just shows "Amazon" instead of "Amazon Sh.."

Instead of changing the number of lines after processing, just set a separate display to the prediction app row

bug:288811197
Flag: teamfood
Test: manual - locally added test BubbleTextView
before 0-state: https://screenshot.googleplex.com/5q9iYypgwwtDa8b
before allapps prediction row: https://screenshot.googleplex.com/BVxGMTT43stDzZ9
after allapps prediction row: https://screenshot.googleplex.com/BfNTFPXwf4FHuRN

Change-Id: Ifefe6dc8dd4a117be7b63f92ff837d0467a51f8b
2023-06-28 14:45:07 -07:00
TreeHugger Robot 2fe4a241c8 Merge "Removing ViewCaptureAnalysisRule" into udc-qpr-dev am: c84ecc0f67 am: 1a23d2986a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23836068

Change-Id: I348629264eee8e90cb308340664240cea503a550
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 20:35:31 +00:00
Schneider Victor-tulias d483bf8a8b Merge "Handle onFlingFinished onRecentsAnimationStart" into udc-qpr-dev am: e2e1b79b06 am: 99e779ad03
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23835673

Change-Id: I4f9e7780e66e6bc2c1eb653b59867292513ebea8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 20:35:11 +00:00
Schneider Victor-tulias e94b266bf3 Merge "Inset the contents of AllSetActivity" into udc-qpr-dev am: 3ce99d1d96 am: 4864de5700
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23835670

Change-Id: I5e489f666e9163a549bccdd08292548034c563a3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 20:34:27 +00:00
TreeHugger Robot 1a23d2986a Merge "Removing ViewCaptureAnalysisRule" into udc-qpr-dev am: c84ecc0f67
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23836068

Change-Id: Ibd0f3c7fdbfd3913e4abe7c78b6013ed1888ee92
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 20:11:36 +00:00
Schneider Victor-tulias 99e779ad03 Merge "Handle onFlingFinished onRecentsAnimationStart" into udc-qpr-dev am: e2e1b79b06
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23835673

Change-Id: I1112987cc848ecaf2c30c383f04843afd6371576
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 20:11:24 +00:00
Schneider Victor-tulias 4864de5700 Merge "Inset the contents of AllSetActivity" into udc-qpr-dev am: 3ce99d1d96
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23835670

Change-Id: Ib71e83fe6fb810383595e03fb3c40a4839d12d8a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 20:11:13 +00:00
TreeHugger Robot c84ecc0f67 Merge "Removing ViewCaptureAnalysisRule" into udc-qpr-dev 2023-06-28 20:08:23 +00:00
Schneider Victor-tulias e2e1b79b06 Merge "Handle onFlingFinished onRecentsAnimationStart" into udc-qpr-dev 2023-06-28 19:59:33 +00:00
Schneider Victor-tulias 3ce99d1d96 Merge "Inset the contents of AllSetActivity" into udc-qpr-dev 2023-06-28 19:59:19 +00:00
Brian Isganitis 033ebc8a22 Only update local zss cache when Taskbar Toast already active.
Toast is handling suggestion updates itself during the session, and we
do not need to send along the new search suggestions passed from
bindExtraContainerItems. We should still store the updated suggestions
in memory for the next time Taskbar All Apps is invoked.

Test: Manual
Bug: 216683257
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Flag: ZERO_STATE_WEB_DATA_LOADER
Change-Id: I68673e5941dc4b81c3e72b7ec579f566f13ee4d2
2023-06-28 19:55:28 +00:00
Schneider Victor-tulias 1b2c2e694c Handle onFlingFinished onRecentsAnimationStart
If the onRecentsAnimationStart callback runs after the user lifts their finger and onFlingFinished runs, then onFlingFinished never has another chance to run, leaving the user trapped in a state where the launcher is not started and the AllSetActivity is still present but invisible. Reverted to allow onFlingFinished to run onRecentsAnimationStart to handle this edge case.

Flag: not needed
Fixes: 285194839
Test: Ran AllSetActivty with a delay in onRecentsAnimationStart
Change-Id: I33ce5c1d4955b34d4b77d3b740dc599621bd4ed1
Merged-In: I33ce5c1d4955b34d4b77d3b740dc599621bd4ed1
2023-06-28 17:43:14 +00:00
Schneider Victor-tulias ad2279a26e Handle onFlingFinished onRecentsAnimationStart
If the onRecentsAnimationStart callback runs after the user lifts their finger and onFlingFinished runs, then onFlingFinished never has another chance to run, leaving the user trapped in a state where the launcher is not started and the AllSetActivity is still present but invisible. Reverted to allow onFlingFinished to run onRecentsAnimationStart to handle this edge case.

Flag: not needed
Fixes: 285194839
Test: Ran AllSetActivty with a delay in onRecentsAnimationStart
Change-Id: I33ce5c1d4955b34d4b77d3b740dc599621bd4ed1
2023-06-28 17:43:03 +00:00
Schneider Victor-tulias ae62216f15 Inset the contents of AllSetActivity
Insetting the contents of AllSetActivity to prevent overlapping with the gesture nav handle

Flag: not needed
Fixes: 275018092
Test: launched AllSetActivity in landscape with largest font and display size
Change-Id: Ia82a007e8a69c637a30c56e079d9c77d73885d9f
2023-06-28 10:02:05 -07:00
Winson Chung 470b3e771e Merge "Workaround for handling the restart of an already visible task" into udc-dev am: 0da5208bb3 am: c8a2f9111b am: b019f371fd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23785437

Change-Id: Ic034129a9d522c2871f7ea2452007a83a9e61691
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 08:56:48 +00:00
Winson Chung 551cbc4969 Merge "Workaround for handling the restart of an already visible task" into udc-dev am: 0da5208bb3 am: c8a2f9111b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23785437

Change-Id: I2a7ebbac3c510d32b70ee57dd8323123800ff09a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 07:52:58 +00:00
Winson Chung b019f371fd Merge "Workaround for handling the restart of an already visible task" into udc-dev am: 0da5208bb3 am: c8a2f9111b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23785437

Change-Id: Ib095560a1ba305ec4150037852caa2d0d58f9121
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 07:48:03 +00:00
Winson Chung b9b039dc02 Merge "Workaround for handling the restart of an already visible task" into udc-dev am: 0da5208bb3 am: 20d1a9975e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23785437

Change-Id: I0f77e2e7437af67bb674667af900a570970a2ce3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 07:47:37 +00:00
Winson Chung 20d1a9975e Merge "Workaround for handling the restart of an already visible task" into udc-dev am: 0da5208bb3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23785437

Change-Id: I6252581b2629fdf6b56a76c781460b97edc3eac4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-28 07:07:50 +00:00