Commit Graph

19452 Commits

Author SHA1 Message Date
Jon @ d2750e315c Merge "Migrate ENABLE_HOME_TRANSITION_LISTENER to launcher.aconfig" into main 2023-10-27 23:12:02 +00:00
Luca Zuccarini d9421f929c Merge "Revert "Reuse the main depth controller for launch animations."" into main 2023-10-27 23:01:00 +00:00
Jagrut Desai 96691aa2e0 Stashing Persistent Taskbar Background for ime invocation
Test: Manual
Bug: 308175076
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED
Change-Id: Ic1091f6493125b123fdd6210d6904f9b175897ee
2023-10-27 15:38:00 -07:00
Ats Jenk 5c25c3a19d Use aconfig flag for desktop mode
Refactors all flag access in Launcher to be from DesktopTaskView and using a method instead of a static field.
Also using static import for the method so if we need to move it, only imports needs to be updated.

Bug: 304778354
Flag: ACONFIG com.android.wm.shell.enable_desktop_windowing TEAMFOOD
Test: enable the aconfig flag, check that desktop windowing is available

Change-Id: Ia2bdfd865802a635878d72cfb5a90c21dad6ed08
2023-10-27 10:58:07 -07:00
Jon Miranda 60ae29ef08 Migrate ENABLE_HOME_TRANSITION_LISTENER to launcher.aconfig
Also set flag to TEAMFOOD.

Flag: ACONFIG ENABLE_HOME_TRANSITION_LISTENER TEAMFOOD
Bug: 306053414
Test: manual
Change-Id: Icf3947e61fa9f20f5b6e5ca2af96e693b55d3edc
2023-10-27 16:43:01 +00:00
Schneider Victor-tulias 1066c74f0f Clean up NPEs in AbsSwipeUpHandler
AbsSwipeUphandler has many potential and common NPEs. Added null checks to AbsSwipeUpHandler

Flag: NONE
Fixes: 307708536
Fixes: 307624168
Test: ran and restarted launcher
Change-Id: I0536612bfb36b4d912155158237fdb2e4fa33126
2023-10-27 11:27:21 -04:00
Luca Zuccarini 8209517c2c Revert "Reuse the main depth controller for launch animations."
This reverts commit ff2b38e366.

Reason for revert: Caused jank regressions: b/307779813, b/307766171.

Change-Id: I3d513196f9fd8f0768affdda73c0ab8924790037
2023-10-27 12:24:08 +00:00
Jagrut Desai b10f2a3d03 Refactor TaskbarActivityContext#applyDeviceProfile
Test: presubmit
Bug: 308024141
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED
Change-Id: Ic0ecc80f9b61910a917b93cbe62139e2c5d0d9d2
2023-10-26 16:12:12 -07:00
Jagrut Desai 24231d9994 Merge "Taskbar pinning animation with no recreate" into main 2023-10-26 21:33:41 +00:00
Jagrut Desai 631b284836 Taskbar pinning animation with no recreate
Test: Manual, Visual
Bug: 265436799
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED

Change-Id: I84a4d1efdb0bd4a0f856fa1f46b6489ef54a3841
2023-10-26 10:36:48 -07:00
Pat Manning 821bc0d034 Merge "Clean up overview icon menu flag after tests and refresh device profile." into main 2023-10-26 16:00:48 +00:00
Pat Manning 999af9cab9 Clean up overview icon menu flag after tests and refresh device profile.
Fix: 306089019
Test: TaplOverviewIconAppChipMenuTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TRUNKFOOD
Change-Id: I04335967e6bfa52d143a399859e2e745d428ab30
2023-10-26 12:02:40 +01:00
Tracy Zhou 0f7a74a219 Merge "Add task bar window of TYPE_NAVIGATION_BAR when FLAG_HIDE_NAVBAR_WINDOW is on" into main 2023-10-25 23:45:33 +00:00
Vinit Nayak 0fcd231173 Merge "Use aconfig flag enable_split_contextual" into main 2023-10-25 23:19:27 +00:00
Tracy Zhou f767c86896 Add task bar window of TYPE_NAVIGATION_BAR when FLAG_HIDE_NAVBAR_WINDOW is on
Bug: 304426019
Test: manual
Change-Id: I0c09e57db5a9bf6391605d5ec667cf12c96a2042
2023-10-25 14:54:01 -07:00
Andy Wickham 49ae8bd240 Merge "Synchonizes touch slop across input consumers" into main 2023-10-25 21:01:01 +00:00
Tracy Zhou 867f7f8360 Merge "Migrate ENABLE_TASKBAR_NO_RECREATION to launcher.aconfig" into main 2023-10-25 17:45:09 +00:00
Schneider Victor-tulias 927c78f2c6 Merge "Fix NPE in overview action buttons" into main 2023-10-25 14:10:45 +00:00
Uwais Ashraf 6eb006ed90 Merge "Add margins to top and bottom when grid only overview enabled" into main 2023-10-25 13:53:24 +00:00
Pat Manning 93f8778da2 Merge "Go home before getting overview in test to ensure overview will exist." into main 2023-10-25 10:37:01 +00:00
Tracy Zhou d313ee0c35 Do not animate icon alignment in phone mode
With the existing code, there is a rare case that mIconAlignControllerLazy is
set from unfolded state, and then go to small screen, and we will reuse mIconAlignControllerLazy to animate, only to find out that scaleX for the icon view is infinity. Instead, we should unset mIconAlignControllerLazy in phone mode.

Fixes: 274517647
Test: manual
Change-Id: I3200761e5f4c6df0d89744f22e38bfe7fc7846cc
2023-10-24 21:50:22 -07:00
Tracy Zhou 00f9e52575 Migrate ENABLE_TASKBAR_NO_RECREATION to launcher.aconfig
Bug: 274517647
Test: manual
Change-Id: I29fe58691440ee757c9f391bd574ef80eefb5ae6
2023-10-24 18:42:15 -07:00
Vinit Nayak a1be4c1123 Use aconfig flag enable_split_contextual
Bug: 276361926
Test: Basic split contextual operations work
as expected

Change-Id: I7202654f8452a0c57e5e728c9baaadf85fa22a96
2023-10-25 01:37:17 +00:00
Sunny Goyal 7955bd97df Merge "Simplifying settings activity" into main 2023-10-24 20:13:17 +00:00
Sunny Goyal 6eb256d794 Simplifying settings activity
> Removing multiple fragments
> Exposing support to select preference root
> Adding support for recreating preferences
> Moving Developer options to same fragment

Bug: 305084752
Flag: N/A
Test: Manual
Change-Id: I499be1938ef8ed58cbc7f9b0f4ad3510d4b306c8
2023-10-24 11:40:12 -07:00
Uwais Ashraf aa7fa886d6 Add margins to top and bottom when grid only overview enabled
Fix: 299100244
Test: OverviewImageTest and dump tests
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Change-Id: I22ebced5bf1e27974036d6e2ef72d2b8d63df824
2023-10-24 16:15:39 +00:00
Pat Manning 3a2fde4db4 Go home before getting overview in test to ensure overview will exist.
Also when opening settings, do not wait for A11Y event which never fires. (added in ag/24777489, but seems to fail as mentioned here b/303329286#comment2 and tracked here b/298114205)

Fix: 307379525
Fix: 307397957
Bug: 298114205
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TRUNKFOOD
Test: TaplOverviewIconTest
Change-Id: Icd8a47b47d22ddb32db7df6882ec655f0e6f54c1
2023-10-24 14:43:11 +00:00
Luca Zuccarini d7e3d8ab90 Merge "Reuse the main depth controller for launch animations." into main 2023-10-24 14:31:20 +00:00
Schneider Victor-tulias a028cd11ba Fix NPE in overview action buttons
Flag: N/A
Fixes: 305894735
Test: pressed screenshot overview action button shortly before/after dismissing the current task
Change-Id: Ife93fa9af5416af60cf8ae24275f14bd6857901a
2023-10-24 14:13:39 +00:00
Tracy Zhou fbc8b715c3 Merge "Null check on RecentsView for endLiveTile" into main 2023-10-24 04:26:35 +00:00
Tracy Zhou 7cf1884d92 Null check on RecentsView for endLiveTile
Fixes: 304914019
manual: N/A
Change-Id: I6c6e3f0f52e57589f71b3c63debac21734fc88bf
2023-10-23 17:17:42 -07:00
Saumya Prakash c14d48c214 Merge "Check status of mEdgeBackGestureHandler to prevent NPE" into main 2023-10-23 20:22:54 +00:00
Tracy Zhou 9070b93f40 Merge "Do not show task bar edu in folded state with task bar / nav bar unification" into main 2023-10-23 18:34:30 +00:00
Pat Manning 1f5d5be70d Merge "Move overview tests to quickstep package." into main 2023-10-23 18:26:38 +00:00
Pat Manning 1eb8bd8735 Merge "Increase pinned taskbar height to fit tooltips." into main 2023-10-23 16:13:03 +00:00
Jon @ b61dcac34e Merge "Add HomeTransitionListener to launcher." into main 2023-10-23 15:56:36 +00:00
Pat Manning 954e3b8dee Move overview tests to quickstep package.
Fix: 305394234
Test: TaplOverviewIconAppChipMenuTest, TaplOverviewIconTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu DEVELOPMENT
Change-Id: Ib39e2ec7f53de0c4b557558776c7ad428e4cab22
2023-10-23 16:15:33 +01:00
Pat Manning 5643e7c047 Increase pinned taskbar height to fit tooltips.
Fix: 305706286
Flag: ACONFIG com.android.launcher3.enable_cursor_hover_states TRUNKFOOD
Test: TaskbarHoverToolTipControllerTest

Change-Id: I767947a752eae7a928d59fe332bc62b9fd5b5f37
2023-10-23 15:52:48 +01:00
Andreas Agvard e3fbfaca73 Synchonizes touch slop across input consumers
This is done so that an outer input consumer isn't inside it's touch slop while an inner consumer has passed it's touch slop. An inner consumer cannot inform the outer consumers that it has intercepted in the current design.

Removes MotionEvent.CLASSIFICATION_AMBIGUOUS_GESTURE handling from NavHandleLongPressInputConsumer since other input consumers do not use this mechanism leading to misalligned touch slops.

OtherActivityInputConsumer now uses touch slop from the device configuration (it already did so for the squared touch slop).

Flag: LEGACY CUSTOM_LPNH_THRESHOLDS DISABLED
Bug: 305924072
Test: Manual
Change-Id: Idf5e88d75914255923fbbcfb602cf2a53773ff9a
2023-10-23 15:36:51 +02:00
Tracy Zhou aa783da782 Do not show task bar edu in folded state with task bar / nav bar unification
Fixes: 306208742
Test: manual
Change-Id: I8321e9d41ea041f77cea3f140d92316c702ce531
2023-10-20 19:47:29 -07:00
Mateusz Cicheński 4d59d52d1e Merge "Validate source rect hint for enter PIP in gesture nav" into main 2023-10-21 00:03:34 +00:00
Jon Miranda 00c3d78191 Add HomeTransitionListener to launcher.
Fixes: 279514548
Bug: 284474103
Bug: 306053414

Flag: LEGACY ENABLE_HOME_TRANSITION_LISTENER DISABLED
Test: App launch -> Hotseat -> Taskbar stashes
      Transluscent app launch and launcher still visible -> No change
      Going home -> Hotseat visible

Change-Id: I6db5253ada3e3b37dfae124f3ee88a9805804fb8
2023-10-20 15:46:11 -07:00
Sunny Goyal e4900713b9 Merge "Remove RPC due to unnecessary permission check" into main 2023-10-20 21:48:36 +00:00
Jagrut Desai 2e53885e86 Merge "Adding screen record TaplTestsQuickStep#testOverviewForTablet" into main 2023-10-20 20:23:16 +00:00
Pat Manning 4c27e8c6f0 Migrate cursor feature flag to trunk stable flag.
Fix: 300054410
Test: TaplTestsTransientTaskbar, TaplTestsQuickstep
Flag: enableCursorHoverStates
Change-Id: I5c320e0fd2bdd2ed39b00b62b1399e163c3384e7
2023-10-20 12:17:36 +01:00
Jagrut Desai caf5c815f3 Adding screen record TaplTestsQuickStep#testOverviewForTablet
Test: Presubmit
Bug: 306089019
Flag: NONE
Change-Id: I1e7474fe5f32e895859ca726fc63f40833ada118
2023-10-20 00:38:14 +00:00
Mateusz Cicheński d21cf61e86 Validate source rect hint for enter PIP in gesture nav
If the source rect hint is going outside of visible app bounds,
we should use icon overlay instead.

Test: before http://recall/-/ekEuGtt9d9HWqkUtAzpHx8/fPfOfGUlrBkJ8WbJDqAr2i
Test: after http://recall/-/ekEuGtt9d9HWqkUtAzpHx8/fMcHGqfpA5HCXYoAPV4vTT
Bug: 305090652
Flag: NA

Change-Id: I161f60bf62888c7922227e5d3185810dbe88e317
2023-10-19 23:45:37 +00:00
Andreas Agvard 257f431da2 Merge "Adds haptic build-up during LPNH behind feature flag" into main 2023-10-19 21:48:21 +00:00
Jagrut Desai 34d135e21a Merge "Always use Transient Taskbar All apps icon for taskbar pinning" into main 2023-10-19 20:03:14 +00:00
Andreas Agvard d1674985d6 Adds haptic build-up during LPNH behind feature flag
Flag: Omnient flags + ENABLE_SEARCH_HAPTIC_HINT
Test: Manual
Bug: 303023676
Change-Id: Ic43d1f34a05622328add6727f36406ce75d5a115
2023-10-19 21:10:42 +02:00