Commit Graph

19452 Commits

Author SHA1 Message Date
Jagrut Desai 29ac20ba6a Merge "Fix TaskbarDividerPopupMenu Switch Style" into main 2023-11-02 22:52:19 +00:00
Winson Chung 9b97217ffb Handle long press directly if recents transition is deferred
- For 3p launchers, the starting of the home activity is deferred until
  the user moves past a slop, in these cases we don't need to worry
  about finishing the recents transition before handling long press
  (since it was never started)

Fixes: 307254136
Test: Enable 3p launcher and invoke omni
Change-Id: I0aed7e7d442e010c38979e3f806f6cf0eb33cfe8
2023-11-02 22:46:23 +00:00
Alex Chau 9c07fc1350 Re-land "Update Tapl tests for enable_grid_only_overview"
- Fix getCurrentTask() to correctly get the top-right tasks in grid only overview. It'll first get the widest task, and then top, and then rightmost task
- Fix scrollLeftByDistance() to correctly account for leftGestureMargin to make sure it scroll by distance provided
- Fix scrollCurrentTaskOffScreen() to actually scroll the task off screen
- Fix createAndLaunchASplitPair() to use Task menu instead of Overview actions for grid only overview
- Skip testOverviewActions() in grid only overview, where Overview actions isn't available
- Fix testOverivewForTablet to expect the correct task in grid only overview; also disabled part of a test due to an animation bug in Overview
- Fix dismissBySwipingUp() to swipe from bottom of task, which is required to effectively dismiss top row tasks
- Also fixed OverviewTask to correctly get objects in FallbackOverview
- Fix touchOutsideContainer() to calcualte y base on container's middle correctly

Bug: 283246928
Test: presubmit
Flag: None
Change-Id: I77e91dcc1a404ade356b29fba6cf967c534c08f4
2023-11-02 22:37:26 +00:00
Jagrut Desai c554d5fa46 Fix TaskbarDividerPopupMenu Switch Style
we recently added support for settings app style switches to Launcher. Use that style for TaskbarDividerPopupMenu Switch

Test: Manual
Bug: 308682758
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED
Change-Id: If61a426e4051ebce67601055942667ed93928d15
2023-11-02 14:23:48 -07:00
Jagrut Desai 755304d592 Remove TaplTestsQuickstep#testPressBack from PlatinumTest
Test: Presubmit
Bug: 303256981
Flag: NONE
Change-Id: I8e502449d03c9ca010fc05297f2edb255e1fa21e
2023-11-02 21:19:18 +00:00
Jagrut Desai 52c9160b0d Merge "Close Taskbar All Apps when Taskbar Pinning is animating" into main 2023-11-02 21:18:44 +00:00
Winson Chung 706c34f2df Merge "Add logs & dump for SysUI/Shell interfaces" into main 2023-11-02 20:46:16 +00:00
Tony Wickham 17c62edb71 Merge "Fix 3 button mode issues in AllSetActivity" into udc-qpr-dev am: 7738b6e943 am: 0eba94ad73
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25240828

Change-Id: Id0fde9bc3939be62aaa97714956607cfee6a93f5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-02 19:57:26 +00:00
Tracy Zhou de8e25cf11 [Trackpad] Do not reverse two-finger gestures on the homescreen when reverse scrolling is on
- Swipe up to pull up all apps
- Swipe down to pull down notifications
- Same gesture to close in reverse scrolling mode

Bug: 301966246
Bug: 301966690
Test: manual
Change-Id: Ia3770ce8b279d24b2de4844f441f14e0feaf57c7
2023-11-02 12:30:50 -07:00
Tony Wickham 0eba94ad73 Merge "Fix 3 button mode issues in AllSetActivity" into udc-qpr-dev am: 7738b6e943
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25240828

Change-Id: Id88a7d427a8a436c2dc7bac2c7dc882d4b56a0cd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-02 19:21:22 +00:00
Schneider Victor-tulias f7e20960e0 Fix unresponsive swipe up after launching the running app from live tile overview
Flag: NONE
Fixes: 245736607
Test: quickly swipe to home after tapping the currently-running task in live tile mode from overview

Change-Id: I3b47ee3645db88bf20e58e673abde7a3b92cef9b
2023-11-02 19:18:11 +00:00
Winson Chung 549eba2c99 Add logs & dump for SysUI/Shell interfaces
- This helps us know if the interfaces are set correctly during a gesture

Bug: 286805673
Test: dumpsys activity service TouchInteractionService
Change-Id: Icebc3d49d299495beb3880eaa591d6e96fdcd27f
2023-11-02 19:16:00 +00:00
Tony Wickham 7738b6e943 Merge "Fix 3 button mode issues in AllSetActivity" into udc-qpr-dev 2023-11-02 18:50:49 +00:00
Pat Manning 8a01ea889f Merge "Shorten app title in overview icon app chip menu." into main 2023-11-02 18:32:53 +00:00
Winson Chung 3e113fef7f Merge "Add logs for starting the home activity directly" into main 2023-11-02 18:18:00 +00:00
Tracy Zhou 109b442a83 Merge "Do not animate icon alignment in phone mode" into main 2023-11-02 16:23:39 +00:00
Pat Manning 616a250b62 Shorten app title in overview icon app chip menu.
- Do not show "work" at the beginning of work apps.
- Do not use the top component name in case any dialogs are on top of app.

Fix: 305988810
Fix: 305983272
Fix: 307231916
Test: OverviewImageTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu DEVELOPMENT
Change-Id: I4ce741529c975db778abc540e6c353ea4c76bf11
2023-11-02 14:15:54 +00:00
Alex Chau 39c548bd03 Merge "Revert "Update Tapl tests for enable_grid_only_overview"" into main 2023-11-02 13:36:34 +00:00
Sam Dubey 0552d37f34 Revert "Update Tapl tests for enable_grid_only_overview"
Revert submission 25220083-b/283246928

Reason for revert: b/308930958

Reverted changes: /q/submissionid:25220083-b/283246928

Bug: 283246928
Change-Id: I69ce128061f7ffad213f8f193122b18e5ee9378d
2023-11-02 13:33:55 +00:00
Alex Chau c543b46070 Merge "Fix TaskViewSimulatorTest to be independent of device it runs on" into main 2023-11-02 11:13:20 +00:00
Alex Chau 25cd358a27 Merge "Update Tapl tests for enable_grid_only_overview" into main 2023-11-02 11:06:03 +00:00
Treehugger Robot 24bb5d95dd Merge "Fix Insets override types can not be changed after the window is added" into main 2023-11-02 03:19:38 +00:00
Tony Wickham eccf070bae Change TAPL to swipe to stash taskbar (instead of deprecated long press)
This also means Taskbar is transient by default in automated tests,
instead of persistent. Updated some checks accordingly.

Flag: LEGACY ENABLE_TRANSIENT_TASKBAR ENABLED
Test: TaskbarExpandCollapse#hideShowTaskbar; TaplTestsTaskbar;
TaplTestsTransientTaskbar; TaplTestsPersistentTaskbar
Bug: 270395798

Change-Id: Ib6e592a31a55a912a7ea991a421a9c60bca51c80
2023-11-01 23:16:10 +00:00
Vinit Nayak a0ed884dfd Merge "Add logs when sysuiProxy clears binder refs" into main 2023-11-01 22:49:17 +00:00
Tracy Zhou b3fdfc650a Fix Insets override types can not be changed after the window is added
insetsSizeOverrides must have the same length and types according to WindowManagerService#relayoutWindow

Bug: 308441430
Test: manual
Change-Id: I7416a5302c90652e1fa266cc98e3c7825fa17e64
2023-11-01 15:36:45 -07:00
Jagrut Desai eaef199883 Close Taskbar All Apps when Taskbar Pinning is animating
Test: Manual
Bug: 308488799
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED
Change-Id: Iec33ba1acb840bb1cd05c440daab4508e91f2bfc
2023-11-01 15:34:18 -07:00
Alex Chau 3029b8314e Update Tapl tests for enable_grid_only_overview
- Add "task" as id for TaskView, and use it instead of "snapshot" when creating OverviewTask, so that for split tasks are caputred as a whole in getCurrentTask and getTasks
- Fix getCurrentTask() to correctly get the top-right tasks in grid only overview. It'll first get the widest task, and then top, and then rightmost task
- Fix scrollLeftByDistance() to correctly account for leftGestureMargin to make sure it scroll by distance provided
- Fix scrollCurrentTaskOffScreen() to actually scroll the task off screen
- Fix createAndLaunchASplitPair() to use Task menu instead of Overview actions for grid only overview
- Skip testOverviewActions() in grid only overview, where Overview actions isn't available
- Fix testOverivewForTablet to expect the correct task in grid only overview; also disabled part of a test due to an animation bug in Overview
- Fix dismissBySwipingUp() to swipe from bottom of task, which is required to effectively dismiss top row tasks
- Also fixed OverviewTask to correctly get objects in FallbackOverview

Bug: 283246928
Test: presubmit
Flag: None
Change-Id: I5dd39b1779ea02738556f921169dbe38aa4cba8c
2023-11-01 22:15:12 +00:00
Jagrut Desai 524e05b921 Merge "Fix Taskabr Divider Line traveling too far" into main 2023-11-01 22:06:16 +00:00
Winson Chung 642559bbf3 Add logs for starting the home activity directly
- We need to narrow down how home is being started after a recents
  transition

Bug: 285636175
Test: dumpsys activity service TouchInteractionService
Change-Id: I527a69cb045d426f820cfb5c8ba3c95eeff92889
2023-11-01 20:28:49 +00:00
Alex Chau 382e1868c7 Fix TaskViewSimulatorTest to be independent of device it runs on
- Fix TaskViewSimulatorTest to properly set up densityDpi, so the test result is consistent regardless of the device it runs on. Also used SandboxContedxt's putObject() to avoid using reflection

Bug: 283246928
Test: TaskViewSimulatorTest
Flag: None
Change-Id: I926459fa97dd09a266cd017e4a0fb8e658a3509c
2023-11-01 19:51:37 +00:00
Tony Wickham 286fc215e6 Fix 3 button mode issues in AllSetActivity
- Set system bars appearance to light/dark depending on device
  theme to ensure visibility
- Also fix issue where taskbar icons would appear partially
  offscreen and prevent pressing nav buttons if you rotated

Fixes: 293438087
Test: adb shell am start -a android.intent.action.MAIN -n com.google.android.setupwizard/.SetupWizardTestActivity
  - Skip to the end (AllSetActivity), and ensure 3 buttons are visible
  - Rotate device and ensure 3 buttons are still visible and functional
  - Will also flash / wipe to the build once it's created
Flag: None
Change-Id: Ie2d9bf1e1d95a6ccbd1f9c592adb51390b21ad85
2023-11-01 17:08:29 +00:00
Thales Lima 9623aaa470 Merge "Change AllApps padding to use a Rect" into main 2023-11-01 12:21:53 +00:00
Andy Wickham 24a50df135 Add animateNavBarLongPress to SystemUiProxy and ANIMATE_LPNH flag
Bug: 306400785
Bug: 308693847
Test: Manual
Flag: LEGACY ANIMATE_LPNH TEAMFOOD
Change-Id: I996c923e5a1949e6219f900da12e2b5091597750
2023-10-31 23:45:12 -07:00
Bill Yi 8862d8f04d Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-10-31 17:46:17 +00:00
Himanshu Gupta 510fa88571 Merge "Adding support for private/clone profile badge in Launcher3." into main 2023-10-31 16:28:40 +00:00
Thales Lima b433c9c312 Change AllApps padding to use a Rect
AllApps uses different values for left and right padding in some places (e.g. ActivityAllAppsContainerView uses workspacePadding.left/right), and this change is the first step into moving those values into DeviceProfile.

Bug: 269632571
Test: NexusLauncherTest
Flag: NONE
Change-Id: I14c4edf55ca74f256b1aaa336fff246a0c78e25d
2023-10-31 16:19:40 +00:00
Anushree Ganjam 39d05284d7 Merge "Call SetSummary for seekbarPref instead of calling onPreferenceChange()." into main 2023-10-31 16:16:28 +00:00
Himanshu Gupta 6e030348dd Adding support for private/clone profile badge in Launcher3.
Bug: 289224457
Flag: None
Test: Flash on device and Presubmit
Change-Id: Icebb5b5129a2f0d909481f00d51e047431a23a15
2023-10-31 07:46:34 +00:00
Ats Jenk 866e77101c Merge "Use aconfig flag for desktop mode" into main 2023-10-31 05:07:02 +00:00
Bill Yi fa473558ba Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I4194ef5bacc03bc059706da3d4336b3cf71a7d1e
2023-10-30 19:58:47 -07:00
Bill Yi bb8419b8f9 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I2e57af4db51bc722d5fe7560c92b371ab61cfcf9
2023-10-30 19:58:19 -07:00
Anushree Ganjam 9b80783031 Call SetSummary for seekbarPref instead of calling onPreferenceChange().
This way the preference will not be created with the default value
initially and preference is created only when seekbar is modified
manually in developer options. Preference can be set using device_config and the default
value can be read from device config flags.

Bug: 301680992
Flag: Legacy CUSTOM_LPNH_THRESHOLDS DISABLED
Test: Manual
Change-Id: Ie48384e4799cfe0f58a469bcb7aafb971beaea19
2023-10-30 18:26:31 -07:00
Vinit Nayak d1e9cacfdc Add logs when sysuiProxy clears binder refs
Bug: 302551868
Flags: None
Change-Id: Iec9fc3cd52a3e3bac0ba61d0f38dbc05933e573c
2023-10-30 16:13:51 -07:00
Sunny Goyal 24e738e872 Merge "Removing some dependencies on Activity" into main 2023-10-30 22:50:19 +00:00
Jagrut Desai b7f4236776 Fix Taskabr Divider Line traveling too far
Currently, all apps button and divider line overlaps each other when launching app from home. so here we are arbituraly making tasakbar divider line position in hotseat to be little off centered so icons don't over lap and divider line travels less to its position on taskbar.

Test: Manual
Bug: 308488785
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED
Change-Id: I6cf9f3db50f34deb0c393ec1cfd0268e1b147758
2023-10-30 15:46:45 -07:00
Helen Cheuk f6c62955d8 Merge "Move task to middle when dragging up in grid only overview" into main 2023-10-30 16:40:05 +00:00
Sunny Goyal e82a20a44d Removing some dependencies on Activity
> Removing activtiy from overlay callbacks
> Removing usage on activtiyLifecycleCallbacks and managing the callbacks ourselves

Bug: 306225896
Test: Existing tests cover the lifecycle changes
Flag: N/A
Change-Id: I79941e364328eecdc8a72cac4d35b75d50a25319
2023-10-30 08:23:15 -07:00
helencheuk d60eff365b Move task to middle when dragging up in grid only overview
When dragging up, TaskView should be in the middle of the screen if grid only overview is enabled.
The pivot and translation of current task and other tasks are changed to move it to the middle.

Bug: 291880228
Test: TaplTestsQuickstep#testBackground
Test: Manual Test, swipe up to go from  app to overview, app launch for live/non-live, split screen as live/non-live task. Test the same scenario in 3P Launcher
Flag: enableGridOnlyOverview
Change-Id: I297119283771ef70c916c63f799552656d767661
2023-10-30 15:04:09 +00:00
Jagrut Desai f5677d69da Merge "Stashing Persistent Taskbar Background for ime invocation" into main 2023-10-28 21:20:44 +00:00
Schneider Victor-tulias e8840348a6 Merge "Clean up NPEs in AbsSwipeUpHandler" into main 2023-10-28 15:16:54 +00:00