Commit Graph

19452 Commits

Author SHA1 Message Date
Schneider Victor-tulias fe7319ec40 Allow KQS to be reopened during the close animation for responsiveness
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 327421402
Test: quickly quick switched during close animation
Change-Id: I11dad62d11afd796aadf9b6165f0b4404f344311
2024-03-25 12:52:12 -04:00
Schneider Victor-tulias 081d6f4b59 Merge "Focus the first task after the desktop task when launching overview from KQS" into main 2024-03-25 15:25:50 +00:00
Schneider Victor-tulias 02e57b3d62 Add ExtendedLongPressTimeoutRule to all AbstractLauncherUiTest
When devices run slow in pre/post-submit, it is possible for a drag to be processed at a long press before the first move event can be created and dispatched. Added a rule to artificially increase this long press timeout in tests.

Flag: N/A
Fixes: 319257820
Test: TAPL tests
Change-Id: I24e0f3baec15db7558351d0cb2bd93a4e49640e8
2024-03-25 11:22:31 -04:00
Tracy Zhou 4dbac6caa9 Revert "Hide task bar when folding before the new config renders the correct task bar"
This reverts commit dfb334f1e1.

Reason for revert: A bunch of WM fixes are in (b/291562764)

Change-Id: I9d08dab976cda112f802ee91256c09ef2026a01f
2024-03-23 19:35:50 +00:00
Vinit Nayak f1a832fa55 Revert^2 "Call setOverviewDragState() whenever taskbar is recreated"
This reverts commit 541c5d272d.

Reason for revert: test still failing w/ revert https://android-build.corp.google.com/abtd/run/L66700030002678824/

Change-Id: If3ab4bb850ee519446e6cae4160ea6271049f83a
2024-03-23 00:51:00 +00:00
Sunny Goyal 9d2ece156d Removing ext_test directory
Except for a few methods, most of the testing code was already in the main
codebase. Maintaining the additional source directory adds unnecessary overhead

Bug: 330920490
Test: Presubmit
Flag: None
Change-Id: I56c43ab7a4869b26858d622d0b8b14f286d50e90
2024-03-22 15:45:32 -07:00
Alex Chau a5d55fe5ef Revert "Log split button visibility to debug spacing issue"
This reverts commit 2d55c9c679.

Reason for revert: Logs not helpful in figuring out the issue and is too spammy
Bug: 321291049

Change-Id: I88a4350277ea3e965493da6386cf4c83c5c564e4
2024-03-22 22:19:13 +00:00
Alex Chau 30d9b190d5 Simplify OverviewActionsView layout to avoid unexpected misalignemnt
- Removed the weight=3 space on left/right and replace with gracvity=central_horizontal
- Removed unused oav_three_button_space
- Removed irrelevant layout_gravity (gravity within parent), as the LinearLayout is already taking full parent width, and its vertical alignemnt si controlled by `updateVerticalMargin` in code

Bug: 329255757
Test: OverviewImageTest
Flag: None
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2cf1a0c08d41ee7a29ea920c93850d3914ed7cd8)
Merged-In: Ice087dde7d3c36b4536d36ce82c382c31c124855
Change-Id: Ice087dde7d3c36b4536d36ce82c382c31c124855
2024-03-22 22:15:40 +00:00
Sukesh Ram a47eff5e21 Merge "Revert "Call setOverviewDragState() whenever taskbar is recreated"" into main 2024-03-22 20:31:42 +00:00
Tiger Huang ee28d64d27 Merge "Let taskbar can trigger insets resize animation" into 24D1-dev 2024-03-22 18:39:16 +00:00
Saumya Prakash dc6ec50558 Merge "Fix incorrect fragment in gesture tutorial when rotating the screen" into main 2024-03-22 18:09:47 +00:00
Federico Baron 2cdbbbcd8a Merge "Revert "Add screenrecord for testOverviewDeadzones"" into main 2024-03-22 17:48:08 +00:00
Bill Yi 397e7e6d3e Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-03-22 17:00:35 +00:00
Treehugger Robot 90879d2008 Merge "Import translations. DO NOT MERGE ANYWHERE" into 24D1-dev 2024-03-22 16:39:52 +00:00
Schneider Victor-tulias 5f14ec50dd Focus the first task after the desktop task when launching overview from KQS
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Fixes: 327420683
Test: opened overview using KQS
Change-Id: I9395ad6065844bf5f5007180cd8c3f80573ee473
2024-03-22 11:36:56 -04:00
Alex Chau 2cf1a0c08d Simplify OverviewActionsView layout to avoid unexpected misalignemnt
- Removed the weight=3 space on left/right and replace with gracvity=central_horizontal
- Removed unused oav_three_button_space
- Removed irrelevant layout_gravity (gravity within parent), as the LinearLayout is already taking full parent width, and its vertical alignemnt si controlled by `updateVerticalMargin` in code

Bug: 329255757
Test: OverviewImageTest
Flag: None
Change-Id: Ice087dde7d3c36b4536d36ce82c382c31c124855
2024-03-22 15:17:16 +00:00
Lynn Yeh 5bdca26a12 Merge "When mLastComputedTaskSize is empty we will recalculate and set it before determining scale and pivot" into 24D1-dev 2024-03-22 08:53:29 +00:00
Tiger 3a9c464eb3 Let taskbar can trigger insets resize animation
All the system bar can trigger insets resize animation before, but some
sources might not have the resize animation. The framework now will only
trigger insets resize animation for sources which apply
FLAG_ANIMATE_RESIZING. So this CL applies the flag for gesture taskbar
because it can toggle its size via "Always show Taskbar"

Bug: 291562764
Flag: NA
Test: Fold and unfold a foldable device and ensure that won't create
      InsetsResizeAnimationRunner.
Merged-In: I0d915422d160a81f12c3992ffe53200fd957f6d7
Change-Id: I0d915422d160a81f12c3992ffe53200fd957f6d7
2024-03-22 07:36:34 +00:00
Treehugger Robot a0c3169c27 Merge "Prevent merging transitions if we don't handle it" into main 2024-03-22 07:22:02 +00:00
Winson Chung ad9cf73bee Prevent merging transitions if we don't handle it
- If we don't handle merging the transition, it will play sequentially
  after the current transition (see ag/26641113)

Bug: 330821548
Test: N/a
Change-Id: I7d35cc173d8ced8ba9b9df02dd8a571ca08e9de7
2024-03-22 05:53:50 +00:00
Tiger Huang d930eefefa Merge "Let taskbar can trigger insets resize animation" into main 2024-03-22 03:39:45 +00:00
Treehugger Robot 96e8528b19 Merge "Debugging Logs for TaplOverviewIconTest#testOverviewActionsMenu" into main 2024-03-22 03:33:32 +00:00
Wei Sheng Shih c5a2e4bf03 Merge "Do not report finish in mergeAnimation..." into main 2024-03-22 03:30:20 +00:00
Bill Yi 095af980d9 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I64669eeaa0d95dfc357636ff5e5b358ea4b30350
2024-03-21 20:26:03 -07:00
Bill Yi 183d5d0982 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I09d1660ae6518ec97787e854db0298dbf22fa8d8
2024-03-21 20:25:26 -07:00
Treehugger Robot a53f3ceb43 Merge "Debugging Logs for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash" into main 2024-03-22 02:09:34 +00:00
wilsonshih 7130116894 Do not report finish in mergeAnimation...
...if the handler don't know how to process the transition.
So the Transitions can pass that transition to next handler.

Flag: NONE
Bug: 328619216
Test: manual, use alt+tab to relaunch a task where it's activity
is destroyed.

Change-Id: Idf3f78103a56e91806ec2f6e364c6e8e7f4e205c
2024-03-22 01:14:37 +00:00
Sukesh Ram 547bb092b2 Debugging Logs for TaplOverviewIconTest#testOverviewActionsMenu
Add logging for TaplOverviewIconTest#testOverviewActionsMenu.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 326073471
Change-Id: I54cd62ea38c28230418031fc7edb4ade1198ca7a
2024-03-21 16:07:00 -07:00
Saumya Prakash c028cc7699 Fix incorrect fragment in gesture tutorial when rotating the screen
This change makes the current fragment load on configuration changes for
the gesture navigation tutorial. Previously, the old fragment would be recreated causing inconsistencies when rotating the screen. Not marking a flag as this change is for both the previous gesture tutorial and the current one.

Fix: 317162126
Test: Run the tutorial and rotate the screen after each step. The
tutorial should progress like normal.
Flag: N/A

Change-Id: I09c40006dd0ef6e9e78fa44e36962a678918420a
2024-03-21 22:27:15 +00:00
Tony Wickham 50d2fad5f2 Merge "Cancel animations after reading MotionPauseDetector#isPaused()" into 24D1-dev 2024-03-21 22:03:18 +00:00
Sukesh Ram b332ff54d1 Debugging Logs for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash
Add logging for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 324940434
Change-Id: If20937ef63c07981ff708e7b50ee682201dcedfc
2024-03-21 15:00:54 -07:00
Sukesh Ram 541c5d272d Revert "Call setOverviewDragState() whenever taskbar is recreated"
This reverts commit 0adca26744.

Reason for revert: potential cause of presubmit failures

Change-Id: I102d92f86afc7fa21c806d3cf1642e343dc91d45
2024-03-21 21:25:30 +00:00
Andy Wickham 88972311a2 Consolidate settings for Assist.
Now there is just 1 toggle for all entrypoints.

Bug: 324036308
Test: Manual and unit tests
Flag: NA
Change-Id: Id4463345c44fa4daba4eac67b5ad00aff7f3a606
Merged-In: Id4463345c44fa4daba4eac67b5ad00aff7f3a606
2024-03-21 20:27:54 +00:00
Ats Jenk ee7a069467 Merge "Set bubble bar alpha to 0 and collapse if it bubbles are hidden" into main 2024-03-21 17:15:45 +00:00
Alex Chau 59781a7d79 Remove DesktopTaskView.isDesktopModeSupported
- Use Flags.eanbleDesktopWindowingMode directly
- Also clean up unnecessary and improper flag usage

Bug: 309008406
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Test: presubmit
Change-Id: I86ce317ce577f279d2ce819d6dc1738204c2631e
2024-03-21 14:05:27 +00:00
Andreas Agvard eccda6f363 Merge "Adds new AssistStateManager settings" into 24D1-dev 2024-03-21 10:55:01 +00:00
Treehugger Robot 362050932e Merge "Making some classess accessible in multivalent tests" into main 2024-03-21 10:38:08 +00:00
Tony Wickham 3c58551e12 Cancel animations after reading MotionPauseDetector#isPaused()
Otherwise, it clears MotionPauseDetector so isPaused returns false.

Fixes: 330186943
Flag: none
Test: manual
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:77802d6da48320e5f5cf5c420fe31a1aa14e478e)
Merged-In: I9e0982c18cc5264a1fab53077ac551d2880a6eae
Change-Id: I9e0982c18cc5264a1fab53077ac551d2880a6eae
24D1-dev is based on 24Q2-release. Therefore, we merged this CL to 24D1-dev.
2024-03-21 07:57:56 +00:00
Vinit Nayak 41e0e65bd4 Merge "Call setOverviewDragState() whenever taskbar is recreated" into 24D1-dev 2024-03-21 02:43:11 +00:00
Treehugger Robot 6a8662c560 Merge "Increase IME switcher Left Margins to meet spec" into main 2024-03-21 02:17:05 +00:00
Sukesh Ram aad306396e Increase IME switcher Left Margins to meet spec
Increase IME switcher Left Margins to meet specifications for taskbar. Result: https://screenshot.googleplex.com/5Ab33jnZiDY5tqm

Flag: NONE
Test: Manually tested in Felix Landscape mode.
Bug: 324269623
Change-Id: Ife3714c4d22d96851618a88ed217009c4f9c3929
2024-03-21 01:04:28 +00:00
Jeremy Sim c22b39a319 Prevent Save App Pair from showing up on 3p launcher
This CL adds a check so that app pairs can't be saved on 3p launchers. This affects the Overview icon dropdown menu and the Overview Actions Bar.

Fixes: 326155701
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, option does not show up when Nova Launcher is set as default home app, and shows up again for Pixel Launcher.
Change-Id: I60d6fd3b3eb39921edafb12faace743d16de270f
(cherry picked from commit 2b2d8cc90b)
Merged-In: I60d6fd3b3eb39921edafb12faace743d16de270f
2024-03-20 23:35:29 +00:00
Willie Koomson 2471805414 Handle widgets added with tap-to-add in AppEventProducer
Widgets added with tap-to-add do not emit an ITEM_DROP_COMPELTED event,
so this change updates AppEventProducer to check for
WIDGET_ADD_BUTTON_TAP event so that it can emit an ACTION_PIN
event for these widgets as well.

Also moves the stats logging for tap to add to after
Launcher.addPendingItem is called, so that the PendingAddItem's container
is set to CONTAINER_DESKTOP.

Bug: 323886237
Test: manual, add widget and confirm event is produced through logging,
 and widget no longer appears in suggestions
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add STAGING
Change-Id: Iaf46a408d05f61864a79f87b23160364b6513323
2024-03-20 22:07:02 +00:00
Federico Baron 0584c86ce6 Revert "Add screenrecord for testOverviewDeadzones"
This reverts commit eb65ca1600.

Reason for revert: test fixed with ag/26635495

Change-Id: Ic6b131f7a50e8b4f651b601cdf30304ce587eb5d
2024-03-20 20:55:57 +00:00
Vinit Nayak 5afb093a58 Merge "Add CUJ Jank interactions for App Pair saving and launching" into main 2024-03-20 20:31:01 +00:00
Sunny Goyal 5ca50490a3 Making some classess accessible in multivalent tests
Bug: 297950111
Flag: None
Test: Presubmit
Change-Id: I2e4b18fc279cb96b3f68d64f95703c11bb885b2a
2024-03-20 13:30:40 -07:00
Vinit Nayak 3b63408ad1 Call setOverviewDragState() whenever taskbar is recreated
* Un/Pinning taskbar re-creates controllers which led to
stale state for checking if we are allowing split selection

Test: Crash/immediately going into split no longer repros after
un/pinning taskbar in overview and trying to split
Fixes: 326356246

Change-Id: I06cfc4d1c3c7fe071f04414c3134eaff7960ade6
(cherry picked from commit 0adca26744)
2024-03-20 19:42:03 +00:00
Ats Jenk 259552350e Set bubble bar alpha to 0 and collapse if it bubbles are hidden
Only set bubble bar alpha to 0 and mark it collapsed when bubbles are
hidden.
When bubble bar should be hidden due to system ui state, only update
visibility.

Bug: 324068295
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: trigger a buble from bubbles test app
  - swipe to home screen
  - observe bubble bar is shown
  - swipe notification shade down and away again
  - observe bubble bar is hidden when shade is open, and shown when
    closed
  - expand bubble bar
  - repeat swipe shade down and away, observe expanded bubble is hidden
    while shade is open and bubble is expanded when shade is swiped away
Change-Id: Icc717ab250061f14f02a558eb9f7301fdc08c5c7
2024-03-20 12:12:53 -07:00
Vinit Nayak e0c3403a9a Merge "Call setOverviewDragState() whenever taskbar is recreated" into main 2024-03-20 17:20:48 +00:00
Sihua Ma f0518bb89f Fix out-of-sync updates during grid change
This is a combination of two issues:

1. Widget updates are not passed to the holder when the launcher binding starts
2. Updates from widgetHost.startListening() are overriden by out-of-date info

Fix: 322919716
Test: Manual
Flag: N/A
Change-Id: I9665117412c87b19ed5d98263bb4f9b8da21c5c7
(cherry picked from commit f418b2e16d)
2024-03-20 16:58:00 +00:00