- Add back touch handling on icon to make task menu work again
- Add back a couple of UI state handling for icon
- Fixed pivot of TaskView to use overviewTaskThumbnailTopMarginPx for calculations
- No longer require `taskView.getTask().icon` to populate TaskMenuView as it's no longer used in the menu; for TaskMenuViewWithArrow, check iconView.drawable instead which will get copied into DragLayer
- Added menu item handling for DesktopTaskView, and aligned GroupedTaksView handling to same mechanism
- Refactored Screenshot and Modal shortcut availability check into TaskShortFactory for consistency with other shortcuts
Bug: 249371338
Test: manual
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: I22ee6a5ca3c16a1bd510b0910211823e8c0be71b
This reverts commit fb092a9a6c.
Reason for revert: b/333937249
Change-Id: I77bd6c0d2fbe2f2dad074e8e0e741b50d4d7c204
(cherry picked from commit a6bf5a0014)
We use a second set of colors to ensure that the text is more visible in light mode for the gesture navigation tutorial.
Fix: 318471359
Test: Run the gesture navigation tutorial in light mode and dark mode
Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED
Change-Id: Ib83fdcce1d2bd057ca4bf3258cc81fda704bf149
Made icons elevation animates to flat state while bubble bar is being
expanded and animate to full elevation while bubble bar is being
collapsed.
Test: Visual
Fixes: 295027436
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Change-Id: I8286cd79904367654e319d6a84a307bd64c28d93
We only need to run the Search edu if it is enabled on devices. The code
itself is also made more generic in terms of method and variable names.
Fix: 330401405
Test: Enable and disable the search function and check whether the edu tooltip shows
up for each specific use case.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning NEXTFOOD
Change-Id: I1cea3ee56922c0b47ae7e8379aad4b36570daa17
Merged-In: I1cea3ee56922c0b47ae7e8379aad4b36570daa17
Shell-transit has been in production for a whole release
now, so disable the flag.
Bug: 294268547
Test: N/A - unused
Flag: NA
Change-Id: Idbc8ffc007b4d0aa01ecdfe47c846c05a937de70
This reverts commit 8771dfe3dd.
Reason for revert: was only a temporary fix while investigating issue, should be unnecessary after ag/27089675 is landed.
Change-Id: I5963dc77f31eb45c1cdd100788b045891de2d716
This reverts commit 41fcfc1f72.
Reason for revert: was only a temporary fix while investigating issue, should be unnecessary after ag/27089675 is landed.
Change-Id: Ic1ab614cfc0e7bf4b82c8d0eaa1662fd4129932a
We should first decide how we would like to animate dismissal of the
selected bubble, and than implement arrow animation. The issue exists
because background is shrinked without an animation.
Test: Visual
Fixes: 293350516
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Change-Id: Ia0cf04671bf9e93c98c45c99a21865055462e6df
- TaskThumbnails in DesktopTaskView already take into account topMarign during onMeasure, we should avoid adding double margin
- mTaskThumbnailViewDeprecated's visibility is always GONE, so no need to set margin either
Fix: 336968808
Test: manual, image test to follow-up
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: I6a7cb128ead0b042974b95199ab720cafc3bcc18
This refactor will make it easier to initialize TaskbarManager in a test
environment. Se go/taskbar-controller-tests for context.
Test: TaskbarNavButtonControllerTest
Bug: 230027385
Flag: N/A
Change-Id: I157649ff93b5e1751e6774e2cba2f76750792292
- Instead of using widthPx/heightPx, use BaseContainerInterface.getTaskDimension that takes into account of whether Taskbar is persistent or pinned
Fix: 336788597
Test: Swipe up from Desktop; press recents button from Desktop
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: I04d3b5bbc577ea650f8a9dc45cc6d01bca3f6466
This reverts commit dfb334f1e1.
Reason for revert: A bunch of WM fixes are in (b/291562764)
Change-Id: I9d08dab976cda112f802ee91256c09ef2026a01f
(cherry picked from commit 4dbac6caa9)
- ag/27016210 caused a regression for DesktopTaskView, where shouldAddStubTaskView returns false whenever DesktopTaskView have multiple tasks
- This is because for an unknown reason, runningTasks for Desktop task is always a single element array. This will be further investigated in b/249371338
- For now, shouldAddStubTaskView will still match DesktopTaskView if any runningTasks matches any of the tasks
Bug: 333844287
Test: With 2 split tasks, unsplit one, go to Overview, launch the other split, unsplit, go to Overview
Test: Swipe up from desktop
Flag: NONE
Change-Id: I40cff473595a21ad1619bcdbde30bb8bfd600e15
- Completely rewrote shouldAddStubTaskView to simplify the logic
Fix: 333844287
Test: With 2 split tasks, unsplit one, go to Overview, launch the other split, unsplit, go to Overview
Flag: None
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:492965326e7391c8427b6fca7875508e7a957b49)
Merged-In: I2f33f91956d485957cedf43ccd684f16d42803be
Change-Id: I2f33f91956d485957cedf43ccd684f16d42803be
Sam Cackett
Mykola Podolian
Alex Chau
Anushree Ganjam
Andy Wickham
Vinit Nayak
Saumya Prakash
Liran Binyamin
Bill Yi
Brandon Dayauon
Brian Isganitis
Shan Huang
Daniel Akinola
Evan Rosky
Holly Jiuyu Sun
Jagrut Desai
Treehugger Robot
Tracy Zhou
Sukesh Ram
Anna Zhuravleva
Jordan Silva
Himanshu Gupta