PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Avoid adding unnecessary topMargin to TaskThumbnails in DesktopTaskView

Browse Source 
- TaskThumbnails in DesktopTaskView already take into account topMarign during onMeasure, we should avoid adding double margin
- mTaskThumbnailViewDeprecated's visibility is always GONE, so no need to set margin either

Fix: 336968808
Test: manual, image test to follow-up
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: I6a7cb128ead0b042974b95199ab720cafc3bcc18
This commit is contained in:
Alex Chau
2024-04-25 10:57:01 +01:00
parent de68b73d16
commit fa402d1da9
1 changed files with 1 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
quickstep/src/com/android/quickstep/views/DesktopTaskView.java
+1 -11
View File
@@ -38,7 +38,6 @@ import android.widget.FrameLayout;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import com.android.launcher3.DeviceProfile;
import com.android.launcher3.R;
import com.android.launcher3.Utilities;
import com.android.launcher3.desktop.DesktopRecentsTransitionController;
@@ -305,16 +304,7 @@ public class DesktopTaskView extends TaskView {
@Override
protected void setThumbnailOrientation(RecentsOrientedState orientationState) {
DeviceProfile deviceProfile = mContainer.getDeviceProfile();
int thumbnailTopMargin = deviceProfile.overviewTaskThumbnailTopMarginPx;
LayoutParams snapshotParams = (LayoutParams) mTaskThumbnailViewDeprecated.getLayoutParams();
snapshotParams.topMargin = thumbnailTopMargin;
for (int i = 0; i < mSnapshotViewMap.size(); i++) {
TaskThumbnailViewDeprecated thumbnailView = mSnapshotViewMap.valueAt(i);
thumbnailView.setLayoutParams(snapshotParams);
}
// no-op
}
@Override