Commit Graph

77757 Commits

Author SHA1 Message Date
Shamali Patwa 94c4dbfbbb Merge "Reuse widget picker's surface color in add item dialog." into main 2024-08-27 13:55:03 +00:00
Treehugger Robot 565f7e73b5 Merge "Convert OverviewCommandHelper to Kotlin" into main 2024-08-27 12:54:04 +00:00
Tracy Zhou 9146984e69 Merge "Only call notifyUpdateLayoutParams when the params is changed" into main 2024-08-27 02:31:15 +00:00
Treehugger Robot fe4cb0de51 Merge "Add logging around InstallSessionTracker to verify PackageInstaller is communicating with Launcher." into main 2024-08-27 00:55:49 +00:00
Shamali P 0cac409a60 Reuse widget picker's surface color in add item dialog.
In ag/28129361 add item dialog's color was changed to reference
material color token defined in launcher theme. But add item activity
inherits from Theme.Translucent.NoTitleBar for its appearance (while
launcher theme uses deviceDefault.Light), so, cannot inherit as is from
the launcher theme. Since, there is already a token specific for widget
picker surface color imported via widgetTheme, using it so it stays
in sync with main picker.

Bug: 354604590
Test: Manual
Flag: EXEMPT BUGFIX
Change-Id: I61ed5e65b0efd065490a54251028cde5888e4391
2024-08-26 23:16:25 +00:00
Charlie Anderson e745aa87fc Add logging around InstallSessionTracker to verify PackageInstaller is communicating with Launcher.
Bug: 350144057
Flag: NONE just logs
Test: Locally
Change-Id: I600cac50d7202458abf968fc0707eba58ffc0e65
2024-08-26 19:15:58 -04:00
Bryce Lee 4d2091e8f0 Merge "Show Taskbar when Glanceable Hub is showing." into main 2024-08-26 21:50:18 +00:00
Sebastián Franco b9ce69db9e Merge "Correctly map the drag view position to the Workspace" into main 2024-08-26 21:13:06 +00:00
Brandon Dayauon 412821fadf Merge "Create an alpha letter scroller" into main 2024-08-26 20:21:17 +00:00
Treehugger Robot cc22b62109 Merge "Recreate icon alignment controller when isIconAlignedWithHotseat changes." into main 2024-08-26 19:10:31 +00:00
Brandon Dayauon 1f8f88696b Create an alpha letter scroller
- The function used is a raised cosine function to determine the sections to animate.

Tested flag: adb shell device_config put launcher com.android.launcher3.letter_fast_scroller true
Based on recent figmaspec, size of selected letter is 28dp and regular is 20dp. That means scaling should be 28/20.
Colors are:
onSurface for letter
surfaceContainer for background.
Figma shows selected colors are materialColorOnSecondary

bug:358673724
Test manually: https://drive.google.com/file/d/1gvJd5KoK8X_Sv8jXg1cZ65R4AuqHuvcd/view?usp=sharing
Flag: com.android.launcher3.letter_fast_scroller

Change-Id: Ia86eb0e8c41bc043fda3c44aeaf59e204429f337
2024-08-26 11:21:26 -07:00
Jon Miranda f9e46eaa15 Recreate icon alignment controller when isIconAlignedWithHotseat changes.
Before: when launching an app and immediately swiping home, the icon alignment
animation would become stale, which lead us to playing the wrong interpolator
for the action key alpha animator.

Fixes: 359579152
Test: open app, then immediately swipe home
Flag: EXEMPT bugfix
Change-Id: Ief08bd0fcb9fdc60efd0b8dd0821c1122cfa6f4f
2024-08-26 17:24:46 +00:00
Winson Chung e584fb3b31 Merge "Fix regression in ending recents transition while locked" into main 2024-08-26 16:12:18 +00:00
Mykola Podolian d56fb26f84 Merge "Fixed issue with the bottom zone of launcher is not touchable." into main 2024-08-26 15:43:39 +00:00
Liran Binyamin 9720472a8a Merge "Revert^2 "Synchronize bar expansion with WM Shell"" into main 2024-08-26 11:29:31 +00:00
Liran Binyamin b0801dcc3c Merge "Update both width and height in BubbleBarView" into main 2024-08-26 11:28:19 +00:00
Luca Zuccarini 6bf20cd965 Merge "2/3 Move some Shell utils to the Shared package." into main 2024-08-26 10:07:55 +00:00
Sebastian Franco 4bedb18466 Correctly map the drag view position to the Workspace
The drag view needs to be mapped to the drop target which in this
case is the Workspace instead of the CellLayout

Fix: 352569050
Test: IntegrationReorderWidgetsTest
Flag: TEST_ONLY
Change-Id: I233c2b3bf0b8637f80d74d201189b2290ef59c94
2024-08-25 20:41:00 -07:00
Winson Chung 6d1dcc2b4e Fix regression in ending recents transition while locked
- Prior to ag/28807475 we would not finish the recents transition
  when ending to home while the device is locked, so we need to
  continue to skip that now.

Flag: EXEMPT bugfix
Bug: 361950809
Bug: 359608026
Test: Lock the device, open camera and swipe up
Change-Id: I66ba065ebd0084ecd51ea803e88e31bf8acbfdcb
2024-08-25 20:45:03 +00:00
Tracy Zhou e5be9281c5 Only call notifyUpdateLayoutParams when the params is changed
Bug: 361405157
Test: manual
Flag: com.android.wm.shell.enable_taskbar_on_phones
Change-Id: Ieddcfbc8a8deea9415fe9815926e5fa5552b4be3
2024-08-24 03:10:42 +00:00
Treehugger Robot 9de3b46abf Merge "Rename test helper filegroup to robo" into main 2024-08-23 23:44:00 +00:00
mpodolian dcd76d56c7 Fixed issue with the bottom zone of launcher is not touchable.
Updated logic of the touch area configuration. Only add the taskbar
bounds if the taskbar is being shown inside the app or on overview.

Fixes: 358301278
Fixes: 361653416
Test: Manual:
http: //recall/-/gx8ASgewUeUS3QYohfrd1J/lpzJER3iGI5PpZrQqv7b7
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Id9902058c5ec873dab6257a34b4c3a87aec5ae6b
2024-08-23 16:43:37 -07:00
Vinit Nayak 8f53b7be9f Merge "Move CUJ trace start closer to AppPair launch animation" into main 2024-08-23 22:44:49 +00:00
Sihua Ma a9e4324bd5 Rename test helper filegroup to robo
Test: N/A
Flag: EXEMPT filegroup rename
Change-Id: I8afeccc69fbca8e317c6b74a051d6b94239b8c52
2024-08-23 22:13:33 +00:00
Bryce Lee 6668ab9cab Show Taskbar when Glanceable Hub is showing.
This changelist ensures that the Taskbar is not hidden when the
Glanceable Hub is showing. Logic for hiding the Taskbar when dreaming
was suppressing it from showing when Glanceable Hub was present. The
surrounding condition has been updated to now not trigger is Glanceable
Hub is showing.

Test: manual - verified Taskbar was properly displayed and hidden
      between glanceable hub and dreaming.
Flag: EXEMPT bugfix
Fixes: 353803584
Change-Id: I58a61617baff65041757ae0df96687a071120880
2024-08-23 13:31:09 -07:00
Charlie Anderson 19b9344636 Merge "Use bugfix flag for archived broadcast extras" into main 2024-08-23 20:07:06 +00:00
Treehugger Robot 8d18757f77 Merge "Fix wrong condition used to calculate clearAllShortTotalTranslation" into main 2024-08-23 19:56:10 +00:00
Vinit Nayak 71255b93f4 Move CUJ trace start closer to AppPair launch animation
Fixes: 361501841
Test: Logged CUJ and ensuring it gets hits when anim starts
Flag: EXEMPT bugfix
Change-Id: Ifecd2ccd21bf40a69fecad0c9634d122c058f059
2024-08-23 11:44:14 -07:00
Charlie Anderson 4c159412de Use bugfix flag for archived broadcast extras
Bug: 322314760
Test: locally
Flag: com.android.launcher3.enable_first_screen_broadcast_archiving_extras
Change-Id: I9e3944d35a1cf2a17d1b5fcbf249ecf488265a93
2024-08-23 18:08:15 +00:00
Jordan Silva 7775a4da34 Convert OverviewCommandHelper to Kotlin
This CL converts OverviewCommandHelper to kotlin prior to a refactoring CL and improvements in how the command queue is handled.

Bug: 352046797
Bug: 351122926
Flag: EXEMPT bugfix.
Test: Manual. Class conversion without behaviour changes.
Change-Id: I7edda0a5326ad2047546434214e048a5989124a4
2024-08-23 15:49:26 +01:00
Charlie Anderson cbbba7609c Merge "Fix cropped pre-archived app icons by converting to a fixed Adaptive Icon" into main 2024-08-23 14:22:56 +00:00
Shamali Patwa 9374094474 Merge "Fix issue that personal list shows on unfold while on work tab (paused)" into main 2024-08-23 13:41:21 +00:00
Alex Chau 24e03825cd Fix wrong condition used to calculate clearAllShortTotalTranslation
- We now calcualte the first task's start position, and compared against the expected position (mLastComputedTaskSize) to determine if we need extra translation for ClearAllButton
- The calculation is done with `mIsRtl = true`, and only only flip +/- when applying translation
- http://screen/brM3taew74Z3uZJ shows what happens without clearAllShortTotalTranslation:
  - Blue area is mLastComputedGridSize, green area is longRowWidth
  - firstTaskStart is caculated from left of grid size, adding longRowWidth
  - Red area is mLastComputedTaskSize, where focus task is in the middle (for grid-only-overview it's in top right)
  - clearAllShortTotalWidthTranslation is the yellow area

Fix: 354104098
Test: With normal/largest display size, LTR/RTL, focus task /grid only Overview, swipe up with 1/2/6/7 tasks
Flag: EXEMPT BUG_FIX
Change-Id: I324eebc0a2b2129a4ba62d4569bc555b74140c21
2024-08-23 12:03:40 +01:00
Charlie Anderson 4609d53ecf Merge "For archived apps, reset icon span as soon as BubbleTextView starts unarchiving" into main 2024-08-22 20:46:25 +00:00
Shamali P b3153f0bee Fix issue that personal list shows on unfold while on work tab (paused)
Bug: 358041878
Flag: EXEMPT bugfix
Test: on fold device with test dpc
Change-Id: I4b6d758cd4d98af941e2222db21a0307e1088867
2024-08-22 19:17:32 +00:00
Charlie Anderson 2a7b221676 Fix cropped pre-archived app icons by converting to a fixed Adaptive Icon
Bug: 358123888
Test: locally testing B&R with pre-archiving
Flag: com.android.launcher3.use_new_icon_for_archived_apps
Change-Id: Id01ef1e1812dda14a8b456834506c28aebc34623
2024-08-22 18:59:14 +00:00
Tony Wickham 3a47759619 Merge "Fix Taskbar being visible over Hotseat when recreated in Overview" into main 2024-08-22 18:51:55 +00:00
Tony Wickham 39d0107ef2 Merge "Animate away Recent Apps section when going to home" into main 2024-08-22 18:45:08 +00:00
Sebastián Franco 6edce2ad75 Merge "Remove test to postsubmit while they are flaky" into main 2024-08-22 17:08:45 +00:00
Alex Chau 11290775f4 Merge "Refresh runningTaskView's thumbnail after setting shouldShowScreenshot to true" into main 2024-08-22 15:17:35 +00:00
Charlie Anderson 1a30d3ab8c For archived apps, reset icon span as soon as BubbleTextView starts unarchiving
Bug: 350758155
Test: locally verify
Flag: com.android.launcher3.use_new_icon_for_archived_apps
Change-Id: Icc76c1bf300b2aa7883e571333bef1d33698f899
2024-08-22 10:09:09 -04:00
Jordan Silva e7c300f8f5 Merge "Fix condition when should focus on running task" into main 2024-08-22 10:32:50 +00:00
Treehugger Robot 7369348ba8 Merge "Delete dead test SettingsActivityTest" into main 2024-08-22 10:01:55 +00:00
Alex Chau eececf272e Merge "Reset mTopRowIdSet in applyLoadPlan" into main 2024-08-22 09:49:27 +00:00
Uwais Ashraf 37752f5e19 Merge changes I31d9a51e,I1bc14be7 into main
* changes:
  Prevent requestLayout() when updating drawables that don't change size
  Fix splash icon size to 52dp
2024-08-22 09:13:41 +00:00
Jordan Silva 4fb37a8ffa Fix condition when should focus on running task
Bug: 353947137
Fix: 353947516
Fix: 353947467
Fix: 353947334
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: OverviewDesktopTaskImageTest
Change-Id: I6210335333163ba70c228215e01889c0d13ec896
2024-08-22 09:50:52 +01:00
Tony Wickham 79f3cefae2 Animate away Recent Apps section when going to home
Also fix calculation for divider position during this transition
when there are recent apps. Added tests as well.

Flag: com.android.launcher3.enable_recents_in_taskbar
Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Test: TaskbarViewControllerTest
Bug: 343522351

Change-Id: Ifffd620c1d4c156b37561584d6e3278b39804439
2024-08-21 22:48:06 +00:00
Sebastian Franco f989210f5b Remove test to postsubmit while they are flaky
Bug: 332527963
Test: ReorderAlgorithmUnitTest
Flag: TEST_ONLY
Change-Id: I29d631ba7dfe7f2c3a5323bfb414cb4da5b3321b
2024-08-21 15:20:18 -07:00
Tony Wickham 5c32af7e5b Fix Taskbar being visible over Hotseat when recreated in Overview
Debugging locally, it seems there were a couple of state changes
and the last one (which is correct) was getting clobbered by a
previously destroyed instance of TaskbarLauncherStateController.
Fixed this by updating the isDestroyed() call which previously
only checked TaskbarActivityContext to now check
TaskbarLauncherStateController's destroyed state directly. This
is needed because TaskbarLauncherStateController is part of
LauncherTaskbarUIController which can be destroyed independently
of the other Taskbar controllers when Launcher is destroyed.

Also fix a debug log that was not updated long ago in ag/21122190

Flag: EXEMPT bugfix
Test: Go to overview, change Font Scale or Dark Theme from Quick
settings, ensure Taskbar is not visible over Hotseat
Fixes: 302923055

Change-Id: I1299462955b51a2bf931f022177045b1cec039c5
2024-08-21 21:43:54 +00:00
Treehugger Robot 97b4046b39 Merge "Add animation for the predicted icon ring Animation is modeled after the notification dot animation." into main 2024-08-21 21:25:54 +00:00