Commit Graph

6286 Commits

Author SHA1 Message Date
Winson Chung 8bc154a46b Merge "Fix crash when handling recents animation canceled" into sc-dev am: d489a4b6e9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15236027

Change-Id: I78d91a68981eca28e1483498571b8a3e19548a79
2021-07-08 21:34:55 +00:00
Winson Chung d489a4b6e9 Merge "Fix crash when handling recents animation canceled" into sc-dev 2021-07-08 21:21:37 +00:00
Winson Chung 255fe1ea45 Fix crash when handling recents animation canceled
- If Launcher finishes the animation, that also cleans up the screenshot
    on the server side, so we can skip calling it

Fixes: 192684578
Test: N/a, adding a null check
Change-Id: I8bf1ad5089762469697d14842cc14c184055e925
2021-07-08 10:12:34 -07:00
Ashish Gupta 646218ebf6 Merge "NIU Actions: Add NIU Actions tooltip" into sc-dev am: 4e74ccb082
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15126744

Change-Id: I3229482f572feb6e5fbfa8fc338bad23a9525c45
2021-07-08 07:41:46 +00:00
kumarashishg 88be649d21 NIU Actions: Add NIU Actions tooltip
These tooltips are added to educate the user about NIU buttons actions. We have added tooltips for Translate and Listen NIU actions buttons.

Bug: 186006700
Test: Manual
Change-Id: Ib076c2a44055b62f2daf06bddf45aca220a28756
2021-07-08 00:48:22 +00:00
Vinit Nayak 79ef1e59a5 Merge "Set correct divider dimension for task menu options" into sc-dev am: 7d0826f3d1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15164589

Change-Id: I87ad2a546167527cd3dbf2c604e335a0247801ce
2021-07-07 20:12:28 +00:00
Vinit Nayak 7d0826f3d1 Merge "Set correct divider dimension for task menu options" into sc-dev 2021-07-07 19:56:56 +00:00
Winson Chung ce2027d42e Merge "Remove unused logs" into sc-dev am: da587fb7a6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15162482

Change-Id: Iea84d43b7c8cf45e1e97fa290710bd597ac839f8
2021-07-07 18:05:47 +00:00
Winson Chung da587fb7a6 Merge "Remove unused logs" into sc-dev 2021-07-07 18:02:53 +00:00
Bill Yi 74876a5161 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I5f86f87b40f235e4aa46383c09dda8cdf596b692
2021-07-07 16:30:01 +00:00
Bill Yi bf91858e6e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ia27bb122b5cfd53a63f2a3511308dffc0afdce85
2021-07-04 19:05:46 +00:00
Lucas Dupin b546a2d8f8 Merge "Use launcher surface when removing launch target" into sc-dev am: e55878cedf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15193282

Change-Id: Ife796fb90e961d55df70a87cc8f3b84d08a8cc2d
2021-07-03 17:28:56 +00:00
Lucas Dupin e55878cedf Merge "Use launcher surface when removing launch target" into sc-dev 2021-07-03 17:14:32 +00:00
TreeHugger Robot c613a10fc9 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-07-03 04:31:47 +00:00
Winson Chung b8e2ba9203 Merge "Fix crash when handling recents animation canceled" into sc-dev am: a82403ab09
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15192339

Change-Id: Id4eb3b055b9cd640e879a58479b5a9d2bf5eeb12
2021-07-03 03:42:32 +00:00
Winson Chung a82403ab09 Merge "Fix crash when handling recents animation canceled" into sc-dev 2021-07-03 03:26:26 +00:00
Winson Chung 553d978012 Fix crash when handling recents animation canceled
- If Launcher finishes the animation, that also cleans up the screenshot
  on the server side, so we can skip calling it

Fixes: 192684578
Test: N/a, adding a null check
Change-Id: Ia6b99b4262e72f925e7d622ea8833d3c88252633
2021-07-03 03:26:16 +00:00
Bill Yi 08137e17e3 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ib5182dabf0e6a33287a5388449c2378fb2be10d1
2021-07-03 03:13:27 +00:00
Lucas Dupin 20a13047ae Use launcher surface when removing launch target
Otherwise events won't be dispatched properly and window opacity will be
wrong.

Test: manual
Fixes: 191149025
Change-Id: Ice7ea86252282c7dc1cb5925dd1bdb8cade89c08
2021-07-02 17:39:10 -07:00
Tracy Zhou a5dd6fb387 [DO NOT MERGE] Make the cutout slightly smaller am: 26f47c711a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15081309

Change-Id: I5c4e53095fa4a93bf1ce5efbb17832ba92bf7689
2021-07-02 21:54:15 +00:00
Tracy Zhou ee5dc1149e Merge "[DO NOT MERGE] Make the cutout slightly smaller" into sc-dev 2021-07-02 21:41:28 +00:00
Tracy Zhou 26f47c711a [DO NOT MERGE] Make the cutout slightly smaller
Temporary fix for S. Leaving the bug open for a proper fix in T.

Bug: 189265196
Test: https://screenshot.googleplex.com/75fgCva736rqwg5
Change-Id: Ice3b189a41f759e090334e360e44543eabc4836d
2021-07-02 13:35:50 -07:00
Sunny Goyal 13405411e7 Merge "Fix some touch issues during gesture nav transition" into sc-dev am: 6348858734
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15137733

Change-Id: Ibebb2ef1c6c05b95ef143ce0136ea203cd2a7863
2021-07-02 18:35:53 +00:00
Tracy Zhou 6ffacb09a9 Merge "Check if live tile targetSet is null in launchSideTaskInLiveTileModeForRestartedApp" into sc-dev am: fa72529b05
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15184810

Change-Id: I94bff6e7bc83f86aab2fc12d3c2649e4b65360e6
2021-07-02 18:35:15 +00:00
Sunny Goyal 6348858734 Merge "Fix some touch issues during gesture nav transition" into sc-dev 2021-07-02 18:33:34 +00:00
Tracy Zhou fa72529b05 Merge "Check if live tile targetSet is null in launchSideTaskInLiveTileModeForRestartedApp" into sc-dev 2021-07-02 18:18:23 +00:00
Tracy Zhou d2039614e0 Check if live tile targetSet is null in launchSideTaskInLiveTileModeForRestartedApp
Fixes: 192458435
Test: N/A
Change-Id: I3f0b828bf9fa9645bbd253612aa073f37b21e4b2
2021-07-01 23:52:34 -07:00
Tracy Zhou 52eb75bfee Enable live tile in 3 button mode am: 1fe5fda3d8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14254546

Change-Id: If5a526a1e949629ce610ce18a042be9e6eb8b544
2021-07-02 06:51:44 +00:00
Tracy Zhou 1fe5fda3d8 Enable live tile in 3 button mode
- Previously we rely on whether launcher is resumed as a signal to see what "toggle" means. This no longer works since launcher is not resumed in Overview. Instead, we need to check the live tile signals.
- Use screenshot doesn't propagate after setting a new current task. So followed the logic around mRunningTaskIconScaledDown to work it out.
- Get rid of NavigationModeFeatureFlag, pending on 3rd party launcher change ag/14409355

Fixes: 185934639
Test: (1) Toggle overview from home screen and toggle back to fullscreen. (2) Toggle overview from app and keep toggling.

Change-Id: Iffaea18afb2179b5bb7dadda49e56efefa5658bc
Merged-In: Iffaea18afb2179b5bb7dadda49e56efefa5658bc
2021-07-02 05:19:32 +00:00
Alex Chau 4eabe23108 Merge "Restore previous currentPage in applyLoadPlan in case task is re-ordered" into sc-dev am: 679f8bb9ca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15175270

Change-Id: I409622ab04cc934290013203281329987e0ae5ec
2021-07-01 22:27:33 +00:00
Alex Chau 679f8bb9ca Merge "Restore previous currentPage in applyLoadPlan in case task is re-ordered" into sc-dev 2021-07-01 22:12:54 +00:00
Tracy Zhou ec5c2ea87e Merge "Do not switch to screenshot and finish recents animation for menu options that already do so" into sc-dev am: e54f789de9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15176734

Change-Id: I6e980151382b7ce10fb4d206d86295a41e938b8f
2021-07-01 19:45:18 +00:00
Tracy Zhou e54f789de9 Merge "Do not switch to screenshot and finish recents animation for menu options that already do so" into sc-dev 2021-07-01 19:32:39 +00:00
Jonathan Miranda d156f372f5 Merge "Fix bug where app icon is gone for first frame on cold start." into sc-dev am: 3334c32120
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15164770

Change-Id: I3680615723b0ef5edf175db01fd44ed068f2147f
2021-07-01 18:35:30 +00:00
Jonathan Miranda 3334c32120 Merge "Fix bug where app icon is gone for first frame on cold start." into sc-dev 2021-07-01 18:34:47 +00:00
Sunny Goyal 08fa7008b0 Merge "Fixing some dimentions in AllSet activity" into sc-dev am: f3d3dcf4a1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160037

Change-Id: I8f187fe98130bc8c35864a97b21fc31fb1161e30
2021-07-01 18:31:02 +00:00
Sunny Goyal f3d3dcf4a1 Merge "Fixing some dimentions in AllSet activity" into sc-dev 2021-07-01 18:16:45 +00:00
Tracy Zhou 99adef95b3 Do not switch to screenshot and finish recents animation for menu options that already do so
The issue is that in landscape mode we add overview shortcuts (e.g. screenshot) to the task view menu, where we switch to screenshot and finish recents animation before executing the shortcut action. However for shortcut actions like screenshot, we do the same, resulting in two chained "switch to screenshot and finish". This is a temporary fix for S given it's late in the cycle and we don't want to introduce unwanted regressions.

Fixes: 192272546
Test: manual
Change-Id: I7ef596e8bce6c15aa4a27163197beac12359b691
2021-07-01 17:46:44 +00:00
Alex Chau e0fcee01b3 Restore previous currentPage in applyLoadPlan in case task is re-ordered
Fix: 186537288
Test: Repeatededly launch task from home and swipe to home, animation is correct
Test: Quick switch, launch task then swipe up, there is no jump
Change-Id: I9fd7416d9811ce4e54a1c6d20374d89d00417cd5
2021-07-01 18:43:20 +01:00
Tony Wickham 5fac02bc5e Fix some touch issues during gesture nav transition
- Don't recreate the laucher transition controller if we've already ended it, as it could clobber a touch interaction that started in the meantime
  - Test: swipe up from an app to overivew, swipe to dismiss it during the transition.
  - Previously, we were ending the controller twice (once on touch down as we started proxying, and again in setupLauncherUiAfterSwipeUpToRecentsAnimation()), and the second one could happen after starting the dismiss interaction.

- Don't recreateControllers() if orientation didn't change
  - Test: swipe up to go from an app to home, swipe up to all apps during the transition.
  - Previously, we were getting the following sequence:
    1. Touch down on home to start swiping to all apps - all current controllers get this down event to start determining whether to intercept
    2. Before reaching touch slop, we recreateControllers(), so all new controllers won't get the down event and thus won't intercept
  - Now, we avoid unnecessarily recreateControllers(), so the original controllers can still intercept.

Test: see above
Fixes: 189700453
Change-Id: I7b5fb3d21ab7a7a7044fcec7f2c1e39afe23c5dd
2021-07-01 07:39:59 -10:00
Winson Chung 277e9c83c7 Merge "Defer cleaning up screenshot until after we actually switch to screenshot" into sc-dev am: eb0a38c5f2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15160033

Change-Id: I4ed3c6d9009dcff282b08e6597fecd9dcfdecd0e
2021-07-01 17:14:51 +00:00
Winson Chung eb0a38c5f2 Merge "Defer cleaning up screenshot until after we actually switch to screenshot" into sc-dev 2021-07-01 17:11:35 +00:00
Winson Chung 6a777d84b8 Remove unused logs
Bug: 191698994
Test: Just removing logs
Change-Id: Ia6ae528f1444cbdbe3823657492deeb6c4a3d6ce
Merged-In: Ia6ae528f1444cbdbe3823657492deeb6c4a3d6ce
2021-07-01 17:09:40 +00:00
Vinit Nayak 837359b1ea Set correct divider dimension for task menu options
Previously divider drawable dimension was set on height,
which only works when things are divided vertically.
For horizontal layouts, we need to set divider width.

Bug: 192398954
Test: Tested portrait + fake/real landscape
+ tablet

Change-Id: I5a63df9749bf37c3a563e923a1b4724aa17d9409
2021-07-01 02:05:42 +00:00
Jon Miranda 17cc821c28 Fix bug where app icon is gone for first frame on cold start.
We need the icon to be full alpha during the init pass, then when
the actual animation starts, we can swap the icon with the window
(splash screen that draws the icon).

Bug: 192366079
Test: slow down window animations
      check no empty frame on cold start app launch
      check no empty frame on warm start app launch

Change-Id: I16a1779e5252d8e88bc3c408e1dc40b264fe4cf4
2021-07-01 00:11:41 +00:00
Hongwei Wang 52df9c8580 Merge "Polish auto-enter-pip from landscape and split-screen" into sc-dev am: 005e269220
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15132509

Change-Id: I0fa466ab04f93a9d6f1f6ab15658a1d10f968fa4
2021-06-30 20:41:42 +00:00
Hongwei Wang 005e269220 Merge "Polish auto-enter-pip from landscape and split-screen" into sc-dev 2021-06-30 20:23:23 +00:00
Sunny Goyal 25f386edc8 Fixing some dimentions in AllSet activity
Bug: 192412172
Test: Manual
Change-Id: I599c858fc21d45dd41eaa01ff3d91863d52f6ae8
2021-06-30 12:19:30 -07:00
Winson Chung a7d7f78c08 Defer cleaning up screenshot until after we actually switch to screenshot
- In the case where we get a screenshot on cancel, we should wait to
  finish the recents animation until the view gets a chance to update

Bug: 185643608
Test: Swipe up to overview in 2 button, hit home
Change-Id: I2ac3567006f6fa7e6f473499f6862e5e408dfc3d
2021-06-30 12:03:33 -07:00
Yogisha Dixit 669bac8bd6 Merge "Log widgets source." into sc-dev am: f9acf1d5d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14690879

Change-Id: Ib47b6d3aaacaa30c723dafeeb65492510a150eb2
2021-06-30 18:32:53 +00:00