Commit Graph

18990 Commits

Author SHA1 Message Date
Adam Cohen 8f7d2b0dfd Fix issue where Assistant could be invoked at the same time as all apps
issue 132366412

-> First, we shouldn't accept flings when the delegate has intercepted. This prevents any situation
   where both are triggered.

-> Modified the slop to be the standard 8dp. This acts as a standalone fix because
   it means that there are no situations where we cross all apps slop before assistant slop.
   ie. in a purely vertical gesture from the corner, without this change, it's possible to trigger
   all apps instead of Assistant.

Change-Id: I39e3d8a525e165024399d9802d4cc1d7ae329ee6
2019-05-21 15:52:34 -07:00
TreeHugger Robot 4b41793155 Merge "Not allowing applying dot state to override "disabled" description" into ub-launcher3-qt-dev 2019-05-21 21:05:03 +00:00
Miranda Kephart 49e5d8227b Merge "Pass in fling velocity for gesture progress" into ub-launcher3-qt-dev 2019-05-21 21:05:00 +00:00
vadimt da6dad5101 Not allowing applying dot state to override "disabled" description
Disabled apps were always accessibility-marked like "Disabled Messenger"

With introduction of dots, this degraded, the the "Disabled" part was
never added.

Restoring the old behavior here.

Bug: 129036789
Change-Id: Icb97ea9a190643449d90f558a78039df30c53cbf
2019-05-21 13:24:23 -07:00
TreeHugger Robot 32ba3c1125 Merge "Using squared hypot to optimize some comparisions" into ub-launcher3-qt-dev 2019-05-21 19:48:37 +00:00
vadimt 3479cf80e7 More logging in AllApps + a fix
Change-Id: Iebcb336beee36b0aea47404f8c5d31dec14e7383
2019-05-21 12:08:15 -07:00
vadimt a1a417c994 Searching icons only in apps_list_view
This should help avoiding situations when an icon is intermittently
found in the suggested row vs. the recycler.

Change-Id: I71b17caa5f827999f0901d5c4d4348de7e16f053
2019-05-21 11:49:49 -07:00
vadimt 1053de165e Marking sure the center of icon is not under search box in all apps
Change-Id: I9cfc9941be2bed7834d58039fbfc2741fcf50cba
2019-05-21 11:10:03 -07:00
vadimt 982ea56122 Making sure that the icon in all apps is not under search box
Bug: 133011252
Bug: 133010447
Change-Id: Ie735ac36fa063d0d9290c59f6ad4af9e05600ddf
2019-05-20 16:53:39 -07:00
Sunny Goyal 878aa33567 Using squared hypot to optimize some comparisions
Change-Id: Ia5b99c2e60eedf02dea26857819f0e13127db4e2
2019-05-20 15:20:47 -07:00
Miranda Kephart b063775eb9 Pass in fling velocity for gesture progress
Calls SystemUIProxy.onGestureCompletion for a completed gesture
(either drag or fling) and passes in the velocity (0 for drags).

Bug: 132356358
Test: manual

Change-Id: I080adc401e19a6141627d1806b425056f7eefcbd
2019-05-20 18:07:44 -04:00
TreeHugger Robot 2445ca0777 Merge "Fix bug where FolderIcon stays visible during swipe up to home animation." into ub-launcher3-qt-dev 2019-05-20 20:16:47 +00:00
TreeHugger Robot 692b5a26d9 Merge "Swipe up to home into FolderIcon animation bug fixes." into ub-launcher3-qt-dev 2019-05-20 20:10:18 +00:00
TreeHugger Robot dea6ee23c6 Merge "Fixing inset map in case of display cutouts" into ub-launcher3-qt-dev 2019-05-20 19:11:19 +00:00
Sunny Goyal c79bd21471 Fixing inset map in case of display cutouts
Change-Id: Ia2969688d9ae4c89a2da45eb6361f4476e1877ec
2019-05-20 12:00:17 -07:00
TreeHugger Robot 662a14f2de Merge "Using different resource size for touch region in landscape" into ub-launcher3-qt-dev 2019-05-20 18:57:00 +00:00
Jon Miranda ae975a613d Swipe up to home into FolderIcon animation bug fixes.
- Fixes clipping issues.
- Fixes badge being shifted.

Bug: 124510042
Change-Id: I2520d963fb2041a049650c2b8c12ddb3de7b8d87
2019-05-20 11:10:25 -07:00
Zak Cohen 418b9bc5fc Adapt the task footer container to be a named container.
Bug: 126744445
Test: manual
Change-Id: Id00ffac4581bbbe5dfd73a63b05c4512394745c1
2019-05-20 10:44:20 -07:00
Sunny Goyal 1b40b731b2 Using different resource size for touch region in landscape
Bug: 132917885
Change-Id: Ib702fd17fecff980db2e1d00f05cd055bcc3185a
2019-05-20 10:09:26 -07:00
Jon Miranda e543818bb6 Fix bug where FolderIcon stays visible during swipe up to home animation.
This can happen when opening an app from a folder, and then immediately
swiping up back to home.

This happens because when we swipe up to go home, there's a race condition
where the folder close animation finishes and sets the FolderIcon to VISIBLE
right before FloatingIconView sets it to INVISIBLE.

To fix it, in OverviewState#onStateEnabled we call
AbstractFloatingView#closeAllOpenViews(animate=false). Then we added logic
to cancel any Folder closing animation (which there is,
from WindowTransformSwipeHandler#onLauncherStart) and to just close the
folder right then and there.

Bug: 132588097
Change-Id: I4379431815e7cbddede5ea0213fe9323f001484b
2019-05-20 10:01:15 -07:00
Winson Chung 0de5939638 Disable system ui auto scrimming now that we target Q.
Change-Id: Iff9706d078515a280ae7cf9d8c9dae8d269e1939
2019-05-18 21:19:32 -07:00
TreeHugger Robot 136805abdc Merge "Changing target sdk to Q" into ub-launcher3-qt-dev 2019-05-18 06:59:43 +00:00
Sunny Goyal f5577b1117 Changing target sdk to Q
Change-Id: I9c2ac12d81d3b04e1a29f6c2a1f2e32fff76de7f
2019-05-17 23:19:58 -07:00
Vadim Tryshev ef80b4b491 Merge "Make every UI test generate screenshots for local test runs" into ub-launcher3-qt-dev 2019-05-18 01:40:38 +00:00
vadimt c328ac56cf Make every UI test generate screenshots for local test runs
Change-Id: Idb7962e62c0c95f8a50792e9342562c6d8b6ba42
2019-05-17 18:19:13 -07:00
Sunny Goyal 0334047553 Updating SDK check now that the version code is finalized
Change-Id: I2b8d65885f83154f7500adb520b1eed1da5c4a4e
2019-05-17 16:57:23 -07:00
TreeHugger Robot 7c278b62f9 Merge "Continue using window's sysui flags if task thumbnail unavailable" into ub-launcher3-qt-dev 2019-05-17 22:25:42 +00:00
TreeHugger Robot 24200e2757 Merge "Reapply recents attached state in createActivityController()" into ub-launcher3-qt-dev 2019-05-17 22:21:03 +00:00
TreeHugger Robot 95b81c3e55 Merge "Cancelling touch interaction on multi-touch event" into ub-launcher3-qt-dev 2019-05-17 22:21:01 +00:00
TreeHugger Robot 57ffdc4ec7 Merge "Fix issue with restored task display ids" into ub-launcher3-qt-dev 2019-05-17 22:10:02 +00:00
Tony 921da74c64 Continue using window's sysui flags if task thumbnail unavailable
If the centermost task is null or doesn't yet have thumbnail data,
don't use its sysui flags - continue using the window we're swiping
from instead.

Bug: 132898688
Change-Id: I202937d8aa01ee24ef01693d9594c4929e6bd314
2019-05-17 18:04:53 -04:00
Sunny Goyal 78c1a42331 Cancelling touch interaction on multi-touch event
If the second touch happens outside the swipe region, for eg when the user
is using a different gesture like pinch-to-zoom, do not capture the
input events

Bug: 132916535
Change-Id: I59df3831b96689586a2a684bf11805d42f1cb1d9
2019-05-17 14:55:09 -07:00
Winson Chung 5aec768ff4 Fix issue with restored task display ids
- When tasks are restored, they don't have a valid display id yet,
  but they will still be started on the default display and should
  have the same options until proven otherwise.

Bug: 132892578
Change-Id: I8ba0a976bd5682fbcda72ca1a98bf2517eb31312
2019-05-17 14:45:34 -07:00
TreeHugger Robot d3b0e8ed61 Merge "Add more logging and commands to service dump" into ub-launcher3-qt-dev 2019-05-17 21:34:21 +00:00
Winson Chung 9fe9a155ca Add more logging and commands to service dump
Change-Id: I03d5ea5aac618eba7e0e5a1555e45a165918bb60
2019-05-17 14:23:09 -07:00
Tony Wickham c9986f59ac Merge "Remove TaskViewDrawable, scale RecentsView instead" into ub-launcher3-qt-dev 2019-05-17 20:41:55 +00:00
TreeHugger Robot b05fbb8915 Merge "Add getOverviewFullscreenProgress() to LauncherState" into ub-launcher3-qt-dev 2019-05-17 20:39:42 +00:00
Tony 1eb65b8a5b Remove TaskViewDrawable, scale RecentsView instead
Instead of faking recents scaling up when swiping down on a task,
actually scale it up. This is more consistent with what we do
for scaling to/from fullscreen elsewhere, and cleans up some code.

Bug: 130020567
Change-Id: I1a07813468d9a66f8f4e7b5d3d9a191b565f165c
2019-05-17 16:23:07 -04:00
Tony 5406817028 Add getOverviewFullscreenProgress() to LauncherState
- BackgroundAppState sets this to 1, all other states set it to 0
- QuickSwitchState extends BackgroundAppState, and calculations for
  fullscreen scale/translation are moved to BackgroundAppState
- Move fullscreen progress logic out of WindowTransformSwipeHandler
  and into the launcher activity controller, which uses the new
  RecentsView.FULLSCREEN_PROGRESS property to animate it

Bug: 130020567
Change-Id: If6265fcce3749050be354742e7d2c418d11ee9bb
2019-05-17 16:21:02 -04:00
TreeHugger Robot 098febafaa Merge "Make folder backgrounds opaque" into ub-launcher3-qt-dev 2019-05-17 20:13:12 +00:00
TreeHugger Robot a03bec439e Merge "Add padding between nav bar and hotseat in vertical bar layout." into ub-launcher3-qt-dev 2019-05-17 00:29:04 +00:00
Jon Miranda 3f411e7ae4 Add padding between nav bar and hotseat in vertical bar layout.
- Set to match the workspace padding on the opposite side of the
  screen.

Bug: 130521490
Change-Id: I26fd71bb146c56a647397a040dbbac9d1556c3fe
2019-05-16 17:16:21 -07:00
TreeHugger Robot fcfac8156d Merge "Avoid double triggering assistant gesture haptic" into ub-launcher3-qt-dev 2019-05-17 00:03:46 +00:00
Vadim Tryshev 3c7f48116c Merge "Fix pinning tests on android virtual device" into ub-launcher3-qt-dev 2019-05-16 23:51:28 +00:00
vadimt c7bb8479e9 Fix pinning tests on android virtual device
Change-Id: I90a8753975538ab9864591a37a7d366e1222f2d8
2019-05-16 16:32:25 -07:00
Hyunyoung Song 0d51988d6e Merge "Add developer options for grid change for Styles Bug: 118758696" into ub-launcher3-qt-dev 2019-05-16 22:08:43 +00:00
Miranda Kephart 6366d377af Avoid double triggering assistant gesture haptic
If the user drags almost all the way to gesture completion and
then flings, the haptic got triggered twice: first for the drag,
and then once the fling was registered. This checks whether the
assistant was already invoked before triggering the fling
invocation.

Bug: 132908798
Test: manual
Change-Id: Ibeed7279b8db32527490a0e11b8e5f0761187bbf
2019-05-16 18:00:14 -04:00
Jon Miranda c2968da372 Fix bug where FloatingIconView did not use IconShape normalization scale.
This fix allows for a clean tradeoff between the FIV and the original icon
in all icon shapes.

Bug: 130292844
Change-Id: Ief2eec2673161e0f9d32d8710713a1f01880040d
2019-05-16 14:21:28 -07:00
Hyunyoung Song 58de5de42a Add developer options for grid change for Styles
Bug: 118758696

Change-Id: I66cd36cda495d339e0c2550f0957e3fbcddca477
2019-05-16 13:38:38 -07:00
Vadim Tryshev 5338e0540b Merge "Revert "Capture screenshot when animating to home"" into ub-launcher3-qt-dev 2019-05-16 19:10:13 +00:00