PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
71,475 Commits 1 Branch 0 Tags
89d64bb34602d2eba0d3ee69815c59615d5f68fe
Commit Graph

71475 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Schneider Victor-tulias 89d64bb346 Add overview button rate-limiter to fix recurring bug 
Processing the TYPE_TOGGLE command immediately makes it relatively easy to start overlapping animations that clobber each other and prevent clean up callbacks from running. This would cause a janky overview animation, a full command queue that can't be emptied and a recents tile than gets stuck on the screen. Added a rate limiter to (hopefully) prevent this type of bug from recurring.

Flag: not needed
Fixes: 298792963
Test: quickly and repeatedly pressed the overview button, checked logs to check that the error case never occurs anymore and rate-limiter procs instead.
Change-Id: I1575c932bb24d2405792539e8a14ed8d4171f5ae
 2023-09-15 18:51:46 +00:00
Alex Chau 3554656c13 Merge "Add debug log in InvariantDeviceProfile.minCellSize" into main 2023-09-13 10:00:24 +00:00
Jagrut Desai ff077335d1 Merge "Revert "ENABLE_TASKBAR_PINNING for TEAMFOOD"" into main 2023-09-12 23:37:59 +00:00
Colin Cross 3c7e501bb9 [automerger skipped] Fix kotlin nullable errors in Launcher3 am: 70ca32bca2 -s ours am: f65d8e122a -s ours am: 24803b44be -s ours am: d6f2c09616 -s ours 
am skip reason: Merged-In I4525d0fa83a1db9cc5cff90f340fc3f863537c01 with SHA-1 4cc251e6c1 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24721675

Change-Id: I2693da7b6993aa106403a5ab78d5c337b516c5ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-12 22:55:39 +00:00
Colin Cross d74064c1c7 [automerger skipped] Fix kotlin nullable errors in Launcher3 am: e892df24ca -s ours am: 79c7f28993 -s ours am: a42a24fb97 -s ours am: 81ebeb0a3b -s ours 
am skip reason: Merged-In I26edfec35dca14abe90b08e3c74de0446eda95d2 with SHA-1 2608381792 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24723831

Change-Id: Ib37a3a1a097314c8e9deb7b7215dbb67476070e4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-12 22:55:28 +00:00
Winson Chung b0f5838214 Merge "Revert "Reset the frozen recents list state when switching to bu..."" into main 2023-09-12 22:32:10 +00:00
Brian Isganitis a46e03ad90 Merge "Stash transient Taskbar on overlay task stack changes." into main 2023-09-12 22:20:24 +00:00
Colin Cross d6f2c09616 [automerger skipped] Fix kotlin nullable errors in Launcher3 am: 70ca32bca2 -s ours am: f65d8e122a -s ours am: 24803b44be -s ours 
am skip reason: Merged-In I4525d0fa83a1db9cc5cff90f340fc3f863537c01 with SHA-1 4cc251e6c1 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24721675

Change-Id: I764491ddde5dcbb47ed16a5b521b63376cbac081
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-12 21:05:49 +00:00
Colin Cross 81ebeb0a3b [automerger skipped] Fix kotlin nullable errors in Launcher3 am: e892df24ca -s ours am: 79c7f28993 -s ours am: a42a24fb97 -s ours 
am skip reason: Merged-In I26edfec35dca14abe90b08e3c74de0446eda95d2 with SHA-1 2608381792 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24723831

Change-Id: Ifb5e92d872dd7ada0b33986b3b4fe8d0ec4f0adb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-12 21:05:37 +00:00
Ats Jenk d4d114f9cd Merge "Fix flicker when swiping from desktop to home" into main 2023-09-12 20:44:20 +00:00
Colin Cross 24803b44be [automerger skipped] Fix kotlin nullable errors in Launcher3 am: 70ca32bca2 -s ours am: f65d8e122a -s ours 
am skip reason: Merged-In I4525d0fa83a1db9cc5cff90f340fc3f863537c01 with SHA-1 4cc251e6c1 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24721675

Change-Id: I76fe6dcd33355485525ba3a430e5ce662bda73b1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-12 20:27:06 +00:00
Colin Cross a42a24fb97 [automerger skipped] Fix kotlin nullable errors in Launcher3 am: e892df24ca -s ours am: 79c7f28993 -s ours 
am skip reason: Merged-In I26edfec35dca14abe90b08e3c74de0446eda95d2 with SHA-1 2608381792 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24723831

Change-Id: I4370a33f96e6be95261d7caccfaccce664ab561f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-12 20:26:54 +00:00
Jagrut Desai 62bbdcaa15 Revert "ENABLE_TASKBAR_PINNING for TEAMFOOD" 
This reverts commit 1b9f4cc9e8.

Reason for revert: waiting to turn on until feature is complete. 

Change-Id: I362f2e86e0ff512934bf12360fbffbce43c0cdaa
 2023-09-12 20:20:05 +00:00
Colin Cross f65d8e122a [automerger skipped] Fix kotlin nullable errors in Launcher3 am: 70ca32bca2 -s ours 
am skip reason: Merged-In I4525d0fa83a1db9cc5cff90f340fc3f863537c01 with SHA-1 4cc251e6c1 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24721675

Change-Id: I63920878d870037215be05c2c634ffb9264dea86
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-12 19:41:24 +00:00
Colin Cross 79c7f28993 [automerger skipped] Fix kotlin nullable errors in Launcher3 am: e892df24ca -s ours 
am skip reason: Merged-In I26edfec35dca14abe90b08e3c74de0446eda95d2 with SHA-1 2608381792 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24723831

Change-Id: Ia08164cade554914039f024ff1ad2954a5e9a553
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-12 19:41:15 +00:00
Federico Baron 95090ebcc5 Merge "Add flag for smartspace as a widget implementation" into main 2023-09-12 18:43:58 +00:00
Federico Baron 092064e1d0 Merge "Add smartspace custom widget" into main 2023-09-12 18:43:58 +00:00
Alex Chau 2014f50515 Add debug log in InvariantDeviceProfile.minCellSize 
Bug: 298077774
Test: presubmit
Change-Id: I2a4d0a116a36b28c616ddcd18b3448fb2e2a7897
 2023-09-12 19:31:21 +01:00
Winson Chung 9c51128ebe Revert "Reset the frozen recents list state when switching to bu..." 
Revert submission 24683011-extend_recents_freeze_duration

Reason for revert: b/298544839

Reverted changes: /q/submissionid:24683011-extend_recents_freeze_duration

Change-Id: I7e881baf200981bddee39336fc3573dce0dc148f
 2023-09-12 17:01:47 +00:00
Brian Isganitis 0d157469ae Merge "Promote ENABLE_ALL_APPS_SEARCH_IN_TASKBAR to TEAMFOOD." into main 2023-09-12 16:49:52 +00:00
Jagrut Desai 8f754a92c7 Merge "ENABLE_TASKBAR_PINNING for TEAMFOOD" into main 2023-09-12 16:15:55 +00:00
Holly Jiuyu Sun 50fac00e96 Merge "Set focus to EditText after open Toast with Meta key." into udc-qpr-dev am: 997bc3e362 am: 2acdc942a1 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24667858

Change-Id: I34d858aca76915406722227d2c587433c650f07a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-12 04:43:44 +00:00
Holly Jiuyu Sun 2acdc942a1 Merge "Set focus to EditText after open Toast with Meta key." into udc-qpr-dev am: 997bc3e362 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24667858

Change-Id: I06067fd7390e592ad3ea2f3988c920a2146c8d4f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-12 03:53:12 +00:00
Holly Jiuyu Sun 997bc3e362 Merge "Set focus to EditText after open Toast with Meta key." into udc-qpr-dev 2023-09-12 03:12:50 +00:00
Tracy Zhou ca9b884118 Merge "Always recreate TaskbarActivityContext" into main 2023-09-12 02:24:45 +00:00
Jagrut Desai fb4694d51e Merge "Apply ForciblyShown WindowLayoutParam flags for Transient Taskbar" into udc-qpr-dev am: 733d440ac1 am: a1e8f327ff 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24709295

Change-Id: Id84c65adba08bae631cccfd6792c6a90b6992637
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-11 23:47:46 +00:00
Mady Mellor 3edb22bd09 Merge "Stash taskbar when bubbles is expanded in overview" into main 2023-09-11 23:14:40 +00:00
Jagrut Desai 1b9f4cc9e8 ENABLE_TASKBAR_PINNING for TEAMFOOD 
enable taskbar pinning feature for teamfood.

Bug: 270396583
Bug: 265437087
Test: Presubmit
Flag: ENABLE_TASKBAR_PINNING
Change-Id: Ib4c5900bc64b091f3666d06d018d234f3e77f963
 2023-09-11 16:07:42 -07:00
Jagrut Desai a1e8f327ff Merge "Apply ForciblyShown WindowLayoutParam flags for Transient Taskbar" into udc-qpr-dev am: 733d440ac1 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24709295

Change-Id: I0066e91a986878debb75663fa68d4f5408af8898
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-11 22:57:58 +00:00
Jagrut Desai 733d440ac1 Merge "Apply ForciblyShown WindowLayoutParam flags for Transient Taskbar" into udc-qpr-dev 2023-09-11 21:52:08 +00:00
Ats Jenk 521a7e428c Fix flicker when swiping from desktop to home 
When swiping up from desktop, we need to temporarily show launcher views
when user may go to overview. Hide them again when user just swiped up for
taskbar. But not hide them user is swiping home.
Previously we were always hiding launcher views when user swiped up from
desktop and that led to home or transient taskbar.
This change ensures that we only change the visibility of launcher views
when overview ui is hidden, freeform tasks are still visible, and
gesture has ended.
Otherwise there were flickers when, after swiping home, we were hiding
launcher views and then showing them again shortly after as the freeform
tasks were now hidden.

Bug: 297562634
Test: be on desktop with some open apps
      - swipe up to go home, observe that there are no flickers from
        home screen icons, widgets or hotseat
      - swipe up for transient taskbar, observe desktop apps remain
        visible
      - swipe up to go to overview, observe the other fullscreen apps
        flow in from the side

Change-Id: I14f9f95a3a22fbca6878ecea24848f271dc951d7
 2023-09-11 21:43:02 +00:00
Colin Cross 70ca32bca2 Fix kotlin nullable errors in Launcher3 
Fix kotlin nullable errors that were exposed by setting the retention
of android.annotation.NonNull and android.annotation.Nullable to
class retention.

This relands I26edfec35dca14abe90b08e3c74de0446eda95d2 with a fix in
SplitSelectDataHolder.kt to call createPackageContext when user is null
instead of asserting that it is not null.

Bug: 294110802
Test: builds
Test: WMShellFlickerServiceTests
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4cc251e6c1bd5e06ef24a92e08aae043cf3f2587)
Merged-In: I4525d0fa83a1db9cc5cff90f340fc3f863537c01
Change-Id: I4525d0fa83a1db9cc5cff90f340fc3f863537c01
 2023-09-11 20:35:47 +00:00
Colin Cross e892df24ca Fix kotlin nullable errors in Launcher3 
Fix kotlin nullable errors that were exposed by setting the retention
of android.annotation.NonNull and android.annotation.Nullable to
class retention.

Bug: 294110802
Test: builds
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2608381792389b60ba37c08afcea09dca3c6ff9c)
Merged-In: I26edfec35dca14abe90b08e3c74de0446eda95d2
Change-Id: I26edfec35dca14abe90b08e3c74de0446eda95d2
 2023-09-11 20:35:41 +00:00
Brian Isganitis 3cfc2a338d Stash transient Taskbar on overlay task stack changes. 
Test: Manual
Fix: 299515360
Flag: No
Change-Id: I3c182fa51bcb7af908aebf168f017923aff8c789
 2023-09-11 20:32:44 +00:00
Winson Chung 0940399f72 Merge "Reset the frozen recents list state when switching to button navigation" into main 2023-09-11 20:23:16 +00:00
Ivan Tkachenko 068d1ea839 Merge "Bubble bar user education" into main 2023-09-11 17:59:08 +00:00
Brian Isganitis cbaf0a7f70 Merge "Close overlay onTaskStackChanged when All Apps is visible." into main 2023-09-11 17:46:16 +00:00
Vadim Tryshev 63525b8350 Merge "Adding TestStabilityRule to AbstractDeviceProfileTest" into main 2023-09-11 17:38:28 +00:00
Schneider Victor-tulias 7f04c4be18 [automerger skipped] Merge "Add error handling to prevent IllegalArgumentException" into udc-qpr-dev am: 9e6a845ca4 am: ad147bbc0d -s ours 
am skip reason: Merged-In Iddbe55c1ff66b067f8456d058cbc60a2a698c4ae with SHA-1 0fb4b268e5 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24622404

Change-Id: Iefd80fe61819a392bc5bc75c93d260733bdcd8ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-11 17:19:33 +00:00
Mady Mellor 2da9c114c4 Stash taskbar when bubbles is expanded in overview 
Test: manual - have transient taskbar
             - have a bubble
             - go to overview
             - expand bubbles
             => observe that transient taskbar stashes
             - collapse bubbles
             => observe that transient taskbar unstashes

             - verify that expanding bubbles in app and on launcher
               home behaves as expected (stashes taskbar in app and
               don't see taskbar or stashed handle on home)
Bug: 284104811

Change-Id: I3d7057ed651e66ab2a0292725f30153ee4d6d51e
 2023-09-11 09:41:14 -07:00
Jagrut Desai 6472119d4b Apply ForciblyShown WindowLayoutParam flags for Transient Taskbar 
Test: Manual
Bug: 278078311
Flag: Not needed
Change-Id: Ia963e45b3b4e6d928b6292b80b73394e76fe2325
 2023-09-11 09:39:23 -07:00
Schneider Victor-tulias ad147bbc0d Merge "Add error handling to prevent IllegalArgumentException" into udc-qpr-dev am: 9e6a845ca4 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24622404

Change-Id: I543b44b24c93508776bcc4a7c24a8142a70d698c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-11 16:29:01 +00:00
Schneider Victor-tulias 9e6a845ca4 Merge "Add error handling to prevent IllegalArgumentException" into udc-qpr-dev 2023-09-11 15:30:05 +00:00
Tracy Zhou 01cc856157 Always recreate TaskbarActivityContext 
- Add ENABLE_TASKBAR_NO_RECREATION flag
  When the flag is turned on,
  * Always destroy and recreate
  * Move task bar drag layer lifecycle from TaskbarActivityContext to TaskbarManager
  * Wrap the drag layer into a fullscreen root view

Note that in order to preserve the window across multiple TaskbarActivityContext creations, the inset types and ids must stay the same, so it's extracted out.

Bug: 274517647
Test: Fold and unfold a few times. Use a few applications. Make sure the task bar is visible and in the right place (tested with ENABLE_TASKBAR_NO_RECREATION and FLAG_HIDE_NAVBAR_WINDOW both on, both off, and one on and one off)
Change-Id: Ic3f0aa3d056fe178a53b76b2ad6cc6b9bffd5898
 2023-09-10 22:43:47 -07:00
Winson Chung 8bbfc2b667 Reset the frozen recents list state when switching to button navigation 
- A quickswitch will freeze the spatial order of the recents list
  (to allow quickswitching back), but if a nav mode change happens
  immediately after, then the recents list will continue to be
  frozen leaving the list in the wrong order (which can cause a
  flake or failure)

Bug: 298544839
Test: atest NexusLauncherTests:com.android.quickstep.TaplTestsQuickstep
Change-Id: Iabac305ea12cf4a2eb704802a315b6feba49f88a
 2023-09-09 16:44:42 +00:00
Jagrut Desai 2a0d7b5a11 Merge "Add haptic feeback for Transient Taskbar" into main 2023-09-09 02:54:02 +00:00
Bill Yi 3c78dd0bad [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev am: dd88f81f35 -s ours am: 4461d33d01 -s ours am: 6945f5300f -s ours am: 619e391255 -s ours 
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24690757

Change-Id: I70a1902cf83c2f9e59a692c91b841affee35553c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-09 00:13:25 +00:00
Bill Yi 6cc8e38eca [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: be5be22279 -s ours am: 4131d41d68 -s ours am: acc5b334f8 -s ours am: 91675dd75e -s ours 
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24690757

Change-Id: I3afc4464fc7c0fa98ee2c3805a0a3e1366060967
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-09 00:13:13 +00:00
Bill Yi 5c52ffd78a [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: f37892fb64 -s ours am: 446f2b55ef -s ours am: 06c45c574d -s ours am: 243ef8918b -s ours 
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24690755

Change-Id: Idd063bb28057eb7e360425ffff2c12b02743969a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-09 00:12:56 +00:00
Bill Yi a366e454d3 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev am: dd88f81f35 -s ours am: e226e11197 -s ours am: ce63299f85 -s ours am: f1de3307d4 -s ours 
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24690757

Change-Id: Ibca5ac9fb13f31d1a668bbdf2e775f242134b597
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-09 00:06:08 +00:00