Commit Graph

27689 Commits

Author SHA1 Message Date
Tracy Zhou 8951db2d23 Merge "Improve grid preview performance" into rvc-d1-dev 2020-07-15 19:38:01 +00:00
Tracy Zhou 92628f5305 Improve grid preview performance
After breaking down the time we spend in rendering preview under a different grid setting, I found out that we spend a huge amount of time loading the workspace. It takes a long time in non preview case (launcher workspace init), so to optimize we should try to cut down things that are not necessary for preview. Widget model loading (widget and shortcut updates) takes half of the time, and can be optimized with minimal risks / code changes.

Bug: 160662425
Test: Manual

Change-Id: I89029d0ddf6e2517077a0ba3fbbcfdcd60b268d9
2020-07-15 17:09:57 +00:00
Sunny Goyal 6d6dca6d39 Import translations. DO NOT MERGE
Force snapping translations from unbundled branch
Bug: 159176821

Test: N/A
Change-Id: I2406edf7eef6aa683f99b2b5f897d16b8968a28d
2020-07-14 22:04:42 +00:00
Sunny Goyal 88e9c5dcb1 Preventing disambiguation screen when swiping up am: f130c29882
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12141303

Change-Id: I4af9c71769ac0ce7d30311b88a1564e31a5eac8d
2020-07-13 21:37:47 +00:00
Sunny Goyal f130c29882 Preventing disambiguation screen when swiping up
Bug: 161052537
Change-Id: Ibeeba0841963dc5eb1b5a09847cafc26eb6e4adc
2020-07-13 19:03:56 +00:00
Sunny Goyal 3338f1e98d [automerger skipped] Import translations. DO NOT MERGE am: e9bf882158 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12130183

Change-Id: I752ca1dcf6fbdca7cf3a568f5d720e632446c23d
2020-07-11 04:53:53 +00:00
Sunny Goyal e9bf882158 Import translations. DO NOT MERGE
Force snapping translations from unbundled branch
Bug: 159176821

Test: N/A
Change-Id: I2406edf7eef6aa683f99b2b5f897d16b8968a28d
2020-07-10 12:07:45 -07:00
TreeHugger Robot 53d65ac84c Merge "Persist prediction cache on every update" into rvc-dev am: 7f1f8030db
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12077951

Change-Id: I1d29a40dcb09249dfdbd35defc8372c9997a9ab8
2020-07-08 18:46:27 +00:00
TreeHugger Robot 7f1f8030db Merge "Persist prediction cache on every update" into rvc-dev 2020-07-08 18:35:26 +00:00
Sunny Goyal e58055d79d Fixing recents orientation (when home rotation is allowed) during swipe-up am: 52f2392405
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12102312

Change-Id: I6aeff866c4a0c5a1a30410adaaf9dd82dbb7510f
2020-07-08 05:11:28 +00:00
Sunny Goyal 52f2392405 Fixing recents orientation (when home rotation is allowed) during swipe-up
Bug: 158781568
Bug: 160149607
Change-Id: I27be09febcdb6f19687469db34b002ce682aa0cb
Merged-In: I27be09febcdb6f19687469db34b002ce682aa0cb
(cherry picked from commit 141c231d2f)
2020-07-08 00:24:29 +00:00
Sunny Goyal f16456f686 Persist prediction cache on every update
Test: Manual
Bug: 160058750
Change-Id: Icb0b7322b7f9754d3f1c3012e1c98a760f83c787
2020-07-07 18:22:37 +00:00
Greg Kaiser 42caab471a Go Launcher: Fix icon placement retention am: 8f490e21c9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12094432

Change-Id: I710bd9cdd2eccc974f476f516b577047dd34e871
2020-07-07 16:45:09 +00:00
Greg Kaiser 8f490e21c9 Go Launcher: Fix icon placement retention
We need dbFile set when MULTI_DB_GRID_MIRATION_ALGO is in
use.  This was set for other launchers, but not the Go launcher.

Bug: 157557047
Test: Built, flashed, moved icons on home screen, rebooted, and confirmed icons retained their position.
Change-Id: Icfcb56e00a8ac2f74e5f7a1957fd46cee5cb8b5b
2020-07-07 04:58:57 +00:00
Thiru Ramasamy fc49c2c54a Merge "Fixes NPE with system shortcuts." into rvc-dev am: 6f5d4bb8ab
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12035575

Change-Id: Iab463bb1eadf656973f7ee8ccbcd32dbbc056101
2020-06-29 23:51:39 +00:00
Thiru Ramasamy 6f5d4bb8ab Merge "Fixes NPE with system shortcuts." into rvc-dev 2020-06-29 23:35:59 +00:00
Zak Cohen 987ba0261f Thumbnail Cache - check canceled status on the right thread. am: 19797b419b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12029198

Change-Id: I4be3f6ad965dce8e01fff78500334b95e098863c
2020-06-29 22:22:19 +00:00
thiruram 43bf883841 Fixes NPE with system shortcuts.
Bug: 160109140
Change-Id: I35c00fc1792fcf11fc61e1876f9184bd5fb309ce
(cherry picked from commit 53925ff9c6)
2020-06-29 19:44:28 +00:00
Zak Cohen 19797b419b Thumbnail Cache - check canceled status on the right thread.
The cache was checking the canceled status on the background
thread, but the cancel call was being made on the main thread.
This was leading to canceled requests still delivering this thumbnail
in some cases.

Bug: 159840851
Test: local build and non-repo of bug
Change-Id: I9a3556f6570eee1db39ebec202c115d58010d7f8
2020-06-29 04:11:04 +00:00
TreeHugger Robot 458fef861f Merge "During accessible drag, hover events were not properly getting dispatched to the DragAndDropAccessibilityDelegate" into rvc-dev am: 0538863c58
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12010483

Change-Id: I99e26524f77c9aee996f693881be4f3de505a53e
2020-06-26 22:14:22 +00:00
TreeHugger Robot 0538863c58 Merge "During accessible drag, hover events were not properly getting dispatched to the DragAndDropAccessibilityDelegate" into rvc-dev 2020-06-26 21:59:15 +00:00
TreeHugger Robot 53c7ddd7fd Merge "Add NPE check for prediction controller" into rvc-dev am: f8e12b78bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12001481

Change-Id: Ibfd144b7208099e3ed50530cd1e7b948c3eb7b80
2020-06-26 19:53:41 +00:00
TreeHugger Robot f8e12b78bf Merge "Add NPE check for prediction controller" into rvc-dev 2020-06-26 19:39:34 +00:00
thiruram aa823d103e Fixes missing folder label after launcher restarts. am: e148652075
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12003751

Change-Id: I4ffa9bc2cb5a838db0d69accb4aaf3797f389c7c
2020-06-26 18:29:02 +00:00
Adam Cohen 9e3aebd8dd During accessible drag, hover events were not properly getting dispatched to the DragAndDropAccessibilityDelegate
=> regressed in ag/10634216 which attemped to use onHoverListener
=> the problem is that onHoverListener is only triggered when the event is passed to the CellLayout, however, as with all dispatching, these events are handled depth first, and so in cases where a child handled the event, it would never bubble back up to the parent.
=> instead we have to continue to override dispatchHover event to always give presecedence to the delegate when it exists

Bug: 155956518

Change-Id: Ic3ecf1b422c1821456328035a66a2fc1277e6746
(cherry picked from commit 6e7c37a205)
2020-06-26 17:15:03 +00:00
thiruram e148652075 Fixes missing folder label after launcher restarts.
Rootcause: FolderInfo was persisted into DB only when folder options are updated. Hence when folder was created (Folder option remains suggested) its title was not persisted into DB.

Fix: Persists folderInfo into DB always whenever title is updated

Bug: 159904890
Change-Id: If0d20b0d7fa6966dd7bb40a2c07bcb22bd0893e0
(cherry picked from commit 6ab4da8aa0)
2020-06-26 16:30:31 +00:00
Tracy Zhou f1c369589a Do preview grid migration in a worker thread am: 6b79a3767d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12002728

Change-Id: I4841e06d7bdbaf71f4d61f7c1da14b40b87fc6cb
2020-06-26 07:47:40 +00:00
Tracy Zhou 6b79a3767d Do preview grid migration in a worker thread
Also remove USE_SURFACE_VIEW_FOR_PREVIEW flag

Fixes: 159755324
Test: manual
Change-Id: I6517c34911e217a69063226b01e4583194902f9c
(cherry picked from commit 633a4bdf57)
2020-06-25 21:05:04 +00:00
Samuel Fufa 0036b2b67a Add NPE check for prediction controller
Bug: 159835714
Test: Manual
Change-Id: I9cc03f6491f4e14462be6c01edf3ed4ca1d82136
2020-06-25 20:10:01 +00:00
TreeHugger Robot 6be2c6cb83 Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev am: ccf588d36b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11994586

Change-Id: If5bd4173783df2ffa89062dece3b0a6b1aa1ffe7
2020-06-25 16:49:17 +00:00
TreeHugger Robot ccf588d36b Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev 2020-06-25 16:38:47 +00:00
Andy Wickham 3fef2dd92d Updates Assistant gesture regions when no longer tracking multiple. am: d2731957ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11992046

Change-Id: Iacfc6d6f8d8eb7eda45137d7aef8941c9620cb39
2020-06-25 02:39:14 +00:00
Tony Wickham 9e84745e4b Pass isLikelyToStartNewTask to onGestureStarted()
This ensures we immediately setRecentsAttachedToAppWindow(). As
mentioned in the bug, there was an edge case where we would animate
the attached state if the first move event passed the touch slop,
causing the adjacent task view to lag behind during the gesture.

Fixes: 159742520
Change-Id: Ie47bb84fdd3dbd69e3b74ca504d487fb9aedb551
(cherry picked from commit c6a56ef7a2)
2020-06-25 02:11:04 +00:00
Andy Wickham d2731957ea Updates Assistant gesture regions when no longer tracking multiple.
This should prevent states where Assistant triggers from
the vertical-center of the screen in portrait (see bug).

Also fleshes out OrientationTouchTransformerTests and
adds some new ones that fail without this change:
 - enableMultipleRegions_assistantTriggersInMostRecent
 - enableMultipleRegions_assistantTriggersInCurrentOrientationAfterDisable

Fixes: 158686674
Change-Id: I6d045a485f62e4010e9e3d00805a50fdd953a2fc
(cherry picked from commit 4b531b972d)
2020-06-24 22:32:14 +00:00
TreeHugger Robot 3af603f240 Merge "Fixing NPE befre ActionsView first initialized." into rvc-dev am: ca493d1426
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11978215

Change-Id: I68378ceec09b495b25568571474f2f4b295388d2
2020-06-24 07:09:46 +00:00
TreeHugger Robot ca493d1426 Merge "Fixing NPE befre ActionsView first initialized." into rvc-dev 2020-06-24 06:52:16 +00:00
TreeHugger Robot e65a33134d Merge "Remove hotseat edu flag" into rvc-dev am: d6cd14d179
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11979630

Change-Id: I1d29e2f3c79905889aad361a149de4dba5b05274
2020-06-24 04:53:00 +00:00
TreeHugger Robot d6cd14d179 Merge "Remove hotseat edu flag" into rvc-dev 2020-06-24 04:43:52 +00:00
Zak Cohen c588af043c Merge "Fixing TaskMenu positioning." into rvc-dev am: b2b0d4d478
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11978354

Change-Id: Id698c09d31f1d6558bd634b4816c985c733a0bec
2020-06-24 04:12:49 +00:00
Sreyas 20024f4447 Fixing NPE befre ActionsView first initialized.
Bug: 159728260
Change-Id: I00e6f8fccf8057495f77873f2f0a1ab01e63ed23
(cherry picked from commit 88f1f2046c)
2020-06-24 04:11:05 +00:00
Zak Cohen b2b0d4d478 Merge "Fixing TaskMenu positioning." into rvc-dev 2020-06-24 03:58:19 +00:00
TreeHugger Robot f58ec22c1c Merge "Use isolated display context to get display info" into rvc-dev am: 7f5a670cc3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11969858

Change-Id: I1a33b6fbdfa1f30031c6122fe0b20313e5f8987b
2020-06-24 03:51:04 +00:00
TreeHugger Robot 7f5a670cc3 Merge "Use isolated display context to get display info" into rvc-dev 2020-06-24 03:44:07 +00:00
TreeHugger Robot f7897465e3 Merge "Merging from ub-launcher3-rvc-dev @ build 6621659" into rvc-dev am: 738b1af342
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11975976

Change-Id: I170ce5d3e3d310b2c02f1ac24037aaef60e7dde9
2020-06-24 03:43:47 +00:00
TreeHugger Robot 738b1af342 Merge "Merging from ub-launcher3-rvc-dev @ build 6621659" into rvc-dev 2020-06-24 03:29:19 +00:00
Tracy Zhou 79e81dd799 Merge "Revert "Disable grid option feature in ThemePicker"" into rvc-d1-dev 2020-06-24 02:53:19 +00:00
Tracy Zhou 7afa69d438 Revert "Disable grid option feature in ThemePicker"
This reverts commit 0c88238966.

Reason for revert: Disable grid in rvc-dev, and revert this change in rvc-d1-dev.

Bug: 158790001

Change-Id: Id19579b87d0a83424be794cbac95b7df3fd67131
2020-06-24 02:53:05 +00:00
TreeHugger Robot 995cab35af Merge "Prevent premature resetting of quickswitch mode" into rvc-dev am: 1c90b51de6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11977176

Change-Id: I31e0e9cd12bc3bdeb9eecceb7d4db4aba20e91e9
2020-06-24 02:51:09 +00:00
TreeHugger Robot 1c90b51de6 Merge "Prevent premature resetting of quickswitch mode" into rvc-dev 2020-06-24 02:48:38 +00:00
Samuel Fufa 6293af5575 Remove hotseat edu flag
Launcher should not restrict user migration to a one time event if we want users to migrate their hotseat by enabling hotseat prediction from suggestion settings.

Test: Manual
Bug: 159731272
Change-Id: I0e42dd6b6cf6374928e5b399d121d17fe8024ae1
2020-06-24 02:01:07 +00:00