Commit Graph

74657 Commits

Author SHA1 Message Date
Sebastián Franco 892ffb8b15 Merge "Making 2 flags read only since they are used on backup and restore" into main 2024-03-14 20:12:05 +00:00
Federico Baron f6fd1f3d46 Merge "Fix bug where folder with 1 icon can exist" into main 2024-03-14 20:02:04 +00:00
Treehugger Robot 40ccc6059a Merge "Fix KQS app launch through tapping" into main 2024-03-14 19:24:29 +00:00
Schneider Victor-tulias 08c2575802 Fix KQS app launch through tapping
KeyboardQuickSwitchView only ever has 2 direct children, and all of the task views we're actually concerned with are in a scrollview. removing the extra index handling as this is being handled properly downstream.

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 328692760
Fixes: 304518513
Test: opened KQS and tapped all tasks (6 + overview)
Change-Id: I4e919cce7f1ab55822f93d34c1533062a71aa879
2024-03-14 19:18:49 +00:00
Schneider Victor-tulias 153dcde49b Merge "Update KQS task view layouts to new specs" into main 2024-03-14 19:17:33 +00:00
Sihua Ma 80a35cce2e Merge "Fix out-of-sync updates during grid change" into main 2024-03-14 18:09:15 +00:00
Pinyao Ting ebd958dc94 Merge "Remote legacy shortcut when failed to migrate" into main 2024-03-14 17:17:45 +00:00
Sebastian Franco 5ea61960ab Making 2 flags read only since they are used on backup and restore
The flags are narrow_grid_restore and grid_migration_fix.

Flag: ACONFIG enable_grid_migration_fix enabled
Flag: ACONFIG enable_narrow_grid_restore enabled
Bug: 325286145
Bug: 325285743
Test: BackupAndRestoreDBSelectionTest.kt
Test: GridMigrationTest.kt
Change-Id: Ia6a439553c3c5098115144eae532342ce73be4f2
2024-03-14 17:16:51 +00:00
fbaron 5645c3ec55 Fix bug where folder with 1 icon can exist
Fix: 329357132
Flag: NONE
Test: TaplDragTest
Change-Id: If381ff56e051c89e9f6162f8a44f8df9e2ae5060
2024-03-14 10:13:00 -07:00
Federico Baron 719075b56c Merge "Update min next page visible to 48dp" into main 2024-03-14 16:32:39 +00:00
Tony Wickham 7233d2a0e0 Merge "Avoid playing taskbar haptic when swiping up from home" into main 2024-03-14 16:20:34 +00:00
Luca Zuccarini bb937b2556 Merge "Introduce a new Home animation for workspace and the outgoing task." into main 2024-03-14 16:11:46 +00:00
Andreas Agvard 576454212c Merge "Removes recovery" into main 2024-03-14 15:51:32 +00:00
Rohit Goyal cbb8328272 Merge "Bugfix: Add null safety when accessing icon database for main activities for LoaderTask loadAllApps." into 24D1-dev am: aca99b60ab
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26554316

Change-Id: I53fc3448db4f8fdbf861df4b6b37f4177faa815e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-14 15:43:11 +00:00
Rohit Goyal aca99b60ab Merge "Bugfix: Add null safety when accessing icon database for main activities for LoaderTask loadAllApps." into 24D1-dev 2024-03-14 15:22:04 +00:00
Brandon Dayauon 69aa9a07ee Merge "Disable two line text legacy flag." into main 2024-03-14 15:11:13 +00:00
Treehugger Robot 2b97a7cd13 Merge "Set next page immediately on subsequent arrow/tab presses when navigating overivew." into main 2024-03-14 12:19:17 +00:00
Luca Zuccarini c9cbc9d5a1 Introduce a new Home animation for workspace and the outgoing task.
The values are currently the same for all display and orientation
configurations, but they might change before launch.

There are a couple known imperfections:
* Swiping out of a hotseat app with very low velocity doesn't look
  great
* Sometimes, if the window movement reaches its final location faster
  than the background is done scaling, there is a small snap in icon
  position

Bug: 298089923
Flag: ACONFIG com.android.launcher3.enable_scaling_reveal_home_animation DISABLED
Test: verified with the flag on and off

Change-Id: Id54c7f0a76f62108d8b92a3b5e78634fff64dbef
2024-03-14 10:48:02 +00:00
Jordan Silva d640a152cd Merge "Converting orientation handler classes to kotlin" into main 2024-03-14 10:03:07 +00:00
Schneider Victor-tulias 06e819d61c Merge "Close the KQS view when touching the gesture nav region" into main 2024-03-14 02:35:42 +00:00
Pinyao Ting f5505bf50e Remote legacy shortcut when failed to migrate
Bug: 329421105
Test: manual
Flag: NA
Change-Id: I84071a1711a36a49ad2ef71dc017ae78e4dd1267
2024-03-13 23:48:18 +00:00
Schneider Victor-tulias 14d912b062 Close the KQS view when touching the gesture nav region
Also, stop handling KQS open/close during gestures

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 328689890
Fixes: 328689534
Fixes: 328692760
Test: attempted gestures while KQS is shown. attempted KQS while attempting gestures
Change-Id: Idbd1f9cef09d9fbf611350d0847d94ccf8300369
2024-03-13 19:02:29 -04:00
Vinit Nayak 3364a1ffee Merge "Disable gestures when split apps are animating in from shell" into main 2024-03-13 22:58:16 +00:00
Brandon Dayauon a7bd5cf6ee Merge changes I209e3ec7,If70df129 into main
* changes:
  Change collapse to use adapterItems instead of getting the childCount()
  Upon expanding, expand just enough so the header shows.
2024-03-13 22:49:02 +00:00
Sebastián Franco 920d333e3a Merge "In the case the gird migration goes to a taller grid keep the grid configuration" into main 2024-03-13 22:26:42 +00:00
Sihua Ma f418b2e16d Fix out-of-sync updates during grid change
This is a combination of two issues:

1. Widget updates are not passed to the holder when the launcher binding starts
2. Updates from widgetHost.startListening() are overriden by out-of-date info

Fix: 322919716
Test: Manual
Flag: N/A
Change-Id: I9665117412c87b19ed5d98263bb4f9b8da21c5c7
2024-03-13 15:21:34 -07:00
Tony Wickham d1915657cc Avoid playing taskbar haptic when swiping up from home
Only play the haptic if the stashed value actually changed. In the
case of home-to-overview, taskbar is unstashed already.

Fixes: 314311118
Flag: none
Test: Manual, feel for haptics during home-to-overview
Change-Id: I36f70740d35bd98feafbb3980f861db16705b1da
2024-03-13 21:39:10 +00:00
Saumya Prakash 42557fe547 [automerger skipped] Merge "Ensure taskbar insets for camera cutout only apply on the needed sides" into 24D1-dev am: 8a85cb5c9b -s ours
am skip reason: Merged-In Iba766b8a19ddce37d9ca20afb0219d679ce36ace with SHA-1 ad5e4c7956 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26559384

Change-Id: I2e9544dfa53fd20033645fd0b09e8d3638c02185
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-13 20:31:52 +00:00
Saumya Prakash 113655615e [automerger skipped] Ensure taskbar insets for camera cutout only apply on the needed sides am: e46e12c0f6 -s ours
am skip reason: Merged-In Iba766b8a19ddce37d9ca20afb0219d679ce36ace with SHA-1 ad5e4c7956 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26559384

Change-Id: I14561946234210b9813c683ef5db3245a0eecb88
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-13 20:31:49 +00:00
Saumya Prakash 8a85cb5c9b Merge "Ensure taskbar insets for camera cutout only apply on the needed sides" into 24D1-dev 2024-03-13 20:12:47 +00:00
Winson Chung b5c4820a5b Merge "Change existing callers to use no matching id constant" into main 2024-03-13 19:11:20 +00:00
Winson Chung 30a9a212cd Change existing callers to use no matching id constant
- Otherwise it can unintentionally match a predicted icon

Fixes: 329353320
Test: None
Change-Id: I9e46126d5fe45a50d4a36140f7ce0317cd2b1b23
2024-03-13 19:11:03 +00:00
Schneider Victor-tulias dba7cbae1a Update KQS task view layouts to new specs
The small size of the screenshots and make text look odd. Implementing new UI specs to improve this.

- Updated icon position and size
- Added some blur to the thumbnail

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 328259439
Fixes: 328692456
Test: opened KQS in dark and light mode
Change-Id: I2b20100ddeb562291edf5f0bacbce916002eee45
2024-03-13 15:03:45 -04:00
Jordan Silva 68d8275949 Converting orientation handler classes to kotlin
This conversion is a first step for the alignment bug fix and cleanup of the fake orientation classes. The goal is to have these classes following the new architecture using Kotlin, smaller, and testable.

Bug: 320314835
Bug: 328028913
Flag: N/A
Test: presubmit. manual.
Change-Id: If0d12ff8c69eca5528fbb6b092bddefd20bc37ba
2024-03-13 18:32:20 +00:00
Sebastian Franco 2eaf15c37a In the case the gird migration goes to a taller grid keep the grid configuration
For example going from 4x5 to 4x6 it will keep the 4x5 configuration
which fits in the 4x6 grid.

Also, it fixes GridMigrationTest which was flaky because of
how it sorted arrays.

Bug: 325286145
Flag: ACONFIG grid_migration_fix disabled
Test: NA
Change-Id: I6063e3c303320096f7429a3b1d909e107d2ef2a0
2024-03-13 11:13:38 -07:00
Pat Manning a9a11b47c3 Set next page immediately on subsequent arrow/tab presses when navigating overivew.
This allows the user to scroll as quickly as they want.

Fix: 328749622
Test: manual
Flag: NONE
Change-Id: I493841f11407e6fb9f15fd90b5a5e55fa4ed3ad3
2024-03-13 17:43:10 +00:00
Jordan Silva 828b9fbfde [automerger skipped] Fix overview live tile flickers when clicking on overview action buttons am: 18bafeb261 -s ours
am skip reason: Merged-In Ibd22a58580b2e5e5b866deb4e7dc87945c7e38c4 with SHA-1 024a1018e4 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26566908

Change-Id: Ieded1bcefa139e50ea02b4aadbbc2869ee1b122b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-13 17:36:47 +00:00
Saumya Prakash e46e12c0f6 Ensure taskbar insets for camera cutout only apply on the needed sides
For devices with a camera cutout, we only need the increased inset to
accomodate a camera cutout on the sides/orientations where the cutout
interrupts the taskbar. This change ensures that the insets are only
added when necessary.

Fix: 325508089
Test: Open an app and ensure the insets remain unchanged for 0 and 90
degree rotations. Ensure the insets for 180 and 270 degrees are still
covering the camera cutout.
Flag: N/A
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:ad5e4c795624955ae2d4a984b93cf7ae900e28aa)
Merged-In: Iba766b8a19ddce37d9ca20afb0219d679ce36ace
Change-Id: Iba766b8a19ddce37d9ca20afb0219d679ce36ace
2024-03-13 17:34:37 +00:00
Andreas Agvard 6ce297a2ff Removes recovery
Flag: NONE
Bug: 326143814
Test: Unit
Change-Id: Icbebeade552cb101eb4b8bae4965b4d6c972f22e
2024-03-13 18:31:51 +01:00
Saumya Prakash b5f0d06360 Merge "Ensure taskbar insets for camera cutout only apply on the needed sides" into main 2024-03-13 17:19:08 +00:00
Jordan Silva 18bafeb261 Fix overview live tile flickers when clicking on overview action buttons
When a Live Tile is present on overview and an action is triggered (e.g., Split, Select, Screenshot), the live tile flickers due to a competing snapshot modification and animation on UI thread. The live tile is updated to switch to screenshot and at the same time the finishRecentsAnimation is triggered.

This CL bumps the number of frames to wait after the view is updated to run the Runnable code. Bumping back the mDeferFrameCount to 2 solves the sync between rendering the snapshot and hiding the Live Tile.

Fix: 327380570
Flag: N/A
Test: Manual. Open an App -> Swipe to Overview (Live title) -> Click on Split.
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:024a1018e4c96b43d8f122bb1c614c3e3ea5bab7)
Merged-In: Ibd22a58580b2e5e5b866deb4e7dc87945c7e38c4
Change-Id: Ibd22a58580b2e5e5b866deb4e7dc87945c7e38c4
2024-03-13 16:59:10 +00:00
Uwais Ashraf cf70589921 Merge "Enable tests which do not require any modification" into main 2024-03-13 15:42:07 +00:00
Alex Chau c16b46d7a1 [automerger skipped] Allow Task menu to draw down to screen bottom am: b9351e4edd -s ours
am skip reason: Merged-In Ibdff07043f2c64495f97e11e80209bcc3f5dcb4f with SHA-1 26e487c6ac is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26565819

Change-Id: Id6bc004e073477767e2549649c324f62dedc8565
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-13 15:37:27 +00:00
Alex Chau b9351e4edd Allow Task menu to draw down to screen bottom
- Use all available spaces minus inset to draw the task menu
- Also enabled scrolling for app chi1p menu

Fix: 329271577
Bug: 326952853
Test: manual
Flag: Nonee
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:26e487c6acd86c668518d379f90cb84f3d89a486)
Merged-In: Ibdff07043f2c64495f97e11e80209bcc3f5dcb4f
Change-Id: Ibdff07043f2c64495f97e11e80209bcc3f5dcb4f
2024-03-13 15:12:41 +00:00
Shamali Patwa 1a72429687 Merge changes from topic "preview-sizes" into main
* changes:
  Limit the recommendations space in two pane picker
  Update the widget previews to use the container sizes
  Avoid cropping image previews.
  Add preview container size helper to display previews in picker.
2024-03-13 13:32:05 +00:00
Uwais Ashraf 4ee1701fd1 Enable tests which do not require any modification
Fix: 329052420
Flag: NA
Test: Presubmits + :NexusLauncher:testGoogleWithQuickstepDebugUnitTest
Change-Id: I27e847c923076e4e978fd7359c9c62745d4f5f0a
2024-03-13 12:27:46 +00:00
Rohit Goyal b313ac7a30 Bugfix: Add null safety when accessing icon database for main activities for LoaderTask loadAllApps.
Test: verified bugfixes locally.
Bug: 329145005
Flag: NA
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3a6318ab5e2dee0b85c3270467477854301497a1)
Merged-In: I9f3145390d0596e55229d7dda08a4a3034d75f31
Change-Id: I9f3145390d0596e55229d7dda08a4a3034d75f31
2024-03-13 10:52:29 +00:00
Federico Baron 2155c07211 Merge "Revert "Add screenrecord for testOverviewDeadzones"" into main 2024-03-13 05:38:54 +00:00
Holly Jiuyu Sun 5beb2498ac Merge "[PS] Do not use AppInfo and use PrivateSpaceInstallAppButtonInfo instead." into main 2024-03-13 03:48:37 +00:00
Shamali P 1076f176c2 Limit the recommendations space in two pane picker
- This makes the suggestion section non-overwhelming
- Currently it shows too many suggestions for user to find any value
- Limiting the height also allows pagination to feel smooth when showing
in categories

Bug: 318410881
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Test: Manual
Change-Id: Iab1f9a15bdd46ee1560734e30551bfb7c8a74a82
2024-03-12 23:47:07 +00:00