Commit Graph

19221 Commits

Author SHA1 Message Date
Sunny Goyal 87c8a511cd resolve merge conflicts of f17eb616a8 to ub-launcher3-qt-r1-dev
Bug: None
Test: I solemnly swear I tested this conflict resolution.
Change-Id: I4e177dfb7ba3bde6eb53f63c2f2df273feef90ee
2019-06-05 10:44:02 -07:00
vadimt 8474ab2b9d Merge "Fixing All Apps's getting stuck in a non-updating state" into ub-launcher3-qt-dev
am: 8789aa05a1

Change-Id: I583ea8c9e6920aa072fa29087c51ce817e6b9d63
2019-06-04 17:51:24 -07:00
TreeHugger Robot f17eb616a8 Merge "Some RecentsView layout fixes" into ub-launcher3-qt-dev 2019-06-04 21:34:19 +00:00
Sunny Goyal 1b52c7e5de Some RecentsView layout fixes
> Only creating task overlay for one view at a time
> Fixing setOverviewStateEnabled called twice when going
  between OVERVIEW and BACKGROUND state

Bug: 132815672
Bug: 122345781
Change-Id: I51ac5b0744af87194eca08e07fd2c75b8fa0d3e0
2019-06-04 14:17:30 -07:00
Perumaal Shanmugam 067bce7d8a Merge "Re-enable chips in qt-r1-dev" into ub-launcher3-qt-r1-dev 2019-06-04 17:29:10 +00:00
TreeHugger Robot 8789aa05a1 Merge "Fixing All Apps's getting stuck in a non-updating state" into ub-launcher3-qt-dev 2019-06-04 16:37:58 +00:00
vadimt 3ca5280186 Fixing All Apps's getting stuck in a non-updating state
Normally, if all apps is open, and an app installs/uninstalls/updates,
All Apps will immediately reflect this.

However, depending on something subtle in the intensity of the swipe
gesture that brought All Apps, all apps will freeze, and won't update.

This frozen state will go away after scrolling in all apps, iteration
with an icon and, generally, any tap interaction with All Apps.
Otherwise, it will stay until it's closed and opened again via a gesture
with a different pattern.

The reason is in the code that freezes All Apps updates during user
interactions with all apps.

For example, during scrolls. Or while the user holds an icon, expecting
to see a context menu; in this case an update would cause the menu to
not appear, which is somewhat annoying.

The motivation to add this code was to solve a category of lab-only
flakes when a context menu couldn't open because the lab device was busy
with post-flash activities.

The code incorrectly assumed that after ACTION_DOWN, we are guaranteed
to get either UP or CANCEL, which is wrong.

It's after *consumed* ACTION_DOWN that we'll get these events.

The fix still solves the user's and tests' problems that the code was
supposed to solve.

Bug: 134442147
Change-Id: I9db74a33ecf93b1dc6bc69df301f7f542dea2a40
2019-06-03 18:35:52 -07:00
Sunny Goyal 7241d7cfe5 Merge "Removing user locked change in LauncherAppState" into ub-launcher3-qt-dev
am: ce0c093133

Change-Id: Ib85ff9f162f4511726d270e9d1ab94734c04e054
2019-06-03 16:55:12 -07:00
TreeHugger Robot ce0c093133 Merge "Removing user locked change in LauncherAppState" into ub-launcher3-qt-dev 2019-06-03 23:44:58 +00:00
Sunny Goyal d17a951df8 Removing user locked change in LauncherAppState
The process will crash anyway when loading sharedPreference. So
we do not need any extra check to cause the same crash.

Bug: 134094839
Change-Id: Icfd4406ff601d6b9a75bd95ddcecb9869f7e7fa2
2019-06-03 23:19:02 +00:00
TreeHugger Robot 0f405d78d7 Merge "Remove unused hints code." into ub-launcher3-qt-r1-dev 2019-06-03 23:02:01 +00:00
Hyunyoung Song 355a04ed39 Merge "Add shape detection logic only for circle icons" into ub-launcher3-qt-dev
am: ed45267bf9

Change-Id: I73fb9cfb2ed66bf88baa62f53714c028ea47b648
2019-06-03 15:46:47 -07:00
Hyunyoung Song ed45267bf9 Merge "Add shape detection logic only for circle icons" into ub-launcher3-qt-dev 2019-06-03 22:34:02 +00:00
Zak Cohen f3231f417d Remove unused hints code.
This layout is handled by the provider of the hints now.

Test: manual
Change-Id: Ifc0db2395a7503b1b03dcb796961ef6647c0413b
2019-06-03 14:58:18 -07:00
Hyunyoung Song f69426c484 Add shape detection logic only for circle icons
b/119330044

Change-Id: I93042effa8417167d844f073275e8b941e861e60
2019-06-03 14:05:20 -07:00
Adam Cohen 80ed6012dd Fix issue where Workspace scrolling doesn't work
am: acdde3d750

Change-Id: If949e3368d383b8a7ba1c6c7608af46011f36f73
2019-06-03 12:34:31 -07:00
Perumaal S 2461d61e14 Re-enable chips in qt-r1-dev
Fixes: 134164918
Change-Id: Ib5441a40ad8043afbe32d6c4c40808676cdcdb20
2019-06-03 10:21:47 -07:00
Adam Cohen acdde3d750 Fix issue where Workspace scrolling doesn't work
=> The WorkspaceTouchListener was relying on receiving TOUCH_DOWN in order to
   clear its state. This is not guaranteed; ie. when touches begin above
   children of the workspace (icons or widgets)

=> Any invocation of the Workspace long press menu would trigger this issue
   and it would persist until a touch went directly onto the Workspace in a
   location without any children.

Bug 132298752

Change-Id: Id8617baaa1ce59dc84758a7c82049329323b04cc
2019-06-01 17:16:59 -06:00
Tony Wickham dcff2f1875 Merge "Fix getting stuck in BackgroundAppState for 2-button mode" into ub-launcher3-qt-dev
am: 72c6e7b736

Change-Id: I6ab2194d50a6d7dfb7bd7c13bab776331c426c23
2019-05-31 16:26:39 -07:00
Sunny Goyal 3695646987 Merge "Fixing overview scrim not initialized properly when launcher starts" into ub-launcher3-qt-dev
am: 061c43eb4f

Change-Id: I58aa5801e698c8e8b2e0133f6995d77b341cc76f
2019-05-31 16:26:05 -07:00
TreeHugger Robot 72c6e7b736 Merge "Fix getting stuck in BackgroundAppState for 2-button mode" into ub-launcher3-qt-dev 2019-05-31 23:22:30 +00:00
Tony Wickham a04e746e84 Fix getting stuck in BackgroundAppState for 2-button mode
When ending in recents, we reapply the state - therefore, it's important
to make sure we are in OverviewState before onSwipeUpComplete(). This is
done by mLauncherTransitionController, which sets OverviewState on end.
We already force mLauncherTransitionController to end before calling
onSwipeUpComplete(), but in this case we were calling cancel() and
setting mLauncherTransitionController = null, which meant we could never
call end() on it. Instead, we should always call end() if we set it to
null.

Also ensure mLauncherTransitionController is created even if the gesture
is completed, if an existing controller isn't already running. This can
happen if you swipe up quickly enough that we get onGestureEnd before
launcher is drawn, and in that case we still want the launcher component
to animate once its ready. This is even more important for 2-button
mode, because again, we rely on mLauncherTransitionController to set the
state to OverviewState before we reapply it.

Finally, clarified some methods by renaming "swipeUp" to
"swipeUpToRecents".

Bug: 132757019
Change-Id: Ieb24a4f36a39780e5d64d7bc312791608db474d1
2019-05-31 16:11:40 -07:00
TreeHugger Robot 061c43eb4f Merge "Fixing overview scrim not initialized properly when launcher starts" into ub-launcher3-qt-dev 2019-05-31 23:01:36 +00:00
Perumaal S 165a28fd26 Merge "Disable chips in qt_dev" into ub-launcher3-qt-dev
am: 045dc86d9f

Change-Id: I3ab54017ec08ff868001ddde2dda58d7d6119961
2019-05-31 15:23:35 -07:00
TreeHugger Robot 045dc86d9f Merge "Disable chips in qt_dev" into ub-launcher3-qt-dev 2019-05-31 22:12:40 +00:00
Vadim Tryshev 55ebd4e653 Merge "More debug tracing for switching to all apps not sending the final event" into ub-launcher3-qt-dev
am: 719908c84b

Change-Id: Ife320795c1034d0b332a652b44d4f2c6e1a66418
2019-05-31 14:46:22 -07:00
Perumaal S 464dda250b Disable chips in qt_dev
- Not for use in qt_r1_dev

Bug: 134164918
Change-Id: Ib49289060a39a1a5615e762a4e72b105ed166135
2019-05-31 21:28:46 +00:00
Vadim Tryshev 719908c84b Merge "More debug tracing for switching to all apps not sending the final event" into ub-launcher3-qt-dev 2019-05-31 21:20:21 +00:00
vadimt a8f77a6afd More debug tracing for switching to all apps not sending the final event
(to the test)

Bug: 134172603
Bug: 133867119
Change-Id: I00cf3a35daefa23d2e72a89d21e6ce37c8a9a46d
2019-05-31 13:34:24 -07:00
Vadim Tryshev c201fe6b0b Merge "Annotating hierarchy dump for the error description" into ub-launcher3-qt-dev
am: 43522d25f2

Change-Id: If5870760faa0150f94487ed9acfd7db724f10a4a
2019-05-31 12:10:25 -07:00
Vadim Tryshev 43522d25f2 Merge "Annotating hierarchy dump for the error description" into ub-launcher3-qt-dev 2019-05-31 18:54:02 +00:00
Govinda Wasserman c985c6e563 Merge "Adds trigger for new gesture entrypoint to Assistant bundle" into ub-launcher3-qt-dev
am: 164ebb2e8c

Change-Id: I43d6d72765b6d7aa69dce40a3350001a18c6ac63
2019-05-31 11:33:11 -07:00
vadimt 8fcf7059ed Annotating hierarchy dump for the error description
Change-Id: I10285d451f4816b4988ce0645669b9ec9cceac81
2019-05-31 11:32:09 -07:00
Govinda Wasserman 164ebb2e8c Merge "Adds trigger for new gesture entrypoint to Assistant bundle" into ub-launcher3-qt-dev 2019-05-31 18:09:53 +00:00
Sunny Goyal 03d32ddb23 Fixing overview scrim not initialized properly when launcher starts
State UI depends on visible content, which can change due to predicitons.
Reapplying the state whenever then happens ensures that we are in correct
start UI

Change-Id: I9f195a92b747fda8a5b217dc960f230d7a695255
2019-05-31 11:00:35 -07:00
Tony Wickham ab384404b1 Merge "Don't recreate the launcher animation controller if gesture ended" into ub-launcher3-qt-dev
am: 8765e262c2

Change-Id: Ieb53126643d9f41a5ba5b85ca0d8b02ef2f6eb47
2019-05-31 10:55:54 -07:00
Tony Wickham 8765e262c2 Merge "Don't recreate the launcher animation controller if gesture ended" into ub-launcher3-qt-dev 2019-05-31 17:46:03 +00:00
Tony Wickham 436d5971b1 Don't recreate the launcher animation controller if gesture ended
This can happen if we get onApplyWindowInsets() after onGestureEnded().
In that case, we can get into some bad states because the running
animation is overwritten and thus can't be canceled.

Bug: 134096917
Bug: 133806285
Change-Id: Ic517d68a46a4446ca382445df1ba62c26e8243ad
2019-05-31 10:21:28 -07:00
Sunny Goyal f0a5ffe0fc Letting touch pass even in disabled states
am: 33838e8a2f

Change-Id: I3ff0d3218cf961c6a5f96c2aa9be9795386aed9a
2019-05-31 09:45:28 -07:00
Govinda Wasserman 254be7b0e4 Adds trigger for new gesture entrypoint to Assistant bundle
BUG:130186141
Change-Id: I43a4c3d3c9a46b4a1a5c53a81b037ba2be194188
FIX:130186141
2019-05-31 12:20:50 -04:00
Sunny Goyal 33838e8a2f Letting touch pass even in disabled states
In disabled states, dragLayer should not receive touch anyway. Removing
the additional check to avoid user getting stuck.

Bug: 134062513
Change-Id: Id31a31254377e9a737ecd6e9905e66c54e4eb740
2019-05-31 08:56:13 -07:00
Sunny Goyal 1343a69647 Merge "Fixing interactive state for background states and notifying LauncherCallback accordingly" into ub-launcher3-qt-dev
am: f36e5e002a

Change-Id: I7cf80c0047fce5c189dcaf0c77d3642300eaa458
2019-05-30 23:18:03 -07:00
TreeHugger Robot f36e5e002a Merge "Fixing interactive state for background states and notifying LauncherCallback accordingly" into ub-launcher3-qt-dev 2019-05-31 06:01:25 +00:00
Jon Miranda 88c2fd603d Fix bug where QSB flickers on app close.
am: 2ff7b53ec5

Change-Id: I0dedd1a8e054d06593253ed3c94303b42427b0c4
2019-05-30 21:16:09 -07:00
Jon Miranda 2ff7b53ec5 Fix bug where QSB flickers on app close.
Bug: 123900446
Change-Id: I9b03b2d91d264de237328511b5406e5fcd22dbac
2019-05-30 20:53:27 -07:00
Jon Miranda 457deedd53 Merge "Tuning app open/close animation." into ub-launcher3-qt-dev
am: 958cc0657f

Change-Id: I7a36afd0b02ee3c3892d14c4210246841b904d74
2019-05-30 19:18:13 -07:00
TreeHugger Robot 958cc0657f Merge "Tuning app open/close animation." into ub-launcher3-qt-dev 2019-05-31 02:04:03 +00:00
Jon Miranda b3c9077c76 Tuning app open/close animation.
* Mostly value changes.
* Added a way to round the corners during swipe up to home animation.

Bug: 123900446
Change-Id: Id61d241d919ba51ced0633585e36b7d93efe30b0
2019-05-30 18:43:22 -07:00
Tony Wickham e358d1fb92 Merge "If y velocity > x velocity in 2-button mode, go to recents" into ub-launcher3-qt-dev
am: ba33d1d216

Change-Id: I393f6e3dfc12c3b97196454322e0012a2a287489
2019-05-30 18:02:54 -07:00
TreeHugger Robot ba33d1d216 Merge "If y velocity > x velocity in 2-button mode, go to recents" into ub-launcher3-qt-dev 2019-05-31 00:49:10 +00:00