This was previously the case, but I think I mistakenly updated this
to include phones with the all_apps_sheet_for_handheld flag at some
point. However, there was also some broken logic with the panel bounds
on phones. panel.getLeft() would be 0 because that's relative to the
container, so we need to do getLeft() + panel.getLeft().
Landscape (camera on left): https://hsv.googleplex.com/5035787895701504
Seascape (camera on right): https://hsv.googleplex.com/6210562886205440
Portrait: https://hsv.googleplex.com/6563945312681984
Tablet: https://hsv.googleplex.com/6704696994562048
Bug: 419235232
Test: See HSVs above compared to before images in the bug
Flag: com.android.launcher3.all_apps_sheet_for_handheld
Change-Id: Id8b6f3367ee94ef22cb917e00518e843553b42d8
When tapping the nav handle from running app, OtherActivityInputConsumer will start the recents window through TaskAnimationManager. The recents window would then typically be closed through the StateManager, however since the state isn't changing, then RecentsWindowManger never actually gets any signal to close the recents window. Added a new callback to fix this flow.
Flag: com.android.launcher3.enable_launcher_overview_in_window
Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: pre/post submit tests. tapped nev handle from a runnign app
Change-Id: If1fe7de195a9a8a98c72629c7904d469a5768d7f
The go home action for action corner should be irreversible for now.
When home action corner is triggered at homepage, it should just stay at homepage and would not go back to previous task.
Add flag for the reversible behavior for non-desktop mode home action corner. It is to be completed with dekstop mode in later release.
Bug: 397182595
Test: ActionCornerHandlerTest
Flag: com.android.launcher3.enable_reversible_home_action_corner
Change-Id: Ib36581d0d3d81d4a7ff8f8d6265d8d5d5f5872fd
- Call setTaskIconVisible(true) at the end of the gesture regardless of `setCurrentTask`.
- Resets the icon visibility when RecentsView resets to make sure the bad state won't get stuck.
Fix: 332744660
Flag: EXEMPT bug fix
Test: Manual test on device
Change-Id: Ie8b86efa4892298f0071ad304a8c77698c306d6a
Crash happened because the split config taskId couldn't be found in the
list of remote targets, however I can't reproduce this, so adding
additional logging in case it happens again
Fix: 411897545
Flag: EXEMPT. Bugfix
Test: N/A. Logs
Change-Id: Id6ad6f5dc94aa904e1ea89f3ec59cdcd4114ec73
Previously we updated many other things, such as the buttons and RV
decorators, but the latest UX guidance is to use the same colors
when blurs are enabled or disabled, other than the panel color.
Note: When Overview blur is enabled, the activity is recreated and
this change is redundant. So this is only done if that flag is off.
Demo with home and taskbar all apps (toggling blur with adb):
https://drive.google.com/file/d/1HzveExKpAERxMVdu7JXQSYeGRwaBNR4_/view?usp=sharing&resourcekey=0-l-dGWOS6aCQjj2KStvwySA
Fix: 413229346
Flag: com.android.launcher3.all_apps_blur
Test: Manual with battery saver and `adb shell wm disable-blur 1` / 0
Change-Id: I55c9b46f0999c574c29a6ac7ae557b1e30d91d15
This change adapts the "Done" button in the gesture navigation tutorial
according to new UX specs. Specifically, the button is wider and may
have a different font according to theme.
Fix: 416144733
Test: Run the gesture navigation tutorial and observe the done button
Flag: EXEMPT bugfix
Change-Id: I4732a21c76e5a0e95433a211cd747cb36aaeaa4d
- Using setFloat instead of setViewAlpha for animation. The difference between setViewAlpha
and setFloat is that the latter will flip the view visibility as a short circuit of its
implementation. Moving to setFloat ensures that we only mutate the alpha values themselves.
Bug: 414949943
Flag: EXEMPT Bug fix
Tested: Manually, simulated
Change-Id: Id0152ac4780568dd31224df8dcea5c7ad9d309d8
This reverts commit 3551983a01.
Reason for revert:
- PlatformComposeCore uses PlatformAnimationLib that requires min_sdk_version: "33". Launcher has minSdkVersion 31 at this moment.
- Error during build: uses-sdk:minSdkVersion 33 cannot be different than version Baklava declared in library
- Reverting this CL to prevent build breaks when Compose is enabled.
Change-Id: Ia8436338c9c547bd638796f331ae9f77977d0f84
Updated icon and text font as well as scrim values to make the text and
icon visible in both themes and different wallpapers.
Fix: 408437743
Test: Go to overview in empty state(no tasks)
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: Ic76d25f4a70bffa402950fc4c3c3fade32c66c2b
There seems to be some flakiness with fonts; while I figure it out,
disabling the tests.
Bug: 418064758
Flag: EXEMPT test
Test: Not applicable.
Change-Id: I4ff19db8a18c76814a9af0d0589f1a2aa90d68d1
Andy Wickham
Schneider Victor-Tulias
Kevin Lim
Jordan Silva
Treehugger Robot
Helen Cheuk
Alex Chau
Sebastián Franco
Pierre Barbier de Reuille
Will Osborn
Saumya Prakash
Sam Cackett
Shamali Patwa
Cosmin Băieș
Adnan Begovic
Bill Yi
vinayjoglekar